i18n: Encode string lengths after strip #1535

2019-11-28T07:32:17Z

djoate commented

2019-11-28 07:32:17 +00:00

(Migrated from github.com)

This PR modifies weblate-source-file.yml

There's a bug in the current code that introduced cases where there were multiple strings with the same source but different keys.
https://github.com/privacytoolsIO/privacytools.io/blob/9c0fcec3305c6adb65c5fb6bf924dda1b8cc2a90/weblate-source-file.yml#L2330-L2331
https://github.com/privacytoolsIO/privacytools.io/blob/9c0fcec3305c6adb65c5fb6bf924dda1b8cc2a90/weblate-source-file.yml#L4160-L4161

From a grepping of the files, it became apparent that the extra length was from how the keys were inconsistently keyed:

{% t Cryptomator's mobile apps are not open-source. %}
{% t Cryptomator's mobile apps are not open-source.%}

A solution is to modify the ID code to base the length encoding on the stripped source string rather than the raw string itself.

This PR modifies weblate-source-file.yml There's a bug in the current code that introduced cases where there were multiple strings with the same source but different keys. https://github.com/privacytoolsIO/privacytools.io/blob/9c0fcec3305c6adb65c5fb6bf924dda1b8cc2a90/weblate-source-file.yml#L2330-L2331 https://github.com/privacytoolsIO/privacytools.io/blob/9c0fcec3305c6adb65c5fb6bf924dda1b8cc2a90/weblate-source-file.yml#L4160-L4161 From a grepping of the files, it became apparent that the extra length was from how the keys were inconsistently keyed: ``` {% t Cryptomator's mobile apps are not open-source. %} {% t Cryptomator's mobile apps are not open-source.%} ``` A solution is to modify the ID code to base the length encoding on the stripped source string rather than the raw string itself.

This repo is archived. You cannot comment on pull requests.

1 Participants

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: privacyguides/privacytools.io#1535