add a tab_undo suggestion to firefox tweaks #15

2015-08-26T13:54:39Z

matthewdavis commented

2015-08-26 13:54:39 +00:00

(Migrated from github.com)

I don't know of any way to pull this info remotely via javascript or otherwise. But it was a bit surprising to see a list of my previouslly closed tabs even while using private browsing. As seen here.

I don't know of any way to pull this info remotely via javascript or otherwise. But it was a bit surprising to see a list of my previouslly closed tabs even while using private browsing. As seen here. ![blah](https://cloud.githubusercontent.com/assets/298426/9495224/6dc0b5d4-4bd8-11e5-8004-cc881c12c3ec.png)

bookercodes commented

2015-08-26 13:58:33 +00:00

(Migrated from github.com)

Indeed, that is quite disconcerting - thank you for bringing it up!

I do not use Firefox personally, so I'll leave it up to @privacytoolsIO to review this one.

Indeed, that is quite disconcerting - thank you for bringing it up! I do not use Firefox personally, so I'll leave it up to @privacytoolsIO to review this one.

bookercodes commented

2015-08-26 14:14:11 +00:00

(Migrated from github.com)

Just a couple of suggestions:

Use an upper-case "F" for the proper noun "Firefox".
Could be nice to mention where the history surfaces (i.e. in the recently closed tab list).

~~And one concern:~~

Hm. It sounds like the history is stored for the duration of the session. I imagine this is required to power the "undo" button. If you set max_tabs_undo = 0, does the "undo" button still work? If it does, someone could still see your session history by hitting the "undo" button. It would also mean the history is still stored in memory (although the browser security model won't allow access via JS, I am sure). If the "undo" button does not work, then this sounds like it comes at too high of a cost to usability and probably is not something to recommend by default.

I just re-read the issue and was reminded that this issue pertains to recently closed tabs, not recent history - sorry for the misunderstanding.

Just a couple of suggestions: - Use an upper-case _"F"_ for the proper noun _"Firefox"_. - Could be nice to mention where the history surfaces (i.e. in the recently closed tab list). ~~And one concern:~~ - ~~Hm. It sounds like the history is stored for the duration of the session. I _imagine_ this is required to power the "undo" button. If you set `max_tabs_undo = 0`, does the "undo" button still work? If it does, someone could _still_ see your session history by hitting the "undo" button. It would also mean the history is still stored in memory (although the browser security model won't allow access via JS, I am sure). If the "undo" button does _not_ work, then this sounds like it comes at too high of a cost to usability and _probably_ is not something to recommend by default.~~ I just re-read the issue and was reminded that this issue pertains to recently closed tabs, not recent history - sorry for the misunderstanding.

matthewdavis commented

2015-08-26 18:30:20 +00:00

(Migrated from github.com)

Thanks for the suggestions Alex, I modified the wording a bit.

This repo is archived. You cannot comment on pull requests.

No reviewers