i18n: Key donate and sponsors, fix navbar, merge master #1457

2019-11-03T02:28:51Z

djoate commented

2019-11-03 02:28:51 +00:00

(Migrated from github.com)

This is a part of https://github.com/privacytoolsIO/privacytools.io/issues/1106. Please take a look at my reviews before merging

Keys the strings of /donate and /sponsors into en.yml; fix some unkeyed strings in navbar; merge master.
PR also fixes Whonix string taking up two lines and some minor punctuation

This is a part of https://github.com/privacytoolsIO/privacytools.io/issues/1106. Please take a look at my reviews before merging Keys the strings of /donate and /sponsors into en.yml; fix some unkeyed strings in navbar; merge master. PR also fixes Whonix string taking up two lines and some minor punctuation

privacytoolsIO (Migrated from github.com) reviewed 2019-11-03 02:28:51 +00:00

jonah reviewed 2019-11-03 02:28:51 +00:00

dawidpotocki (Migrated from github.com) reviewed 2019-11-03 02:28:51 +00:00

djoate (Migrated from github.com) reviewed 2019-11-03 02:47:26 +00:00

_i18n/en.yml

djoate (Migrated from github.com) commented

2019-11-03 02:47:25 +00:00

These three strings break up one paragraph into three because "tax-deductible" is surrounded with a <strong> tag. Should we just put the entire paragraph in one string opting to include the <strong> tags in en.yml instead?

For context, the entire paragraph is this:

Your contribution to privacytools.io will be handled by the Open Collective Foundation 501(c)(3). For US companies and taxpayers, this means your contribution is tax deductible. As a non-profit, your sponsorship contribution will not be used for private profit and will only be used to cover expenses incurred by the project. All of our transactions (donations and expenses) are published transparently on OpenCollective. For the benefit of our readership, anonymous contributions will not be eligible for the sponsorship opportunities outlined above.

These three strings break up one paragraph into three because "tax-deductible" is surrounded with a `<strong>` tag. Should we just put the entire paragraph in one string opting to include the `<strong>` tags in `en.yml` instead? For context, the entire paragraph is this: > Your contribution to privacytools.io will be handled by the Open Collective Foundation 501(c)(3). For US companies and taxpayers, this means your contribution is **tax deductible**. As a non-profit, your sponsorship contribution will not be used for private profit and will only be used to cover expenses incurred by the project. All of our transactions (donations and expenses) are published transparently on OpenCollective. For the benefit of our readership, anonymous contributions will not be eligible for the sponsorship opportunities outlined above.

jonah reviewed 2019-11-03 04:20:29 +00:00

_i18n/en.yml

jonah commented

2019-11-03 04:20:29 +00:00

Yeah... That seems like a better plan, and I'm wondering if we should do that for all the strings we've broken up too 😳

djoate (Migrated from github.com) reviewed 2019-11-03 05:35:30 +00:00

_i18n/en.yml

djoate (Migrated from github.com) commented

2019-11-03 05:35:29 +00:00

This is done in https://github.com/privacytoolsIO/privacytools.io/pull/1457/commits/a007e37a5f79f0d72dad69e5448a898424bf63ac. (Of course, for those not knowledgeable about HTML, doing this means that we should to advise translators in the future about not translating < ... > contents)

This is done in https://github.com/privacytoolsIO/privacytools.io/pull/1457/commits/a007e37a5f79f0d72dad69e5448a898424bf63ac. (Of course, for those not knowledgeable about HTML, doing this means that we should to advise translators in the future about not translating `< ... >` contents)

This repo is archived. You cannot comment on pull requests.

No Reviewers

jonah

privacytoolsIO

dawidpotocki

djoate

1 Participants

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: privacyguides/privacytools.io#1457