Add hosting providers to DNS table #1261
No reviewers
Labels
No Label
🔍🤖 Search Engines
approved
dependencies
duplicate
feedback wanted
high priority
I2P
iOS
low priority
OS
Self-contained networks
Social media
stale
streaming
todo
Tor
WIP
wontfix
XMPP
[m]
₿ cryptocurrency
ℹ️ help wanted
↔️ file sharing
⚙️ web extensions
✨ enhancement
❌ software removal
💬 discussion
🤖 Android
🐛 bug
💢 conflicting
📝 correction
🆘 critical
📧 email
🔒 file encryption
📁 file storage
🦊 Firefox
💻 hardware
🌐 hosting
🏠 housekeeping
🔐 password managers
🧰 productivity tools
🔎 research required
🌐 Social News Aggregators
🆕 software suggestion
👥 team chat
🔒 VPN
🌐 website issue
🚫 Windows
👁️ browsers
🖊️ digital notebooks
🗄️ DNS
🗨️ instant messaging (im)
🇦🇶 translations
No Milestone
No Assignees
1 Participants
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: privacyguides/privacytools.io#1261
Loading…
Reference in New Issue
No description provided.
Delete Branch "1221"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Description
Adds a new "hosting provider" column to the DNS table. Also attempted to give the "filtering" column more width for readability. Can add a separate "hosting provider location" column in this or a separate PR.
Resolves: https://github.com/privacytoolsIO/privacytools.io/issues/1221
Check List
I have read and understand the contributing guidelines.
This project has an associated discussion.
Deploy preview for privacytools-io ready!
Built with commit
706d0c3d45
https://deploy-preview-1261--privacytools-io.netlify.com
I think it looks good overall, but some comments in case there is anything to do towards them:
Otherwise I am surprised at how the amount of Cloudflare has dropped, maybe the providers using it only have their websites.
Thanks a lot 💜
I think this may be wrong and the IP range just didn't have owner specified or something.
I think this may be wrong and the IP range just didn't have owner specified or something.
@ -336,2 +400,4 @@
</a>
</td>
<td>
<span class="no-text-wrap">
I think this may be wrong and the IP range just didn't have owner specified or something.
@ -385,0 +464,4 @@
<span class="no-text-wrap">
Based on server choice
</span>
</td>
I think this may be wrong and the IP range just didn't have owner specified or something.
Good points 👍 Scroll bars are inevitable if we want this table to remain readable I think. And the table headers are annoyingly on different lines for some columns due to the cell values having a shorter length than the column title. Maybe this can be explored further in a separate PR.
A small suggestion for future would be to refer where information comes in future commit messages, I was confused on the last commit until I saw https://github.com/privacytoolsIO/privacytools.io/issues/1221