Add hosting providers to DNS table #1261

Merged
nitrohorse merged 4 commits from 1221 into master 2019-09-04 14:30:20 +00:00
nitrohorse commented 2019-09-02 07:24:58 +00:00 (Migrated from github.com)

Description

Adds a new "hosting provider" column to the DNS table. Also attempted to give the "filtering" column more width for readability. Can add a separate "hosting provider location" column in this or a separate PR.

Resolves: https://github.com/privacytoolsIO/privacytools.io/issues/1221

Check List

<!-- PLEASE READ OUR CONTRIBUTING GUIDELINES (https://github.com/privacytoolsIO/privacytools.io/blob/master/.github/CONTRIBUTING.md) BEFORE SUBMITTING --> ## Description Adds a new "hosting provider" column to the DNS table. Also attempted to give the "filtering" column more width for readability. Can add a separate "hosting provider location" column in this or a separate PR. Resolves: https://github.com/privacytoolsIO/privacytools.io/issues/1221 #### Check List <!-- Please add an x in each box below, like so: [x] --> - [x] I have read and understand [the contributing guidelines](https://github.com/privacytoolsIO/privacytools.io/blob/master/.github/CONTRIBUTING.md). - [x] This project has an [associated discussion](https://github.com/privacytoolsIO/privacytools.io/issues). * Netlify preview for the mainly edited page: https://deploy-preview-1261--privacytools-io.netlify.com/providers/dns/#icanndns
netlify[bot] commented 2019-09-02 07:25:35 +00:00 (Migrated from github.com)

Deploy preview for privacytools-io ready!

Built with commit 706d0c3d45

https://deploy-preview-1261--privacytools-io.netlify.com

Deploy preview for *privacytools-io* ready! Built with commit 706d0c3d45019d4c8d09d2079ad795f2c1203513 https://deploy-preview-1261--privacytools-io.netlify.com
Mikaela (Migrated from github.com) reviewed 2019-09-02 12:30:16 +00:00
Mikaela (Migrated from github.com) left a comment

I think it looks good overall, but some comments in case there is anything to do towards them:

  • RIPE and APNIC are who distribute IP addresses initially, I don't think they are hosting providers so I would prefer to instead say Unknown or ??? or maybe even reach out to those providers and ask, if their websites don't reveal the information?
  • Vertical scrollbar appears on my system, but it really cannot be helped with the amount of detail that we have.
  • The table headers aren't on a straight line, but I am not sure if anything can be done to that.

Otherwise I am surprised at how the amount of Cloudflare has dropped, maybe the providers using it only have their websites.

Thanks a lot 💜

I think it looks good overall, but some comments in case there is anything to do towards them: * RIPE and APNIC are who distribute IP addresses initially, I don't think they are hosting providers so I would prefer to instead say Unknown or ??? or maybe even reach out to those providers and ask, if their websites don't reveal the information? * Vertical scrollbar appears on my system, but it really cannot be helped with the amount of detail that we have. * The table headers aren't on a straight line, but I am not sure if anything can be done to that. Otherwise I am surprised at how the amount of Cloudflare has dropped, maybe the providers using it only have their websites. Thanks a lot :purple_heart:
Mikaela (Migrated from github.com) commented 2019-09-02 12:20:35 +00:00

I think this may be wrong and the IP range just didn't have owner specified or something.

I think this may be wrong and the IP range just didn't have owner specified or something.
Mikaela (Migrated from github.com) commented 2019-09-02 12:21:14 +00:00

I think this may be wrong and the IP range just didn't have owner specified or something.

I think this may be wrong and the IP range just didn't have owner specified or something.
@ -336,2 +400,4 @@
</a>
</td>
<td>
<span class="no-text-wrap">
Mikaela (Migrated from github.com) commented 2019-09-02 12:22:28 +00:00

I think this may be wrong and the IP range just didn't have owner specified or something.

I think this may be wrong and the IP range just didn't have owner specified or something.
@ -385,0 +464,4 @@
<span class="no-text-wrap">
Based on server choice
</span>
</td>
Mikaela (Migrated from github.com) commented 2019-09-02 12:22:39 +00:00

I think this may be wrong and the IP range just didn't have owner specified or something.

I think this may be wrong and the IP range just didn't have owner specified or something.
Mikaela (Migrated from github.com) reviewed 2019-09-02 17:59:32 +00:00
nitrohorse commented 2019-09-02 21:04:18 +00:00 (Migrated from github.com)

I think it looks good overall, but some comments in case there is anything to do towards them:

* RIPE and APNIC are who distribute IP addresses initially, I don't think they are hosting providers so I would prefer to instead say Unknown or ??? or maybe even reach out to those providers and ask, if their websites don't reveal the information?

* Vertical scrollbar appears on my system, but it really cannot be helped with the amount of detail that we have.

* The table headers aren't on a straight line, but I am not sure if anything can be done to that.

Otherwise I am surprised at how the amount of Cloudflare has dropped, maybe the providers using it only have their websites.

Thanks a lot purple_heart

Good points 👍 Scroll bars are inevitable if we want this table to remain readable I think. And the table headers are annoyingly on different lines for some columns due to the cell values having a shorter length than the column title. Maybe this can be explored further in a separate PR.

> I think it looks good overall, but some comments in case there is anything to do towards them: > > * RIPE and APNIC are who distribute IP addresses initially, I don't think they are hosting providers so I would prefer to instead say Unknown or ??? or maybe even reach out to those providers and ask, if their websites don't reveal the information? > > * Vertical scrollbar appears on my system, but it really cannot be helped with the amount of detail that we have. > > * The table headers aren't on a straight line, but I am not sure if anything can be done to that. > > > Otherwise I am surprised at how the amount of Cloudflare has dropped, maybe the providers using it only have their websites. > > Thanks a lot purple_heart Good points :+1: Scroll bars are inevitable if we want this table to remain readable I think. And the table headers are annoyingly on different lines for some columns due to the cell _values_ having a shorter length than the column title. Maybe this can be explored further in a separate PR.
dawidpotocki (Migrated from github.com) approved these changes 2019-09-04 01:54:25 +00:00
Mikaela (Migrated from github.com) approved these changes 2019-09-04 09:08:15 +00:00
Mikaela (Migrated from github.com) left a comment

A small suggestion for future would be to refer where information comes in future commit messages, I was confused on the last commit until I saw https://github.com/privacytoolsIO/privacytools.io/issues/1221

Also: BuyVM is a brand of FranTech, Vultr is a brand of Choopa

A small suggestion for future would be to refer where information comes in future commit messages, I was confused on the last commit until I saw https://github.com/privacytoolsIO/privacytools.io/issues/1221 > Also: BuyVM is a brand of FranTech, Vultr is a brand of Choopa
This repo is archived. You cannot comment on pull requests.
No Milestone
No Assignees
1 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: privacyguides/privacytools.io#1261
No description provided.