Fix dark theme's input forms colors #1237

2019-08-29T21:18:32Z

Strappazzon commented

2019-08-29 21:18:32 +00:00

(Migrated from github.com)

Description

This PR fixes the dark theme's input forms colors.

Preview

Before	After

Check List

I have read and understand the contributing guidelines.

## Description This PR fixes the dark theme's input forms colors. ## Preview |Before|After| |---|---| |![](https://user-images.githubusercontent.com/19752093/63976744-4d37c200-cab2-11e9-9b95-814fb6b3aeaf.png)|![](https://user-images.githubusercontent.com/19752093/63976764-59238400-cab2-11e9-9370-f7c954496bd6.png)| #### Check List - [x] I have read and understand [the contributing guidelines](https://github.com/privacytoolsIO/privacytools.io/blob/master/.github/CONTRIBUTING.md).

netlify[bot] commented

2019-08-29 21:19:19 +00:00

(Migrated from github.com)

Deploy preview for privacytools-io ready!

Built with commit eb4062121a

https://deploy-preview-1237--privacytools-io.netlify.com

Deploy preview for *privacytools-io* ready! Built with commit eb4062121ae636c2e0a0647fcbe9c67fa03275d9 https://deploy-preview-1237--privacytools-io.netlify.com

blacklight447 (Migrated from github.com) reviewed 2019-08-29 21:29:34 +00:00

blacklight447 (Migrated from github.com) left a comment

looks good to me.

dawidpotocki (Migrated from github.com) reviewed 2019-08-30 01:01:54 +00:00

assets/css/dark.scss

dawidpotocki (Migrated from github.com) commented

2019-08-30 01:01:42 +00:00

We use 2 spaces for indentation.

dawidpotocki commented

2019-08-30 01:06:20 +00:00

(Migrated from github.com)

Oh, I did saw it before, but forgot about that.
But your fix does not completely fix them.

Oh, I did saw it before, but forgot about that. But your fix does not completely fix them.

nitrohorse commented

2019-08-30 01:12:42 +00:00

(Migrated from github.com)

Oh, I did saw it before, but forgot about that. But your fix does not completely fix them.

What's missing?

> Oh, I did saw it before, but forgot about that. But your fix does not completely fix them. What's missing?

dawidpotocki (Migrated from github.com) reviewed 2019-08-30 01:43:47 +00:00

assets/css/dark.scss

dawidpotocki (Migrated from github.com) commented

2019-08-30 01:43:36 +00:00

Remove color, border-color and !important next to background.
Also move this under

.form-control,
.form-control:focus {

because my Firefox gives me white box otherwise.

Remove `color`, `border-color` and `!important` next to `background`. Also move this under ``` .form-control, .form-control:focus { ``` because my Firefox gives me white box otherwise.

dawidpotocki (Migrated from github.com) reviewed 2019-08-30 01:59:58 +00:00

assets/css/dark.scss

dawidpotocki (Migrated from github.com) commented

2019-08-30 01:54:19 +00:00

Replace it with .form-control[readonly]

Replace it with `.form-control[readonly]`

dawidpotocki (Migrated from github.com) approved these changes 2019-08-30 11:43:28 +00:00

Mikaela (Migrated from github.com) approved these changes 2019-08-30 12:12:09 +00:00

Mikaela (Migrated from github.com) left a comment

Approving as @dawidpotocki approves

This repo is archived. You cannot comment on pull requests.

1 Participants

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: privacyguides/privacytools.io#1237