Remove text wrapping for DNS providers table server locations column #1222

2019-08-26T05:39:16Z

nitrohorse commented

2019-08-26 05:39:16 +00:00

(Migrated from github.com)

Description

Resolves: https://github.com/privacytoolsIO/privacytools.io/issues/1185

Check List

I have read and understand the contributing guidelines.
I have listed the source code.
This project is free/libre software.
This project has an associated discussion.

Netlify preview for the mainly edited page: https://deploy-preview-1222--privacytools-io.netlify.com/providers/dns/#icanndns
Code Repository (if applicable): N/A

## Description Resolves: https://github.com/privacytoolsIO/privacytools.io/issues/1185 #### Check List  - [x] I have read and understand [the contributing guidelines](https://github.com/privacytoolsIO/privacytools.io/blob/master/.github/CONTRIBUTING.md). - [x] I have [listed the source code](https://github.com/privacytoolsIO/privacytools.io/blob/master/source_code.md). - [x] This project is [free/libre software](https://www.wikipedia.org/wiki/Free_software). - [x] This project has an [associated discussion](https://github.com/privacytoolsIO/privacytools.io/issues). * Netlify preview for the mainly edited page: https://deploy-preview-1222--privacytools-io.netlify.com/providers/dns/#icanndns * Code Repository (if applicable): N/A

jonah reviewed 2019-08-26 05:39:16 +00:00

netlify[bot] commented

2019-08-26 05:39:56 +00:00

(Migrated from github.com)

Deploy preview for privacytools-io ready!

Built with commit 3ff07953de

https://deploy-preview-1222--privacytools-io.netlify.com

Deploy preview for *privacytools-io* ready! Built with commit 3ff07953ded4f9ad1c32f10e0900c4f95aad91dd https://deploy-preview-1222--privacytools-io.netlify.com

Mikaela (Migrated from github.com) reviewed 2019-08-26 07:40:35 +00:00

Mikaela (Migrated from github.com) left a comment

Looks good, thanks 👍

Looks good, thanks :+1:

dawidpotocki (Migrated from github.com) reviewed 2019-08-26 07:43:48 +00:00

_includes/sections/dns.html

dawidpotocki (Migrated from github.com) commented

2019-08-26 07:35:57 +00:00

Move ) and , up, because on website it will display space between them, which looks bad.

https://github.com/privacytoolsIO/privacytools.io/blob/7993b559f0a7b22f225cc701e9016afc9938f012/_includes/sections/dns.html#L88-L89
https://github.com/privacytoolsIO/privacytools.io/blob/7993b559f0a7b22f225cc701e9016afc9938f012/_includes/sections/dns.html#L92-L93
https://github.com/privacytoolsIO/privacytools.io/blob/7993b559f0a7b22f225cc701e9016afc9938f012/_includes/sections/dns.html#L124-L125
https://github.com/privacytoolsIO/privacytools.io/blob/7993b559f0a7b22f225cc701e9016afc9938f012/_includes/sections/dns.html#L224-L225
https://github.com/privacytoolsIO/privacytools.io/blob/7993b559f0a7b22f225cc701e9016afc9938f012/_includes/sections/dns.html#L276-L277
https://github.com/privacytoolsIO/privacytools.io/blob/7993b559f0a7b22f225cc701e9016afc9938f012/_includes/sections/dns.html#L324-L325

Move `)` and `,` up, because on website it will display space between them, which looks bad. https://github.com/privacytoolsIO/privacytools.io/blob/7993b559f0a7b22f225cc701e9016afc9938f012/_includes/sections/dns.html#L88-L89 https://github.com/privacytoolsIO/privacytools.io/blob/7993b559f0a7b22f225cc701e9016afc9938f012/_includes/sections/dns.html#L92-L93 https://github.com/privacytoolsIO/privacytools.io/blob/7993b559f0a7b22f225cc701e9016afc9938f012/_includes/sections/dns.html#L124-L125 https://github.com/privacytoolsIO/privacytools.io/blob/7993b559f0a7b22f225cc701e9016afc9938f012/_includes/sections/dns.html#L224-L225 https://github.com/privacytoolsIO/privacytools.io/blob/7993b559f0a7b22f225cc701e9016afc9938f012/_includes/sections/dns.html#L276-L277 https://github.com/privacytoolsIO/privacytools.io/blob/7993b559f0a7b22f225cc701e9016afc9938f012/_includes/sections/dns.html#L324-L325

_includes/sections/dns.html

						
				@@ -89,3 +114,4 @@

				        </td>

				        <td>Yes</td>

				        <td>Yes</td>

				        <td>Ads, trackers, malicious domains <span class="badge badge-warning" data-toggle="tooltip" data-original-title="And some wildcard, IDN, and non-ASCII domains."><a href="https://github.com/ookangzheng/blahdns#default-blocked-wildcard-domain"><i class="fas fa-exclamation-triangle"></i></a></span></td>

dawidpotocki (Migrated from github.com) commented

2019-08-26 07:36:32 +00:00

Indentation ;p

assets/css/style.scss

dawidpotocki (Migrated from github.com) commented

2019-08-26 07:16:15 +00:00

Add newline at the end of the file.

https://stackoverflow.com/a/729795

Add newline at the end of the file. https://stackoverflow.com/a/729795

Mikaela (Migrated from github.com) reviewed 2019-08-26 08:03:20 +00:00

assets/css/style.scss

Mikaela (Migrated from github.com) commented

2019-08-26 08:03:20 +00:00

Thanks, so that is what git sometimes complains about!

dawidpotocki commented

2019-08-26 08:04:19 +00:00

(Migrated from github.com)

I noticed that bold DoT is on seperate line when there , after it, which was not the case before (with some fonts, like one that is used on my Tor Browser)

https://github.com/privacytoolsIO/privacytools.io/blob/7993b559f0a7b22f225cc701e9016afc9938f012/_includes/sections/dns.html#L186
https://github.com/privacytoolsIO/privacytools.io/blob/7993b559f0a7b22f225cc701e9016afc9938f012/_includes/sections/dns.html#L106

change to

<td data-value="dot/443">
  <span class="no-text-wrap">
    DoH,
    <span data-toggle="tooltip" data-placement="bottom" data-original-title="Supports port 443 in addition to 853">
      <strong>DoT</strong>,
    </span>
  </span>
  DNSCrypt
</td>

I noticed that bold DoT is on seperate line when there `,` after it, which was not the case before (with some fonts, like one that is used on my Tor Browser) ![screenshot](https://user-images.githubusercontent.com/38681822/63674122-605a4180-c7d5-11e9-84b1-963d87cacc2f.png) https://github.com/privacytoolsIO/privacytools.io/blob/7993b559f0a7b22f225cc701e9016afc9938f012/_includes/sections/dns.html#L186 https://github.com/privacytoolsIO/privacytools.io/blob/7993b559f0a7b22f225cc701e9016afc9938f012/_includes/sections/dns.html#L106 change to ``` <td data-value="dot/443"> DoH, DoT, DNSCrypt </td> ```

👍 1

blacklight447 (Migrated from github.com) reviewed 2019-08-26 18:57:19 +00:00

nitrohorse (Migrated from github.com) reviewed 2019-08-27 01:57:29 +00:00

_includes/sections/dns.html

nitrohorse (Migrated from github.com) commented

2019-08-27 01:57:29 +00:00

Ah good catch! Didn't even realize this.