privacyguides
/
privacytools.io
Archived
1
0
Fork 0
Code Issues 304 Pull Requests 47 Activity

DNS: add Nebulo as worth mentioning & warn about DoH metadata & sort worth mentioning/additional information into sublists #1200

Merged
Mikaela merged 15 commits from nebulo into master 2019-08-24 14:55:35 +00:00
Conversation 3 Commits 15 Files Changed 2 +40 -13
Mikaela commented 2019-08-22 20:26:04 +00:00 (Migrated from github.com)
Copy Link

Description

Resolves: #1187

Check List

<!-- PLEASE READ OUR CONTRIBUTING GUIDELINES (https://github.com/privacytoolsIO/privacytools.io/blob/master/.github/CONTRIBUTING.md) BEFORE SUBMITTING --> ## Description Resolves: #1187 #### Check List <!-- Please add an x in each box below, like so: [x] --> - [x] I have read and understand [the contributing guidelines](https://github.com/privacytoolsIO/privacytools.io/blob/master/.github/CONTRIBUTING.md). - [x] I have [listed the source code](https://github.com/privacytoolsIO/privacytools.io/blob/master/source_code.md). - [x] This project is [free/libre software](https://www.wikipedia.org/wiki/Free_software). - [x] This project has an [associated discussion](https://github.com/privacytoolsIO/privacytools.io/issues). * Netlify preview for the mainly edited page: https://deploy-preview-1200--privacytools-io.netlify.com/providers/dns/#icanndns * Code Repository (if applicable): https://git.frostnerd.com/PublicAndroidApps/smokescreen/
👍 1
blacklight447 (Migrated from github.com) reviewed 2019-08-22 20:26:04 +00:00
jonah reviewed 2019-08-22 20:26:04 +00:00
netlify[bot] commented 2019-08-22 20:27:40 +00:00 (Migrated from github.com)
Copy Link

Deploy preview for privacytools-io ready!

Built with commit 6a91bff702

https://deploy-preview-1200--privacytools-io.netlify.com

Deploy preview for *privacytools-io* ready! Built with commit 6a91bff7024cdf5e86d62a258bd59b7cb516bbe6 https://deploy-preview-1200--privacytools-io.netlify.com
Mikaela (Migrated from github.com) reviewed 2019-08-22 20:37:26 +00:00
_includes/sections/dns.html
Mikaela (Migrated from github.com) commented 2019-08-22 20:37:25 +00:00

TODO: find a more authoritative source than someone on our issue tracker? :)

TODO: find a more authoritative source than someone on our issue tracker? :)
Mikaela (Migrated from github.com) reviewed 2019-08-22 20:43:19 +00:00
_includes/sections/dns.html
Mikaela (Migrated from github.com) commented 2019-08-22 20:43:18 +00:00

Show me a more authoritative source than the RFC!

Show me a more authoritative source than the RFC!
Mikaela (Migrated from github.com) reviewed 2019-08-22 20:44:03 +00:00
_includes/sections/dns.html
Mikaela (Migrated from github.com) commented 2019-08-22 20:44:03 +00:00

English: Do things contain or include metadata?

English: Do things contain or include metadata?
nitrohorse (Migrated from github.com) reviewed 2019-08-23 04:31:42 +00:00
_includes/sections/dns.html
nitrohorse (Migrated from github.com) commented 2019-08-23 04:31:42 +00:00

I think "contains" is fine. I think we could also make this a tad more readable by:

DoH contains metadata such as user-agent (which may include system information) that is sent to the DNS server. (also add a period)

I think "contains" is fine. I think we could also make this a tad more readable by: > DoH contains metadata such as user-agent (which may include system information) **that is sent** to the DNS server. (also add a period)
nitrohorse (Migrated from github.com) reviewed 2019-08-23 04:32:16 +00:00
_includes/sections/dns.html
@ -300,0 +293,4 @@
<li><em>Firefox</em> comes with built-in DoH support with Cloudflare set as the default resolver, but can be configured to use any DoH resolver. <span class="badge badge-warning" data-toggle="tooltip" data-placement="bottom" data-original-title='"Cloudflare has agreed to collect only a limited amount of data about the DNS requests that are sent to the Cloudflare Resolver for Firefox via the Firefox browser."'><a href="https://developers.cloudflare.com/1.1.1.1/commitment-to-privacy/privacy-policy/firefox/"><i class="fas fa-exclamation-triangle"></i></a></span> Currently Mozilla is <a href="https://blog.mozilla.org/futurereleases/2019/07/31/dns-over-https-doh-update-detecting-managed-networks-and-user-choice/">conducting studies</a> before enabling DoH by default for all US-based Firefox users.</li>
</ul>
</li>
<li><strong>Encrypted DNS clients for mobile:</strong>
nitrohorse (Migrated from github.com) commented 2019-08-23 04:32:16 +00:00

Could we move this directly above or below DNSCloak just to group similar apps together?

Could we move this directly above or below DNSCloak just to group similar apps together?
nitrohorse (Migrated from github.com) reviewed 2019-08-23 04:49:25 +00:00
nitrohorse (Migrated from github.com) left a comment

Small suggestions, otherwise LGTM

Small suggestions, otherwise LGTM
Mikaela (Migrated from github.com) reviewed 2019-08-23 11:15:03 +00:00
_includes/sections/dns.html
Mikaela (Migrated from github.com) commented 2019-08-23 11:15:03 +00:00

Sure, will do

Sure, will do
Mikaela (Migrated from github.com) reviewed 2019-08-23 11:17:30 +00:00
_includes/sections/dns.html
@ -300,0 +293,4 @@
<li><em>Firefox</em> comes with built-in DoH support with Cloudflare set as the default resolver, but can be configured to use any DoH resolver. <span class="badge badge-warning" data-toggle="tooltip" data-placement="bottom" data-original-title='"Cloudflare has agreed to collect only a limited amount of data about the DNS requests that are sent to the Cloudflare Resolver for Firefox via the Firefox browser."'><a href="https://developers.cloudflare.com/1.1.1.1/commitment-to-privacy/privacy-policy/firefox/"><i class="fas fa-exclamation-triangle"></i></a></span> Currently Mozilla is <a href="https://blog.mozilla.org/futurereleases/2019/07/31/dns-over-https-doh-update-detecting-managed-networks-and-user-choice/">conducting studies</a> before enabling DoH by default for all US-based Firefox users.</li>
</ul>
</li>
<li><strong>Encrypted DNS clients for mobile:</strong>
Mikaela (Migrated from github.com) commented 2019-08-23 11:17:30 +00:00

How about copying the XMPP syntax from https://www.privacytools.io/software/real-time-communication/#im to do it?

I didn't see the logic before, so I just put it in order of addition. I will try to commit it so we will see how it looks like.

How about copying the XMPP syntax from https://www.privacytools.io/software/real-time-communication/#im to do it? I didn't see the logic before, so I just put it in order of addition. I will try to commit it so we will see how it looks like.
Mikaela (Migrated from github.com) reviewed 2019-08-23 12:11:34 +00:00
_includes/sections/dns.html
@ -300,0 +293,4 @@
<li><em>Firefox</em> comes with built-in DoH support with Cloudflare set as the default resolver, but can be configured to use any DoH resolver. <span class="badge badge-warning" data-toggle="tooltip" data-placement="bottom" data-original-title='"Cloudflare has agreed to collect only a limited amount of data about the DNS requests that are sent to the Cloudflare Resolver for Firefox via the Firefox browser."'><a href="https://developers.cloudflare.com/1.1.1.1/commitment-to-privacy/privacy-policy/firefox/"><i class="fas fa-exclamation-triangle"></i></a></span> Currently Mozilla is <a href="https://blog.mozilla.org/futurereleases/2019/07/31/dns-over-https-doh-update-detecting-managed-networks-and-user-choice/">conducting studies</a> before enabling DoH by default for all US-based Firefox users.</li>
</ul>
</li>
<li><strong>Encrypted DNS clients for mobile:</strong>
Mikaela (Migrated from github.com) commented 2019-08-23 12:11:34 +00:00

I think it looks better, but now I have to sort everything else too, not that it's a bad thing:

image

I fear we may be causing merge conflicts for each other depending on which PRs are merged, but if that happens, we can resolve them.

I think it looks better, but now I have to sort everything else too, not that it's a bad thing: ![image](https://user-images.githubusercontent.com/831184/63591714-1851d980-c59f-11e9-8c6b-5769a700ba20.png) I fear we may be causing merge conflicts for each other depending on which PRs are merged, but if that happens, we can resolve them.
Mikaela commented 2019-08-23 12:32:38 +00:00 (Migrated from github.com)
Copy Link

So currently it looks like this:

image

So currently it looks like this: ![image](https://user-images.githubusercontent.com/831184/63592811-0e7da580-c5a2-11e9-845f-757e75cce864.png)
Mikaela (Migrated from github.com) reviewed 2019-08-23 12:40:49 +00:00
Mikaela (Migrated from github.com) left a comment

What's up with the excess spaces? I tried to make it readable while I worked on it in mousepad.

Open question: should I keep the :s or not, before bolding I thought that it definitely needs something, but now I am not sure whether to move them outside of the <strong>s or drop them entirely.

What's up with the excess spaces? I tried to make it readable while I worked on it in mousepad. Open question: should I keep the `:`s or not, before bolding I thought that it definitely needs something, but now I am not sure whether to move them outside of the `<strong>`s or drop them entirely.
_includes/sections/dns.html
Mikaela (Migrated from github.com) commented 2019-08-23 12:34:26 +00:00

I understand that we don't have a mobile-first attitude, so desktop software is what a visitor is most likely looking for and for now it's not so long, so I think it makes the most sense being on top.

I understand that we don't have a mobile-first attitude, so desktop software is what a visitor is most likely looking for and for now it's not so long, so I think it makes the most sense being on top.
Mikaela (Migrated from github.com) commented 2019-08-23 12:34:49 +00:00

I think it's the second most likely thing someone is looking for

I think it's the second most likely thing someone is looking for
Mikaela (Migrated from github.com) commented 2019-08-23 12:35:05 +00:00

Anyone can run them, so I think it's a good third thing to list

Anyone can run them, so I think it's a good third thing to list
Mikaela (Migrated from github.com) commented 2019-08-23 12:36:47 +00:00

I think it's the most technical thing we list and requires the most, so it's good to be on the bottom of recommendations.

I think it's the most technical thing we list and requires the most, so it's good to be on the bottom of recommendations.
Mikaela (Migrated from github.com) commented 2019-08-23 12:39:04 +00:00

I first thought about putting it on top, but as the heading says "Worth mentioning and additional information" I thought it should be on bottom and I cannot think of anything better here. Isn't "further reading" generally something that one doesn't have to read, but which can be of interest to someone who is especially interested in the topic?

I first thought about putting it on top, but as the heading says "Worth mentioning and additional information" I thought it should be on bottom and I cannot think of anything better here. Isn't "further reading" generally something that one doesn't have to read, but which can be of interest to someone who is especially interested in the topic?
source_code.md
Mikaela (Migrated from github.com) commented 2019-08-23 12:39:34 +00:00

I didn't start touching this file as there hasn't been feedback (and I forgot it), but should I start sorting the recommendations there? I hope not.

I didn't start touching this file as there hasn't been feedback (and I forgot it), but should I start sorting the recommendations there? I hope not.
nitrohorse (Migrated from github.com) reviewed 2019-08-24 02:31:12 +00:00
_includes/sections/dns.html
nitrohorse (Migrated from github.com) commented 2019-08-24 02:31:12 +00:00

Yeah, makes sense to me 👍

Yeah, makes sense to me :+1:
nitrohorse (Migrated from github.com) reviewed 2019-08-24 02:32:24 +00:00
_includes/sections/dns.html
nitrohorse (Migrated from github.com) commented 2019-08-24 02:32:24 +00:00

I wonder if these titles are as clear and a bit less wordy?

  • Encrypted DNS clients for desktop:
  • Encrypted DNS clients for mobile:
I wonder if these titles are as clear and a bit less wordy? - `Encrypted DNS clients for desktop:` - `Encrypted DNS clients for mobile:`
nitrohorse (Migrated from github.com) reviewed 2019-08-24 02:35:06 +00:00
_includes/sections/dns.html
nitrohorse (Migrated from github.com) commented 2019-08-24 02:35:06 +00:00

Yeah, makes sense to me!

Yeah, makes sense to me!
nitrohorse (Migrated from github.com) reviewed 2019-08-24 02:36:36 +00:00
source_code.md
nitrohorse (Migrated from github.com) commented 2019-08-24 02:36:36 +00:00

Ideally I think each section would have the same order as what's on the section but I think as long as the source code is listed in the right section that's fine.

Ideally I think each section would have the same order as what's on the section but I think as long as the source code is listed in the right section that's fine.
nitrohorse (Migrated from github.com) reviewed 2019-08-24 02:42:20 +00:00
_includes/sections/dns.html
nitrohorse (Migrated from github.com) commented 2019-08-24 02:42:20 +00:00

I think just to keep the HTML tidy, we should move the </li> tags to the bottom of their corresponding </ul> tag, wrapping the list. Ex:

  <ul>
    <li><strong>Desktop software with support for encrypted DNS:</strong>
      <ul>
        <li><em>Firefox</em> comes with built-in DoH support with Cloudflare set as the default resolver, but can be configured to use any DoH resolver. <span class="badge badge-warning" data-toggle="tooltip" data-placement="bottom" data-original-title='"Cloudflare has agreed to collect only a limited amount of data about the DNS requests that are sent to the Cloudflare Resolver for Firefox via the Firefox browser."'><a href="https://developers.cloudflare.com/1.1.1.1/commitment-to-privacy/privacy-policy/firefox/"><i class="fas fa-exclamation-triangle"></i></a></span> Currently Mozilla is <a href="https://blog.mozilla.org/futurereleases/2019/07/31/dns-over-https-doh-update-detecting-managed-networks-and-user-choice/">conducting studies</a> before enabling DoH by default for all US-based Firefox users.</li>
      </ul>
    </li>
    <li><strong>Mobile software with support for encrypted DNS:</strong>
      <ul>
        <li><em>Android 9</em> comes with a DoT client by <a href="https://support.google.com/android/answer/9089903">default</a>. <span class="badge badge-warning" data-toggle="tooltip" data-original-title="...but with some caveats"><a href="https://www.quad9.net/private-dns-quad9-android9/"><i class="fas fa-exclamation-triangle"></i></a></span></li>
        <li><em><a href="https://apps.apple.com/app/id1452162351">DNSCloak</a></em> - An <a href="https://github.com/s-s/dnscloak">open-source</a> DNSCrypt and DoH client for iOS by <td><a data-toggle="tooltip" data-placement="bottom" data-original-title='"A charitable non-profit host organization for international Free Software projects."' href="https://techcultivation.org/">the Center for the Cultivation of Technology gemeinnuetzige GmbH</a>.</li>
        <li><em><a href="https://git.frostnerd.com/PublicAndroidApps/smokescreen/blob/master/README.md">Nebulo</a></em> - An open-source application for Android supporting DoH and DoT. It also supports caching DNS responses and locally logging DNS queries.</li>
      </ul>
    </li>
    <li><strong>Local DNS servers:</strong>
      <ul>
        <li><em><a href="https://dnsprivacy.org/wiki/display/DP/DNS+Privacy+Daemon+-+Stubby">Stubby</a></em> - An open-source application for Linux, macOS, and Windows that acts as a local DNS Privacy stub resolver using DoT.</li>
        <li><em><a href="https://namecoin.info/">Namecoin</a></em> - A decentralized DNS open-source information registration and transfer system based on the Bitcoin cryptocurrency.</li>
      </ul>
    </li>
    <li><strong>Network wide DNS servers:</strong>
      <ul>
        <li><em><a href="https://pi-hole.net/">Pi-hole</a></em> - A network-wide DNS server mainly for the Raspberry Pi. Blocks ads, tracking, and malicious domains for all devices on your network.</li>
        <li><em><a href="https://gitlab.com/quidsup/notrack">NoTrack</a></em> - A network-wide DNS server like Pi-hole for blocking ads, tracking, and malicious domains.</li>
      </ul>
    </li>
    <li><strong>Further reading:</strong>
      <ul>
        <li><a href="https://www.isc.org/blogs/qname-minimization-and-privacy/">QNAME Minimization and Your Privacy</a> by the Internet Systems Consortium (ISC)</li>
        <li><a href="https://www.isc.org/dnssec/">DNSSEC and BIND 9</a> by the ISC</li>
      </ul>
    </li>
  </ul>
I think just to keep the HTML tidy, we should move the `</li>` tags to the bottom of their corresponding `</ul>` tag, wrapping the list. Ex: ```html <ul> <li><strong>Desktop software with support for encrypted DNS:</strong> <ul> <li><em>Firefox</em> comes with built-in DoH support with Cloudflare set as the default resolver, but can be configured to use any DoH resolver. <span class="badge badge-warning" data-toggle="tooltip" data-placement="bottom" data-original-title='"Cloudflare has agreed to collect only a limited amount of data about the DNS requests that are sent to the Cloudflare Resolver for Firefox via the Firefox browser."'><a href="https://developers.cloudflare.com/1.1.1.1/commitment-to-privacy/privacy-policy/firefox/"><i class="fas fa-exclamation-triangle"></i></a></span> Currently Mozilla is <a href="https://blog.mozilla.org/futurereleases/2019/07/31/dns-over-https-doh-update-detecting-managed-networks-and-user-choice/">conducting studies</a> before enabling DoH by default for all US-based Firefox users.</li> </ul> </li> <li><strong>Mobile software with support for encrypted DNS:</strong> <ul> <li><em>Android 9</em> comes with a DoT client by <a href="https://support.google.com/android/answer/9089903">default</a>. <span class="badge badge-warning" data-toggle="tooltip" data-original-title="...but with some caveats"><a href="https://www.quad9.net/private-dns-quad9-android9/"><i class="fas fa-exclamation-triangle"></i></a></span></li> <li><em><a href="https://apps.apple.com/app/id1452162351">DNSCloak</a></em> - An <a href="https://github.com/s-s/dnscloak">open-source</a> DNSCrypt and DoH client for iOS by <td><a data-toggle="tooltip" data-placement="bottom" data-original-title='"A charitable non-profit host organization for international Free Software projects."' href="https://techcultivation.org/">the Center for the Cultivation of Technology gemeinnuetzige GmbH</a>.</li> <li><em><a href="https://git.frostnerd.com/PublicAndroidApps/smokescreen/blob/master/README.md">Nebulo</a></em> - An open-source application for Android supporting DoH and DoT. It also supports caching DNS responses and locally logging DNS queries.</li> </ul> </li> <li><strong>Local DNS servers:</strong> <ul> <li><em><a href="https://dnsprivacy.org/wiki/display/DP/DNS+Privacy+Daemon+-+Stubby">Stubby</a></em> - An open-source application for Linux, macOS, and Windows that acts as a local DNS Privacy stub resolver using DoT.</li> <li><em><a href="https://namecoin.info/">Namecoin</a></em> - A decentralized DNS open-source information registration and transfer system based on the Bitcoin cryptocurrency.</li> </ul> </li> <li><strong>Network wide DNS servers:</strong> <ul> <li><em><a href="https://pi-hole.net/">Pi-hole</a></em> - A network-wide DNS server mainly for the Raspberry Pi. Blocks ads, tracking, and malicious domains for all devices on your network.</li> <li><em><a href="https://gitlab.com/quidsup/notrack">NoTrack</a></em> - A network-wide DNS server like Pi-hole for blocking ads, tracking, and malicious domains.</li> </ul> </li> <li><strong>Further reading:</strong> <ul> <li><a href="https://www.isc.org/blogs/qname-minimization-and-privacy/">QNAME Minimization and Your Privacy</a> by the Internet Systems Consortium (ISC)</li> <li><a href="https://www.isc.org/dnssec/">DNSSEC and BIND 9</a> by the ISC</li> </ul> </li> </ul> ```
nitrohorse commented 2019-08-24 02:43:33 +00:00 (Migrated from github.com)
Copy Link

Some further suggestions but LGTM otherwise; glad to see this further organized! 😄

Some further suggestions but LGTM otherwise; glad to see this further organized! :smile:
Mikaela (Migrated from github.com) reviewed 2019-08-24 10:10:10 +00:00
source_code.md
Mikaela (Migrated from github.com) commented 2019-08-24 10:10:09 +00:00

I tried to change the order to that

I tried to change the order to that
nitrohorse (Migrated from github.com) approved these changes 2019-08-24 14:36:29 +00:00
nitrohorse (Migrated from github.com) left a comment

Looks great!

Looks great!
dawidpotocki (Migrated from github.com) approved these changes 2019-08-24 14:53:45 +00:00
This repo is archived. You cannot comment on pull requests.
Reviewers
No reviewers
jonah
blacklight447
nitrohorse
dawidpotocki
Labels
Clear labels   
🔍🤖 Search Engines

   
approved

approved, waiting for a PR

  
dependencies

Pull requests that update a dependency file

  
duplicate

   
feedback wanted

   
high priority

   
I2P

The Invisible Internet Project (I2P)

  
iOS

   
low priority

   
OS

Operating Systems

  
Self-contained networks

   
Social media

   
stale

A label for stalebot if it gets added

  
streaming

Anything related to media streaming.

  
todo

   
Tor

Anything covering the Tor network

  
WIP

active work in progress, do not merge or PR (yet)!

  
wontfix

Issues or bugs that will not be fixed and/or do not have significant impact on the project.

  
XMPP

Extensible Messaging and Presence Protocol

  
[m]

Matrix protocol

  
₿ cryptocurrency

   
ℹ️ help wanted

   
↔️ file sharing

   
⚙️ web extensions

Browser Extension related issues

  
✨ enhancement

   
❌ software removal

   
💬 discussion

   
🤖 Android

   
🐛 bug

   
💢 conflicting

   
📝 correction

Correction of content on the website

  
🆘 critical

   
📧 email

   
🔒 file encryption

   
📁 file storage

   
🦊 Firefox

Firefox & forks, about:config etc.

  
💻 hardware

   
🌐 hosting

   
🏠 housekeeping

Anything primarily related to site cleanup.

  
🔐 password managers

   
🧰 productivity tools

   
🔎 research required

   
🌐 Social News Aggregators

   
🆕 software suggestion

   
👥 team chat

   
🔒 VPN

Virtual Private Network

  
🌐 website issue

*Technical* issues with the website.

  
🚫 Windows

   
👁️ browsers

   
🖊️ digital notebooks

   
🗄️ DNS

Domain Name System

  
🗨️ instant messaging (im)

   
🇦🇶 translations

Anything covering a translated version of the site

No Label
🔍🤖 Search Engines
approved
dependencies
duplicate
feedback wanted
high priority
I2P
iOS
low priority
OS
Self-contained networks
Social media
stale
streaming
todo
Tor
WIP
wontfix
XMPP
[m]
₿ cryptocurrency
ℹ️ help wanted
↔️ file sharing
⚙️ web extensions
✨ enhancement
❌ software removal
💬 discussion
🤖 Android
🐛 bug
💢 conflicting
📝 correction
🆘 critical
📧 email
🔒 file encryption
📁 file storage
🦊 Firefox
💻 hardware
🌐 hosting
🏠 housekeeping
🔐 password managers
🧰 productivity tools
🔎 research required
🌐 Social News Aggregators
🆕 software suggestion
👥 team chat
🔒 VPN
🌐 website issue
🚫 Windows
👁️ browsers
🖊️ digital notebooks
🗄️ DNS
🗨️ instant messaging (im)
🇦🇶 translations
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
1 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: privacyguides/privacytools.io#1200
No description provided.
Delete Branch "nebulo"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?