Update Email column sorting #1143

jonah · 2019-08-12T05:42:28Z

nitrohorse commented

2019-08-12 05:42:28 +00:00

(Migrated from github.com)

Description

Addresses some Email Providers table sorting issues:

Because the Email (name) column header has data-sorted="true", we need to have all the providers already in alphabetical order because we're telling the table, 'hey, you're sorted alphabetically already' 😄
Soverin had a value of "1" for the Encryption cell value -- corrected to "0"
Updated all the data-value for each provider's price cell to 4 digits to account for cents.

Resolves: https://github.com/privacytoolsIO/privacytools.io/issues/1140

Check List

I have read and understand CONTRIBUTING.md.
~~[] I have listed the source code for this project in source_code.md.~~
~~This project is free/libre software.~~
~~This project has an associated discussion.~~

Code Repository (if applicable): N/A

## Description Addresses some Email Providers table sorting issues: - Because the Email (name) column header has `data-sorted="true"`, we need to have all the providers already in alphabetical order because we're telling the table, 'hey, you're sorted alphabetically already' :smile: - Soverin had a value of "1" for the Encryption cell value -- corrected to "0" - Updated all the data-value for each provider's price cell to 4 digits to account for cents. Resolves: https://github.com/privacytoolsIO/privacytools.io/issues/1140 #### Check List  - [x] I have read and understand [CONTRIBUTING.md](https://github.com/privacytoolsIO/privacytools.io/blob/master/.github/CONTRIBUTING.md). - ~~[] I have listed the source code for this project in [source_code.md](https://github.com/privacytoolsIO/privacytools.io/blob/master/source_code.md).~~ - ~~[ ] This project is [free/libre software](https://www.wikipedia.org/wiki/Free_software).~~ - ~~[ ] This project has an [associated discussion](https://github.com/privacytoolsIO/privacytools.io/issues).~~ Code Repository (if applicable): N/A

netlify[bot] commented

2019-08-12 05:43:10 +00:00

(Migrated from github.com)

Deploy preview for privacytools-io ready!

Built with commit d906b095c2

https://deploy-preview-1143--privacytools-io.netlify.com

Deploy preview for *privacytools-io* ready! Built with commit d906b095c2b6369c995398a8c69f1efefcdf1aaa https://deploy-preview-1143--privacytools-io.netlify.com

jonah reviewed 2019-08-12 05:45:18 +00:00

Mikaela (Migrated from github.com) reviewed 2019-08-13 11:43:59 +00:00

Mikaela (Migrated from github.com) left a comment

If I understand correctly that you are putting these in alphabetical order, the end is wrong.

Your list: Runbox Tutanota Soverin Startmail

Alphabetical order: Runbox Soverin Startmail Tutanota

If I understand correctly that you are putting these in alphabetical order, the end is wrong. Your list: Runbox *Tutanota* Soverin Startmail Alphabetical order: Runbox Soverin Startmail *Tutanota*

Mikaela commented

2019-08-13 11:47:20 +00:00

(Migrated from github.com)

I am also wondering how you assign the numbers? Are you converting EUR to USD?

nitrohorse commented

2019-08-14 03:02:25 +00:00

(Migrated from github.com)

I am also wondering how you assign the numbers? Are you converting EUR to USD?

Yeah, you think that's ok?

> I am also wondering how you assign the numbers? Are you converting EUR to USD? Yeah, you think that's ok?

jonah approved these changes 2019-08-14 06:10:14 +00:00

blacklight447 (Migrated from github.com) approved these changes 2019-08-14 15:19:22 +00:00

blacklight447 (Migrated from github.com) left a comment

looks alright!

Mikaela commented

2019-08-16 17:06:04 +00:00

(Migrated from github.com)

I am also wondering how you assign the numbers? Are you converting EUR to USD?

Yeah, you think that's ok?

Sure as long as it's known, I would probably add a comment to explain it.

>> I am also wondering how you assign the numbers? Are you converting EUR to USD? > Yeah, you think that's ok? Sure as long as it's known, I would probably add a comment to explain it.

This repo is archived. You cannot comment on pull requests.

No reviewers

blacklight447