privacyguides/privacytools.io
Archived
1
0
Fork 0
Code Issues 304 Pull Requests 47 Activity

Merge im, teamchat and video-voice into real-time-communication #1136

Merged
Mikaela merged 8 commits from real-time-communication into master 2019-08-12 03:18:19 +00:00
Conversation 11 Commits 8 Files Changed 6 +22 -27
Mikaela commented 2019-08-11 16:06:36 +00:00 (Migrated from github.com)
Copy Link

Resolves: #1078

Closes: #746

Preview: https://deploy-preview-1136--privacytools-io.netlify.com/software/real-time-communication/

Resolves: #1078 Closes: #746 Preview: https://deploy-preview-1136--privacytools-io.netlify.com/software/real-time-communication/
blacklight447 (Migrated from github.com) reviewed 2019-08-11 16:06:36 +00:00
netlify[bot] commented 2019-08-11 16:07:19 +00:00 (Migrated from github.com)
Copy Link

Deploy preview for privacytools-io ready!

Built with commit 98bca69952

https://deploy-preview-1136--privacytools-io.netlify.com

Deploy preview for *privacytools-io* ready! Built with commit 98bca69952354bf4a8413c287f0eaaf501900068 https://deploy-preview-1136--privacytools-io.netlify.com
Mikaela (Migrated from github.com) reviewed 2019-08-11 16:23:03 +00:00
Mikaela (Migrated from github.com) left a comment

Commentary on why I did what I did

Commentary on why I did what I did
_config.yml
@ -5,6 +5,7 @@ sass:
style: compressed
plugins:
- jekyll-sitemap
- jekyll-redirect-from
Mikaela (Migrated from github.com) commented 2019-08-11 16:20:41 +00:00

I think @JonahAragon said that he would do this with nginx which is more elegant, but I guess it won't hurt being here too as Nginx is going to take a preference and in case nginx got forgotten, the user wouldn't see that much of a difference.

I think @JonahAragon said that he would do this with nginx which is more elegant, but I guess it won't hurt being here too as Nginx is going to take a preference and in case nginx got forgotten, the user wouldn't see that much of a difference.
_includes/nav.html
Mikaela (Migrated from github.com) commented 2019-08-11 16:20:53 +00:00

Better icon suggestions?

Better icon suggestions?
pages/software/real-time-communication.html
@ -0,0 +6,4 @@
- /software/voip/
- /software/teamchat/
title: "Real-Time Communication"
description: "Discover secure and private ways to communicate with others online without letting any third parties read your messages."
Mikaela (Migrated from github.com) commented 2019-08-11 16:21:21 +00:00

I thought that this was the best applying description to them all together.

I thought that this was the best applying description to them all together.
pages/software/real-time-communication.html
@ -0,0 +11,4 @@
{% include sections/instant-messenger.html %}
<hr/>
Mikaela (Migrated from github.com) commented 2019-08-11 16:21:38 +00:00

I wish to have some separator between the different sections, even if they are on the same page.

I wish to have some separator between the different sections, even if they are on the same page.
Mikaela (Migrated from github.com) commented 2019-08-11 16:22:42 +00:00

And I think this ordering makes the most sense as I think people are most often looking for instant messengers, then VoIP and team chat is a bit rarer scenario as I think that is mostly forced on people from whichever the team founder prefers.

And I think this ordering makes the most sense as I think people are most often looking for instant messengers, then VoIP and team chat is a bit rarer scenario as I think that is mostly forced on people from whichever the team founder prefers.
nitrohorse (Migrated from github.com) reviewed 2019-08-11 16:23:39 +00:00
nitrohorse (Migrated from github.com) left a comment

Minor suggestions but otherwise lgtm!

Minor suggestions but otherwise lgtm!
_includes/nav.html
nitrohorse (Migrated from github.com) commented 2019-08-11 16:22:28 +00:00

What if we updated the title to "Real-Time Communication"?

What if we updated the title to "Real-Time Communication"?
pages/software/real-time-communication.html
nitrohorse (Migrated from github.com) commented 2019-08-11 16:22:45 +00:00

"Real-Time Communication"?

"Real-Time Communication"?
nitrohorse (Migrated from github.com) reviewed 2019-08-11 16:24:27 +00:00
pages/software/real-time-communication.html
@ -0,0 +6,4 @@
- /software/voip/
- /software/teamchat/
title: "Real-Time Communication"
description: "Discover secure and private ways to communicate with others online without letting any third parties read your messages."
nitrohorse (Migrated from github.com) commented 2019-08-11 16:24:27 +00:00

That sounds good to me.

That sounds good to me.
nitrohorse (Migrated from github.com) reviewed 2019-08-11 16:26:28 +00:00
pages/software/real-time-communication.html
@ -0,0 +11,4 @@
{% include sections/instant-messenger.html %}
<hr/>
nitrohorse (Migrated from github.com) commented 2019-08-11 16:26:28 +00:00

Yeah the breaks work well in my perspective.

Yeah the breaks work well in my perspective.
Mikaela commented 2019-08-11 16:27:00 +00:00 (Migrated from github.com)
Copy Link

Changed to Real-Time Communication as requested by @nitrohorse

Changed to Real-Time Communication as requested by @nitrohorse
nitrohorse (Migrated from github.com) reviewed 2019-08-11 17:06:15 +00:00
_includes/nav.html
nitrohorse (Migrated from github.com) commented 2019-08-11 17:06:15 +00:00

I forget which issue but I thought @JonahAragon had a recommendation for this...

I forget which issue but I thought @JonahAragon had a recommendation for this...
nitrohorse (Migrated from github.com) approved these changes 2019-08-11 17:06:40 +00:00
nitrohorse (Migrated from github.com) left a comment

LGTM

LGTM
jonah requested changes 2019-08-11 23:16:38 +00:00
jonah left a comment

I would rather do redirects with Nginx only I think, so as to not require too many Jekyll extensions on both the server and on local dev machines.

If we want, we could add an Nginx config file to this repo that would then be “include”d in the server config, so we can add redirects and other server-side configs here directly?

I would rather do redirects with Nginx only I think, so as to not require too many Jekyll extensions on both the server and on local dev machines. If we want, we could add an Nginx config file to this repo that would then be “include”d in the server config, so we can add redirects and other server-side configs here directly?
nitrohorse commented 2019-08-12 00:33:41 +00:00 (Migrated from github.com)
Copy Link

If we want, we could add an Nginx config file to this repo that would then be “include”d in the server config, so we can add redirects and other server-side configs here directly?

Oh nice, that sounds helpful 👍

> If we want, we could add an Nginx config file to this repo that would then be “include”d in the server config, so we can add redirects and other server-side configs here directly? Oh nice, that sounds helpful :+1:
This repo is archived. You cannot comment on pull requests.
Reviewers
No Reviewers
jonah
blacklight447
nitrohorse
Labels
Clear labels
🔍🤖 Search Engines
approved
approved, waiting for a PR
dependencies
Pull requests that update a dependency file
duplicate
feedback wanted
high priority
I2P
The Invisible Internet Project (I2P)
iOS
low priority
OS
Operating Systems
Self-contained networks
Social media
stale
A label for stalebot if it gets added
streaming
Anything related to media streaming.
todo
Tor
Anything covering the Tor network
WIP
active work in progress, do not merge or PR (yet)!
wontfix
Issues or bugs that will not be fixed and/or do not have significant impact on the project.
XMPP
Extensible Messaging and Presence Protocol
[m]
Matrix protocol
₿ cryptocurrency
ℹ️ help wanted
↔️ file sharing
⚙️ web extensions
Browser Extension related issues
✨ enhancement
❌ software removal
💬 discussion
🤖 Android
🐛 bug
💢 conflicting
📝 correction
Correction of content on the website
🆘 critical
📧 email
🔒 file encryption
📁 file storage
🦊 Firefox
Firefox & forks, about:config etc.
💻 hardware
🌐 hosting
🏠 housekeeping
Anything primarily related to site cleanup.
🔐 password managers
🧰 productivity tools
🔎 research required
🌐 Social News Aggregators
🆕 software suggestion
👥 team chat
🔒 VPN
Virtual Private Network
🌐 website issue
*Technical* issues with the website.
🚫 Windows
👁️ browsers
🖊️ digital notebooks
🗄️ DNS
Domain Name System
🗨️ instant messaging (im)
🇦🇶 translations
Anything covering a translated version of the site
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
jonah
No Assignees
1 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: privacyguides/privacytools.io#1136
No description provided.
Delete Branch "real-time-communication"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?