dns: add ICANN DNS supporting encryption to worth mentioning #1054

jonah · 2019-07-25T13:48:33Z

Mikaela commented

2019-07-25 13:48:33 +00:00

(Migrated from github.com)

Resolves: #1028

Unblocks: #785

Resolves: #1028 Unblocks: #785

blacklight447 (Migrated from github.com) reviewed 2019-07-25 13:48:33 +00:00

bookercodes (Migrated from github.com) reviewed 2019-07-25 13:48:33 +00:00

privacytoolsIO (Migrated from github.com) reviewed 2019-07-25 13:48:33 +00:00

c0rdis (Migrated from github.com) reviewed 2019-07-25 13:48:33 +00:00

jxtsai (Migrated from github.com) reviewed 2019-07-25 13:48:33 +00:00

kewde (Migrated from github.com) reviewed 2019-07-25 13:48:33 +00:00

victorhck (Migrated from github.com) reviewed 2019-07-25 13:48:33 +00:00

Vincevrp (Migrated from github.com) reviewed 2019-07-25 13:48:33 +00:00

netlify[bot] commented

2019-07-25 13:49:13 +00:00

(Migrated from github.com)

Deploy preview for privacytools-io ready!

Built with commit 621ec36999

https://deploy-preview-1054--privacytools-io.netlify.com

Deploy preview for *privacytools-io* ready! Built with commit 621ec36999d9b3090a91a93a9a56c90dfacb1da1 https://deploy-preview-1054--privacytools-io.netlify.com

Mikaela (Migrated from github.com) reviewed 2019-07-25 13:57:16 +00:00

_includes/sections/dns.html

Mikaela (Migrated from github.com) commented

2019-07-25 13:57:16 +00:00

TODO: is ICANN DNS the correct word? @JonahAragon you know what the OpenNIC people call it?

Mikaela commented

2019-07-25 14:43:18 +00:00

(Migrated from github.com)

I guess this is ready for review. My only bigger problem (other than the ICANN DNS word of which I am not sure) is that the anchor doesn't work as I wish it would work, see https://deploy-preview-1054--privacytools-io.netlify.com/providers/dns/#icanndns . How would I go fixing it?

Mikaela (Migrated from github.com) reviewed 2019-07-30 17:54:30 +00:00

_includes/sections/dns.html

Mikaela (Migrated from github.com) commented

2019-07-30 17:54:30 +00:00

@JonahAragon I take the 👍 that it's the correct word, could you then review and maybe merge this? :)

nitrohorse commented

2019-07-30 18:03:05 +00:00

(Migrated from github.com)

How would I go fixing it?

@Mikaela, I’ll take a look at this later and see if I can help here.

> How would I go fixing it? @Mikaela, I’ll take a look at this later and see if I can help here.

nitrohorse (Migrated from github.com) reviewed 2019-07-31 05:08:30 +00:00

nitrohorse (Migrated from github.com) left a comment

LGTM

_includes/sections/dns.html

nitrohorse (Migrated from github.com) commented

2019-07-31 04:59:17 +00:00

Small typo here:

<a href=https://www.globalcyberalliance.org/quad9/"">Global Cyber Alliance</a>

Should be:

<a href="https://www.globalcyberalliance.org/quad9/">Global Cyber Alliance</a>

Small typo here: ```html <a href=https://www.globalcyberalliance.org/quad9/"">Global Cyber Alliance</a> ``` Should be: ```html <a href="https://www.globalcyberalliance.org/quad9/">Global Cyber Alliance</a> ```

nitrohorse (Migrated from github.com) reviewed 2019-07-31 05:13:08 +00:00

_includes/sections/dns.html

nitrohorse (Migrated from github.com) commented

2019-07-31 05:13:08 +00:00

I'm wondering if we should use "DNS over TLS" and "DNS over HTTPS" in the AdGuard description for consistency? Not sure if "DoH" and "DoT" shorthands are easily understandable unless stated somewhere here?

nitrohorse (Migrated from github.com) reviewed 2019-07-31 05:30:15 +00:00

_includes/sections/dns.html

nitrohorse (Migrated from github.com) commented

2019-07-31 05:30:14 +00:00

Looks like

Bundling some of my non-blocking suggestions below 😄

I thought also pulling out the "malicious domain filtering" note from Q9's tooltip could be helpful for visibility.
Some grammatical updates, and clear up uses of "DoT" and "DoH" for users who don’t know what they stand for.
Add "anycast" to the early descriptions of AdGuard and Q9
Fix the anchor link

  <li><a href="#icanndns" id="icanndns">ICANN DNS</a> resolvers with support for encrypted DNS</li>
  <ul>
    <li><a href="https://adguard.com/en/adguard-dns/overview.html">AdGuard DNS</a> - A commercial, anycast DNS resolver with ad-blocking and support for DNS over HTTPS (DoH), DNS over TLS (DoT), and DNSCrypt. <span class="badge badge-warning" data-toggle="tooltip" title="Uses Cloudflare, no DNSSEC, for-profit (in Cyprus)">Warnings <i class="far fa-question-circle"></i></a></span></li>
    <li><a href="https://blahdns.com/">BlahDNS</a> - A small hobby ad-blocking DNS project with DoH, DoT, and DNSCrypt support. Servers located in Switzerland, Japan, and Germany. <span class="badge badge-warning" data-toggle="tooltip" title="'Use at your own risk.', uses Cloudflare">Warnings <i class="far fa-question-circle"></i></a></span></li>
    <li><a href="https://powerdns.org/">PowerDNS</a> - A best effort DoH service. Servers located in the Netherlands.</li>
    <li><a href="https://quad9.net/">Quad9 DNS</a> - A non-profit, anycast DNS provider founded by <a href="https://www-03.ibm.com/press/us/en/pressrelease/53388.wss">IBM</a>, <a href="https://www.pch.net/">PCH</a>, and <a href=https://www.globalcyberalliance.org/quad9/"">Global Cyber Alliance</a>. Provides malicious domain filtering and supports DoH, DoT, and DNSCrypt. <span class="badge badge-warning" data-toggle="tooltip" title="Founders of Global Cyber Alliance include: City of London Police & Manhattan District Attorney's Office">Warnings <i class="far fa-question-circle"></i></a></span></li>
  </ul>

Looks like - [AdGuard supports DNSCrypt](https://adguard.com/en/blog/adguard-dns-now-supports-dnscrypt.html) - and [Quad9 supports DNSCrypt](https://www.quad9.net/dnscryptlive/) Bundling some of my non-blocking suggestions below :smile: - I thought also pulling out the "malicious domain filtering" note from Q9's tooltip could be helpful for visibility. - Some grammatical updates, and clear up uses of "DoT" and "DoH" for users who don’t know what they stand for. - Add "anycast" to the early descriptions of AdGuard and Q9 - Fix the anchor link ```html <li><a href="#icanndns" id="icanndns">ICANN DNS</a> resolvers with support for encrypted DNS</li> <ul> <li><a href="https://adguard.com/en/adguard-dns/overview.html">AdGuard DNS</a> - A commercial, anycast DNS resolver with ad-blocking and support for DNS over HTTPS (DoH), DNS over TLS (DoT), and DNSCrypt. Warnings </a></li> <li><a href="https://blahdns.com/">BlahDNS</a> - A small hobby ad-blocking DNS project with DoH, DoT, and DNSCrypt support. Servers located in Switzerland, Japan, and Germany. Warnings </a></li> <li><a href="https://powerdns.org/">PowerDNS</a> - A best effort DoH service. Servers located in the Netherlands.</li> <li><a href="https://quad9.net/">Quad9 DNS</a> - A non-profit, anycast DNS provider founded by <a href="https://www-03.ibm.com/press/us/en/pressrelease/53388.wss">IBM</a>, <a href="https://www.pch.net/">PCH</a>, and <a href=https://www.globalcyberalliance.org/quad9/"">Global Cyber Alliance</a>. Provides malicious domain filtering and supports DoH, DoT, and DNSCrypt. Warnings </a></li> </ul> ```

Mikaela (Migrated from github.com) reviewed 2019-07-31 11:29:44 +00:00

_includes/sections/dns.html

Mikaela (Migrated from github.com) commented

2019-07-31 11:29:44 +00:00

I am confused by having everything in one and I guess I am just committing your changes to see the diff and then commenting on the result.

Mikaela (Migrated from github.com) reviewed 2019-07-31 11:34:20 +00:00

_includes/sections/dns.html

Mikaela (Migrated from github.com) commented

2019-07-31 11:34:20 +00:00

@nitrohorse I am otherwise happy with your suggestions, but I don't understand this line as it results ICANN DNS into being a link to itself.

Mikaela (Migrated from github.com) reviewed 2019-07-31 11:38:55 +00:00

_includes/sections/dns.html

Mikaela (Migrated from github.com) commented

2019-07-31 11:38:55 +00:00

Proposed link: https://en.wikipedia.org/wiki/DNS_root_zone ?

nitrohorse (Migrated from github.com) reviewed 2019-07-31 15:01:05 +00:00

_includes/sections/dns.html

nitrohorse (Migrated from github.com) commented

2019-07-31 15:01:04 +00:00

Ah, ok, I misunderstood what you were trying to do 👍🏼That makes it an anchor link so when clicked, the page navigates “down” to put it more into focus. Didn’t realize you wanted it to be an actual href 🤓

Mikaela (Migrated from github.com) reviewed 2019-07-31 21:23:54 +00:00

_includes/sections/dns.html

Mikaela (Migrated from github.com) commented

2019-07-31 21:23:54 +00:00

I am going to restore it into what it was and hope that it's fine for you then.

Mikaela (Migrated from github.com) reviewed 2019-07-31 21:30:07 +00:00

_includes/sections/dns.html

Mikaela (Migrated from github.com) commented

2019-07-31 21:30:07 +00:00

What I want is to being able to link to https://deploy-preview-1054--privacytools-io.netlify.com/providers/dns/#icanndns from the implementation of #785 as network.trr.uri in my vision is going to ask for checking the documentation of your DNS provider and it doesn't support DoH, check our list for pointers https://deploy-preview-1054--privacytools-io.netlify.com/providers/dns/#icanndns

What I want is to being able to link to https://deploy-preview-1054--privacytools-io.netlify.com/providers/dns/#icanndns from the implementation of #785 as `network.trr.uri` in my vision is going to ask for checking the documentation of your DNS provider and it doesn't support DoH, check our list for pointers https://deploy-preview-1054--privacytools-io.netlify.com/providers/dns/#icanndns