Add Checklist to PRs #1041
|
@ -2,10 +2,16 @@
|
|||
|
||||
## Description
|
||||
|
||||
Resolves: #none <!-- The number of the issue that is resolved by this pull request. If there is none, feel free to delete this line -->
|
||||
Resolves: #none <!-- The number of the issue that is resolved by this pull request. If there is none, feel free to delete this line
|
||||
|
||||
|
||||
<!--
|
||||
## Screenshots
|
||||
#### Check List <!-- Please add an x in each box below, like so: [x] -->
|
||||
|
||||
I think this is reduntant as when you open a PR, GitHub suggests you on the right to read the contributing guidelines. It also appears somewhat formal to me. I think this is reduntant as when you open a PR, GitHub suggests you on the right to read the contributing guidelines. It also appears somewhat formal to me.
I am not sure if this is that good idea as it could easily cause a merge conflict if multiple users were submitting PRs to add multiple apps/services simultaneously. I think it should possibly be something for a team member to update (but it needs a PR with approval)? Ideas @BurungHantu1605 ? I am not sure if this is that good idea as it could easily cause a merge conflict if multiple users were submitting PRs to add multiple apps/services simultaneously. I think it should possibly be something for a team member to update (but it needs a PR with approval)? Ideas @BurungHantu1605 ?
I think this should be "Project is preferably..." I think this should be "Project is preferably..."
I wonder if this could be removed as Netlify handles that? I wonder if this could be removed as Netlify handles that?
jonah
commented
AFAIK it will only cause a merge conflict if people edit the same line, which seems unlikely since they'll likely be editing different sections of the file. But in any case merge conflicts are relatively easy to solve when a team member merges them. I would however make the following grammatical changes:
AFAIK it will only cause a merge conflict if people edit the same line, which seems unlikely since they'll likely be editing different sections of the file. But in any case merge conflicts are relatively easy to solve when a team member merges them. I would however make the following grammatical changes:
```suggestion
- [ ] I have listed any applicable source code in [source_code.md](https://github.com/privacytoolsIO/privacytools.io/blob/master/source_code.md)
```
jonah
commented
I think this is fine to include if we're doing this, because it means people need to affirm that they have read it directly.
I think this is fine to include if we're doing this, because it means people need to affirm that they have read it directly.
```suggestion
- [ ] I have read and understand [CONTRIBUTING.md](https://github.com/privacytoolsIO/privacytools.io/blob/master/.github/CONTRIBUTING.md)
```
jonah
commented
I would add instructions for those unfamiliar with Markdown.
I would add instructions for those unfamiliar with Markdown.
```suggestion
#### Check List <!-- Please add an x in each box below, like so: [x] -->
```
jonah
commented
```suggestion
- [ ] This project is [free software](https://www.wikipedia.org/wiki/Free_software), unless 1) no free software alternative exists, or 2) this software is significantly better than a free software alternative.
```
```suggestion
```
fixed in latest commit. Thx fixed in latest commit.
Thx
Software must actually be free software: But, ya that description makes more sense. Software must actually be [free software](https://www.wikipedia.org/wiki/Free_software):
https://github.com/privacytoolsIO/privacytools.io/blob/master/.github/CONTRIBUTING.md#software
But, ya that description makes more sense.
|
||||
Please add screenshots if applicable
|
||||
-->
|
||||
- [ ] I have read and understand [CONTRIBUTING.md](https://github.com/privacytoolsIO/privacytools.io/blob/master/.github/CONTRIBUTING.md).
|
||||
|
||||
- [ ] I have listed the source code for this project in [source_code.md](https://github.com/privacytoolsIO/privacytools.io/blob/master/source_code.md).
|
||||
|
||||
- [ ] This project is [free/libre software](https://www.wikipedia.org/wiki/Free_software).
|
||||
|
||||
- [ ] This project has an [associated discussion](https://github.com/privacytoolsIO/privacytools.io/issues).
|
||||
|
||||
Code Repository (if applicable):
|
||||
|
|
Thanks