privacyguides/privacytools.io
Archived
1
0
Fork 0
Code Issues 304 Pull Requests 47 Activity

Add Checklist to PRs #1041

Merged
ggg27 merged 10 commits from patch-2 into master 2019-08-09 02:12:05 +00:00
Conversation 27 Commits 10 Files Changed 1 +10 -1
1 changed files with 10 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit c627535beb - Show all commits

1
.github/PULL_REQUEST_TEMPLATE.md vendored
View File

@ -7,7 +7,6 @@ Resolves: #none <!-- The number of the issue that is resolved by this pull reque
<!-- <!--
## Screenshots ## Screenshots
Mikaela commented 2019-07-22 18:06:09 +00:00 (Migrated from github.com)
Review
Copy Link

I think this is reduntant as when you open a PR, GitHub suggests you on the right to read the contributing guidelines. It also appears somewhat formal to me.

I think this is reduntant as when you open a PR, GitHub suggests you on the right to read the contributing guidelines. It also appears somewhat formal to me.
Mikaela commented 2019-07-22 18:10:56 +00:00 (Migrated from github.com)
Review
Copy Link

I am not sure if this is that good idea as it could easily cause a merge conflict if multiple users were submitting PRs to add multiple apps/services simultaneously. I think it should possibly be something for a team member to update (but it needs a PR with approval)? Ideas @BurungHantu1605 ?

I am not sure if this is that good idea as it could easily cause a merge conflict if multiple users were submitting PRs to add multiple apps/services simultaneously. I think it should possibly be something for a team member to update (but it needs a PR with approval)? Ideas @BurungHantu1605 ?
Mikaela commented 2019-07-22 18:11:30 +00:00 (Migrated from github.com)
Review
Copy Link

I think this should be "Project is preferably..."

I think this should be "Project is preferably..."
Mikaela commented 2019-07-22 18:11:55 +00:00 (Migrated from github.com)
Review
Copy Link

I wonder if this could be removed as Netlify handles that?

I wonder if this could be removed as Netlify handles that?
jonah commented 2019-07-23 00:38:56 +00:00
Review
Copy Link

AFAIK it will only cause a merge conflict if people edit the same line, which seems unlikely since they'll likely be editing different sections of the file. But in any case merge conflicts are relatively easy to solve when a team member merges them. I would however make the following grammatical changes:

- [ ] I have listed any applicable source code in [source_code.md](https://github.com/privacytoolsIO/privacytools.io/blob/master/source_code.md)
AFAIK it will only cause a merge conflict if people edit the same line, which seems unlikely since they'll likely be editing different sections of the file. But in any case merge conflicts are relatively easy to solve when a team member merges them. I would however make the following grammatical changes: ```suggestion - [ ] I have listed any applicable source code in [source_code.md](https://github.com/privacytoolsIO/privacytools.io/blob/master/source_code.md) ```
jonah commented 2019-07-23 00:39:42 +00:00
Review
Copy Link

I think this is fine to include if we're doing this, because it means people need to affirm that they have read it directly.

- [ ] I have read and understand [CONTRIBUTING.md](https://github.com/privacytoolsIO/privacytools.io/blob/master/.github/CONTRIBUTING.md)
I think this is fine to include if we're doing this, because it means people need to affirm that they have read it directly. ```suggestion - [ ] I have read and understand [CONTRIBUTING.md](https://github.com/privacytoolsIO/privacytools.io/blob/master/.github/CONTRIBUTING.md) ```
jonah commented 2019-07-23 00:41:12 +00:00
Review
Copy Link

I would add instructions for those unfamiliar with Markdown.

#### Check List <!-- Please add an x in each box below, like so: [x] -->
I would add instructions for those unfamiliar with Markdown. ```suggestion #### Check List <!-- Please add an x in each box below, like so: [x] --> ```
jonah commented 2019-07-23 00:43:37 +00:00
Review
Copy Link
- [ ] This project is [free software](https://www.wikipedia.org/wiki/Free_software), unless 1) no free software alternative exists, or 2) this software is significantly better than a free software alternative.
```suggestion - [ ] This project is [free software](https://www.wikipedia.org/wiki/Free_software), unless 1) no free software alternative exists, or 2) this software is significantly better than a free software alternative. ```
nitrohorse commented 2019-07-26 01:59:43 +00:00 (Migrated from github.com)
Review
Copy Link
```suggestion ```
ggg27 commented 2019-07-26 02:21:36 +00:00 (Migrated from github.com)
Review
Copy Link

fixed in latest commit.

Thx

fixed in latest commit. Thx
ggg27 commented 2019-07-26 02:23:11 +00:00 (Migrated from github.com)
Review
Copy Link

Software must actually be free software:
https://github.com/privacytoolsIO/privacytools.io/blob/master/.github/CONTRIBUTING.md#software

But, ya that description makes more sense.

Software must actually be [free software](https://www.wikipedia.org/wiki/Free_software): https://github.com/privacytoolsIO/privacytools.io/blob/master/.github/CONTRIBUTING.md#software But, ya that description makes more sense.
Please add screenshots if applicable
--> -->
#### Check List <!-- Please add an x in each box below, like so: [x] --> #### Check List <!-- Please add an x in each box below, like so: [x] -->