Enable flags again #873

2019-04-18T15:04:28Z

Strappazzon commented

2019-04-18 15:04:28 +00:00

(Migrated from github.com)

#825 removed national flags representing languages, but this also removed flags representing countries (see screenshot below). I added the flags again but without representing languages.

#825 removed national flags representing languages, but this also removed flags representing **countries** (see screenshot below). I added the flags again but without representing languages. ![](https://user-images.githubusercontent.com/19752093/56370218-1e076f00-61fb-11e9-8bcb-11becdd0cc19.png)

netlify[bot] commented

2019-04-18 15:05:16 +00:00

(Migrated from github.com)

Deploy preview for privacytools-io ready!

Built with commit 8be2c18416

https://deploy-preview-873--privacytools-io.netlify.com

Deploy preview for *privacytools-io* ready! Built with commit 8be2c18416d29bb7796151dd8ee52436c059bfa1 https://deploy-preview-873--privacytools-io.netlify.com

Mikaela (Migrated from github.com) reviewed

2019-04-18 17:41:59 +00:00

assets/img/flags/.move svg files in the 4x3 folder if you want to use them

Mikaela (Migrated from github.com) commented

2019-04-18 17:39:55 +00:00

I think this is a bit of nasty filename, could the information be in README.md of that directory instead?

jonah requested changes

2019-04-18 18:44:27 +00:00

jonah left a comment

There's a better place for documentation than file names. Out of curiosity, why does the 4x3 folder need to exist at all?

There's a better place for documentation than file names. Out of curiosity, why does the `4x3` folder need to exist at all?

assets/img/flags/.move svg files in the 4x3 folder if you want to use them

jonah commented

2019-04-18 18:43:07 +00:00

Agree, this file doesn't appear necessary.

Strappazzon commented

2019-04-18 19:26:39 +00:00

(Migrated from github.com)

@JonahAragon The 4x3 folder was there before the removal.
I removed 4x3, .move svg files and edited flag-icon.scss accordingly in https://github.com/privacytoolsIO/privacytools.io/pull/873/commits/8be2c18416d29bb7796151dd8ee52436c059bfa1.

@JonahAragon The `4x3` folder was there before the removal. I removed `4x3`, `.move svg files` and edited `flag-icon.scss` accordingly in https://github.com/privacytoolsIO/privacytools.io/pull/873/commits/8be2c18416d29bb7796151dd8ee52436c059bfa1.

jonah approved these changes

2019-04-18 20:33:41 +00:00

jonah left a comment

This seems fine to me

Mikaela commented

2019-04-21 20:30:11 +00:00

(Migrated from github.com)

This seems fine to me

I am taking this as OK to merge as I don't see anything strange anymore either.

Thank you for your contribution @Strappazzon :)

> This seems fine to me I am taking this as OK to merge as I don't see anything strange anymore either. Thank you for your contribution @Strappazzon :)

🎉 1

This repo is archived. You cannot comment on pull requests.

1 Participants

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: privacyguides/privacytools.io#873