privacyguides/privacytools.io
Archived
1
0
Fork 0
Code Issues 304 Pull Requests 47 Activity

Remove national flags from the language select. #824

Closed
tomac4t wants to merge 3 commits from language-select-patch-1 into master
pull from: language-select-patch-1
merge into: privacyguides:master
Conversation 5 Commits 3 Files Changed 268 +13 -18580
tomac4t commented 2019-04-03 12:27:31 +00:00 (Migrated from github.com)
Copy Link

Description

Resolves: https://github.com/privacytoolsIO/privacytools.io/issues/185

<!-- PLEASE READ OUR [CONTRIBUTING GUIDELINES](https://github.com/privacytoolsIO/privacytools.io/blob/master/.github/CONTRIBUTING.md) BEFORE SUBMITTING --> ## Description Resolves: https://github.com/privacytoolsIO/privacytools.io/issues/185 <!-- The number of the issue that is resolved by this pull request. If there is none, feel free to delete this line --> <!-- ## Screenshots Please add screenshots if applicable -->
👍 1
jonah commented 2019-04-03 14:13:02 +00:00
Copy Link

It’s live at https://deploy-preview-824--privacytools-io.netlify.com/ btw.

Kind of broken on mobile:

29D92029-155E-4087-BD43-C4D7D0D7CC57

It’s live at https://deploy-preview-824--privacytools-io.netlify.com/ btw. Kind of broken on mobile: ![29D92029-155E-4087-BD43-C4D7D0D7CC57](https://user-images.githubusercontent.com/3637842/55485741-a6c5be80-55f0-11e9-90e9-8809701a1897.png)
👍 1
ghost commented 2019-04-03 14:18:50 +00:00 (Migrated from github.com)
Copy Link

@JonahAragon you set up PR previews? That's cool, I wanted to write a bot for that. Can you easily make netlify comment with a link to the preview when the PR is submitted?

@JonahAragon you set up PR previews? That's cool, I wanted to write a bot for that. Can you easily make netlify comment with a link to the preview when the PR is submitted?
jonah commented 2019-04-03 15:24:20 +00:00
Copy Link

@Shifterovich if you click Details on the deploy/netlify check it will open:

image

But, I can set it up to do comments as well I'm pretty sure. I'll investigate that.

@Shifterovich if you click Details on the deploy/netlify check it will open: ![image](https://user-images.githubusercontent.com/3637842/55491149-97e40980-55fa-11e9-9c99-16de01c736f3.png) But, I can set it up to do comments as well I'm pretty sure. I'll investigate that.
privacytoolsIO commented 2019-04-05 23:06:26 +00:00 (Migrated from github.com)
Copy Link

I'll close this one here since it's not working right and the other version submitted is live and working.

I'll close this one here since it's not working right and the other version submitted is live and working.
jonah commented 2019-04-05 23:11:04 +00:00
Copy Link

...

image

But whatever @BurungHantu1605 :P

[...](https://deploy-preview-824--privacytools-io.netlify.com/) ![image](https://user-images.githubusercontent.com/3637842/55660882-26f54b00-57ce-11e9-9849-8afc4984d0ec.png) But whatever @BurungHantu1605 :P
This repo is archived. You cannot comment on pull requests.
Reviewers
No Reviewers
Labels
Clear labels
🔍🤖 Search Engines
approved
approved, waiting for a PR
dependencies
Pull requests that update a dependency file
duplicate
feedback wanted
high priority
I2P
The Invisible Internet Project (I2P)
iOS
low priority
OS
Operating Systems
Self-contained networks
Social media
stale
A label for stalebot if it gets added
streaming
Anything related to media streaming.
todo
Tor
Anything covering the Tor network
WIP
active work in progress, do not merge or PR (yet)!
wontfix
Issues or bugs that will not be fixed and/or do not have significant impact on the project.
XMPP
Extensible Messaging and Presence Protocol
[m]
Matrix protocol
₿ cryptocurrency
ℹ️ help wanted
↔️ file sharing
⚙️ web extensions
Browser Extension related issues
✨ enhancement
❌ software removal
💬 discussion
🤖 Android
🐛 bug
💢 conflicting
📝 correction
Correction of content on the website
🆘 critical
📧 email
🔒 file encryption
📁 file storage
🦊 Firefox
Firefox & forks, about:config etc.
💻 hardware
🌐 hosting
🏠 housekeeping
Anything primarily related to site cleanup.
🔐 password managers
🧰 productivity tools
🔎 research required
🌐 Social News Aggregators
🆕 software suggestion
👥 team chat
🔒 VPN
Virtual Private Network
🌐 website issue
*Technical* issues with the website.
🚫 Windows
👁️ browsers
🖊️ digital notebooks
🗄️ DNS
Domain Name System
🗨️ instant messaging (im)
🇦🇶 translations
Anything covering a translated version of the site
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
jonah
No Assignees
1 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: privacyguides/privacytools.io#824
No description provided.
Delete Branch "language-select-patch-1"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?