privacyguides/privacytools.io
Archived
1
0
Fork 0
Code Issues 304 Pull Requests 47 Activity

Add experimental label to Brave, add tooltip support for labels #661

Closed
ghost wants to merge 2 commits from brave-label into master
pull from: brave-label
merge into: :master
Conversation 5 Commits 2 Files Changed 3
+11 -2
ghost commented 2018-12-13 21:22:07 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Description

See #657

Resolves: #161

Screenshots

screenshot from 2018-12-13 22-15-33

The tooltip text can be changed. @Vincevrp feel free to change it

## Description See #657 Resolves: #161 <!-- The number of the issue that is resolved by this pull request. If there is none, feel free to delete this line --> ## Screenshots ![screenshot from 2018-12-13 22-15-33](https://user-images.githubusercontent.com/4354706/49967992-b677a500-ff24-11e8-8b18-f000fc573af2.png) The tooltip text can be changed. @Vincevrp feel free to change it
Vincevrp (Migrated from github.com) reviewed 2018-12-13 21:22:07 +00:00
ghost commented 2018-12-13 21:24:15 +00:00 (Migrated from github.com)
Copy Link
Copy Source

The index.html diff isn't displayed in the PR, but it does work in terminal now (so it presumably will work after merge).

screenshot from 2018-12-13 22-23-46

The index.html diff isn't displayed in the PR, but it does work in terminal now (so it presumably will work after merge). ![screenshot from 2018-12-13 22-23-46](https://user-images.githubusercontent.com/4354706/49968335-ce9bf400-ff25-11e8-85f4-2c23a3339fb3.png)
ghost commented 2018-12-15 11:17:42 +00:00 (Migrated from github.com)
Copy Link
Copy Source

@Vincevrp I'm closing this and pushing the changes to master due to the conflics, but please review the tooltip message:

labels="warning:experimental:Brave is a good choice if you want to use a Chromium-based browser. But at this point in Brave's development&comma; it's not as good as Firefox with privacy addons."

@Vincevrp I'm closing this and pushing the changes to master due to the conflics, but please review the tooltip message: `labels="warning:experimental:Brave is a good choice if you want to use a Chromium-based browser. But at this point in Brave's development&comma; it's not as good as Firefox with privacy addons."`
qmontal commented 2018-12-17 14:26:38 +00:00 (Migrated from github.com)
Copy Link
Copy Source

@Shifterovich thank you for your patience and commitment through the whole discussion and process, you handled it amazingly! Hoping for Brave to improve :)

@Shifterovich thank you for your patience and commitment through the whole discussion and process, you handled it amazingly! Hoping for Brave to improve :)
ghost commented 2018-12-17 15:33:42 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Thanks :)

Thanks :)
This repo is archived. You cannot comment on pull requests.
Reviewers
No Reviewers
Vincevrp
Labels
Clear labels
:mag:🤖 Search Engines
approved
approved, waiting for a PR
 dependencies
Pull requests that update a dependency file
 duplicate
feedback wanted
high priority
I2P
The Invisible Internet Project (I2P)
 iOS
low priority
OS
Operating Systems
 Self-contained networks
Social media
stale
A label for stalebot if it gets added
 streaming
Anything related to media streaming.
 todo
Tor
Anything covering the Tor network
 WIP
active work in progress, do not merge or PR (yet)!
 wontfix
Issues or bugs that will not be fixed and/or do not have significant impact on the project.
 XMPP
Extensible Messaging and Presence Protocol
 [m]
Matrix protocol
 ₿ cryptocurrency
ℹ️ help wanted
↔️ file sharing
⚙️ web extensions
Browser Extension related issues
 ✨ enhancement
❌ software removal
💬 discussion
🤖 Android
🐛 bug
💢 conflicting
📝 correction
Correction of content on the website
 🆘 critical
📧 email
🔒 file encryption
📁 file storage
🦊 Firefox
Firefox & forks, about:config etc.
 💻 hardware
🌐 hosting
🏠 housekeeping
Anything primarily related to site cleanup.
 🔐 password managers
🧰 productivity tools
🔎 research required
🌐 Social News Aggregators
🆕 software suggestion
👥 team chat
🔒 VPN
Virtual Private Network
 🌐 website issue
*Technical* issues with the website.
 🚫 Windows
👁️ browsers
🖊️ digital notebooks
🗄️ DNS
Domain Name System
 🗨️ instant messaging (im)
🇦🇶 translations
Anything covering a translated version of the site
No labels high priority
Milestone
No items
No Milestone
Assignees
Clear assignees
jonah
No Assignees
1 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: privacyguides/privacytools.io#661