privacyguides/privacytools.io
Archived
1
0
Fork 0
Code Issues 304 Pull Requests 47 Activity

Update 5Eyes formatting to be consistent #625

Closed
samclane wants to merge 1 commits from patch-1 into master
pull from: patch-1
merge into: privacyguides:master
Conversation 3 Commits 1 Files Changed 1 +6 -5
samclane commented 2018-11-25 21:27:13 +00:00 (Migrated from github.com)
Copy Link

Was 5-Eyes countries to be bullet points, with AUS showing as ( • 1. Australia) and the rest without numbers.

Description

Resolves: #none

Screenshots

Before: https://i.imgur.com/rrgUYn6.png

After: https://i.imgur.com/TW6uQJ6.png (EDIT: Just realized I did this with the Dev console open, so the elements are moved. This is not a byproduct of my change, which is just the text, and the layout is still unchanged)

Was 5-Eyes countries to be bullet points, with AUS showing as ( • 1. Australia) and the rest without numbers. ## Description Resolves: #none ## Screenshots Before: https://i.imgur.com/rrgUYn6.png After: https://i.imgur.com/TW6uQJ6.png (EDIT: Just realized I did this with the Dev console open, so the elements are moved. This is not a byproduct of my change, which is just the text, and the layout is still unchanged)
Vincevrp (Migrated from github.com) reviewed 2018-11-25 21:27:13 +00:00
ghost commented 2018-11-25 21:35:22 +00:00 (Migrated from github.com)
Copy Link

Take a look at this: 49bd02aa67

Take a look at this: https://github.com/privacytoolsIO/privacytools.io/commit/49bd02aa67d75b252f469164d8070b458f1a7a66
👍 1
Vincevrp commented 2018-11-25 21:38:32 +00:00 (Migrated from github.com)
Copy Link

Seems like a made a small mistake with Australia in 49bd02a. Please use ordered lists instead of breaklines and hard coding the numbers.

Seems like a made a small mistake with Australia in 49bd02a. Please use ordered lists instead of breaklines and hard coding the numbers.
This repo is archived. You cannot comment on pull requests.
Reviewers
No Reviewers
Vincevrp
Labels
Clear labels
🔍🤖 Search Engines
approved
approved, waiting for a PR
dependencies
Pull requests that update a dependency file
duplicate
feedback wanted
high priority
I2P
The Invisible Internet Project (I2P)
iOS
low priority
OS
Operating Systems
Self-contained networks
Social media
stale
A label for stalebot if it gets added
streaming
Anything related to media streaming.
todo
Tor
Anything covering the Tor network
WIP
active work in progress, do not merge or PR (yet)!
wontfix
Issues or bugs that will not be fixed and/or do not have significant impact on the project.
XMPP
Extensible Messaging and Presence Protocol
[m]
Matrix protocol
₿ cryptocurrency
ℹ️ help wanted
↔️ file sharing
⚙️ web extensions
Browser Extension related issues
✨ enhancement
❌ software removal
💬 discussion
🤖 Android
🐛 bug
💢 conflicting
📝 correction
Correction of content on the website
🆘 critical
📧 email
🔒 file encryption
📁 file storage
🦊 Firefox
Firefox & forks, about:config etc.
💻 hardware
🌐 hosting
🏠 housekeeping
Anything primarily related to site cleanup.
🔐 password managers
🧰 productivity tools
🔎 research required
🌐 Social News Aggregators
🆕 software suggestion
👥 team chat
🔒 VPN
Virtual Private Network
🌐 website issue
*Technical* issues with the website.
🚫 Windows
👁️ browsers
🖊️ digital notebooks
🗄️ DNS
Domain Name System
🗨️ instant messaging (im)
🇦🇶 translations
Anything covering a translated version of the site
No Label
ℹ️ help wanted
Milestone
No items
No Milestone
Assignees
Clear assignees
jonah
No Assignees
1 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: privacyguides/privacytools.io#625
No description provided.
Delete Branch "patch-1"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?