Update PR template #583

jonah · 2018-11-12T19:40:35Z

Vincevrp commented

2018-11-12 19:40:35 +00:00

(Migrated from github.com)

Description

Replace HTML preview with screenshots since this doesn't work with Jekyll
Reference contributing guidelines
Add place to fill in issue number

### Description * Replace HTML preview with screenshots since this doesn't work with Jekyll * Reference contributing guidelines * Add place to fill in issue number

jonah reviewed 2018-11-13 07:40:45 +00:00

.github/PULL_REQUEST_TEMPLATE.md

jonah commented

2018-11-13 07:40:13 +00:00

Maybe add (none) as a default value?

Maybe add `(none)` as a default value?

jonah commented

2018-11-13 07:40:27 +00:00

Make this an HTML comment.

.github/PULL_REQUEST_TEMPLATE.md

jonah commented

2018-11-13 07:39:31 +00:00

I would make this an HTML comment. People who open PRs will see that but it won't be rendered in the markdown.

Vincevrp commented

2018-11-13 08:49:12 +00:00

(Migrated from github.com)

Should be fixed now.

ghost commented

2018-11-13 08:54:02 +00:00

(Migrated from github.com)

Thanks!

🎉 1

ghost commented

2018-11-14 11:23:07 +00:00

(Migrated from github.com)

https://github.com/laravel/framework/issues/new/choose I like this.

Would be cool if we could implement that. Like "Software suggestion", "Software removal", "Feature", "Discussion" or some such categories.

Here's the code laravel/framework uses for this.

GH documentation: https://blog.github.com/2018-05-02-issue-template-improvements/

Could you try adding something like that?

https://github.com/laravel/framework/issues/new/choose I like this. Would be cool if we could implement that. Like "Software suggestion", "Software removal", "Feature", "Discussion" or some such categories. [Here's the code]( https://github.com/laravel/framework/tree/5.7/.github/ISSUE_TEMPLATE) laravel/framework uses for this. GH documentation: https://blog.github.com/2018-05-02-issue-template-improvements/ Could you try adding something like that?

👍 1

Vincevrp commented

2018-11-14 12:43:13 +00:00

(Migrated from github.com)

https://github.com/laravel/framework/issues/new/choose I like this.

Would be cool if we could implement that. Like "Software suggestion", "Software removal", "Feature", "Discussion" or some such categories.

Here's the code laravel/framework uses for this.

GH documentation: https://blog.github.com/2018-05-02-issue-template-improvements/

Could you try adding something like that?

Looks really good. I'll have a look at this!

> https://github.com/laravel/framework/issues/new/choose I like this. > > Would be cool if we could implement that. Like "Software suggestion", "Software removal", "Feature", "Discussion" or some such categories. > > [Here's the code](https://github.com/laravel/framework/tree/5.7/.github/ISSUE_TEMPLATE) laravel/framework uses for this. > > GH documentation: https://blog.github.com/2018-05-02-issue-template-improvements/ > > Could you try adding something like that? Looks really good. I'll have a look at this!

This repo is archived. You cannot comment on pull requests.

1 Participants

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: privacyguides/privacytools.io#583