add magic-wormhole to the file sharing section #359

jonah · 2017-11-11T18:39:42Z

emanresusername commented

2017-11-11 18:39:42 +00:00

(Migrated from github.com)

Description

add magic-wormhole to the file sharing section

for #357

just copied the description from the github page (might be a little long?)

took (and resized) the picture from the slides pdf

wasn't sure on os, it explicitly mentions osx, linux and windows, but i'd imagine you could get it on android or ios (jailbroken) if python's there 🤔

HTML Preview

http://htmlpreview.github.io/?https://github.com/emanresusername/privacytools.io/blob/master/index.html

### Description add [magic-wormhole](https://github.com/warner/magic-wormhole) to the file sharing section for #357 just copied the description from the github page (might be a little long?) took (and resized) the picture from the [slides pdf](http://www.lothar.com/~warner/MagicWormhole-PyCon2016.pdf) wasn't sure on os, it explicitly mentions [osx](https://github.com/warner/magic-wormhole#os-x), [linux](https://github.com/warner/magic-wormhole#linux) and [windows](https://github.com/warner/magic-wormhole#windows), but i'd imagine you could get it on android or ios (jailbroken) if python's there :thinking: ### HTML Preview http://htmlpreview.github.io/?https://github.com/emanresusername/privacytools.io/blob/master/index.html

ghost commented

2017-11-11 18:47:15 +00:00

(Migrated from github.com)

Maybe remove the link to the PyCon resources. Also, not sure whether HTML5 doesn't break some things to some degree.

@kewde is it normal that htmlpreview doesn't display flag icons?

Maybe remove the link to the PyCon resources. Also, not sure whether HTML5 doesn't break some things to some degree. @kewde is it normal that htmlpreview doesn't display flag icons?

emanresusername commented

2017-11-11 19:04:25 +00:00

(Migrated from github.com)

removed pycon 👍
didn't add any new html5 features, intentionally anyway, mainly just copied and tweaked the div.col-sm-4 elem from onionshare?

removed pycon :+1: didn't add any new html5 features, intentionally anyway, mainly just copied and tweaked the `div.col-sm-4` elem from onionshare?

ghost commented

2017-11-11 20:17:31 +00:00

(Migrated from github.com)

Ah, well for some reason GitHub shows that line as modified.

Anyway, I'll wait for an approval and then merge (if we can't get an approval in the next few days, I'll merge anyway). @kewde

Ah, well for some reason GitHub shows that line as modified. ![screenshot-2017-11-11 add magic-wormhole to the file sharing section by emanresusername pull request 359 privacytoolsi](https://user-images.githubusercontent.com/4354706/32693121-1b6ced58-c71d-11e7-8aae-ec0a667b8112.png) Anyway, I'll wait for an approval and then merge (if we can't get an approval in the next few days, I'll merge anyway). @kewde

jonah approved these changes 2017-11-11 20:17:43 +00:00

emanresusername commented

2017-11-11 20:29:41 +00:00

(Migrated from github.com)

oh 😲
must be an autosave/cleanup hook i wasn't paying attention to
i can remove that and squash everything down into 1 commit if you like?

oh :astonished: must be an autosave/cleanup hook i wasn't paying attention to i can remove that and squash everything down into 1 commit if you like?

Omar-Elrefaei commented

2017-11-12 11:36:44 +00:00

(Migrated from github.com)

Yeah this is an amazing tool

kewde (Migrated from github.com) reviewed 2017-11-12 23:13:17 +00:00

kewde (Migrated from github.com) left a comment

OK

This repo is archived. You cannot comment on pull requests.

1 Participants

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: privacyguides/privacytools.io#359