Add warning to Invidious #2182

2021-01-06T22:50:13Z

Gusted commented

2021-01-06 22:50:13 +00:00

(Migrated from github.com)

Description

Resolves: #2144

As described in #2144 the current box is misleading, which I agree with. To clarify why I agree with this:

As a new user(private window) and open a video you can see it will by default request the video from an google server googlevideo.com as seen in the source code where they add the CSP headers when the user has not enabled local.
As seen in the source code the default preference for local which is the preference to see if the user wants proxied video, is false and by default not proxied if not otherwise changed in the preference if the instance allows this, some have disabled this to be enabled.
As seen in the source code it will look if the host parameter is in the request and use the custom host if the parameter is found. The call to this webpoint is handled in videos.cr that added the host parameter when user prefers(local preference) it.

I've now added an warning however, I think the whole proxy aspect to this can be removed as invidious main goal is provide an front-end and not serve as proxy. I think it's good to make people aware of this as I've heard great things over invidious even to degoogle, however knowing that it's not by default proxied and some instances don't allow this is not common knowledge.

Check List

I understand that by not opening an issue about a software/service/similar addition/removal, this pull request will be closed without merging.
I have read and understand the contributing guidelines.
The project is Free Libre and/or Open Source Software

Netlify preview for the mainly edited page: https://deploy-preview-2182--privacytools-io.netlify.app/

## Description Resolves: #2144 As described in #2144 the current box is misleading, which I agree with. To clarify why I agree with this: - As a new user(private window) and open a video you can see it will by default request the video from an google server `googlevideo.com` as seen in the [source code](https://github.com/iv-org/invidious/blob/168376b04671c6e362468267a3b07dd332b40702/src/invidious.cr#L211) where they add the CSP headers when the user has not enabled `local`. - As seen in the [source code](https://github.com/iv-org/invidious/blob/168376b04671c6e362468267a3b07dd332b40702/src/invidious/helpers/helpers.cr#L38) the default preference for `local` which is the preference to see if the user wants proxied video, is false and by default not proxied if not otherwise changed in the preference *if the instance allows this, some have disabled this to be enabled*. - As seen in the [source code](https://github.com/iv-org/invidious/blob/168376b04671c6e362468267a3b07dd332b40702/src/invidious.cr#L3479) it will look if the host parameter is in the request and use the custom host if the parameter is found. The call to this webpoint is handled in videos.cr that added the host parameter when user prefers(local preference) it. I've now added an warning however, I think the whole `proxy` aspect to this can be removed as invidious [main goal](https://github.com/iv-org/invidious#invidious-is-an-alternative-front-end-to-youtube) is provide an front-end and not serve as proxy. I think it's good to make people aware of this as I've heard great things over invidious even to degoogle, however knowing that it's not by default proxied and some instances don't allow this is not common knowledge. #### Check List  - [x] I understand that by not opening an issue about a software/service/similar addition/removal, this pull request will be closed without merging. - [x] I have read and understand [the contributing guidelines](https://github.com/privacytools/privacytools.io/blob/master/.github/CONTRIBUTING.md). - [x] The project is [Free Libre](https://en.wikipedia.org/wiki/Free_software) and/or [Open Source](https://en.wikipedia.org/wiki/Open-source_software) Software * Netlify preview for the mainly edited page: https://deploy-preview-2182--privacytools-io.netlify.app/

freddy-m (Migrated from github.com) approved these changes 2021-01-13 10:44:23 +00:00

gary-host-laptop commented

2021-01-20 17:48:15 +00:00

(Migrated from github.com)

Was this fully merged? I can still see the same phrasing on the web site.

Gusted commented

2021-01-20 17:51:57 +00:00

(Migrated from github.com)

Reminds me of #2135

gary-host-laptop commented

2021-01-20 21:01:53 +00:00

(Migrated from github.com)

Any ideas, @dngray?

This repo is archived. You cannot comment on pull requests.

1 Participants

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: privacyguides/privacytools.io#2182