DNS: migrate software suggestions from DNS page to DNS section to make it appear in /classic #2028

2020-08-25T19:48:40Z

Mikaela commented

2020-08-25 19:48:40 +00:00

(Migrated from github.com)

Resolves: #2029

Check List

I understand that by not opening an issue about a software/service/similar addition/removal, this pull request will be closed without merging.
I have read and understand the contributing guidelines.
The project is Free Libre and/or Open Source Software

Netlify preview for the mainly edited page:
- https://deploy-preview-2028--privacytools-io.netlify.app/providers/dns/
- https://deploy-preview-2028--privacytools-io.netlify.app/classic/#dns

Resolves: #2029 #### Check List  - [x] I understand that by not opening an issue about a software/service/similar addition/removal, this pull request will be closed without merging. - [x] I have read and understand [the contributing guidelines](https://github.com/privacytools/privacytools.io/blob/master/.github/CONTRIBUTING.md). - [x] The project is [Free Libre](https://en.wikipedia.org/wiki/Free_software) and/or [Open Source](https://en.wikipedia.org/wiki/Open-source_software) Software * Netlify preview for the mainly edited page: * https://deploy-preview-2028--privacytools-io.netlify.app/providers/dns/ * https://deploy-preview-2028--privacytools-io.netlify.app/classic/#dns

Mikaela (Migrated from github.com) reviewed 2020-08-25 19:49:36 +00:00

pages/old.html

Mikaela (Migrated from github.com) commented

2020-08-25 19:49:36 +00:00

Proper fix would be making a DNS software section and moving the DNS software there from the main DNS page. There are no other pages included, only sections.

Mikaela (Migrated from github.com) reviewed 2020-08-25 20:07:42 +00:00

Mikaela (Migrated from github.com) left a comment

Potential problem: this makes the history for the software list more difficult to find by moving it to different file.

freddy-m (Migrated from github.com) approved these changes 2020-08-29 20:23:48 +00:00

freddy-m commented

2020-08-29 20:23:58 +00:00

(Migrated from github.com)

LGTM!

dngray (Migrated from github.com) approved these changes 2020-09-12 05:27:51 +00:00

This repo is archived. You cannot comment on pull requests.

1 Participants

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: privacyguides/privacytools.io#2028