privacyguides/privacytools.io
Archived
1
0
Fork 0
Code Issues 304 Pull Requests 47 Activity

Some more fixes for the chat page #2012

Merged
dngray merged 10 commits from pr-fix_fragment_chat_page into master 2020-08-13 13:38:23 +00:00
Conversation 10 Commits 10 Files Changed 3 +8 -8
dngray commented 2020-08-05 04:39:13 +00:00 (Migrated from github.com)
Copy Link

https://deploy-preview-2012--privacytools-io.netlify.app/services/chat/

https://deploy-preview-2012--privacytools-io.netlify.app/services/chat/
Mikaela (Migrated from github.com) requested changes 2020-08-05 09:26:32 +00:00
pages/services/chat.html
Mikaela (Migrated from github.com) commented 2020-08-05 09:25:58 +00:00 
<p>The default matrix.org homeserver is behind Cloudflare. The PrivacyTools homeserver (<a href="https://chat.privacytools.io/">chat.privacytools.io</a> is not.

Element still seems to be the webclient while chat. says to be the homeserver.

```suggestion <p>The default matrix.org homeserver is behind Cloudflare. The PrivacyTools homeserver (<a href="https://chat.privacytools.io/">chat.privacytools.io</a> is not. ``` Element still seems to be the webclient while chat. says to be the homeserver.
dngray (Migrated from github.com) reviewed 2020-08-05 11:44:35 +00:00
pages/services/chat.html
dngray (Migrated from github.com) commented 2020-08-05 11:44:34 +00:00

Ah yes. good point.

Ah yes. good point.
Mikaela (Migrated from github.com) reviewed 2020-08-05 11:58:40 +00:00
freddy-m commented 2020-08-07 17:02:16 +00:00 (Migrated from github.com)
Copy Link

Related: #11

Related: [#11](https://github.com/privacytools/static-sites/pull/11)
dngray commented 2020-08-08 07:52:57 +00:00 (Migrated from github.com)
Copy Link

We should probably look at https://github.com/privacytools/privacytools.io/issues/2015 as well for this issue.

We should probably look at https://github.com/privacytools/privacytools.io/issues/2015 as well for this issue.
jonah reviewed 2020-08-08 19:05:41 +00:00
pages/services/chat.html
jonah commented 2020-08-08 19:05:01 +00:00 
<p>The default matrix.org homeserver is behind Cloudflare. The PrivacyTools homeserver is not.
```suggestion <p>The default matrix.org homeserver is behind Cloudflare. The PrivacyTools homeserver is not. ```
jonah requested changes 2020-08-11 19:43:30 +00:00
pages/services/chat.html
jonah commented 2020-08-11 19:42:33 +00:00 
<p><strong>To register on or connect to our homeserver, simply use <code>https://chat.privacytools.io</code> as the homeserver in your Matrix client.</strong></p>
<p><mark>You must read and accept our community <a href="https://wiki.privacytools.io/view/PrivacyTools:Code_of_Conduct">code of conduct</a> before joining our rooms or using our services.</mark></p>

Fix crazy formatting

```suggestion <p><strong>To register on or connect to our homeserver, simply use <code>https://chat.privacytools.io</code> as the homeserver in your Matrix client.</strong></p> <p><mark>You must read and accept our community <a href="https://wiki.privacytools.io/view/PrivacyTools:Code_of_Conduct">code of conduct</a> before joining our rooms or using our services.</mark></p> ``` Fix crazy formatting
jonah approved these changes 2020-08-11 19:51:31 +00:00
freddy-m (Migrated from github.com) approved these changes 2020-08-13 10:45:59 +00:00
dngray commented 2020-08-25 17:16:21 +00:00 (Migrated from github.com)
Copy Link

It seems this didn't take place on the live page https://www.privacytools.io/services/chat @jonaharagon.

Two things I noticed that didn't seem to make it was the CoC, and the refinement of the Cloudflare related question.

It seems this didn't take place on the live page https://www.privacytools.io/services/chat @jonaharagon. Two things I noticed that didn't seem to make it was the CoC, and the refinement of the Cloudflare related question.
This repo is archived. You cannot comment on pull requests.
Reviewers
No Reviewers
jonah
Mikaela
freddy-m
Labels
Clear labels
🔍🤖 Search Engines
approved
approved, waiting for a PR
dependencies
Pull requests that update a dependency file
duplicate
feedback wanted
high priority
I2P
The Invisible Internet Project (I2P)
iOS
low priority
OS
Operating Systems
Self-contained networks
Social media
stale
A label for stalebot if it gets added
streaming
Anything related to media streaming.
todo
Tor
Anything covering the Tor network
WIP
active work in progress, do not merge or PR (yet)!
wontfix
Issues or bugs that will not be fixed and/or do not have significant impact on the project.
XMPP
Extensible Messaging and Presence Protocol
[m]
Matrix protocol
₿ cryptocurrency
ℹ️ help wanted
↔️ file sharing
⚙️ web extensions
Browser Extension related issues
✨ enhancement
❌ software removal
💬 discussion
🤖 Android
🐛 bug
💢 conflicting
📝 correction
Correction of content on the website
🆘 critical
📧 email
🔒 file encryption
📁 file storage
🦊 Firefox
Firefox & forks, about:config etc.
💻 hardware
🌐 hosting
🏠 housekeeping
Anything primarily related to site cleanup.
🔐 password managers
🧰 productivity tools
🔎 research required
🌐 Social News Aggregators
🆕 software suggestion
👥 team chat
🔒 VPN
Virtual Private Network
🌐 website issue
*Technical* issues with the website.
🚫 Windows
👁️ browsers
🖊️ digital notebooks
🗄️ DNS
Domain Name System
🗨️ instant messaging (im)
🇦🇶 translations
Anything covering a translated version of the site
No Label
WIP
Milestone
No items
No Milestone
Assignees
Clear assignees
jonah
No Assignees
1 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: privacyguides/privacytools.io#2012
No description provided.
Delete Branch "pr-fix_fragment_chat_page"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?