Updated Bitwarden logo #1968

Merged
jackmchou merged 3 commits from issue-1960 into master 2020-07-02 17:53:59 +00:00
jackmchou commented 2020-06-30 14:43:15 +00:00 (Migrated from github.com)

Description

Resolves: #1960

Check List

  • I understand that by not opening an issue about a software/service/similar addition/removal, this pull request will be closed without merging.

  • I have read and understand the contributing guidelines.

  • The project is Free Libre and/or Open Source Software

<!-- PLEASE READ OUR CODE OF CONDUCT (https://wiki.privacytools.io/view/PrivacyTools:Code_of_Conduct) AND CONTRIBUTING GUIDELINES (https://github.com/privacytools/privacytools.io/blob/master/.github/CONTRIBUTING.md) BEFORE SUBMITTING --> ## Description Resolves: #1960 <!-- A link to the (discussion) issue resolved by this pull request. There must be a discussion issue here at GitHub, before a pull request of software/service suggestion can be considered for merging. --> #### Check List <!-- Please add an x in each box below, like so: [x] --> - [x] I understand that by not opening an issue about a software/service/similar addition/removal, this pull request will be closed without merging. - [x] I have read and understand [the contributing guidelines](https://github.com/privacytools/privacytools.io/blob/master/.github/CONTRIBUTING.md). - [x] The project is [Free Libre](https://en.wikipedia.org/wiki/Free_software) and/or [Open Source](https://en.wikipedia.org/wiki/Open-source_software) Software * Netlify preview for the mainly edited page: https://deploy-preview-1968--privacytools-io.netlify.app/software/passwords/ <!-- link or Non Applicable? Edit this in afterwards --> * Code repository of the project (if applicable): N/A
dngray commented 2020-07-02 04:25:50 +00:00 (Migrated from github.com)

We like to optimize all SVGs we add to the site. This is a helpful guide as to how we do it with Inkscape:

optimize_svg

We like to optimize all SVGs we add to the site. This is a helpful guide as to how we do it with Inkscape: ![optimize_svg](https://user-images.githubusercontent.com/48640805/86316352-14113680-bc1c-11ea-922b-419d373f6830.png)
dngray (Migrated from github.com) approved these changes 2020-07-02 04:26:10 +00:00
jackmchou commented 2020-07-02 15:18:55 +00:00 (Migrated from github.com)

We like to optimize all SVGs we add to the site. This is a helpful guide as to how we do it with Inkscape:

optimize_svg

Got it! Will do in the future. Could I also update the contributing guidelines with this information?

> > > We like to optimize all SVGs we add to the site. This is a helpful guide as to how we do it with Inkscape: > > ![optimize_svg](https://user-images.githubusercontent.com/48640805/86316352-14113680-bc1c-11ea-922b-419d373f6830.png) Got it! Will do in the future. Could I also update the contributing guidelines with this information?
nitrohorse commented 2020-07-02 17:53:33 +00:00 (Migrated from github.com)

@jackmchou that’s a good idea! Having the optimization recommendation somewhere visible will be helpful.

@jackmchou that’s a good idea! Having the optimization recommendation somewhere visible will be helpful.
nitrohorse (Migrated from github.com) approved these changes 2020-07-02 17:53:47 +00:00
dngray commented 2020-07-03 04:08:57 +00:00 (Migrated from github.com)

Got it! Will do in the future. Could I also update the contributing guidelines with this information?

We should do that actually, and also mention that images must be 128x128 or 384x128. It is also a good idea to copy the SVG content to a new SVG document and adjust canvas size. That fixes some breakages with rendering.

> Got it! Will do in the future. Could I also update the contributing guidelines with this information? We should do that actually, and also mention that images must be 128x128 or 384x128. It is also a good idea to copy the SVG content to a new SVG document and adjust canvas size. That fixes some breakages with rendering.
This repo is archived. You cannot comment on pull requests.
No Milestone
No Assignees
1 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: privacyguides/privacytools.io#1968
No description provided.