Only recommend LineageOS official builds #1935

jonah · 2020-05-27T01:41:07Z

jonah commented

2020-05-27 01:41:07 +00:00

nitrohorse (Migrated from github.com) requested changes 2020-05-27 02:20:16 +00:00

_includes/sections/mobile-operating-systems.html

nitrohorse (Migrated from github.com) commented

2020-05-27 02:20:07 +00:00

  description='LineageOS is a free and open-source successor to the CyanogenMod project. They have <a href="https://wiki.lineageos.org/devices/">official support for a variety of devices</a>, based on clean releases of the Android Open Source Project. For security reasons, we do not recommend third-party builds of LineageOS for unsupported devices.'

```suggestion description='LineageOS is a free and open-source successor to the CyanogenMod project. They have <a href="https://wiki.lineageos.org/devices/">official support for a variety of devices</a>, based on clean releases of the Android Open Source Project. For security reasons, we do not recommend third-party builds of LineageOS for unsupported devices.' ```

jonah reviewed 2020-05-27 02:27:28 +00:00

_includes/sections/mobile-operating-systems.html

jonah commented

2020-05-27 02:27:28 +00:00

or...

  description='LineageOS is the free and open-source successor to the CyanogenMod project. They have <a href="https://wiki.lineageos.org/devices/">official support for a variety of devices</a>, based on clean releases of the Android Open Source Project. For security reasons, we do not recommend third-party builds of LineageOS for unsupported devices.'

which is more accurate?

or... ```suggestion description='LineageOS is the free and open-source successor to the CyanogenMod project. They have <a href="https://wiki.lineageos.org/devices/">official support for a variety of devices</a>, based on clean releases of the Android Open Source Project. For security reasons, we do not recommend third-party builds of LineageOS for unsupported devices.' ``` which is more accurate?

nitrohorse (Migrated from github.com) reviewed 2020-05-27 05:39:11 +00:00

_includes/sections/mobile-operating-systems.html

nitrohorse (Migrated from github.com) commented

2020-05-27 05:39:11 +00:00

And good point, “the” makes more sense.

koenvervloesem commented

2020-05-27 06:35:23 +00:00

(Migrated from github.com)

Someone who is new to the scene and doesn't know CyanogenMod (after all, the final release is already 3.5 years ago) still doesn't have a clue what LineageOS is after the first sentence. I found the old way with "It is the continuation of the CyanogenMod project." at the end clearer, so the most important information (what LineageOS is) comes first.

👍 1

blacklight447 (Migrated from github.com) approved these changes 2020-06-03 20:29:21 +00:00

blacklight447 (Migrated from github.com) left a comment

looks good to me. @nitrohorse ?

nitrohorse (Migrated from github.com) approved these changes 2020-06-07 18:29:16 +00:00

This repo is archived. You cannot comment on pull requests.

1 Participants

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: privacyguides/privacytools.io#1935