privacyguides/privacytools.io
Archived
1
0
Fork 0
Code Issues 304 Pull Requests 47 Activity

Update DNS page with card-based client recommendations #1900

Merged
nitrohorse merged 17 commits from rework-dns-page into master 2020-06-04 16:00:32 +00:00
Conversation 17 Commits 17 Files Changed 7 +194 -121
nitrohorse commented 2020-05-09 23:01:42 +00:00 (Migrated from github.com)
Copy Link

Description

Let's cleanup the DNS page and simplify the text into card recommendations--a bit more easily digestible for users.

Resolves:

Todo in subsequent PRs

  • Add section for Pi-hole and AdGuard Home cards.

Todo:

  • Determine if LibreDNS supports QNAME resolution.

Check List

  • I understand that by not opening an issue about a software/service/similar addition/removal, this pull request will be closed without merging.

  • I have read and understand the contributing guidelines.

<!-- PLEASE READ OUR CODE OF CONDUCT (https://wiki.privacytools.io/view/PrivacyTools:Code_of_Conduct) AND CONTRIBUTING GUIDELINES (https://github.com/privacytoolsIO/privacytools.io/blob/master/.github/CONTRIBUTING.md) BEFORE SUBMITTING --> ## Description Let's cleanup the DNS page and simplify the text into card recommendations--a bit more easily digestible for users. Resolves: - https://github.com/privacytools/privacytools.io/issues/1466 - https://github.com/privacytools/privacytools.io/issues/1822 - https://github.com/privacytools/privacytools.io/issues/1841 - https://github.com/privacytools/privacytools.io/issues/1917 - https://github.com/privacytools/privacytools.io/issues/1922 #### Todo in subsequent PRs - [x] Add section for Pi-hole and AdGuard Home cards. #### Todo: - Determine if LibreDNS supports QNAME resolution. #### Check List <!-- Please add an x in each box below, like so: [x] --> - [x] I understand that by not opening an issue about a software/service/similar addition/removal, this pull request will be closed without merging. - [x] I have read and understand [the contributing guidelines](https://github.com/privacytoolsIO/privacytools.io/blob/master/.github/CONTRIBUTING.md). * Netlify preview for the mainly edited page: https://deploy-preview-1900--privacytools-io.netlify.app/providers/dns/#dns
👍 2 ❤️ 1
netlify[bot] commented 2020-05-09 23:04:22 +00:00 (Migrated from github.com)
Copy Link

Deploy preview for privacytools-io ready!

Built with commit 82a6b483ca

https://deploy-preview-1900--privacytools-io.netlify.app

Deploy preview for *privacytools-io* ready! Built with commit 82a6b483cadf17c351410edf4de0cb0610c4119e https://deploy-preview-1900--privacytools-io.netlify.app
nitrohorse (Migrated from github.com) reviewed 2020-05-23 00:27:11 +00:00
assets/img/svg/3rd-party/android.svg
@ -0,0 +1,19 @@
<?xml version="1.0"?>
nitrohorse (Migrated from github.com) commented 2020-05-23 00:27:10 +00:00

Likely want to find a better Android logo without the white outline.

Likely want to find a better Android logo without the white outline.
nitrohorse (Migrated from github.com) reviewed 2020-05-23 00:29:03 +00:00
pages/providers/dns.html
nitrohorse (Migrated from github.com) commented 2020-05-23 00:29:02 +00:00

Having the privacy policy as a Google doc sucks but it's what's linked officially on the app store page: https://bit.ly/DCPrivacyPolicy

Having the privacy policy as a Google doc sucks but it's what's linked officially on the app store page: https://bit.ly/DCPrivacyPolicy
dngray commented 2020-05-23 09:57:55 +00:00 (Migrated from github.com)
Copy Link

1590227713

Maybe we should put these descriptions under headers. Also that badge looks weird on the second line like that.

![1590227713](https://user-images.githubusercontent.com/48640805/82727724-c11e9800-9cdb-11ea-9ffc-55e3e13aa8fb.png) Maybe we should put these descriptions under <h></h> headers. Also that badge looks weird on the second line like that.
👍 3
nitrohorse commented 2020-05-27 02:29:04 +00:00 (Migrated from github.com)
Copy Link

1590227713

Maybe we should put these descriptions under headers. Also that badge looks weird on the second line like that.

Updated 👍

> ![1590227713](https://user-images.githubusercontent.com/48640805/82727724-c11e9800-9cdb-11ea-9ffc-55e3e13aa8fb.png) > > Maybe we should put these descriptions under headers. Also that badge looks weird on the second line like that. Updated :+1:
blacklight447 commented 2020-05-27 12:59:55 +00:00 (Migrated from github.com)
Copy Link

Looks good! but personally, i think that having the explanations on top looks a bit messy, especially since most folks on that page only want to look at the providers themselves. i would recommend shoving the terms to the bottem of the page, and adding a single line of text in the "
Encrypted DNS Resolver" block which links to an text anchor at the bottem (where the explanations of the terms would be.)

Looks good! but personally, i think that having the explanations on top looks a bit messy, especially since most folks on that page only want to look at the providers themselves. i would recommend shoving the terms to the bottem of the page, and adding a single line of text in the " Encrypted DNS Resolver" block which links to an text anchor at the bottem (where the explanations of the terms would be.)
nitrohorse commented 2020-05-28 02:03:00 +00:00 (Migrated from github.com)
Copy Link

Looks good! but personally, i think that having the explanations on top looks a bit messy, especially since most folks on that page only want to look at the providers themselves. i would recommend shoving the terms to the bottem of the page, and adding a single line of text in the "

Encrypted DNS Resolver" block which links to an text anchor at the bottem (where the explanations of the terms would be.)

Ah, that makes sense 🤔 I’ll push a commit with this change.

> Looks good! but personally, i think that having the explanations on top looks a bit messy, especially since most folks on that page only want to look at the providers themselves. i would recommend shoving the terms to the bottem of the page, and adding a single line of text in the " > > Encrypted DNS Resolver" block which links to an text anchor at the bottem (where the explanations of the terms would be.) Ah, that makes sense 🤔 I’ll push a commit with this change.
👍 1
nitrohorse commented 2020-05-28 05:52:29 +00:00 (Migrated from github.com)
Copy Link

Todo: add forum links

Todo: add forum links
blacklight447 (Migrated from github.com) reviewed 2020-05-28 12:40:01 +00:00
danarel commented 2020-05-28 18:52:56 +00:00 (Migrated from github.com)
Copy Link

Should we use this chance to update some of the listings? Like we know AdGuard is using Vultr servers too.

Should we use this chance to update some of the listings? Like we know AdGuard is using Vultr servers too.
nitrohorse commented 2020-05-28 19:14:58 +00:00 (Migrated from github.com)
Copy Link

Should we use this chance to update some of the listings? Like we know AdGuard is using Vultr servers too.

Yeah, that makes sense. I forgot about that issue. I’ll dig it up and add a commit for it. Any other issues need to be addressed that you can recall? I’ll double-check through the issues myself later.

Also I’m wondering if we should include a section for “local ad/tracker blocking DNS recommendations for desktop” and include new cards for AdGuard Home and Pi-hole. That could be a separate PR though.

> Should we use this chance to update some of the listings? Like we know AdGuard is using Vultr servers too. Yeah, that makes sense. I forgot about that issue. I’ll dig it up and add a commit for it. Any other issues need to be addressed that you can recall? I’ll double-check through the issues myself later. Also I’m wondering if we should include a section for “local ad/tracker blocking DNS recommendations for desktop” and include new cards for AdGuard Home and Pi-hole. That could be a separate PR though.
nitrohorse commented 2020-05-30 00:56:30 +00:00 (Migrated from github.com)
Copy Link

Okay, updated AdGuard by adding Choopa (Vultr) as their hosting provider (couldn't find the associated issue for it though). I'll create a new issue for adding Pi-hole/AdGuard Home later.

Okay, updated AdGuard by adding Choopa (Vultr) as their hosting provider (couldn't find the associated issue for it though). I'll create a new issue for adding Pi-hole/AdGuard Home later.
danarel (Migrated from github.com) reviewed 2020-05-30 01:16:59 +00:00
danarel (Migrated from github.com) reviewed 2020-06-01 20:00:26 +00:00
danarel (Migrated from github.com) left a comment

LGTM

LGTM
blacklight447 (Migrated from github.com) approved these changes 2020-06-03 20:33:11 +00:00
danarel (Migrated from github.com) approved these changes 2020-06-04 15:59:32 +00:00
lrq3000 commented 2021-06-02 02:05:19 +00:00 (Migrated from github.com)
Copy Link

Thank you @nitrohorse for this awesome update! Very clear explanations!

Thank you @nitrohorse for this awesome update! Very clear explanations!
This repo is archived. You cannot comment on pull requests.
Reviewers
No Reviewers
blacklight447
danarel
Labels
Clear labels
🔍🤖 Search Engines
approved
approved, waiting for a PR
dependencies
Pull requests that update a dependency file
duplicate
feedback wanted
high priority
I2P
The Invisible Internet Project (I2P)
iOS
low priority
OS
Operating Systems
Self-contained networks
Social media
stale
A label for stalebot if it gets added
streaming
Anything related to media streaming.
todo
Tor
Anything covering the Tor network
WIP
active work in progress, do not merge or PR (yet)!
wontfix
Issues or bugs that will not be fixed and/or do not have significant impact on the project.
XMPP
Extensible Messaging and Presence Protocol
[m]
Matrix protocol
₿ cryptocurrency
ℹ️ help wanted
↔️ file sharing
⚙️ web extensions
Browser Extension related issues
✨ enhancement
❌ software removal
💬 discussion
🤖 Android
🐛 bug
💢 conflicting
📝 correction
Correction of content on the website
🆘 critical
📧 email
🔒 file encryption
📁 file storage
🦊 Firefox
Firefox & forks, about:config etc.
💻 hardware
🌐 hosting
🏠 housekeeping
Anything primarily related to site cleanup.
🔐 password managers
🧰 productivity tools
🔎 research required
🌐 Social News Aggregators
🆕 software suggestion
👥 team chat
🔒 VPN
Virtual Private Network
🌐 website issue
*Technical* issues with the website.
🚫 Windows
👁️ browsers
🖊️ digital notebooks
🗄️ DNS
Domain Name System
🗨️ instant messaging (im)
🇦🇶 translations
Anything covering a translated version of the site
No Label
🏠 housekeeping
🗄️ DNS
Milestone
No items
No Milestone
Assignees
Clear assignees
jonah
No Assignees
1 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: privacyguides/privacytools.io#1900
No description provided.
Delete Branch "rework-dns-page"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?