Adding new Qubes OS logo + File Sharing section with Onionshare #189
jonah
Reference in New Issue
Block a user
No description provided.
Delete Branch "master"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Tool logos are required to be 120 pixels, the image you provided is 128 pixels.
I believe 128 pixels is a more common format, my personal taste goes out to 128 but as it stands, the format is 120x120.
The OnionShare logo is 300x300 and does not confirm to the 120x120 rule.
The content is okay; OnionShare promotes the idea that onion links are unguessable, I'd like to note that onion URLs can be retrieved through "honions" and therefore you should not rely on the URL to act as a password.
A new hidden service architecture is proposed that patches the vulnerability and increases the URL size (and thus entropy) rendering the attack described above useless. It is however currently not in effect yet.
Source:
Honion simple read: https://nakedsecurity.sophos.com/2016/07/26/honey-onions-probe-the-tor-dark-webt-at-least-3-of-dark-web-nodes-are-rogues/
Honion whitepaper: https://regmedia.co.uk/2016/07/25/10_honions-sanatinia.pdf
@kewde I already added the
width="120px" height="120px"attributes, or you prefer that I should manually resize that image and upload it?As Micah Lee describes, "If an attacker enumerates the onion service, the shared files remain safe. There have been attacks against the Tor network that can enumerate onion services. If someone discovers the .onion address of an OnionShare onion service, they still cannot download the shared files without knowing the full URL, and OnionShare has rate-limited to protect against attempts to guess the URL."
@e5f3c2ea895af0f27667 I don't mind the usage of the resizing tags, but I can't speak for the other maintainers.
That's good, I was hoping a protection measure like that was imposed on the URL. I misinterpreted the content "they can't guess the url" in regards to the onion domain name. I do not have any issues anymore with this pull request, I have however not tested this PR for errors. The URLs for OnionShare and Qubes are correct.
Have you tested it? @e5f3c2ea895af0f27667 I will trust you word here.
URLs are OK.
Did not test Format/HTML.
Images do not match size requirements by image resize tags were used.
I'd prefer the image to be resized. If using resize tags instead of resizing images becomes a practice here, the website will be unnecessarily big. It's big enough already.
@kewde @Shifterovich Done, here's a preview https://htmlpreview.github.io/?https://github.com/e5f3c2ea895af0f27667/privacytools.io/blob/master/index.html#filesharing
The Qubes logo is still 128x128.
@Shifterovich Oh, thought that it was 120x120, changed that.
@Shifterovich https://htmlpreview.github.io/?https://github.com/e5f3c2ea895af0f27667/privacytools.io/blob/master/index.html#os
The worth reading section, next to Whonix, as Tor icon. What do you think?
Looks good. I'd use a wider image to make it easier-to-click-on, though.
@Shifterovich Made it a bit bigger but that's about it, otherwise it messes with line spacing.
@kewde Please change the tag of this PR.
URLs ok.
This merge seems alright by me..
Resolve conflicts and we'll merge.
@Shifterovich The author of this pull request has deleted his account. I really like the changes of this pull request, if nobody adopts it then I suppose I will fix the conflicts myself.
@Shifterovich @kewde Are you still going to push for this pull? At the present status only those with write level can fix it, and it seems it doesn't require much work to solve the conflicts.
QubesOS logo was already fixed #237
Added OnionShare in #246