Adding new Qubes OS logo + File Sharing section with Onionshare #189
Closed
ghost wants to merge 24 commits from
master
into master
pull from: master
merge into: privacyguides:master
privacyguides:dependabot/bundler/nokogiri-1.13.6
privacyguides:dependabot/bundler/addressable-2.8.0
privacyguides:freddy-m-patch-3
privacyguides:pr-add_RemoveMyPhone_sponsor
privacyguides:pr-browser_cleanup_1257_1328_1430
privacyguides:freddy-m-patch-2
privacyguides:freddy-m-patch-1
privacyguides:pr-vpn_hated_one_video
privacyguides:cdn
privacyguides:update-nitrohorse-image
privacyguides:promote-metager-to-card
privacyguides:hardware
privacyguides:pr-add_azirevpn
privacyguides:pr-add_mailfence
privacyguides:shop
privacyguides:1673
privacyguides:pr/1658
privacyguides:i18n-simple
privacyguides:sponsorship-edits-nov2019
privacyguides:i18n
privacyguides:ipfs
privacyguides:blacklight447-ptio-patch-3
privacyguides:blog
privacyguides:remove-windows-icons
privacyguides:pr/1147
privacyguides:i18n-testing
privacyguides:add-beautify
Labels
Clear labels
🔍🤖 Search Engines
approved
approved, waiting for a PR
dependencies
Pull requests that update a dependency file
duplicate
feedback wanted
high priority
I2P
The Invisible Internet Project (I2P)
iOS
low priority
OS
Operating Systems
Self-contained networks
Social media
stale
A label for stalebot if it gets added
streaming
Anything related to media streaming.
todo
Tor
Anything covering the Tor network
WIP
active work in progress, do not merge or PR (yet)!
wontfix
Issues or bugs that will not be fixed and/or do not have significant impact on the project.
XMPP
Extensible Messaging and Presence Protocol
[m]
Matrix protocol
₿ cryptocurrency
ℹ️ help wanted
↔️ file sharing
⚙️ web extensions
Browser Extension related issues
✨ enhancement
❌ software removal
💬 discussion
🤖 Android
🐛 bug
💢 conflicting
📝 correction
Correction of content on the website
🆘 critical
📧 email
🔒 file encryption
📁 file storage
🦊 Firefox
Firefox & forks, about:config etc.
💻 hardware
🌐 hosting
🏠 housekeeping
Anything primarily related to site cleanup.
🔐 password managers
🧰 productivity tools
🔎 research required
🌐 Social News Aggregators
🆕 software suggestion
👥 team chat
🔒 VPN
Virtual Private Network
🌐 website issue
*Technical* issues with the website.
🚫 Windows
👁️ browsers
🖊️ digital notebooks
🗄️ DNS
Domain Name System
🗨️ instant messaging (im)
🇦🇶 translations
Anything covering a translated version of the site
No Label
✨ enhancement
Milestone
No items
No Milestone
No due date set.
Dependencies
No dependencies set.
Reference: privacyguides/privacytools.io#189
Reference in New Issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
No description provided.
Delete Branch "master"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Tool logos are required to be 120 pixels, the image you provided is 128 pixels.
I believe 128 pixels is a more common format, my personal taste goes out to 128 but as it stands, the format is 120x120.
The OnionShare logo is 300x300 and does not confirm to the 120x120 rule.
The content is okay; OnionShare promotes the idea that onion links are unguessable, I'd like to note that onion URLs can be retrieved through "honions" and therefore you should not rely on the URL to act as a password.
A new hidden service architecture is proposed that patches the vulnerability and increases the URL size (and thus entropy) rendering the attack described above useless. It is however currently not in effect yet.
Source:
Honion simple read: https://nakedsecurity.sophos.com/2016/07/26/honey-onions-probe-the-tor-dark-webt-at-least-3-of-dark-web-nodes-are-rogues/
Honion whitepaper: https://regmedia.co.uk/2016/07/25/10_honions-sanatinia.pdf
@kewde I already added the
width="120px" height="120px"
attributes, or you prefer that I should manually resize that image and upload it?As Micah Lee describes, "If an attacker enumerates the onion service, the shared files remain safe. There have been attacks against the Tor network that can enumerate onion services. If someone discovers the .onion address of an OnionShare onion service, they still cannot download the shared files without knowing the full URL, and OnionShare has rate-limited to protect against attempts to guess the URL."
@e5f3c2ea895af0f27667 I don't mind the usage of the resizing tags, but I can't speak for the other maintainers.
That's good, I was hoping a protection measure like that was imposed on the URL. I misinterpreted the content "they can't guess the url" in regards to the onion domain name. I do not have any issues anymore with this pull request, I have however not tested this PR for errors. The URLs for OnionShare and Qubes are correct.
Have you tested it? @e5f3c2ea895af0f27667 I will trust you word here.
URLs are OK.
Did not test Format/HTML.
Images do not match size requirements by image resize tags were used.
I'd prefer the image to be resized. If using resize tags instead of resizing images becomes a practice here, the website will be unnecessarily big. It's big enough already.
@kewde @Shifterovich Done, here's a preview https://htmlpreview.github.io/?https://github.com/e5f3c2ea895af0f27667/privacytools.io/blob/master/index.html#filesharing
The Qubes logo is still 128x128.
@Shifterovich Oh, thought that it was 120x120, changed that.
@Shifterovich https://htmlpreview.github.io/?https://github.com/e5f3c2ea895af0f27667/privacytools.io/blob/master/index.html#os
The worth reading section, next to Whonix, as Tor icon. What do you think?
Looks good. I'd use a wider image to make it easier-to-click-on, though.
@Shifterovich Made it a bit bigger but that's about it, otherwise it messes with line spacing.
@kewde Please change the tag of this PR.
URLs ok.
This merge seems alright by me..
Resolve conflicts and we'll merge.
@Shifterovich The author of this pull request has deleted his account. I really like the changes of this pull request, if nobody adopts it then I suppose I will fix the conflicts myself.
@Shifterovich @kewde Are you still going to push for this pull? At the present status only those with write level can fix it, and it seems it doesn't require much work to solve the conflicts.
QubesOS logo was already fixed #237
Added OnionShare in #246