Joining CanvasBlocker to the Add-Ons List #1787

Merged
hugoncosta merged 3 commits from master into pr-add_canvasblocker 2020-05-05 09:41:55 +00:00
hugoncosta commented 2020-03-14 15:16:21 +00:00 (Migrated from github.com)

Resolves: https://github.com/privacytoolsIO/privacytools.io/issues/1786

Description

Currently, CanvasBlocker is discretly mentioned under Browser Fingerprinting. Since it's a plugin like all the others, I believe it should join the Add-Ons. The order is indifferent, I put it in the middle. #1786

Check List

  • I understand that by not opening an issue about a software/service/similar addition/removal, this pull request will be closed without merging.

  • I have read and understand the contributing guidelines.

  • The project is Free Libre and/or Open Source Software

Resolves: https://github.com/privacytoolsIO/privacytools.io/issues/1786 <!-- PLEASE READ OUR CODE OF CONDUCT (https://wiki.privacytools.io/view/PrivacyTools:Code_of_Conduct) AND CONTRIBUTING GUIDELINES (https://github.com/privacytoolsIO/privacytools.io/blob/master/.github/CONTRIBUTING.md) BEFORE SUBMITTING --> ## Description Currently, CanvasBlocker is discretly mentioned under Browser Fingerprinting. Since it's a plugin like all the others, I believe it should join the Add-Ons. The order is indifferent, I put it in the middle. #1786 #### Check List <!-- Please add an x in each box below, like so: [x] --> - [X] I understand that by not opening an issue about a software/service/similar addition/removal, this pull request will be closed without merging. - [X] I have read and understand [the contributing guidelines](https://github.com/privacytoolsIO/privacytools.io/blob/master/.github/CONTRIBUTING.md). - [X] The project is [Free Libre](https://en.wikipedia.org/wiki/Free_software) and/or [Open Source](https://en.wikipedia.org/wiki/Open-source_software) Software * Netlify preview for the mainly edited page: https://deploy-preview-1787--privacytools-io.netlify.com/ * Code repository of the project (if applicable): https://github.com/hugoncosta/privacytools.io
netlify[bot] commented 2020-03-14 15:16:57 +00:00 (Migrated from github.com)

Deploy preview for privacytools-io ready!

Built with commit 8be8849bd9

https://deploy-preview-1787--privacytools-io.netlify.app

Deploy preview for *privacytools-io* ready! Built with commit 8be8849bd9fccc40d3c24a6a938f1da23a34c98e https://deploy-preview-1787--privacytools-io.netlify.app
Mikaela commented 2020-03-19 15:57:11 +00:00 (Migrated from github.com)

Netlify preview for the mainly edited page: https://deploy-preview-1787--privacytools-io.netlify.com/

This means the page you mostly edited which is in this case https://deploy-preview-1787--privacytools-io.netlify.com/browsers/#addons

Code repository of the project (if applicable): https://github.com/hugoncosta/privacytools.io

This means the project you edited which means Canvas Blocker, but I would also accept unapplicable if it was already listed even if as a worth mentioning.

I cannot review at the moment (see my GitHub status).

> Netlify preview for the mainly edited page: https://deploy-preview-1787--privacytools-io.netlify.com/ This means the page you mostly edited which is in this case https://deploy-preview-1787--privacytools-io.netlify.com/browsers/#addons > Code repository of the project (if applicable): https://github.com/hugoncosta/privacytools.io This means the project you edited which means Canvas Blocker, but I would also accept unapplicable if it was already listed even if as a worth mentioning. I cannot review at the moment (see my GitHub status).
dngray commented 2020-03-22 07:09:06 +00:00 (Migrated from github.com)

This is not a good idea if you use privacy.resistFingerprinting = true.

We should include a warning regarding that.

This is not a good idea if you use `privacy.resistFingerprinting = true`. We [should include a warning](https://github.com/ghacksuserjs/ghacks-user.js/issues/767#issuecomment-515738986) regarding that.
dngray commented 2020-05-05 05:06:00 +00:00 (Migrated from github.com)

We could add this as an advanced addon as @Thorin-Oakenpants suggests https://github.com/privacytoolsIO/privacytools.io/issues/1877#issuecomment-623786468

We could add this as an advanced addon as @Thorin-Oakenpants suggests https://github.com/privacytoolsIO/privacytools.io/issues/1877#issuecomment-623786468
dngray (Migrated from github.com) reviewed 2020-05-05 05:08:51 +00:00
dngray (Migrated from github.com) left a comment

SVG needs optimizing

SVG needs optimizing
dngray commented 2020-05-05 09:33:31 +00:00 (Migrated from github.com)

I'm thinking we could list this under advanced, paired with uMatrix as suggested https://github.com/privacytoolsIO/privacytools.io/issues/1877#issuecomment-623786468

I eventually want to move Cookie Autodelete out of there into another group "cookie management" or something like that and mention Containers/Temporary Containers as that's a better approach.

I'm thinking we could list this under advanced, paired with uMatrix as suggested https://github.com/privacytoolsIO/privacytools.io/issues/1877#issuecomment-623786468 I eventually want to move Cookie Autodelete out of there into another group "cookie management" or something like that and mention Containers/Temporary Containers as that's a better approach.
This repo is archived. You cannot comment on pull requests.
No Reviewers
No Label
1 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: privacyguides/privacytools.io#1787
No description provided.