privacyguides/privacytools.io
Archived
1
0
Fork 0
Code Issues 304 Pull Requests 47 Activity

Move IVPN into recommended section #1667

Merged
dngray merged 2 commits from pr-ivpn_recommended into master 2020-01-30 15:07:34 +00:00
Conversation 14 Commits 2 Files Changed 1
+20 -22
dngray commented 2020-01-27 13:11:19 +00:00 (Migrated from github.com)
Copy Link
Copy Source

https://deploy-preview-1667--privacytools-io.netlify.com/providers/vpn/

Resolves: #1664

https://deploy-preview-1667--privacytools-io.netlify.com/providers/vpn/ Resolves: #1664
netlify[bot] commented 2020-01-27 13:12:05 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Deploy preview for privacytools-io ready!

Built with commit 40759bf21a

https://deploy-preview-1667--privacytools-io.netlify.com

Deploy preview for *privacytools-io* ready! Built with commit 40759bf21a6cfdcaf8d3560671ba01b622451e91 https://deploy-preview-1667--privacytools-io.netlify.com
nitrohorse (Migrated from github.com) reviewed 2020-01-27 16:34:53 +00:00
_includes/sections/vpn.html
nitrohorse (Migrated from github.com) commented 2020-01-27 16:34:47 +00:00

Looks like this paragraph cuts off with “IVPN has not only...”

Looks like this paragraph cuts off with “IVPN has not only...”
Mikaela (Migrated from github.com) requested changes 2020-01-27 18:07:35 +00:00
_includes/sections/vpn.html
Mikaela (Migrated from github.com) commented 2020-01-27 18:04:08 +00:00

Also what do strong and premium mean in this context? I think they make this look too much like an advertisement by them.

Another issue is that the country name is missing showing only the flag which I don't recognise.

Also what do _strong_ and _premium_ mean in this context? I think they make this look too much like an advertisement by them. Another issue is that the country name is missing showing only the flag which I don't recognise.
Mikaela (Migrated from github.com) commented 2020-01-27 18:06:10 +00:00

Shouldn't there be a warning symbol here? (This is not a blocker for my approval.)

Shouldn't there be a warning symbol here? (This is not a blocker for my approval.)
dngray (Migrated from github.com) reviewed 2020-01-28 04:51:09 +00:00
_includes/sections/vpn.html
dngray (Migrated from github.com) commented 2020-01-28 04:51:08 +00:00

Yes you're right. I've changed that to a yellow badge.

Yes you're right. I've changed that to a yellow badge.
dngray (Migrated from github.com) reviewed 2020-01-28 04:52:30 +00:00
_includes/sections/vpn.html
dngray (Migrated from github.com) commented 2020-01-28 04:52:30 +00:00

I think I began to do something with that, but then got distracted.

I have also changed the number of servers, to countries. @JonahAragon and I think this is more accurate. A larger VPN provider will require more servers obviously, it's where they are relative to users that is important.

I think I began to do something with that, but then got distracted. I have also changed the number of servers, to countries. @JonahAragon and I think this is more accurate. A larger VPN provider will require more servers obviously, it's where they are relative to users that is important.
dngray (Migrated from github.com) reviewed 2020-01-28 04:53:55 +00:00
_includes/sections/vpn.html
dngray (Migrated from github.com) commented 2020-01-28 04:53:55 +00:00

Also what do strong and premium mean in this context?

I do not know, I did not write that originally. I think we should just remove the word strong, it sounds better I think.

> Also what do _strong_ and _premium_ mean in this context? I do not know, I did not write that originally. I think we should just remove the word strong, it sounds better I think.
dngray (Migrated from github.com) reviewed 2020-01-28 04:57:22 +00:00
_includes/sections/vpn.html
dngray (Migrated from github.com) commented 2020-01-28 04:57:22 +00:00

To be honest, i don't really like that description at all for any of the providers.

Mullvad is a fast and inexpensive VPN with a serious focus on transparency and security.

Kinda makes it sound like it's cheap, also all the providers we choose have transparency and security.

ProtonVPN is a strong contender in the VPN space

What does that even mean?

IVPN is another premium VPN provider

Does sound better than "strong premium".

We might revisit this in another PR, it's fine for the time being I guess.

To be honest, i don't really like that description at all for any of the providers. > Mullvad is a fast and inexpensive VPN with a serious focus on transparency and security. Kinda makes it sound like it's cheap, also all the providers we choose have transparency and security. > ProtonVPN is a strong contender in the VPN space What does that even mean? > IVPN is another premium VPN provider Does sound better than "strong premium". We might revisit this in another PR, it's fine for the time being I guess.
Mikaela (Migrated from github.com) reviewed 2020-01-28 13:16:11 +00:00
_includes/sections/vpn.html
@@ -85,11 +77,14 @@
<span class="badge badge-info">Standard USD $60/Year</span>
<span class="badge badge-secondary">Pro USD $100/Year</span>
Mikaela (Migrated from github.com) commented 2020-01-28 13:15:47 +00:00 
    <p>The source code for the Windows, MacOS, iOS and Android apps is not available. Open source software would allow the community to verify the intended purpose.</p>
```suggestion <p>The source code for the Windows, MacOS, iOS and Android apps is not available. Open source software would allow the community to verify the intended purpose.</p> ```
_includes/sections/vpn.html
Mikaela (Migrated from github.com) commented 2020-01-28 13:15:18 +00:00

What makes them an premium VPN provider?

What makes them an premium VPN provider?
dngray (Migrated from github.com) reviewed 2020-01-28 15:05:25 +00:00
_includes/sections/vpn.html
dngray (Migrated from github.com) commented 2020-01-28 15:05:24 +00:00

In this case, I would say all 3 providers are "premium" or "good" VPN providers, as they use dedicated servers, and support other things such as IPv6, remote port forwarding, have had audits etc.

There's a lot of crappy VPN providers out there, we don't list those. Hence the another. The wording wasn't mine to begin with but that's what I understand it to be.

In this case, I would say all 3 providers are "premium" or "good" VPN providers, as they use dedicated servers, and support other things such as IPv6, remote port forwarding, have had audits etc. There's a lot of crappy VPN providers out there, we don't list those. Hence the *another*. The wording wasn't mine to begin with but that's what I understand it to be.
nitrohorse (Migrated from github.com) reviewed 2020-01-28 16:24:07 +00:00
nitrohorse (Migrated from github.com) left a comment

LGTM. Small suggestion, I wonder if it’s worth calling out further that due to AntiTracker, IVPN is the only recommended provider that includes ad and tracker blocking at the network level?

LGTM. Small suggestion, I wonder if it’s worth calling out further that due to [AntiTracker](https://www.ivpn.net/antitracker), IVPN is the only recommended provider that includes ad and tracker blocking at the network level?
_includes/sections/vpn.html
nitrohorse (Migrated from github.com) commented 2020-01-28 16:19:59 +00:00

Small nit: “it's” to “its”

Small nit: “it's” to “its”
dngray (Migrated from github.com) reviewed 2020-01-29 05:31:25 +00:00
_includes/sections/vpn.html
dngray (Migrated from github.com) commented 2020-01-29 05:31:25 +00:00

Small nit: “it's” to “its”

You're dead right derp.

> Small nit: “it's” to “its” You're dead right derp.
dngray commented 2020-01-29 05:32:06 +00:00 (Migrated from github.com)
Copy Link
Copy Source

reommended provider that includes ad and tracker blocking at the network level?

We could certainly add something under extra features.

> reommended provider that includes ad and tracker blocking at the network level? We could certainly add something under extra features.
nitrohorse (Migrated from github.com) approved these changes 2020-01-29 07:46:04 +00:00
nitrohorse (Migrated from github.com) left a comment

LGTM

LGTM
Mikaela (Migrated from github.com) approved these changes 2020-01-30 11:15:55 +00:00
Mikaela (Migrated from github.com) left a comment

I am not entirely in the state for reviewing, but nothing bad hits my eyes with this PR right now.

👍 for quoting AntiTracker.

I am not entirely in the state for reviewing, but nothing bad hits my eyes with this PR right now. :+1: for quoting AntiTracker.
This repo is archived. You cannot comment on pull requests.
Reviewers
No Reviewers
dngray
nitrohorse
Mikaela
Labels
Clear labels
:mag:🤖 Search Engines
approved
approved, waiting for a PR
 dependencies
Pull requests that update a dependency file
 duplicate
feedback wanted
high priority
I2P
The Invisible Internet Project (I2P)
 iOS
low priority
OS
Operating Systems
 Self-contained networks
Social media
stale
A label for stalebot if it gets added
 streaming
Anything related to media streaming.
 todo
Tor
Anything covering the Tor network
 WIP
active work in progress, do not merge or PR (yet)!
 wontfix
Issues or bugs that will not be fixed and/or do not have significant impact on the project.
 XMPP
Extensible Messaging and Presence Protocol
 [m]
Matrix protocol
 ₿ cryptocurrency
ℹ️ help wanted
↔️ file sharing
⚙️ web extensions
Browser Extension related issues
 ✨ enhancement
❌ software removal
💬 discussion
🤖 Android
🐛 bug
💢 conflicting
📝 correction
Correction of content on the website
 🆘 critical
📧 email
🔒 file encryption
📁 file storage
🦊 Firefox
Firefox & forks, about:config etc.
 💻 hardware
🌐 hosting
🏠 housekeeping
Anything primarily related to site cleanup.
 🔐 password managers
🧰 productivity tools
🔎 research required
🌐 Social News Aggregators
🆕 software suggestion
👥 team chat
🔒 VPN
Virtual Private Network
 🌐 website issue
*Technical* issues with the website.
 🚫 Windows
👁️ browsers
🖊️ digital notebooks
🗄️ DNS
Domain Name System
 🗨️ instant messaging (im)
🇦🇶 translations
Anything covering a translated version of the site
No labels
Milestone
No items
No Milestone
Assignees
Clear assignees
jonah
No Assignees
1 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: privacyguides/privacytools.io#1667