Change a warning of Firefox about:config entering #1603

2019-12-20T10:49:04Z

igoose1 commented

2019-12-20 10:49:04 +00:00

(Migrated from github.com)

Description

Button had been changed to "Accept the Risk and Continue" so I've updated that. More information at #1602

Resolves: https://github.com/privacytoolsIO/privacytools.io/issues/1532

Check List

I have read and understand the contributing guidelines.
The project is Free Libre and/or Open Source Software

## Description Button had been changed to "Accept the Risk and Continue" so I've updated that. More information at #1602 Resolves: https://github.com/privacytoolsIO/privacytools.io/issues/1532 #### Check List  - [x] I have read and understand [the contributing guidelines](https://github.com/privacytoolsIO/privacytools.io/blob/master/.github/CONTRIBUTING.md). - [x] The project is [Free Libre](https://en.wikipedia.org/wiki/Free_software) and/or [Open Source](https://en.wikipedia.org/wiki/Open-source_software) Software

nitrohorse (Migrated from github.com) reviewed 2019-12-20 10:49:04 +00:00

netlify[bot] commented

2019-12-20 10:49:55 +00:00

(Migrated from github.com)

Deploy preview for privacytools-io ready!

Built with commit 2b2a40a159

https://deploy-preview-1603--privacytools-io.netlify.com

Deploy preview for *privacytools-io* ready! Built with commit 2b2a40a1591cd5d8f34254daf9892aefdf792110 https://deploy-preview-1603--privacytools-io.netlify.com

Mikaela (Migrated from github.com) reviewed 2019-12-20 17:10:42 +00:00

Mikaela (Migrated from github.com) left a comment

I think both wordings should be included until Firefox ESR ships this change too.

_includes/sections/browser-tweaks.html

Mikaela (Migrated from github.com) commented

2019-12-20 17:10:13 +00:00

Has it also changed in Firefox ESR?

igoose1 (Migrated from github.com) reviewed 2019-12-20 22:14:42 +00:00

_includes/sections/browser-tweaks.html

igoose1 (Migrated from github.com) commented

2019-12-20 22:14:41 +00:00

Has it also changed in Firefox ESR?

I cannot check that on my system 🤷‍♀️. I'll try to look at someone's ESR version but I cannot promise that. Right now I can say it is, at least, on 71.0, but that's a "standard" version, not ESR.

> Has it also changed in Firefox ESR? I cannot check that on my system :woman_shrugging:. I'll try to look at someone's ESR version but I cannot promise that. Right now I can say it is, at least, on 71.0, but that's a "standard" version, not ESR.

igoose1 commented

2019-12-20 22:33:46 +00:00

(Migrated from github.com)

I added "or" with both wordings but it must be better to check if ESR really hasn't changed the sentence.

👍 1

Thorin-Oakenpants commented

2020-01-09 17:16:22 +00:00

(Migrated from github.com)

ESR 68.0.2, FF70 and lower (tested back to FF60)

I accept the risk

FF71+

Accept the Risk and Continue

I only checked on Windows, but I doubt the OS has any affect here.

No idea where you're getting I'll be careful, I promise! from but it looks vaguely familiar - maybe that's an even older wording?

ESR 68.0.2, FF70 and lower (tested back to FF60) - `I accept the risk` FF71+ - `Accept the Risk and Continue` I only checked on Windows, but I doubt the OS has any affect here. --- No idea where you're getting `I'll be careful, I promise!` from but it looks vaguely familiar - maybe that's an even older wording?

👍 1

Mikaela commented

2020-01-11 22:18:19 +00:00

(Migrated from github.com)

@igoose1 Would you be open to committing based on Thorin-Oakenpants's comment?

igoose1 commented

2020-01-11 23:37:18 +00:00

(Migrated from github.com)

@Mikaela, here is. Thank you, @Thorin-Oakenpants!

Mikaela (Migrated from github.com) approved these changes 2020-01-12 09:00:45 +00:00

dngray (Migrated from github.com) approved these changes 2020-01-24 03:20:46 +00:00

This repo is archived. You cannot comment on pull requests.

1 Participants

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: privacyguides/privacytools.io#1603