Change wording to be closer to Bromite's own description #1597

2019-12-18T21:19:36Z

csagan5 commented

2019-12-18 21:19:36 +00:00

(Migrated from github.com)

This PR changes the wording to be closer to Bromite's own description and mentions ungoogled-chromium instead of GrapheneOS.

Description

Resolves: #1588

Check List

I have read and understand the contributing guidelines.
The project is Free Libre and/or Open Source Software

Netlify preview for the mainly edited page:

This PR changes the wording to be closer to Bromite's own description and mentions ungoogled-chromium instead of GrapheneOS. ## Description Resolves: #1588 #### Check List - [x] I have read and understand [the contributing guidelines](https://github.com/privacytoolsIO/privacytools.io/blob/master/.github/CONTRIBUTING.md). - [x] The project is [Free Libre](https://en.wikipedia.org/wiki/Free_software) and/or [Open Source](https://en.wikipedia.org/wiki/Open-source_software) Software * Netlify preview for the mainly edited page:

netlify[bot] commented

2019-12-18 21:20:29 +00:00

(Migrated from github.com)

Deploy preview for privacytools-io ready!

Built with commit 11cc09a3a8

https://deploy-preview-1597--privacytools-io.netlify.com

Deploy preview for *privacytools-io* ready! Built with commit 11cc09a3a829827d5e3462ac4a7dcceaa5fed1ba https://deploy-preview-1597--privacytools-io.netlify.com

Mikaela (Migrated from github.com) reviewed

2019-12-18 22:19:29 +00:00

_includes/sections/browser-recommendation.html

Mikaela (Migrated from github.com) commented

2019-12-18 22:19:25 +00:00

I think there is an "and" missing.

csagan5 (Migrated from github.com) reviewed

2019-12-18 23:07:20 +00:00

_includes/sections/browser-recommendation.html

csagan5 (Migrated from github.com) commented

2019-12-18 23:07:20 +00:00

Where would you add it? Before DNS over HTTPS?

Where would you add it? Before `DNS over HTTPS`?

nitrohorse (Migrated from github.com) reviewed

2019-12-20 20:07:27 +00:00

_includes/sections/browser-recommendation.html

nitrohorse (Migrated from github.com) commented

2019-12-20 20:07:27 +00:00

Yeah I’d think so

nitrohorse (Migrated from github.com) reviewed

2019-12-20 20:08:44 +00:00

_includes/sections/browser-recommendation.html

nitrohorse (Migrated from github.com) commented

2019-12-20 20:08:43 +00:00

Is there a reason we don’t say patches also come from GrapheneOS?

privacy enhancement patches from Iridium, Inox patchset, Brave and ungoogled-chromium projects
security enhancement patches from GrapheneOS project

Maybe for clarity we do list both ungoogled-chromium and GrapheneOS?

Is there a reason we don’t say patches also come from GrapheneOS? > privacy enhancement patches from Iridium, Inox patchset, Brave and ungoogled-chromium projects > security enhancement patches from GrapheneOS project Maybe for clarity we do list both ungoogled-chromium and GrapheneOS?

csagan5 (Migrated from github.com) reviewed

2019-12-21 08:18:42 +00:00

_includes/sections/browser-recommendation.html

csagan5 (Migrated from github.com) commented

2019-12-21 08:18:41 +00:00

@nitrohorse let's reverse the question: why would you want to mention GrapheneOS in the first place? Is it a non-technical reason?

GrapheneOS is the youngest of the mentioned projects and the one from which I picked the least patches compared to the others; it includes some Bromite patches itself and sometimes create others based on Bromite's patches (see this comment for a recent example), so there is no clear downstream/upstream (more of a collaboration), while for ungoogled-chromium there is a lot of patches in use in Bromite (~11). I keep correct patch author attribution as much as I can and that helps to identify contributions; there are 3 important patches taken from GrapheneOS (64-bit WebView processes, -fstack-protector-strong, -fwrapv in clang), thus I know it's not one I would mention first to be fair vs other projects which contributed more patches.

P.S. it should be Vanadium anyways, since GrapheneOS is not the browser

@nitrohorse let's reverse the question: why would you want to mention GrapheneOS in the first place? Is it a non-technical reason? GrapheneOS is the youngest of the mentioned projects and the one from which I picked the least patches compared to the others; it includes some Bromite patches itself and sometimes create others based on Bromite's patches (see [this comment](https://github.com/GrapheneOS/Vanadium/pull/48#issuecomment-567731962) for a recent example), so there is no clear downstream/upstream (more of a collaboration), while for ungoogled-chromium there is a lot of patches in use in Bromite (~11). I keep correct patch author attribution as much as I can and that helps to identify contributions; there are 3 important patches taken from GrapheneOS (64-bit WebView processes, -fstack-protector-strong, -fwrapv in clang), thus I know it's not one I would mention first to be fair vs other projects which contributed more patches. P.S. it should be Vanadium anyways, since GrapheneOS is not the browser

Mikaela (Migrated from github.com) approved these changes

2019-12-21 12:08:01 +00:00

csagan5 commented

2019-12-31 18:28:29 +00:00

(Migrated from github.com)

I guess this is stuck, somehow?

Mikaela commented

2019-12-31 20:05:13 +00:00

(Migrated from github.com)

@nitrohorse Would you like to rereview or someone else from @privacytoolsIO/editorial ?

I don't know how many people are looking at GitHub at a time like new year though.

@nitrohorse Would you like to rereview or someone else from @privacytoolsIO/editorial ? I don't know how many people are looking at GitHub at a time like new year though.

👍 1

nitrohorse (Migrated from github.com) reviewed

2020-01-05 03:49:33 +00:00

_includes/sections/browser-recommendation.html

nitrohorse (Migrated from github.com) commented

2020-01-05 03:49:32 +00:00

Apologies for the late reply, I missed this. I guess I was under the impression Bromite started from the GrapheneOS project which is why I was thinking it’s still helpful to list GOS in the description. But thanks for clarifying, this change makes sense 👍🏼

nitrohorse (Migrated from github.com) approved these changes

2020-01-05 03:50:01 +00:00

csagan5 (Migrated from github.com) reviewed

2020-01-06 16:10:58 +00:00

_includes/sections/browser-recommendation.html

csagan5 (Migrated from github.com) commented

2020-01-06 16:10:58 +00:00

No problem, I thought it was odd. Bromite is ~2 years older than the GrapheneOS project and Daniel (the author behind GrapheneOS) also refers to Bromite here: https://grapheneos.org/usage

This is because of the ongoing free-form collaboration.

No problem, I thought it was odd. Bromite is ~2 years older than the GrapheneOS project and Daniel (the author behind GrapheneOS) also refers to Bromite here: https://grapheneos.org/usage This is because of the ongoing free-form collaboration.

This repo is archived. You cannot comment on pull requests.

1 Participants

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: privacyguides/privacytools.io#1597