privacyguides/privacytools.io
Archived
1
0
Fork 0
Code Issues 304 Pull Requests 47 Activity

Software Suggestion | DecSync #1530

Merged
moritztk merged 5 commits from patch-1 into master 2019-11-30 15:45:03 +00:00
Conversation 13 Commits 5 Files Changed 1
+67 -298
moritztk commented 2019-11-26 14:55:09 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Description

Resolves: #1416

Check List

<!-- PLEASE READ OUR CODE OF CONDUCT (https://github.com/privacytoolsIO/privacytools.io/blob/master/CODE_OF_CONDUCT.md) AND CONTRIBUTING GUIDELINES (https://github.com/privacytoolsIO/privacytools.io/blob/master/.github/CONTRIBUTING.md) BEFORE SUBMITTING --> ## Description Resolves: #1416 #### Check List <!-- Please add an x in each box below, like so: [x] --> - [X] I have read and understand [the contributing guidelines](https://github.com/privacytoolsIO/privacytools.io/blob/master/.github/CONTRIBUTING.md). - [X] The project is [Free Libre](https://en.wikipedia.org/wiki/Free_software) and/or [Open Source](https://en.wikipedia.org/wiki/Open-source_software) Software * Netlify preview for the mainly edited page: https://deploy-preview-1530--privacytools-io.netlify.com/software/calendar-contacts/#calendar_contacts * Code repository of the project (if applicable): https://github.com/39aldo39/DecSync
netlify[bot] commented 2019-11-26 14:56:01 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Deploy preview for privacytools-io ready!

Built with commit 904e14effa

https://deploy-preview-1530--privacytools-io.netlify.com

Deploy preview for *privacytools-io* ready! Built with commit 904e14effaa95647a58cae4a7c33473642e68216 https://deploy-preview-1530--privacytools-io.netlify.com
Mikaela (Migrated from github.com) reviewed 2019-11-26 16:52:11 +00:00
Mikaela (Migrated from github.com) left a comment

Thank you, I fixed your preview link though.

Some worries:

  • https://github.com/39aldo39/DecSync/pulse/monthly - the project isn't very active according to GitHub's monthly pulse.
  • Should Syncthing be a link in your commit?
  • Is productivity tools the correct section? I understand that it belongs there too, but I wonder if people would be looking for it in calendar/contacts sync? I wonder if there should be an issue about merging the two pages.
Thank you, I fixed your preview link though. Some worries: * ~~https://github.com/39aldo39/DecSync/pulse/monthly - the project isn't very active according to GitHub's monthly pulse.~~ * ~~Should Syncthing be a link in your commit?~~ * ~~Is productivity tools the correct section? I understand that it belongs there too, but I wonder if people would be looking for it in calendar/contacts sync? I wonder if there should be an issue about merging the two pages.~~
moritztk commented 2019-11-27 10:09:02 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Hi Mikaela

https://github.com/39aldo39/DecSync/pulse/monthly - the project isn't very active according to GitHub's monthly pulse.

This is the main repo, just describing the project in docs. The repos containing the apps are more active: Android and Linux.

Is productivity tools the correct section? I understand that it belongs there too, but I wonder if people would be looking for it in calendar/contacts sync?

TBH I am not quite sure about that myself and would be happy about suggestions.

I wonder if there should be an issue about merging the two pages.

I don't quite understand what you mean by that, maybe I am missing some context?

Hi Mikaela > https://github.com/39aldo39/DecSync/pulse/monthly - the project isn't very active according to GitHub's monthly pulse. This is the main repo, just describing the project in docs. The repos containing the apps are more active: [Android](https://github.com/39aldo39/DecSyncCC/pulse/monthly) and [Linux](https://github.com/39aldo39/Evolution-DecSync/pulse/monthly). > Is productivity tools the correct section? I understand that it belongs there too, but I wonder if people would be looking for it in calendar/contacts sync? TBH I am not quite sure about that myself and would be happy about suggestions. > I wonder if there should be an issue about merging the two pages. I don't quite understand what you mean by that, maybe I am missing some context?
👍 1
moritztk commented 2019-11-27 10:15:12 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Added a link to syncthing

Added a link to syncthing
Mikaela (Migrated from github.com) reviewed 2019-11-27 13:20:47 +00:00
Mikaela (Migrated from github.com) left a comment

Thanks, I don't seem to have other concerns than #1533 which doesn't affect this PR.

Thanks, I don't seem to have other concerns than #1533 which doesn't affect this PR.
moritztk commented 2019-11-27 13:43:54 +00:00 (Migrated from github.com)
Copy Link
Copy Source

I moved the link from productivity to cal/con, and somehow accidentaly dismissed your review.

I moved the link from productivity to cal/con, and somehow accidentaly dismissed your review.
Mikaela commented 2019-11-27 13:45:40 +00:00 (Migrated from github.com)
Copy Link
Copy Source

GitHub tells me 0 changed files and reviews are automatically dismissed as something changes, probably in case it fixes old change request or turns from approved to unapproved.

GitHub tells me 0 changed files and reviews are automatically dismissed as something changes, probably in case it fixes old change request or turns from approved to unapproved.
moritztk commented 2019-11-27 13:46:08 +00:00 (Migrated from github.com)
Copy Link
Copy Source

@Mikaela the change should show again, sorry for the confusion

@Mikaela the change should show again, sorry for the confusion
👍 1
Mikaela (Migrated from github.com) reviewed 2019-11-27 13:48:01 +00:00
nitrohorse (Migrated from github.com) requested changes 2019-11-28 23:19:24 +00:00
nitrohorse (Migrated from github.com) left a comment

Small suggestion to improve readability a bit.

Small suggestion to improve readability a bit.
_includes/sections/calendar-contacts-sync.html
nitrohorse (Migrated from github.com) commented 2019-11-28 23:18:54 +00:00 
    <a href="https://github.com/39aldo39/DecSync">DecSync</a> - DecSync can be used to synchronize RSS, contacts, and calendars without a server by using file synchronization software such as <a href="https://syncthing.net/">Syncthing</a>.
```suggestion <a href="https://github.com/39aldo39/DecSync">DecSync</a> - DecSync can be used to synchronize RSS, contacts, and calendars without a server by using file synchronization software such as <a href="https://syncthing.net/">Syncthing</a>. ```
moritztk commented 2019-11-29 13:46:24 +00:00 (Migrated from github.com)
Copy Link
Copy Source

I commited @nitrohorse's suggestion, I agree it's clearer. Somehow that dismissed @Mikaela's review again.

I commited @nitrohorse's suggestion, I agree it's clearer. Somehow that dismissed @Mikaela's review again.
nitrohorse (Migrated from github.com) approved these changes 2019-11-29 15:18:09 +00:00
nitrohorse (Migrated from github.com) left a comment

Thanks! Yeah, any new change drops the current approvals.

Thanks! Yeah, any new change drops the current approvals.
Mikaela (Migrated from github.com) approved these changes 2019-11-30 15:44:13 +00:00
This repo is archived. You cannot comment on pull requests.
Reviewers
No Reviewers
nitrohorse
Mikaela
Labels
Clear labels
:mag:🤖 Search Engines
approved
approved, waiting for a PR
 dependencies
Pull requests that update a dependency file
 duplicate
feedback wanted
high priority
I2P
The Invisible Internet Project (I2P)
 iOS
low priority
OS
Operating Systems
 Self-contained networks
Social media
stale
A label for stalebot if it gets added
 streaming
Anything related to media streaming.
 todo
Tor
Anything covering the Tor network
 WIP
active work in progress, do not merge or PR (yet)!
 wontfix
Issues or bugs that will not be fixed and/or do not have significant impact on the project.
 XMPP
Extensible Messaging and Presence Protocol
 [m]
Matrix protocol
 ₿ cryptocurrency
ℹ️ help wanted
↔️ file sharing
⚙️ web extensions
Browser Extension related issues
 ✨ enhancement
❌ software removal
💬 discussion
🤖 Android
🐛 bug
💢 conflicting
📝 correction
Correction of content on the website
 🆘 critical
📧 email
🔒 file encryption
📁 file storage
🦊 Firefox
Firefox & forks, about:config etc.
 💻 hardware
🌐 hosting
🏠 housekeeping
Anything primarily related to site cleanup.
 🔐 password managers
🧰 productivity tools
🔎 research required
🌐 Social News Aggregators
🆕 software suggestion
👥 team chat
🔒 VPN
Virtual Private Network
 🌐 website issue
*Technical* issues with the website.
 🚫 Windows
👁️ browsers
🖊️ digital notebooks
🗄️ DNS
Domain Name System
 🗨️ instant messaging (im)
🇦🇶 translations
Anything covering a translated version of the site
No labels
Milestone
No items
No Milestone
Assignees
Clear assignees
jonah
No Assignees
1 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: privacyguides/privacytools.io#1530