dns: cleanup legacy parts #1372

2019-10-02T15:10:12Z

Mikaela commented

2019-10-02 15:10:12 +00:00

(Migrated from github.com)

https://deploy-preview-1372--privacytools-io.netlify.com/providers/dns/

netlify[bot] commented

2019-10-02 15:10:54 +00:00

(Migrated from github.com)

Deploy preview for privacytools-io ready!

Built with commit 087101b01a

https://deploy-preview-1372--privacytools-io.netlify.com

Deploy preview for *privacytools-io* ready! Built with commit 087101b01a124743e23f666ca36bd15e1118fd3d https://deploy-preview-1372--privacytools-io.netlify.com

Mikaela (Migrated from github.com) reviewed 2019-10-02 15:13:04 +00:00

_includes/sections/dns.html

Mikaela (Migrated from github.com) commented

2019-10-02 15:11:06 +00:00

Listed in https://www.privacytools.io/providers/hosting/#host

Mikaela (Migrated from github.com) commented

2019-10-02 15:12:08 +00:00

I think there is no point in specifying ICANN since the removal of OpenDNS, but I want to leave the anchor as it's linked from elsewhere.

_includes/sections/dns.html

Mikaela (Migrated from github.com) commented

2019-10-02 15:11:31 +00:00

Listed below with all the other clients

_includes/sections/dns.html

Mikaela (Migrated from github.com) commented

2019-10-02 15:12:40 +00:00

I think there is no point in specifying ICANN since the removal of OpenDNS.

_includes/sections/dns.html

Mikaela (Migrated from github.com) commented

2019-10-02 15:12:56 +00:00

I don't think worth mentioning really works here anymore.

Mikaela commented

2019-10-02 15:16:29 +00:00

(Migrated from github.com)

Help wanted on handling this without breaking the anchors

Help wanted on handling this without breaking the anchors ![kuva](https://user-images.githubusercontent.com/831184/66057023-b17df380-e540-11e9-8f69-24fc8fd5756d.png)

Mikaela commented

2019-10-15 21:57:24 +00:00

(Migrated from github.com)

Solution: just removing the icanndns anchor as it's going to be top section of https://deploy-preview-1372--privacytools-io.netlify.com/providers/dns/ anyway!

Mikaela (Migrated from github.com) reviewed 2019-10-18 08:49:16 +00:00

_includes/sections/dns.html

Mikaela (Migrated from github.com) commented

2019-10-18 08:49:16 +00:00

Minor inconsistency with capitalization on line 573/545

I guess I should make the S capital letter

> Minor inconsistency with capitalization on line 573/545 I guess I should make the S capital letter

jonah requested changes 2019-10-22 06:22:57 +00:00

_includes/sections/dns.html

jonah commented

2019-10-22 06:22:53 +00:00

I don't think we can remove this without changing the name of this page ("DNS / Domain Providers"). Maybe just to "DNS Resolvers" instead since that seems to be the focus now?

Mikaela commented

2019-11-04 12:04:15 +00:00

(Migrated from github.com)

Sorry @JonahAragon , I had forgotten this.

Also merge conflict fixed.

Sorry @JonahAragon , I had forgotten this. Also merge conflict fixed.

nitrohorse (Migrated from github.com) approved these changes 2019-11-04 18:52:29 +00:00

Mikaela commented

2019-11-14 20:09:29 +00:00

(Migrated from github.com)

@JonahAragon I think this has been waiting for your rereview for 10 days? @privacytoolsIO/editorial How about you?

jonah approved these changes 2019-11-25 22:09:26 +00:00

This repo is archived. You cannot comment on pull requests.

No Reviewers

jonah

Mikaela

nitrohorse

1 Participants

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: privacyguides/privacytools.io#1372