Add Resolve-DnsName to QNAME Minimization under DNS validation section #1234

2019-08-28T20:04:56Z

Strappazzon commented

2019-08-28 20:04:56 +00:00

(Migrated from github.com)

Description

dig on Windows doesn't exist so I added Resolve-DnsName.

Check List

I have read and understand the contributing guidelines.

Netlify preview for the mainly edited page: https://deploy-preview-1234--privacytools-io.netlify.com/providers/dns/

## Description `dig` on Windows doesn't exist so I added [`Resolve-DnsName`](https://docs.microsoft.com/en-us/powershell/module/dnsclient/resolve-dnsname?view=win10-ps). #### Check List - [x] I have read and understand [the contributing guidelines](https://github.com/privacytoolsIO/privacytools.io/blob/master/.github/CONTRIBUTING.md). * Netlify preview for the mainly edited page: https://deploy-preview-1234--privacytools-io.netlify.com/providers/dns/

👍 1

privacytoolsIO (Migrated from github.com) reviewed 2019-08-28 20:04:56 +00:00

netlify[bot] commented

2019-08-28 20:05:35 +00:00

(Migrated from github.com)

Deploy preview for privacytools-io ready!

Built with commit 5f2a2a176c

https://deploy-preview-1234--privacytools-io.netlify.com

Deploy preview for *privacytools-io* ready! Built with commit 5f2a2a176c7f2e3d5058fb2b2b7be0368cddab98 https://deploy-preview-1234--privacytools-io.netlify.com

Mikaela (Migrated from github.com) requested changes 2019-08-28 22:41:39 +00:00

Mikaela (Migrated from github.com) left a comment

Thanks, two comments however:

I think the link makes it a bit more difficult to see that Resolve-DnsName is part of the command, but this isn't a blocker for me as it still has monospacing
Would you mind updating also the two other instances where dig is mentioned?
- https://github.com/privacytoolsIO/privacytools.io/blob/master/.github/CONTRIBUTING.md#dns
- https://github.com/privacytoolsIO/privacytools.io/blob/master/.github/ISSUE_TEMPLATE/7_DNS_provider.md (a HTML comment so invisible in the preview)

Thanks, two comments however: * I think the link makes it a bit more difficult to see that Resolve-DnsName is part of the command, but this isn't a blocker for me as it still has monospacing * Would you mind updating also the two other instances where `dig` is mentioned? * https://github.com/privacytoolsIO/privacytools.io/blob/master/.github/CONTRIBUTING.md#dns * https://github.com/privacytoolsIO/privacytools.io/blob/master/.github/ISSUE_TEMPLATE/7_DNS_provider.md (a HTML comment so invisible in the preview)

nitrohorse commented

2019-08-29 06:54:48 +00:00

(Migrated from github.com)

I think the link makes it a bit more difficult to see that Resolve-DnsName is part of the command, but this isn't a blocker for me as it still has monospacing...

Yeah, I wonder if we should just remove the hyperlinks from dig and Resolve-DnsName? I suspect users would research themselves more about these commands if they run into issues?

> I think the link makes it a bit more difficult to see that Resolve-DnsName is part of the command, but this isn't a blocker for me as it still has monospacing... Yeah, I wonder if we should just remove the hyperlinks from `dig` and `Resolve-DnsName`? I suspect users would research themselves more about these commands if they run into issues?

👍 2

Strappazzon commented

2019-08-29 10:49:37 +00:00

(Migrated from github.com)

Would you mind updating also the two other instances where dig is mentioned?

https://github.com/privacytoolsIO/privacytools.io/blob/master/.github/CONTRIBUTING.md#dns

https://github.com/privacytoolsIO/privacytools.io/blob/master/.github/ISSUE_TEMPLATE/7_DNS_provider.md (a HTML comment so invisible in the preview)

I made the requested changes.

Yeah, I wonder if we should just remove the hyperlinks from dig and Resolve-DnsName? I suspect users would research themselves more about these commands if they run into issues?

I agree, I removed both links.

> * Would you mind updating also the two other instances where `dig` is mentioned? > * https://github.com/privacytoolsIO/privacytools.io/blob/master/.github/CONTRIBUTING.md#dns > * https://github.com/privacytoolsIO/privacytools.io/blob/master/.github/ISSUE_TEMPLATE/7_DNS_provider.md (a HTML comment so invisible in the preview) I made the requested changes. > Yeah, I wonder if we should just remove the hyperlinks from `dig` and `Resolve-DnsName`? I suspect users would research themselves more about these commands if they run into issues? I agree, I removed both links.

👍 1

Mikaela (Migrated from github.com) reviewed 2019-08-29 12:31:29 +00:00

Mikaela (Migrated from github.com) left a comment

Thanks :)

nitrohorse (Migrated from github.com) reviewed 2019-08-29 14:50:40 +00:00

nitrohorse (Migrated from github.com) left a comment

LGTM 👍🏼