privacyguides/privacytools.io
Archived
1
0
Fork 0
Code Issues 304 Pull Requests 47 Activity

Make JavaScript work with LibreJS #1213

Merged
dawidpotocki merged 1 commits from librejs into master 2019-08-25 04:01:50 +00:00
Conversation 12 Commits 1 Files Changed 4 +62 -23
dawidpotocki commented 2019-08-24 17:10:02 +00:00 (Migrated from github.com)
Copy Link
  • Works. LibreJS is happy.
- [x] Works. LibreJS is happy.
Vincevrp (Migrated from github.com) reviewed 2019-08-24 17:10:02 +00:00
netlify[bot] commented 2019-08-24 17:10:57 +00:00 (Migrated from github.com)
Copy Link

Deploy preview for privacytools-io ready!

Built with commit 2a478ded0f

https://deploy-preview-1213--privacytools-io.netlify.com

Deploy preview for *privacytools-io* ready! Built with commit 2a478ded0ffab00899a0b3b6516143d57720ee73 https://deploy-preview-1213--privacytools-io.netlify.com
nitrohorse (Migrated from github.com) reviewed 2019-08-24 17:27:21 +00:00
assets/js/main.js
@ -34,0 +44,4 @@
g.defer = true;
g.src = u + "matomo.js";
s.parentNode.insertBefore(g, s);
})();
nitrohorse (Migrated from github.com) commented 2019-08-24 17:27:21 +00:00

Doesn't matter too much but could we make this a bit more readable?

// Matomo
var _paq = window._paq || [];
// tracker methods like "setCustomDimension" should be called before "trackPageView"
_paq.push(['trackPageView']);
_paq.push(['enableLinkTracking']);
(function() {
  var u = 'https://stats.privacytools.io/';
  _paq.push(['setTrackerUrl', u + 'matomo.php']);
  _paq.push(['setSiteId', '1']);
  var d = document;
  var g = d.createElement('script');
  var s = d.getElementsByTagName('script')[0];
  g.type = 'text/javascript';
  g.async = true;
  g.defer = true;
  g.src = u + 'matomo.js';
  s.parentNode.insertBefore(g, s);
})();
Doesn't matter too much but could we make this a bit more readable? ```javascript // Matomo var _paq = window._paq || []; // tracker methods like "setCustomDimension" should be called before "trackPageView" _paq.push(['trackPageView']); _paq.push(['enableLinkTracking']); (function() { var u = 'https://stats.privacytools.io/'; _paq.push(['setTrackerUrl', u + 'matomo.php']); _paq.push(['setSiteId', '1']); var d = document; var g = d.createElement('script'); var s = d.getElementsByTagName('script')[0]; g.type = 'text/javascript'; g.async = true; g.defer = true; g.src = u + 'matomo.js'; s.parentNode.insertBefore(g, s); })(); ```
nitrohorse (Migrated from github.com) reviewed 2019-08-24 17:30:49 +00:00
_includes/footer.html
@ -77,0 +77,4 @@
</a>
<p class="mt-2">
<strong>No Ads, No Google Analytics, No Affiliates, No Cross-Site Requests.</strong>
<em>privacytools.io is a socially motivated website that provides information for protecting your data security and privacy. Never trust any company with your privacy, always encrypt.</em>
nitrohorse (Migrated from github.com) commented 2019-08-24 17:30:49 +00:00

Could we add a slight space here? <br />

Could we add a slight space here? `<br />`
nitrohorse (Migrated from github.com) reviewed 2019-08-24 17:31:21 +00:00
about/javascript/index.html
nitrohorse (Migrated from github.com) commented 2019-08-24 17:31:21 +00:00

I'm thinking for the creativecommons links we could use https://

I'm thinking for the creativecommons links we could use `https://`
nitrohorse commented 2019-08-24 17:31:46 +00:00 (Migrated from github.com)
Copy Link

Super cool!

Super cool!
nitrohorse (Migrated from github.com) reviewed 2019-08-24 17:47:59 +00:00
nitrohorse (Migrated from github.com) left a comment

LGTM!

LGTM!
nitrohorse (Migrated from github.com) approved these changes 2019-08-24 19:00:29 +00:00
nitrohorse (Migrated from github.com) left a comment

LGTM

LGTM
Mikaela (Migrated from github.com) approved these changes 2019-08-24 20:33:14 +00:00
Mikaela (Migrated from github.com) left a comment

LGTM, I guess, but I would like to have @JonahAragon to check it

LGTM, I guess, but I would like to have @JonahAragon to check it
jonah approved these changes 2019-08-25 03:44:49 +00:00
jonah left a comment

Uhh... YOLO, right? I don't see why this shouldn't work.

Uhh... YOLO, right? I don't see why this shouldn't work.
jonah commented 2019-08-25 03:46:14 +00:00
Copy Link

Have you removed all the inline JS in this PR? We could probably update the CSP too.

Have you removed all the inline JS in this PR? We could probably update [the CSP](https://github.com/privacytoolsIO/privacytools.io/blob/master/nginx/010-headers.conf#L4) too.
dawidpotocki commented 2019-08-25 03:52:26 +00:00 (Migrated from github.com)
Copy Link

Have you removed all the inline JS in this PR? We could probably update the CSP too.

Well… I only found this in scripts.html and LibreJS does not inform me
about other stuff. So probably, yes.

> Have you removed all the inline JS in this PR? We could probably update [the CSP](https://github.com/privacytoolsIO/privacytools.io/blob/master/nginx/010-headers.conf#L4) too. Well… I only found this in `scripts.html` and LibreJS does not inform me about other stuff. So probably, yes.
This repo is archived. You cannot comment on pull requests.
Reviewers
No Reviewers
jonah
Vincevrp
nitrohorse
Mikaela
Labels
Clear labels
🔍🤖 Search Engines
approved
approved, waiting for a PR
dependencies
Pull requests that update a dependency file
duplicate
feedback wanted
high priority
I2P
The Invisible Internet Project (I2P)
iOS
low priority
OS
Operating Systems
Self-contained networks
Social media
stale
A label for stalebot if it gets added
streaming
Anything related to media streaming.
todo
Tor
Anything covering the Tor network
WIP
active work in progress, do not merge or PR (yet)!
wontfix
Issues or bugs that will not be fixed and/or do not have significant impact on the project.
XMPP
Extensible Messaging and Presence Protocol
[m]
Matrix protocol
₿ cryptocurrency
ℹ️ help wanted
↔️ file sharing
⚙️ web extensions
Browser Extension related issues
✨ enhancement
❌ software removal
💬 discussion
🤖 Android
🐛 bug
💢 conflicting
📝 correction
Correction of content on the website
🆘 critical
📧 email
🔒 file encryption
📁 file storage
🦊 Firefox
Firefox & forks, about:config etc.
💻 hardware
🌐 hosting
🏠 housekeeping
Anything primarily related to site cleanup.
🔐 password managers
🧰 productivity tools
🔎 research required
🌐 Social News Aggregators
🆕 software suggestion
👥 team chat
🔒 VPN
Virtual Private Network
🌐 website issue
*Technical* issues with the website.
🚫 Windows
👁️ browsers
🖊️ digital notebooks
🗄️ DNS
Domain Name System
🗨️ instant messaging (im)
🇦🇶 translations
Anything covering a translated version of the site
No Label
🏠 housekeeping
Milestone
No items
No Milestone
Assignees
Clear assignees
jonah
No Assignees
1 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: privacyguides/privacytools.io#1213
No description provided.
Delete Branch "librejs"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?