privacyguides/privacytools.io
Archived
1
0
Fork 0
Code Issues 304 Pull Requests 47 Activity

Real time communication improvements #1147

Merged
Mikaela merged 19 commits from rtc-improvements into master 2019-08-17 02:33:33 +00:00
Conversation 23 Commits 19 Files Changed 5 +47 -62
Mikaela commented 2019-08-12 09:35:05 +00:00 (Migrated from github.com)
Copy Link

Resolves: #1137

  • Remove duplicate Signal & Wire (which also fixes Wire VoIP warning being wrong)
  • Move Tox and Jami to instant messengers
  • Change Jitsi to Jitsi Meet
  • List Mumble

Resolves: #967

  • Remove Signal Desktop platforms as Android/iOS is required.

References: #1071

List security audits for:

  • Signal
  • Wire
  • Keybase

Preview: https://deploy-preview-1147--privacytools-io.netlify.com/software/real-time-communication/

Resolves: #1137 * [x] Remove duplicate Signal & Wire (which also fixes Wire VoIP warning being wrong) * [x] Move Tox and Jami to instant messengers * [x] Change Jitsi to Jitsi Meet * [x] List Mumble Resolves: #967 * [x] Remove Signal Desktop platforms as Android/iOS is required. References: #1071 List security audits for: * [x] Signal * [x] Wire * [x] Keybase Preview: https://deploy-preview-1147--privacytools-io.netlify.com/software/real-time-communication/
blacklight447 (Migrated from github.com) reviewed 2019-08-12 09:35:05 +00:00
netlify[bot] commented 2019-08-12 09:35:43 +00:00 (Migrated from github.com)
Copy Link

Deploy preview for privacytools-io ready!

Built with commit 9235f50abc

https://deploy-preview-1147--privacytools-io.netlify.com

Deploy preview for *privacytools-io* ready! Built with commit 9235f50abc63dd22e82e3187f8a52281bd10200d https://deploy-preview-1147--privacytools-io.netlify.com
Mikaela (Migrated from github.com) reviewed 2019-08-12 10:41:18 +00:00
Mikaela (Migrated from github.com) left a comment

My usual commentary

My usual commentary
_includes/sections/instant-messenger.html
Mikaela (Migrated from github.com) commented 2019-08-12 10:33:51 +00:00

See #967

See #967
_includes/sections/instant-messenger.html
Mikaela (Migrated from github.com) commented 2019-08-12 10:35:03 +00:00

I copied this style from XMPP again.

I copied this style from XMPP again.
_includes/sections/instant-messenger.html
Mikaela (Migrated from github.com) commented 2019-08-12 10:35:18 +00:00

This is the same order we list them in on the page.

This is the same order we list them in on the page.
_includes/sections/voice-video-messenger.html
Mikaela (Migrated from github.com) commented 2019-08-12 10:35:46 +00:00

I try to address the concern of many being already listed and now this section has only less known software.

I try to address the concern of many being already listed and now this section has only less known software.
_includes/sections/voice-video-messenger.html
Mikaela (Migrated from github.com) commented 2019-08-12 10:38:17 +00:00

See also the related information section

See also the related information section
Mikaela (Migrated from github.com) commented 2019-08-12 10:38:46 +00:00

I wonder if a warning on WebRTC being required should be here?

I wonder if a warning on WebRTC being required should be here?
_includes/sections/voice-video-messenger.html
Mikaela (Migrated from github.com) commented 2019-08-12 10:37:58 +00:00

I suggested it in #1137 and thus had to remove encrypted from the title. @nitrohorse OKed it, but I understand if you wish to remove it.

I think Mumble may be more beginner friendly than Linphone and currently the only other suggestion is Jitsi Meet, which requires WebRTC that many are going to have disabled thanks to the Firefox tweaks.

I suggested it in #1137 and thus had to remove encrypted from the title. @nitrohorse OKed it, but I understand if you wish to remove it. I think Mumble may be more beginner friendly than Linphone and currently the only other suggestion is Jitsi Meet, which requires WebRTC that many are going to have disabled thanks to the Firefox tweaks.
_includes/sections/voice-video-messenger.html
Mikaela (Migrated from github.com) commented 2019-08-12 10:40:11 +00:00

I think this may make Mumble more privacy friendly than Jitsi Meet, presuming logging is disabled. Tor Browser disables WebRTC, doesn't it?

I think this may make Mumble more privacy friendly than Jitsi Meet, presuming logging is disabled. Tor Browser disables WebRTC, doesn't it?
source_code.md
@ -137,1 +138,4 @@
Ring/Jami: https://git.jami.net/savoirfairelinux
## Team chat
Mikaela (Migrated from github.com) commented 2019-08-12 10:40:50 +00:00

I corrected the source code location for Jami. Otherwise I just moved things around.

I corrected the source code location for Jami. Otherwise I just moved things around.
Mikaela commented 2019-08-12 11:23:31 +00:00 (Migrated from github.com)
Copy Link

Would there be any point in listing Signal desktop separately and saying that it needs to be linked to Signal mobile?

Would there be any point in listing Signal desktop separately and saying that it needs to be linked to Signal mobile?
jonah requested changes 2019-08-13 01:45:01 +00:00
jonah left a comment

Made some changes at https://github.com/Mikaela/privacytools.io/pull/1 I'd like to see included, otherwise LGTM.

I also can't decide if we should include a Supports VoIP badge on the Instant Messengers that support VoIP, because we removed them from the Voice section. I just want it to be clear that Signal/Wire also support Voice. But maybe the warning listed is enough. I'm very on the fence about it. If we do want to add a badge like that though, I need the cardv2.html changes I made in #1148 to be merged first.

Made some changes at https://github.com/Mikaela/privacytools.io/pull/1 I'd like to see included, otherwise LGTM. I also can't decide if we should include a `Supports VoIP` badge on the Instant Messengers that support VoIP, because we removed them from the Voice section. I just want it to be clear that Signal/Wire also support Voice. But maybe the warning listed is enough. I'm very on the fence about it. If we do want to add a badge like that though, I need the cardv2.html changes I made in #1148 to be merged first.
nitrohorse (Migrated from github.com) reviewed 2019-08-13 06:04:26 +00:00
_includes/sections/instant-messenger.html
nitrohorse (Migrated from github.com) commented 2019-08-13 06:04:26 +00:00

Minor typo: Independent

Minor typo: `Independent`
nitrohorse (Migrated from github.com) reviewed 2019-08-13 06:08:10 +00:00
_includes/sections/voice-video-messenger.html
nitrohorse (Migrated from github.com) commented 2019-08-13 06:08:10 +00:00

Yeah, just validated myself and it's disabled in about:config.

Yeah, just validated myself and it's disabled in `about:config`.
nitrohorse (Migrated from github.com) reviewed 2019-08-13 06:09:01 +00:00
_includes/sections/instant-messenger.html
@ -55,3 +54,3 @@
<li><a href="https://gajim.org/">Gajim</a> (FreeBSD, Linux, Windows) - An open source fully featured XMPP client. <span class="badge badge-success">OMEMO</span></li>
<li><a href="https://monal.im/">Monal</a> (iOS, MacOS) - An XMPP client in active development. <span class="badge badge-success">OMEMO</span></li>
<li><a href="https://monal.im/">Monal</a> (iOS, MacOS) - An XMPP client in active development. <span class="badge badge-success">OMEMO</span> <span class="badge badge-success">VoIP</span></li>
<li><a href="https://omemo.top/">Other OMEMO ready clients</a>.</li>
nitrohorse (Migrated from github.com) commented 2019-08-13 06:09:01 +00:00

Minor suggestion; remove "a": Gives you full control...

Minor suggestion; remove "a": `Gives you full control...`
nitrohorse (Migrated from github.com) reviewed 2019-08-13 06:10:12 +00:00
_includes/sections/voice-video-messenger.html
nitrohorse (Migrated from github.com) commented 2019-08-13 06:10:12 +00:00

Small suggestion: add "the"; in the instant

Small suggestion: add "the"; `in the instant`
nitrohorse (Migrated from github.com) reviewed 2019-08-13 06:11:34 +00:00
_includes/sections/voice-video-messenger.html
nitrohorse (Migrated from github.com) commented 2019-08-13 06:11:34 +00:00

I would say so since we encourage it's disablement: https://www.privacytools.io/browsers/#webrtc

I would say so since we encourage it's disablement: https://www.privacytools.io/browsers/#webrtc
nitrohorse commented 2019-08-13 06:16:53 +00:00 (Migrated from github.com)
Copy Link

I also can't decide if we should include a Supports VoIP badge on the Instant Messengers that support VoIP, because we removed them from the Voice section. I just want it to be clear that Signal/Wire also support Voice. But maybe the warning listed is enough. I'm very on the fence about it.

Looking it over I think adding a badge would be a good idea. The callout in the warning alert is kind of easy to miss.

Otherwise, LGTM too!

> I also can't decide if we should include a `Supports VoIP` badge on the Instant Messengers that support VoIP, because we removed them from the Voice section. I just want it to be clear that Signal/Wire also support Voice. But maybe the warning listed is enough. I'm very on the fence about it. Looking it over I think adding a badge would be a good idea. The callout in the warning alert is kind of easy to miss. Otherwise, LGTM too!
nitrohorse (Migrated from github.com) reviewed 2019-08-13 06:17:29 +00:00
nitrohorse (Migrated from github.com) left a comment

LGTM once comments are resolved 👍

LGTM once comments are resolved :+1:
Mikaela (Migrated from github.com) reviewed 2019-08-13 08:16:30 +00:00
_includes/sections/voice-video-messenger.html
Mikaela (Migrated from github.com) commented 2019-08-13 08:16:30 +00:00

I think this became obsolete.

I think this became obsolete.
Mikaela commented 2019-08-13 08:20:03 +00:00 (Migrated from github.com)
Copy Link

So I just need to warn about WebRTC and Minor suggestion; remove "a": Gives you full control...?

Do I need to somehow add the supports VoIP label or will @JonahAragon do that later?

So I just need to warn about WebRTC and *Minor suggestion; remove "a": Gives you full control...*? Do I need to somehow add the supports VoIP label or will @JonahAragon do that later?
Mikaela commented 2019-08-13 11:34:17 +00:00 (Migrated from github.com)
Copy Link

@JonahAragon @nitrohorse How about this?

@JonahAragon @nitrohorse How about this?
Mikaela commented 2019-08-13 11:35:55 +00:00 (Migrated from github.com)
Copy Link

image

I am going to cancel that last commit though as I think it looks better with the space.

![image](https://user-images.githubusercontent.com/831184/62938367-740dad00-bdbe-11e9-84f5-4dda35fb375b.png) I am going to cancel that last commit though as I think it looks better with the space.
jonah approved these changes 2019-08-13 17:31:01 +00:00
jonah requested changes 2019-08-13 17:57:07 +00:00
jonah left a comment

K last change: Since #1148 was merged the changes I pushed to Mikaela#2 make more sense for the VoIP and other badges.

K last change: Since #1148 was merged the changes I pushed to Mikaela#2 make more sense for the VoIP and other badges.
Mikaela (Migrated from github.com) reviewed 2019-08-13 19:30:01 +00:00
_includes/sections/voice-video-messenger.html
Mikaela (Migrated from github.com) commented 2019-08-13 19:30:00 +00:00

@JonahAragon Did you remove the warning label?

@JonahAragon Did you remove the warning label?
Mikaela (Migrated from github.com) reviewed 2019-08-13 19:38:29 +00:00
_includes/sections/voice-video-messenger.html
Mikaela (Migrated from github.com) commented 2019-08-13 19:38:28 +00:00

No, looking better the warning is there, but it's not visible on live site. I don't know when I can look at it better to fix it.

I will grant permissions to write in my fork in case it helps.

No, looking better the warning is there, but it's not visible on live site. I don't know when I can look at it better to fix it. I will grant permissions to write in my fork in case it helps.
jonah reviewed 2019-08-13 21:17:06 +00:00
_includes/sections/voice-video-messenger.html
jonah commented 2019-08-13 21:17:06 +00:00

I don't think I made any changes here. The issue is the backslashes, not sure where those are from.

  <li><a href="https://jitsi.org/">Jitsi Meet</a> - Jitsi Meet is a free and open source multiplatform voice (VoIP), videoconferencing and instant messaging application. <span class="badge badge-warning" data-toggle="tooltip" title="Our Firefox tweaks recommend disabling WebRTC as it can be used to leak your IP address even behind a VPN, which is why Tor Browser disables it.">Requires WebRTC</span></li>
I don't think I made any changes here. The issue is the backslashes, not sure where those are from. ```suggestion <li><a href="https://jitsi.org/">Jitsi Meet</a> - Jitsi Meet is a free and open source multiplatform voice (VoIP), videoconferencing and instant messaging application. <span class="badge badge-warning" data-toggle="tooltip" title="Our Firefox tweaks recommend disabling WebRTC as it can be used to leak your IP address even behind a VPN, which is why Tor Browser disables it.">Requires WebRTC</span></li> ```
jonah reviewed 2019-08-13 21:19:05 +00:00
nitrohorse (Migrated from github.com) reviewed 2019-08-14 16:11:22 +00:00
nitrohorse (Migrated from github.com) left a comment

👍🏼

👍🏼
This repo is archived. You cannot comment on pull requests.
Reviewers
No Reviewers
jonah
blacklight447
Labels
Clear labels
🔍🤖 Search Engines
approved
approved, waiting for a PR
dependencies
Pull requests that update a dependency file
duplicate
feedback wanted
high priority
I2P
The Invisible Internet Project (I2P)
iOS
low priority
OS
Operating Systems
Self-contained networks
Social media
stale
A label for stalebot if it gets added
streaming
Anything related to media streaming.
todo
Tor
Anything covering the Tor network
WIP
active work in progress, do not merge or PR (yet)!
wontfix
Issues or bugs that will not be fixed and/or do not have significant impact on the project.
XMPP
Extensible Messaging and Presence Protocol
[m]
Matrix protocol
₿ cryptocurrency
ℹ️ help wanted
↔️ file sharing
⚙️ web extensions
Browser Extension related issues
✨ enhancement
❌ software removal
💬 discussion
🤖 Android
🐛 bug
💢 conflicting
📝 correction
Correction of content on the website
🆘 critical
📧 email
🔒 file encryption
📁 file storage
🦊 Firefox
Firefox & forks, about:config etc.
💻 hardware
🌐 hosting
🏠 housekeeping
Anything primarily related to site cleanup.
🔐 password managers
🧰 productivity tools
🔎 research required
🌐 Social News Aggregators
🆕 software suggestion
👥 team chat
🔒 VPN
Virtual Private Network
🌐 website issue
*Technical* issues with the website.
🚫 Windows
👁️ browsers
🖊️ digital notebooks
🗄️ DNS
Domain Name System
🗨️ instant messaging (im)
🇦🇶 translations
Anything covering a translated version of the site
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
jonah
No Assignees
1 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: privacyguides/privacytools.io#1147
No description provided.
Delete Branch "rtc-improvements"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?