privacyguides/privacytools.io
Archived
1
0
Fork 0
Code Issues 304 Pull Requests 47 Activity

Update Email column sorting #1143

Merged
nitrohorse merged 3 commits from 1140 into master 2019-08-14 15:29:24 +00:00
Conversation 8 Commits 3 Files Changed 1 +139 -139
nitrohorse commented 2019-08-12 05:42:28 +00:00 (Migrated from github.com)
Copy Link

Description

Addresses some Email Providers table sorting issues:

  • Because the Email (name) column header has data-sorted="true", we need to have all the providers already in alphabetical order because we're telling the table, 'hey, you're sorted alphabetically already' 😄
  • Soverin had a value of "1" for the Encryption cell value -- corrected to "0"
  • Updated all the data-value for each provider's price cell to 4 digits to account for cents.

Resolves: https://github.com/privacytoolsIO/privacytools.io/issues/1140

Check List

Code Repository (if applicable): N/A

<!-- PLEASE READ OUR [CONTRIBUTING GUIDELINES](https://github.com/privacytoolsIO/privacytools.io/blob/master/.github/CONTRIBUTING.md) BEFORE SUBMITTING --> ## Description Addresses some Email Providers table sorting issues: - Because the Email (name) column header has `data-sorted="true"`, we need to have all the providers already in alphabetical order because we're telling the table, 'hey, you're sorted alphabetically already' :smile: - Soverin had a value of "1" for the Encryption cell value -- corrected to "0" - Updated all the data-value for each provider's price cell to 4 digits to account for cents. Resolves: https://github.com/privacytoolsIO/privacytools.io/issues/1140 #### Check List <!-- Please add an x in each box below, like so: [x] --> - [x] I have read and understand [CONTRIBUTING.md](https://github.com/privacytoolsIO/privacytools.io/blob/master/.github/CONTRIBUTING.md). - ~~[] I have listed the source code for this project in [source_code.md](https://github.com/privacytoolsIO/privacytools.io/blob/master/source_code.md).~~ - ~~[ ] This project is [free/libre software](https://www.wikipedia.org/wiki/Free_software).~~ - ~~[ ] This project has an [associated discussion](https://github.com/privacytoolsIO/privacytools.io/issues).~~ Code Repository (if applicable): N/A
netlify[bot] commented 2019-08-12 05:43:10 +00:00 (Migrated from github.com)
Copy Link

Deploy preview for privacytools-io ready!

Built with commit d906b095c2

https://deploy-preview-1143--privacytools-io.netlify.com

Deploy preview for *privacytools-io* ready! Built with commit d906b095c2b6369c995398a8c69f1efefcdf1aaa https://deploy-preview-1143--privacytools-io.netlify.com
jonah reviewed 2019-08-12 05:45:18 +00:00
Mikaela (Migrated from github.com) reviewed 2019-08-13 11:43:59 +00:00
Mikaela (Migrated from github.com) left a comment

If I understand correctly that you are putting these in alphabetical order, the end is wrong.

Your list: Runbox Tutanota Soverin Startmail

Alphabetical order: Runbox Soverin Startmail Tutanota

If I understand correctly that you are putting these in alphabetical order, the end is wrong. Your list: Runbox *Tutanota* Soverin Startmail Alphabetical order: Runbox Soverin Startmail *Tutanota*
Mikaela commented 2019-08-13 11:47:20 +00:00 (Migrated from github.com)
Copy Link

I am also wondering how you assign the numbers? Are you converting EUR to USD?

I am also wondering how you assign the numbers? Are you converting EUR to USD?
nitrohorse commented 2019-08-14 03:02:25 +00:00 (Migrated from github.com)
Copy Link

I am also wondering how you assign the numbers? Are you converting EUR to USD?

Yeah, you think that's ok?

> I am also wondering how you assign the numbers? Are you converting EUR to USD? Yeah, you think that's ok?
jonah approved these changes 2019-08-14 06:10:14 +00:00
blacklight447 (Migrated from github.com) approved these changes 2019-08-14 15:19:22 +00:00
blacklight447 (Migrated from github.com) left a comment

looks alright!

looks alright!
Mikaela commented 2019-08-16 17:06:04 +00:00 (Migrated from github.com)
Copy Link

I am also wondering how you assign the numbers? Are you converting EUR to USD?

Yeah, you think that's ok?

Sure as long as it's known, I would probably add a comment to explain it.

>> I am also wondering how you assign the numbers? Are you converting EUR to USD? > Yeah, you think that's ok? Sure as long as it's known, I would probably add a comment to explain it.
This repo is archived. You cannot comment on pull requests.
Reviewers
No Reviewers
jonah
blacklight447
Labels
Clear labels
🔍🤖 Search Engines
approved
approved, waiting for a PR
dependencies
Pull requests that update a dependency file
duplicate
feedback wanted
high priority
I2P
The Invisible Internet Project (I2P)
iOS
low priority
OS
Operating Systems
Self-contained networks
Social media
stale
A label for stalebot if it gets added
streaming
Anything related to media streaming.
todo
Tor
Anything covering the Tor network
WIP
active work in progress, do not merge or PR (yet)!
wontfix
Issues or bugs that will not be fixed and/or do not have significant impact on the project.
XMPP
Extensible Messaging and Presence Protocol
[m]
Matrix protocol
₿ cryptocurrency
ℹ️ help wanted
↔️ file sharing
⚙️ web extensions
Browser Extension related issues
✨ enhancement
❌ software removal
💬 discussion
🤖 Android
🐛 bug
💢 conflicting
📝 correction
Correction of content on the website
🆘 critical
📧 email
🔒 file encryption
📁 file storage
🦊 Firefox
Firefox & forks, about:config etc.
💻 hardware
🌐 hosting
🏠 housekeeping
Anything primarily related to site cleanup.
🔐 password managers
🧰 productivity tools
🔎 research required
🌐 Social News Aggregators
🆕 software suggestion
👥 team chat
🔒 VPN
Virtual Private Network
🌐 website issue
*Technical* issues with the website.
🚫 Windows
👁️ browsers
🖊️ digital notebooks
🗄️ DNS
Domain Name System
🗨️ instant messaging (im)
🇦🇶 translations
Anything covering a translated version of the site
No Label
📧 email
🌐 website issue
Milestone
No items
No Milestone
Assignees
Clear assignees
jonah
No Assignees
1 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: privacyguides/privacytools.io#1143
No description provided.
Delete Branch "1140"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?