privacyguides/privacytools.io
Archived
1
0
Fork 0
Code Issues 304 Pull Requests 47 Activity

Add CryptPad to Paste Services #1115

Merged
kryptish merged 7 commits from patch-1 into master 2019-08-10 03:00:30 +00:00
Conversation 18 Commits 7 Files Changed 2 +13 -1
kryptish commented 2019-08-08 10:16:48 +00:00 (Migrated from github.com)
Copy Link

Adds CryptPad to paste services section.

Adds CryptPad to paste services section.
Mikaela (Migrated from github.com) reviewed 2019-08-08 10:16:48 +00:00
netlify[bot] commented 2019-08-08 10:17:36 +00:00 (Migrated from github.com)
Copy Link

Deploy preview for privacytools-io ready!

Built with commit 579d52e0e4

https://deploy-preview-1115--privacytools-io.netlify.com

Deploy preview for *privacytools-io* ready! Built with commit 579d52e0e4904f8ea16dd04a82f6afdae93736ab https://deploy-preview-1115--privacytools-io.netlify.com
nitrohorse commented 2019-08-08 16:38:35 +00:00 (Migrated from github.com)
Copy Link

Hey @kryptish, thanks for submitting the PR! We usually look for an associated discussion as a pre-requisite; would you be able to create a “software suggestion” Issue to capture any discussion related to CryptPad?

Hey @kryptish, thanks for submitting the PR! We usually look for an [associated discussion](https://github.com/privacytoolsIO/privacytools.io/issues) as a pre-requisite; would you be able to create a “software suggestion” Issue to capture any discussion related to CryptPad?
kryptish commented 2019-08-08 18:01:48 +00:00 (Migrated from github.com)
Copy Link

@nitrohorse done #1116

@nitrohorse done #1116
👍 2
nitrohorse (Migrated from github.com) reviewed 2019-08-09 20:12:16 +00:00
nitrohorse (Migrated from github.com) left a comment

LGTM

LGTM
nitrohorse (Migrated from github.com) reviewed 2019-08-09 20:13:12 +00:00
_includes/sections/paste-services.html
nitrohorse (Migrated from github.com) commented 2019-08-09 20:13:12 +00:00

Don’t we already have a PNG for CryptPad we could reference?

Don’t we already have a PNG for CryptPad we could reference?
blacklight447 (Migrated from github.com) reviewed 2019-08-09 20:18:02 +00:00
_includes/sections/paste-services.html
blacklight447 (Migrated from github.com) commented 2019-08-09 20:18:02 +00:00

im not sure, is it even the same logo?

im not sure, is it even the same logo?
nitrohorse (Migrated from github.com) reviewed 2019-08-09 21:15:16 +00:00
_includes/sections/paste-services.html
nitrohorse (Migrated from github.com) commented 2019-08-09 21:15:15 +00:00

Hmm, looks like it is (under Productivity Tools, assets/img/provider/CryptPad.png).

Hmm, looks like it is (under Productivity Tools, assets/img/provider/CryptPad.png).
nitrohorse (Migrated from github.com) reviewed 2019-08-09 21:15:53 +00:00
_includes/sections/paste-services.html
nitrohorse (Migrated from github.com) commented 2019-08-09 21:15:53 +00:00

Just not as high quality. But I don’t think we use base64 strings for logos.

Just not as high quality. But I don’t think we use base64 strings for logos.
blacklight447 (Migrated from github.com) reviewed 2019-08-09 21:18:53 +00:00
_includes/sections/paste-services.html
blacklight447 (Migrated from github.com) commented 2019-08-09 21:18:53 +00:00

in that case i would be fine with merging, we could always change the image later if we think its not sharp enough.

in that case i would be fine with merging, we could always change the image later if we think its not sharp enough.
blacklight447 (Migrated from github.com) reviewed 2019-08-09 21:20:32 +00:00
Mikaela (Migrated from github.com) reviewed 2019-08-09 21:23:25 +00:00
Mikaela (Migrated from github.com) left a comment

I will create a forum thread if no one else did it yet.

I will create a forum thread if no one else did it yet.
_includes/sections/paste-services.html
Mikaela (Migrated from github.com) commented 2019-08-09 21:22:59 +00:00

This needs to be done first.

This needs to be done first.
Mikaela (Migrated from github.com) reviewed 2019-08-09 21:26:11 +00:00
_includes/sections/paste-services.html
Mikaela (Migrated from github.com) commented 2019-08-09 21:26:10 +00:00 
forum="https://forum.privacytools.io/t/discussion-cryptpad/1270"
```suggestion forum="https://forum.privacytools.io/t/discussion-cryptpad/1270" ```
nitrohorse (Migrated from github.com) reviewed 2019-08-09 22:40:32 +00:00
_includes/sections/paste-services.html
nitrohorse (Migrated from github.com) commented 2019-08-09 22:40:32 +00:00

Hmm I think just that the string is so large, it clutters up the file a bit too much for my taste to easily work around for future changes. I can push an update later referencing the png.

Hmm I think just that the string is so large, it clutters up the file a bit too much for my taste to easily work around for future changes. I can push an update later referencing the png.
nitrohorse (Migrated from github.com) reviewed 2019-08-10 02:50:54 +00:00
_includes/sections/paste-services.html
nitrohorse (Migrated from github.com) commented 2019-08-10 02:50:54 +00:00

Updated.

Updated.
nitrohorse (Migrated from github.com) reviewed 2019-08-10 02:52:59 +00:00
nitrohorse (Migrated from github.com) left a comment

LGTM

LGTM
nitrohorse (Migrated from github.com) reviewed 2019-08-10 02:55:33 +00:00
_includes/sections/paste-services.html
nitrohorse (Migrated from github.com) commented 2019-08-10 02:55:33 +00:00

Added 👍 I tried to commit directly through the UI but apparently I "don't have permission to push to this repository" so making a new commit.

Added :+1: I tried to commit directly through the UI but apparently I "don't have permission to push to this repository" so making a new commit.
nitrohorse (Migrated from github.com) approved these changes 2019-08-10 03:00:20 +00:00
nitrohorse (Migrated from github.com) left a comment

LGTM

LGTM
This repo is archived. You cannot comment on pull requests.
Reviewers
No Reviewers
Mikaela
nitrohorse
Labels
Clear labels
🔍🤖 Search Engines
approved
approved, waiting for a PR
dependencies
Pull requests that update a dependency file
duplicate
feedback wanted
high priority
I2P
The Invisible Internet Project (I2P)
iOS
low priority
OS
Operating Systems
Self-contained networks
Social media
stale
A label for stalebot if it gets added
streaming
Anything related to media streaming.
todo
Tor
Anything covering the Tor network
WIP
active work in progress, do not merge or PR (yet)!
wontfix
Issues or bugs that will not be fixed and/or do not have significant impact on the project.
XMPP
Extensible Messaging and Presence Protocol
[m]
Matrix protocol
₿ cryptocurrency
ℹ️ help wanted
↔️ file sharing
⚙️ web extensions
Browser Extension related issues
✨ enhancement
❌ software removal
💬 discussion
🤖 Android
🐛 bug
💢 conflicting
📝 correction
Correction of content on the website
🆘 critical
📧 email
🔒 file encryption
📁 file storage
🦊 Firefox
Firefox & forks, about:config etc.
💻 hardware
🌐 hosting
🏠 housekeeping
Anything primarily related to site cleanup.
🔐 password managers
🧰 productivity tools
🔎 research required
🌐 Social News Aggregators
🆕 software suggestion
👥 team chat
🔒 VPN
Virtual Private Network
🌐 website issue
*Technical* issues with the website.
🚫 Windows
👁️ browsers
🖊️ digital notebooks
🗄️ DNS
Domain Name System
🗨️ instant messaging (im)
🇦🇶 translations
Anything covering a translated version of the site
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
jonah
No Assignees
1 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: privacyguides/privacytools.io#1115
No description provided.
Delete Branch "patch-1"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?