privacyguides/privacytools.io
Archived
1
0
Fork 0
Code Issues 304 Pull Requests 47 Activity

Highlight first columns in Email and VPN tables and consolidate column names #1079

Merged
nitrohorse merged 4 commits from highlight-first-cols-automatically into master 2019-08-03 22:17:15 +00:00
Conversation 4 Commits 4 Files Changed 2 +25 -6
nitrohorse commented 2019-08-02 02:41:10 +00:00 (Migrated from github.com)
Copy Link

Description

This PR increases the consistency between the Email and VPN provider tables. If these changes should be separated into additional PRs, please let me know 🤓

  1. Uses the same vocabulary, e.g. "Email/VPN Provider", for the first column.
  2. Highlights the first column to bring visibility to users that the columns are sortable.
  3. Uses the same vocabulary, e.g. "Yearly Price", for the yearly price column (rather than "Price / Year").
  4. Uses the same vocabulary, e.g. "Jurisdiction", for jurisdiction column (rather than "Server").
  5. Added "Since" column to VPN table with info gathered from here:

Before

vpn-before-1

After

vpn-after-2

Before

email-before-1

After

email-after-3

<!-- PLEASE READ OUR [CONTRIBUTING GUIDELINES](https://github.com/privacytoolsIO/privacytools.io/blob/master/.github/CONTRIBUTING.md) BEFORE SUBMITTING --> ## Description This PR increases the consistency between the Email and VPN provider tables. If these changes should be separated into additional PRs, please let me know 🤓 1. Uses the same vocabulary, e.g. "Email/VPN Provider", for the first column. 2. Highlights the first column to bring visibility to users that the columns are sortable. 3. Uses the same vocabulary, e.g. "Yearly Price", for the yearly price column (rather than "Price / Year"). 4. Uses the same vocabulary, e.g. "Jurisdiction", for jurisdiction column (rather than "Server"). 5. Added "Since" column to VPN table with info gathered from here: - [AirVPN, since 2010](https://airvpn.org/aboutus/) - [AzireVPN, since 2012](https://www.azirevpn.com/about/) - [blackVPN, since 2009](https://www.blackvpn.com/about/) - [Cryptostorm, since 2006](https://cointelegraph.com/news/cryptostorm-vpn-unites-white-and-dark-webs-supports-namecoin-tor-and-i2p-domains) - [ExpressVPN, since 2009](https://www.expressvpn.com/press) - [FrootVPN, since 2014](https://thebestvpn.com/reviews/frootvpn/) - [hide.me, since 2012](https://hide.me/en/press) - [IVPN, since 2009](https://www.ivpn.net/aboutus) - [Mullvad, since 2009](https://mullvad.net/en/what-is-privacy/) - [NordVPN, since 2012](https://nordvpn.com/about-us/) - [OVPN, since 2014](https://www.ovpn.com/en/blog/ovpn-turns-four/) - [Perfect Privacy, since 2008](https://www.perfect-privacy.com/en/why-vpn) - [ProtonVPN, since 2016](https://www.linkedin.com/company/protonvpn/about/) - [Proxy.sh, since 2012](https://proxy.sh/about) - [Trust.Zone, since 2014](https://thebestvpn.com/reviews/trust-zone/) - [VPN.ht, since 2014](https://vpn.ht/) - [VPNArea, since 2012](https://vpnarea.com) - [VPNTunnel, since 2008](http://www.vpncomparison.org/provider/vpn-tunnel/) ## Before ![vpn-before-1](https://user-images.githubusercontent.com/1514352/62340274-85a5a980-b4ce-11e9-8a28-f97d06ab1a02.png) ## After ![vpn-after-2](https://user-images.githubusercontent.com/1514352/62406538-1480f780-b59d-11e9-91b5-d995298a873d.png) ## Before ![email-before-1](https://user-images.githubusercontent.com/1514352/62340287-935b2f00-b4ce-11e9-896b-2f6884bf0479.png) ## After ![email-after-3](https://user-images.githubusercontent.com/1514352/62406195-40997a00-b597-11e9-8b2c-f05ec98e4dbb.png)
Mikaela (Migrated from github.com) reviewed 2019-08-02 02:41:10 +00:00
netlify[bot] commented 2019-08-02 02:41:51 +00:00 (Migrated from github.com)
Copy Link

Deploy preview for privacytools-io ready!

Built with commit 94d85f6d02

https://deploy-preview-1079--privacytools-io.netlify.com

Deploy preview for *privacytools-io* ready! Built with commit 94d85f6d021bed24cbc17c672f53f8b025405c6f https://deploy-preview-1079--privacytools-io.netlify.com
nitrohorse commented 2019-08-03 02:37:11 +00:00 (Migrated from github.com)
Copy Link

I'm thinking adding a "Since" column to the VPN table would be valuable, just like the Email column.

I'm thinking adding a "Since" column to the VPN table would be valuable, just like the Email column.
jonah approved these changes 2019-08-03 19:24:37 +00:00
jonah left a comment

Beautiful 🙏 LGTM

Beautiful 🙏 LGTM
This repo is archived. You cannot comment on pull requests.
Reviewers
No Reviewers
jonah
Mikaela
Labels
Clear labels
🔍🤖 Search Engines
approved
approved, waiting for a PR
dependencies
Pull requests that update a dependency file
duplicate
feedback wanted
high priority
I2P
The Invisible Internet Project (I2P)
iOS
low priority
OS
Operating Systems
Self-contained networks
Social media
stale
A label for stalebot if it gets added
streaming
Anything related to media streaming.
todo
Tor
Anything covering the Tor network
WIP
active work in progress, do not merge or PR (yet)!
wontfix
Issues or bugs that will not be fixed and/or do not have significant impact on the project.
XMPP
Extensible Messaging and Presence Protocol
[m]
Matrix protocol
₿ cryptocurrency
ℹ️ help wanted
↔️ file sharing
⚙️ web extensions
Browser Extension related issues
✨ enhancement
❌ software removal
💬 discussion
🤖 Android
🐛 bug
💢 conflicting
📝 correction
Correction of content on the website
🆘 critical
📧 email
🔒 file encryption
📁 file storage
🦊 Firefox
Firefox & forks, about:config etc.
💻 hardware
🌐 hosting
🏠 housekeeping
Anything primarily related to site cleanup.
🔐 password managers
🧰 productivity tools
🔎 research required
🌐 Social News Aggregators
🆕 software suggestion
👥 team chat
🔒 VPN
Virtual Private Network
🌐 website issue
*Technical* issues with the website.
🚫 Windows
👁️ browsers
🖊️ digital notebooks
🗄️ DNS
Domain Name System
🗨️ instant messaging (im)
🇦🇶 translations
Anything covering a translated version of the site
No Label
✨ enhancement
📧 email
🔒 VPN
Milestone
No items
No Milestone
Assignees
Clear assignees
jonah
No Assignees
1 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: privacyguides/privacytools.io#1079
No description provided.
Delete Branch "highlight-first-cols-automatically"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?