privacyguides/privacytools.io
Archived
1
0
Fork 0
Code Issues 304 Pull Requests 47 Activity

browser-recommendation: suggest Firefox ESR instead of Firefox #881

Closed
Mikaela wants to merge 1 commits from firefox-esr into master
pull from: firefox-esr
merge into: privacyguides:master
Conversation 17 Commits 1 Files Changed 1 +4 -3
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
_includes/sections/browser-recommendation.html
View File

@ -12,12 +12,13 @@
%} %}
{% include card.html color="primary" {% include card.html color="primary"
title="Mozilla Firefox" title="Mozilla Firefox ESR"
image="/assets/img/tools/Firefox.png" image="/assets/img/tools/Firefox.png"
url="https://www.firefox.com/" website="mozilla.org"
url="https://www.mozilla.org/en-US/firefox/organizations/all/"
footer="OS: Windows, macOS, Linux, Android, iOS, BSD." footer="OS: Windows, macOS, Linux, Android, iOS, BSD."
description='Firefox is fast, reliable, open source and respects your privacy. Don\'t forget to adjust the settings according to our description='Firefox is fast, reliable, open source and respects your privacy. Don\'t forget to adjust the settings according to our
Mikaela commented 2019-04-24 19:49:17 +00:00 (Migrated from github.com)
Review
Copy Link

I will need help on how to format URL if this PR is judged acceptable.

Screenshot from 2019-04-24 22-48-44

I will need help on how to format URL if this PR is judged acceptable. ![Screenshot from 2019-04-24 22-48-44](https://user-images.githubusercontent.com/831184/56689164-041dce80-66ca-11e9-98ed-2113f3aa6167.png)
jonah commented 2019-04-24 19:53:14 +00:00
Review
Copy Link

Add a website="mozilla.org" parameter. I set it up so that when website is missing, it's created from url by removing things like slashes, https: etc.

Add a `website="mozilla.org"` parameter. I set it up so that when `website` is missing, it's created from `url` by removing things like slashes, `https:` etc.
recommendations: <a href="#webrtc"><i class="fas fa-link"></i> WebRTC</a> and <a href="#about_config"><i class="fas fa-link"></i> about:config</a> and get the <a href="#addons"><i class="fas fa-link"></i> privacy add-ons</a>.' recommendations: <a href="#webrtc"><i class="fas fa-link"></i> WebRTC</a> and <a href="#about_config"><i class="fas fa-link"></i> about:config</a> and get the <a href="#addons"><i class="fas fa-link"></i> privacy add-ons</a>. The extended support release (ESR) gets new features more slowly, while still receiving backported security updates promptly.'
%} %}
{% include card.html color="warning" {% include card.html color="warning"