privacyguides/privacytools.io
Archived
1
0
Fork 0
Code Issues 304 Pull Requests 47 Activity

Add Key icon and links in the /about/ page #1498

Merged
dawidpotocki merged 3 commits from add-key-icon into master 2019-11-17 08:26:16 +00:00
Conversation 7 Commits 3 Files Changed 3 +48 -30
2 changed files with 48 additions and 30 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit fc59b75f1e - Show all commits

62
_includes/team.html
View File

@ -14,36 +14,38 @@
<meta itemprop="affiliation" content="PrivacyTools" /> <meta itemprop="affiliation" content="PrivacyTools" />
<h6 class="card-subtitle mb-2 text-muted" itemprop="jobTitle">{{ include.role | default: "Contributor" }}</h6> <h6 class="card-subtitle mb-2 text-muted" itemprop="jobTitle">{{ include.role | default: "Contributor" }}</h6>
<p class="card-text" {% if include.bio %}itemprop="description"{% endif %}>{{ include.bio | default: "<i>Hmm, this user hasn't written a bio quite yet :(</i>" }}</p> <p class="card-text" {% if include.bio %}itemprop="description"{% endif %}>{{ include.bio | default: "<i>Hmm, this user hasn't written a bio quite yet :(</i>" }}</p>
{% if include.email %} <div class="mx-n2">
<a href="mailto:{{ include.email }}" aria-label="Email" class="card-link" itemprop="email"> {% if include.email %}
<i class="fas fa-envelope" aria-hidden="true" title="{{ include.email }}"></i> <a href="mailto:{{ include.email }}" aria-label="Email" class="mx-2 text-decoration-none" itemprop="email">
</a> <i class="fas fa-envelope" aria-hidden="true" title="{{ include.email }}"></i>
{% endif %} </a>
{% if include.website %} {% endif %}
<a href="{{ include.website }}" aria-label="Website" class="card-link" itemprop="url"> {% if include.website %}
jonah commented 2019-11-17 07:54:17 +00:00
Review
Copy Link
      <a href="{{ include.keys }}" aria-label="Keys" class="card-link" itemprop="sameAs">

https://schema.org/Person

```suggestion <a href="{{ include.keys }}" aria-label="Keys" class="card-link" itemprop="sameAs"> ``` https://schema.org/Person
<i class="fas fa-link" aria-hidden="true" title="Website"></i> <a href="{{ include.website }}" aria-label="Website" class="mx-2 text-decoration-none" itemprop="url">
</a> <i class="fas fa-link" aria-hidden="true" title="Website"></i>
{% endif %} </a>
{% if include.keys %} {% endif %}
<a href="{{ include.keys }}" aria-label="Keys" class="card-link" itemprop="sameAs"> {% if include.keys %}
<i class="fas fa-key" aria-hidden="true" title="Keys"></i> <a href="{{ include.keys }}" aria-label="Keys" class="mx-2 text-decoration-none" itemprop="sameAs">
</a> <i class="fas fa-key" aria-hidden="true" title="Keys"></i>
{% endif %} </a>
{% if include.mastodon %} {% endif %}
<a href="{{ include.mastodon }}" aria-label="Mastodon" class="card-link" itemprop="sameAs"> {% if include.mastodon %}
<i class="fab fa-mastodon" aria-hidden="true" title="Mastodon Profile"></i> <a href="{{ include.mastodon }}" aria-label="Mastodon" class="mx-2 text-decoration-none" itemprop="sameAs">
</a> <i class="fab fa-mastodon" aria-hidden="true" title="Mastodon Profile"></i>
{% endif %} </a>
{% if include.twitter %} {% endif %}
<a href="https://twitter.com/{{ include.twitter }}" aria-label="Twitter" class="card-link" itemprop="sameAs"> {% if include.twitter %}
<i class="fab fa-twitter" aria-hidden="true" title="Twitter Profile"></i> <a href="https://twitter.com/{{ include.twitter }}" aria-label="Twitter" class="mx-2 text-decoration-none" itemprop="sameAs">
</a> <i class="fab fa-twitter" aria-hidden="true" title="Twitter Profile"></i>
{% endif %} </a>
{% if include.blog %} {% endif %}
<a href="https://blog.privacytools.io/author/{{ include.blog }}" aria-label="Blog" class="card-link" itemprop="sameAs"> {% if include.blog %}
<i class="fas fa-pen-nib" aria-hidden="true" title="PrivacyTools Blog Author"></i> <a href="https://blog.privacytools.io/author/{{ include.blog }}" aria-label="Blog" class="mx-2 text-decoration-none" itemprop="sameAs">
</a> <i class="fas fa-pen-nib" aria-hidden="true" title="PrivacyTools Blog Author"></i>
{% endif %} </a>
{% endif %}
</div>
</div> </div>
</div> </div>
</div> </div>

16
assets/css/style.scss
View File

@ -220,6 +220,22 @@ footer {
} }
/*
* Bootstrap 4.2+ features
*/
.text-decoration-none {
text-decoration: none !important;
}
.mx-n2 {
margin-left: -0.5rem;
margin-right: -0.5rem;
}
/* /*
* Navbar * Navbar
*/ */