privacyguides/privacytools.io
Archived
1
0
Fork 0
Code Issues 304 Pull Requests 47 Activity

clarify PULL_REQUST_TEMPLATE.md & CONTRIBUTING.md #1291

Merged
Mikaela merged 8 commits from pr-template into master 2019-09-23 20:50:52 +00:00
Conversation 26 Commits 8 Files Changed 2 +13 -12
2 changed files with 13 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
.github/CONTRIBUTING.md vendored
View File

@ -7,6 +7,9 @@ Please read this before contributing.
- Be nice and respectful. - Be nice and respectful.
- English only. - English only.
- Be constructive. - Be constructive.
- Please feel free to *review changes* in the *files changed* tab of any
pull request at any time.
Mikaela commented 2019-09-12 21:19:15 +00:00 (Migrated from github.com)
Review
Copy Link

The only change I could do towards https://github.com/privacytoolsIO/privacytools.io/issues/1296, but I don't feel comfortable closing it in case there will be ideas and concensus for something more.

The only change I could do towards https://github.com/privacytoolsIO/privacytools.io/issues/1296, but I don't feel comfortable closing it in case there will be ideas and concensus for something more.
- See also our [Code of Conduct](https://github.com/privacytoolsIO/privacytools.io/blob/master/CODE_OF_CONDUCT.md)
Mikaela commented 2019-09-12 21:20:05 +00:00 (Migrated from github.com)
Review
Copy Link

I think it should be mentioned together with "rules" which I would be comfortable removing entirely instead pointing only to it. We also don't have the "English only" documented anywhere else. Do we?

I think it should be mentioned together with "rules" which I would be comfortable removing entirely instead pointing only to it. We also don't have the "English only" documented anywhere else. Do we?
nitrohorse commented 2019-09-13 01:34:51 +00:00 (Migrated from github.com)
Review
Copy Link

Not anywhere else, no. I think it's good to add a link to it as a reminder.

Not anywhere else, no. I think it's good to add a link to it as a reminder.
Mikaela commented 2019-09-13 10:21:02 +00:00 (Migrated from github.com)
Review
Copy Link

Sorry, could you clarify? It's good to add a link to the CoC as a reminder here, or should English-only be documented somewhere else?

I kind of would like to have language specific subforums and accept contributions or at least feedback in other languages too, assuming we have team member(s) fluent in that language.

Sorry, could you clarify? It's good to add a link to the CoC as a reminder here, or should English-only be documented somewhere else? I kind of would like to have language specific subforums and accept contributions or at least feedback in other languages too, assuming we have team member(s) fluent in that language.
nitrohorse commented 2019-09-13 13:46:31 +00:00 (Migrated from github.com)
Review
Copy Link

Sorry, I meant to say I think we only have this English only version of the CoC at the moment so adding a link to it like your change does I think is good 👍🏼

Sorry, I meant to say I think we only have this English only version of the CoC at the moment so adding a link to it like your change does I think is good 👍🏼
## Quality over Quantity ## Quality over Quantity
@ -17,7 +20,7 @@ We're trying to keep it simple and promote the best tools, not all of them.
- Easy to use. Could your mother use that tool or service? Usability is most important. - Easy to use. Could your mother use that tool or service? Usability is most important.
- Cross-platform / Accessible. - Cross-platform / Accessible.
- Privacy respecting. - Privacy respecting.
- Open Source / free software is preferred but not required. - Open Source / Free Software is preferred but not required.
- Must list source code in [source_code.md](https://github.com/privacytoolsIO/privacytools.io/blob/master/source_code.md) (if applicable) - Must list source code in [source_code.md](https://github.com/privacytoolsIO/privacytools.io/blob/master/source_code.md) (if applicable)
- Prioritize Products without Vendor Lock-in (decentralized/self-hostable) or data interoperability. - Prioritize Products without Vendor Lock-in (decentralized/self-hostable) or data interoperability.
@ -37,7 +40,7 @@ Note: This criteria applies to all of privacytools.io
### VPN ### VPN
- Prioritize Products by privacy respecting nationality. - Prioritize Products by privacy respecting nationality.
- Cannot be based in USA or UK. - Cannot be based in USA or UK.
- Must be acessable via free software (i.e OpenVPN, WireGuard) - Must be accessible via Open Source Software (i.e OpenVPN, WireGuard)
- Use Encryption - Use Encryption
- Accept Cryptocurrency - Accept Cryptocurrency
- No logging policy - No logging policy
@ -45,16 +48,16 @@ Note: This criteria applies to all of privacytools.io
### Email ### Email
- Outside of USA - Outside of USA
- Support SMTP SSL - Support SMTP SSL
- Accessable Using Free Software (i.e IMAP) - Accessable Using Open Source Software (i.e IMAP)
### Hardware ### Hardware
- Must be [H-Node Class A](https://h-node.org/wiki/page/en/compatibility-classes) or Equivlant (if applicable) - Must be [H-Node Class A](https://h-node.org/wiki/page/en/compatibility-classes) or equivalent (if applicable)
- Must prioritize hardware certifications like [RYF](https://ryf.fsf.org/), [OSHWA](https://certification.oshwa.org/), and OSI when avalible. - Must prioritize hardware certifications like [RYF](https://ryf.fsf.org/), [OSHWA](https://certification.oshwa.org/), and OSI when avalible.
- Cannot lock users to a particular platform. - Cannot lock users to a particular platform.
### Software ### Software
- Must be able to download over encrypted network (can be a mirror) - Must be able to download over encrypted network (can be a mirror)
- Must be free software - Must be Open Source Software
### Encryption ### Encryption
- Only verifiable encryption is to be trusted - Only verifiable encryption is to be trusted

12
.github/PULL_REQUEST_TEMPLATE.md vendored
View File

@ -1,19 +1,17 @@
<!-- PLEASE READ OUR CONTRIBUTING GUIDELINES (https://github.com/privacytoolsIO/privacytools.io/blob/master/.github/CONTRIBUTING.md) BEFORE SUBMITTING --> <!-- PLEASE READ OUR CODE OF CONDUCT (https://github.com/privacytoolsIO/privacytools.io/blob/master/CODE_OF_CONDUCT.md) AND CONTRIBUTING GUIDELINES (https://github.com/privacytoolsIO/privacytools.io/blob/master/.github/CONTRIBUTING.md) BEFORE SUBMITTING -->
Mikaela commented 2019-09-10 19:43:58 +00:00 (Migrated from github.com)
Review
Copy Link

First hint that we do want the discussion issue to exist.

First hint that we do want the discussion issue to exist.
Mikaela commented 2019-09-10 19:44:47 +00:00 (Migrated from github.com)
Review
Copy Link

I may want to check that wiki page and if there is a better one.

I may want to check that wiki page and if there is a better one.
Mikaela commented 2019-09-10 19:45:51 +00:00 (Migrated from github.com)
Review
Copy Link
- [ ] The project has an associated discussion: # <!-- issue number -->

oops. Anyway the previous formatting was very unhelpful in my opinion as it just went to issue page and forced me to use search as no one (me included) never changed the link.

and I think The fits here better than This, even if there is probably no practical difference.

```suggestion - [ ] The project has an associated discussion: # <!-- issue number --> ``` oops. Anyway the previous formatting was very unhelpful in my opinion as it just went to issue page and forced me to use search as no one (me included) never changed the link. and I think `The` fits here better than `This`, even if there is probably no practical difference.
nitrohorse commented 2019-09-11 02:32:39 +00:00 (Migrated from github.com)
Review
Copy Link

I would probably tidy this up a bit to:

<!-- A link to the discussion issue(s) resolved by this pull request. If there is none, feel free to delete this line. -->
I would probably tidy this up a bit to: ``` <!-- A link to the discussion issue(s) resolved by this pull request. If there is none, feel free to delete this line. --> ```
nitrohorse commented 2019-09-11 02:34:12 +00:00 (Migrated from github.com)
Review
Copy Link

Is this somewhat redundant due to already having a "Resolves"? Could we remove this line in favor of having the "Resolves"?

Is this somewhat redundant due to already having a "Resolves"? Could we remove this line in favor of having the "Resolves"?
Mikaela commented 2019-09-11 07:55:43 +00:00 (Migrated from github.com)
Review
Copy Link

👍 I think I also need to clarify that discussion issue means software suggestion to distinguish it from discussions about news which we hoped to move to the forums.

:+1: I think I also need to clarify that discussion issue means software suggestion to distinguish it from discussions about news which we hoped to move to the forums.
Mikaela commented 2019-09-11 07:56:00 +00:00 (Migrated from github.com)
Review
Copy Link

I guess

I guess
Mikaela commented 2019-09-12 21:01:11 +00:00 (Migrated from github.com)
Review
Copy Link

Sorry, I have to mess it up, because if there are multiple issues, Resolves: #1, #2 closes only #1.

Sorry, I have to mess it up, because if there are multiple issues, `Resolves: #1, #2` closes only `#1`.
Mikaela commented 2019-09-12 21:02:05 +00:00 (Migrated from github.com)
Review
Copy Link

No, I seem to be simplifying it more due to the other thread where I remove mentioning on the issue.

No, I seem to be simplifying it more due to the other thread where I remove mentioning on the issue.
## Description ## Description
Mikaela commented 2019-09-10 19:46:39 +00:00 (Migrated from github.com)
Review
Copy Link

Oh and I wonder if we should also mention CODE_OF_CONDUCT.md on the top, but if we get a project that is full of hate, I guess we can refer to it separately.

Oh and I wonder if we should also mention CODE_OF_CONDUCT.md on the top, but if we get a project that is full of hate, I guess we can refer to it separately.
nitrohorse commented 2019-09-11 02:31:06 +00:00 (Migrated from github.com)
Review
Copy Link

Hmm, I'm not sure but it doesn't hurt to add it as a comment at the top as a reminder.

Hmm, I'm not sure but it doesn't hurt to add it as a comment at the top as a reminder.
Mikaela commented 2019-09-11 07:55:05 +00:00 (Migrated from github.com)
Review
Copy Link

👍

:+1:
Resolves: #none <!-- The number of the issue that is resolved by this pull request. If there is none, feel free to delete this line --> Resolves: #none <!-- A link to the (discussion) issue resolved by this pull request. There must be a discussion issue here at GitHub, before a pull request of software/service suggestion can be considered for merging. -->
#### Check List <!-- Please add an x in each box below, like so: [x] --> #### Check List <!-- Please add an x in each box below, like so: [x] -->
Mikaela commented 2019-09-12 21:22:56 +00:00 (Migrated from github.com)
Review
Copy Link

I think this is necessary if we are removing the "has associated discussion" part.

I think this is necessary if we are removing the "has associated discussion" part.
- [ ] I have read and understand [the contributing guidelines](https://github.com/privacytoolsIO/privacytools.io/blob/master/.github/CONTRIBUTING.md). - [ ] I have read and understand [the contributing guidelines](https://github.com/privacytoolsIO/privacytools.io/blob/master/.github/CONTRIBUTING.md).
- [ ] I have [listed the source code](https://github.com/privacytoolsIO/privacytools.io/blob/master/source_code.md). - [ ] I have listed the source code in [source_code.md](https://github.com/privacytoolsIO/privacytools.io/blob/master/source_code.md).
- [ ] This project is [free/libre software](https://www.wikipedia.org/wiki/Free_software). - [ ] The project is [Free Libre](https://en.wikipedia.org/wiki/Free_software) and/or [Open Source](https://en.wikipedia.org/wiki/Open-source_software) Software
- [ ] This project has an [associated discussion](https://github.com/privacytoolsIO/privacytools.io/issues).
* Netlify preview for the mainly edited page: <!-- link or Non Applicable? Edit this in afterwards --> * Netlify preview for the mainly edited page: <!-- link or Non Applicable? Edit this in afterwards -->
Mikaela commented 2019-09-10 19:44:25 +00:00 (Migrated from github.com)
Review
Copy Link

I think this is more clear formatting.

I think this is more clear formatting.
* Code Repository (if applicable): * Code repository of the project (if applicable):