privacyguides/privacytools.io
Archived
1
0
Fork 0
Code Issues 304 Pull Requests 47 Activity

clarify PULL_REQUST_TEMPLATE.md & CONTRIBUTING.md #1291

Merged
Mikaela merged 8 commits from pr-template into master 2019-09-23 20:50:52 +00:00
Conversation 26 Commits 8 Files Changed 2 +5 -5
1 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 632ce4463b - Show all commits

10
.github/PULL_REQUEST_TEMPLATE.md vendored
View File

@@ -2,18 +2,18 @@
## Description
Mikaela commented 2019-09-10 19:46:39 +00:00 (Migrated from github.com)
Review
Copy Link

Oh and I wonder if we should also mention CODE_OF_CONDUCT.md on the top, but if we get a project that is full of hate, I guess we can refer to it separately.

Oh and I wonder if we should also mention CODE_OF_CONDUCT.md on the top, but if we get a project that is full of hate, I guess we can refer to it separately.
nitrohorse commented 2019-09-11 02:31:06 +00:00 (Migrated from github.com)
Review
Copy Link

Hmm, I'm not sure but it doesn't hurt to add it as a comment at the top as a reminder.

Hmm, I'm not sure but it doesn't hurt to add it as a comment at the top as a reminder.
Mikaela commented 2019-09-11 07:55:05 +00:00 (Migrated from github.com)
Review
Copy Link

👍

:+1:
Resolves: #none <!-- The number of the issue that is resolved by this pull request. If there is none, feel free to delete this line -->
Resolves: #none <!-- The number of the issue that is resolved by this pull request. This should be number of the discussion issue. If there is none, feel free to delete this line -->
#### Check List <!-- Please add an x in each box below, like so: [x] -->
Mikaela commented 2019-09-12 21:22:56 +00:00 (Migrated from github.com)
Review
Copy Link

I think this is necessary if we are removing the "has associated discussion" part.

I think this is necessary if we are removing the "has associated discussion" part.
- [ ] I have read and understand [the contributing guidelines](https://github.com/privacytoolsIO/privacytools.io/blob/master/.github/CONTRIBUTING.md).
- [ ] I have [listed the source code](https://github.com/privacytoolsIO/privacytools.io/blob/master/source_code.md).
- [ ] I have listed the source code in [source_code.md](https://github.com/privacytoolsIO/privacytools.io/blob/master/source_code.md).
- [ ] This project is [free/libre software](https://www.wikipedia.org/wiki/Free_software).
- [ ] The project is [free/libre software](https://www.wikipedia.org/wiki/Free_software).
- [ ] This project has an [associated discussion](https://github.com/privacytoolsIO/privacytools.io/issues).
- [ ] The project has an associated discussion: # <!-- issue number -->
Mikaela commented 2019-09-10 19:44:25 +00:00 (Migrated from github.com)
Review
Copy Link

I think this is more clear formatting.

I think this is more clear formatting.
* Netlify preview for the mainly edited page: <!-- link or Non Applicable? Edit this in afterwards -->
* Code Repository (if applicable):
* Code repository of the project (if applicable):