privacyguides/privacytools.io
Archived
1
0
Fork 0
Code Issues 304 Pull Requests 47 Activity

clarify PULL_REQUST_TEMPLATE.md & CONTRIBUTING.md #1291

Merged
Mikaela merged 8 commits from pr-template into master 2019-09-23 20:50:52 +00:00
Conversation 26 Commits 8 Files Changed 2 +3
1 changed files with 3 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 2ff1f6e816 - Show all commits

3
.github/CONTRIBUTING.md vendored
View File

@@ -7,6 +7,9 @@ Please read this before contributing.
- Be nice and respectful.
- English only.
- Be constructive.
- Please feel free to *review changes* in the *files changed* tab of any
pull request at any time.
Mikaela commented 2019-09-12 21:19:15 +00:00 (Migrated from github.com)
Review
Copy Link

The only change I could do towards https://github.com/privacytoolsIO/privacytools.io/issues/1296, but I don't feel comfortable closing it in case there will be ideas and concensus for something more.

The only change I could do towards https://github.com/privacytoolsIO/privacytools.io/issues/1296, but I don't feel comfortable closing it in case there will be ideas and concensus for something more.
- See also our [Code of Conduct](https://github.com/privacytoolsIO/privacytools.io/blob/master/CODE_OF_CONDUCT.md)
Mikaela commented 2019-09-12 21:20:05 +00:00 (Migrated from github.com)
Review
Copy Link

I think it should be mentioned together with "rules" which I would be comfortable removing entirely instead pointing only to it. We also don't have the "English only" documented anywhere else. Do we?

I think it should be mentioned together with "rules" which I would be comfortable removing entirely instead pointing only to it. We also don't have the "English only" documented anywhere else. Do we?
nitrohorse commented 2019-09-13 01:34:51 +00:00 (Migrated from github.com)
Review
Copy Link

Not anywhere else, no. I think it's good to add a link to it as a reminder.

Not anywhere else, no. I think it's good to add a link to it as a reminder.
Mikaela commented 2019-09-13 10:21:02 +00:00 (Migrated from github.com)
Review
Copy Link

Sorry, could you clarify? It's good to add a link to the CoC as a reminder here, or should English-only be documented somewhere else?

I kind of would like to have language specific subforums and accept contributions or at least feedback in other languages too, assuming we have team member(s) fluent in that language.

Sorry, could you clarify? It's good to add a link to the CoC as a reminder here, or should English-only be documented somewhere else? I kind of would like to have language specific subforums and accept contributions or at least feedback in other languages too, assuming we have team member(s) fluent in that language.
nitrohorse commented 2019-09-13 13:46:31 +00:00 (Migrated from github.com)
Review
Copy Link

Sorry, I meant to say I think we only have this English only version of the CoC at the moment so adding a link to it like your change does I think is good 👍🏼

Sorry, I meant to say I think we only have this English only version of the CoC at the moment so adding a link to it like your change does I think is good 👍🏼
## Quality over Quantity