[WIP] Browser overhaul. Browser section. #1256

Merged
blacklight447 merged 44 commits from blacklight447-ptio-patch-1 into master 2019-09-12 14:13:11 +00:00
6 changed files with 87 additions and 10 deletions
Showing only changes of commit 73b7638c75 - Show all commits

View File

@ -67,7 +67,7 @@ android="https://www.bromite.org/news/2018-12-21-new-fdroid-repository-url"
dawidpotocki commented 2019-09-01 10:49:52 +00:00 (Migrated from github.com)
Review
Change "Mozilla Firefox" to "Firefox Browser", that's how they name it now. https://github.com/privacytoolsIO/privacytools.io/blob/7022e125b9d9a14173437d2898fdbd80fa261417/_includes/sections/browser-recommendation.html#L36 https://github.com/privacytoolsIO/privacytools.io/blob/7022e125b9d9a14173437d2898fdbd80fa261417/_includes/sections/browser-recommendation.html#L83 ![image](https://user-images.githubusercontent.com/38681822/64075295-0a3e4000-cca6-11e9-9119-ac6479733a9d.png)
dawidpotocki commented 2019-09-01 10:49:52 +00:00 (Migrated from github.com)
Review
Change "Mozilla Firefox" to "Firefox Browser", that's how they name it now. https://github.com/privacytoolsIO/privacytools.io/blob/7022e125b9d9a14173437d2898fdbd80fa261417/_includes/sections/browser-recommendation.html#L36 https://github.com/privacytoolsIO/privacytools.io/blob/7022e125b9d9a14173437d2898fdbd80fa261417/_includes/sections/browser-recommendation.html#L83 ![image](https://user-images.githubusercontent.com/38681822/64075295-0a3e4000-cca6-11e9-9119-ac6479733a9d.png)
blacklight447 commented 2019-09-01 10:54:02 +00:00 (Migrated from github.com)
Review

Are you sure that's not only the case with the aurora version?

Are you sure that's not only the case with the aurora version?
blacklight447 commented 2019-09-01 10:54:02 +00:00 (Migrated from github.com)
Review

Are you sure that's not only the case with the aurora version?

Are you sure that's not only the case with the aurora version?
dawidpotocki commented 2019-09-01 10:59:41 +00:00 (Migrated from github.com)
Review

Yes. I'm sure.

image
image
image
image

Yes. I'm sure. ![image](https://user-images.githubusercontent.com/38681822/64075399-4920c580-cca7-11e9-93a7-8bbffbd7395a.png) ![image](https://user-images.githubusercontent.com/38681822/64075401-563db480-cca7-11e9-9108-c7fbca0e05b7.png) ![image](https://user-images.githubusercontent.com/38681822/64075415-84bb8f80-cca7-11e9-8e9b-4c36aa1fe8e1.png) ![image](https://user-images.githubusercontent.com/38681822/64075390-2abaca00-cca7-11e9-9a91-8961df28ca85.png)
dawidpotocki commented 2019-09-01 10:59:41 +00:00 (Migrated from github.com)
Review

Yes. I'm sure.

image
image
image
image

Yes. I'm sure. ![image](https://user-images.githubusercontent.com/38681822/64075399-4920c580-cca7-11e9-93a7-8bbffbd7395a.png) ![image](https://user-images.githubusercontent.com/38681822/64075401-563db480-cca7-11e9-9108-c7fbca0e05b7.png) ![image](https://user-images.githubusercontent.com/38681822/64075415-84bb8f80-cca7-11e9-8e9b-4c36aa1fe8e1.png) ![image](https://user-images.githubusercontent.com/38681822/64075390-2abaca00-cca7-11e9-9a91-8961df28ca85.png)
nitrohorse commented 2019-09-01 16:13:20 +00:00 (Migrated from github.com)
Review

I think we'll want all these links to be filled out in all these browser cards, yeah? Just like the password manager section.

I think we'll want all these links to be filled out in all these browser cards, yeah? Just like the [password manager section](https://www.privacytools.io/software/passwords/#pw).
nitrohorse commented 2019-09-01 16:13:20 +00:00 (Migrated from github.com)
Review

I think we'll want all these links to be filled out in all these browser cards, yeah? Just like the password manager section.

I think we'll want all these links to be filled out in all these browser cards, yeah? Just like the [password manager section](https://www.privacytools.io/software/passwords/#pw).
blacklight447 commented 2019-09-03 09:05:58 +00:00 (Migrated from github.com)
Review

I added all the links. there is one thing I haven't made up my mind about yet: Bromite.
its not the on google play, so we need to link to either their Github release page, or the page where they describe their f-droid repo. While the Github might be easier as people can directly download it, they will not be prompted of new updates, which is a security risk. what do you think? For now, I linked to their f-droid page.

I added all the links. there is one thing I haven't made up my mind about yet: Bromite. its not the on google play, so we need to link to either their Github release page, or the page where they describe their f-droid repo. While the Github might be easier as people can directly download it, they will not be prompted of new updates, which is a security risk. what do you think? For now, I linked to their f-droid page.
blacklight447 commented 2019-09-03 09:05:58 +00:00 (Migrated from github.com)
Review

I added all the links. there is one thing I haven't made up my mind about yet: Bromite.
its not the on google play, so we need to link to either their Github release page, or the page where they describe their f-droid repo. While the Github might be easier as people can directly download it, they will not be prompted of new updates, which is a security risk. what do you think? For now, I linked to their f-droid page.

I added all the links. there is one thing I haven't made up my mind about yet: Bromite. its not the on google play, so we need to link to either their Github release page, or the page where they describe their f-droid repo. While the Github might be easier as people can directly download it, they will not be prompted of new updates, which is a security risk. what do you think? For now, I linked to their f-droid page.
Mikaela commented 2019-09-03 15:36:19 +00:00 (Migrated from github.com)
Review

I prefer F-Droid.

I prefer F-Droid.
Mikaela commented 2019-09-03 15:36:19 +00:00 (Migrated from github.com)
Review

I prefer F-Droid.

I prefer F-Droid.
blacklight447 commented 2019-09-04 22:04:29 +00:00 (Migrated from github.com)
Review

Im not sure on this one, @dawidpotocki mentioned its called Firefox browser now, but im personally also fine with either Mozilla Firefox or just Firefox.

Im not sure on this one, @dawidpotocki mentioned its called Firefox browser now, but im personally also fine with either Mozilla Firefox or just Firefox.
blacklight447 commented 2019-09-04 22:04:29 +00:00 (Migrated from github.com)
Review

Im not sure on this one, @dawidpotocki mentioned its called Firefox browser now, but im personally also fine with either Mozilla Firefox or just Firefox.

Im not sure on this one, @dawidpotocki mentioned its called Firefox browser now, but im personally also fine with either Mozilla Firefox or just Firefox.
Review

I haven't found any references to "Firefox Browser" besides the Play Store listing on Android, and even then the app itself is simply "Firefox". And their new websites are all simply "Firefox".

Since we're in the browser section I don't think it's necessary to include the "Browser" part even if it is official. Just redundant.

I haven't found any references to "Firefox Browser" besides the Play Store listing on Android, and even then the app itself is simply "Firefox". And their new websites are all simply "Firefox". Since we're in the browser section I don't think it's necessary to include the "Browser" part even if it is official. Just redundant.
Review

I haven't found any references to "Firefox Browser" besides the Play Store listing on Android, and even then the app itself is simply "Firefox". And their new websites are all simply "Firefox".

Since we're in the browser section I don't think it's necessary to include the "Browser" part even if it is official. Just redundant.

I haven't found any references to "Firefox Browser" besides the Play Store listing on Android, and even then the app itself is simply "Firefox". And their new websites are all simply "Firefox". Since we're in the browser section I don't think it's necessary to include the "Browser" part even if it is official. Just redundant.
blacklight447 commented 2019-09-04 22:24:40 +00:00 (Migrated from github.com)
Review

Shall we go with just "Firefox" then?

Shall we go with just "Firefox" then?
blacklight447 commented 2019-09-04 22:24:40 +00:00 (Migrated from github.com)
Review

Shall we go with just "Firefox" then?

Shall we go with just "Firefox" then?
blacklight447 commented 2019-09-06 10:07:47 +00:00 (Migrated from github.com)
Review

The name is now changed to just "Firefox".

The name is now changed to just "Firefox".
blacklight447 commented 2019-09-06 10:07:47 +00:00 (Migrated from github.com)
Review

The name is now changed to just "Firefox".

The name is now changed to just "Firefox".
dawidpotocki commented 2019-09-11 23:30:00 +00:00 (Migrated from github.com)
Review

Remove en-US/, not everyone is a native English speaker.

Remove `en-US`/, not everyone is a native English speaker.
dawidpotocki commented 2019-09-11 23:30:00 +00:00 (Migrated from github.com)
Review

Remove en-US/, not everyone is a native English speaker.

Remove `en-US`/, not everyone is a native English speaker.
dawidpotocki commented 2019-09-11 23:45:14 +00:00 (Migrated from github.com)
Review
description='Firefox is fast, reliable, open source and respects your privacy. Don\'t forget to adjust the settings according to our
```suggestion description='Firefox is fast, reliable, open source and respects your privacy. Don\'t forget to adjust the settings according to our ```
dawidpotocki commented 2019-09-11 23:45:14 +00:00 (Migrated from github.com)
Review
description='Firefox is fast, reliable, open source and respects your privacy. Don\'t forget to adjust the settings according to our
```suggestion description='Firefox is fast, reliable, open source and respects your privacy. Don\'t forget to adjust the settings according to our ```
dawidpotocki commented 2019-09-11 23:46:20 +00:00 (Migrated from github.com)
Review
recommendations: <a href="#webrtc"><i class="fas fa-link"></i> WebRTC</a> and <a href="#about_config"><i class="fas fa-link"></i> about:config</a> and get the <a href="#addons"><i class="fas fa-link"></i> privacy add-ons</a>.'
```suggestion recommendations: <a href="#webrtc"><i class="fas fa-link"></i> WebRTC</a> and <a href="#about_config"><i class="fas fa-link"></i> about:config</a> and get the <a href="#addons"><i class="fas fa-link"></i> privacy add-ons</a>.' ```
dawidpotocki commented 2019-09-11 23:46:20 +00:00 (Migrated from github.com)
Review
recommendations: <a href="#webrtc"><i class="fas fa-link"></i> WebRTC</a> and <a href="#about_config"><i class="fas fa-link"></i> about:config</a> and get the <a href="#addons"><i class="fas fa-link"></i> privacy add-ons</a>.'
```suggestion recommendations: <a href="#webrtc"><i class="fas fa-link"></i> WebRTC</a> and <a href="#about_config"><i class="fas fa-link"></i> about:config</a> and get the <a href="#addons"><i class="fas fa-link"></i> privacy add-ons</a>.' ```
dawidpotocki commented 2019-09-12 06:33:11 +00:00 (Migrated from github.com)
Review

What is that ' doing here

What is that `'` doing here
dawidpotocki commented 2019-09-12 06:33:11 +00:00 (Migrated from github.com)
Review

What is that ' doing here

What is that `'` doing here
blacklight447 commented 2019-09-12 06:36:09 +00:00 (Migrated from github.com)
Review

Thats me trying stuff to fix the build, after i made on of your suggested commits, the build broke, netlify also indicates that here is something wrong with the Firefox section, I am still trying to figure out whats wrong exactly.

Thats me trying stuff to fix the build, after i made on of your suggested commits, the build broke, netlify also indicates that here is something wrong with the Firefox section, I am still trying to figure out whats wrong exactly.
blacklight447 commented 2019-09-12 06:36:09 +00:00 (Migrated from github.com)
Review

Thats me trying stuff to fix the build, after i made on of your suggested commits, the build broke, netlify also indicates that here is something wrong with the Firefox section, I am still trying to figure out whats wrong exactly.

Thats me trying stuff to fix the build, after i made on of your suggested commits, the build broke, netlify also indicates that here is something wrong with the Firefox section, I am still trying to figure out whats wrong exactly.
dawidpotocki commented 2019-09-12 06:41:56 +00:00 (Migrated from github.com)
Review
Can you look at the https://github.com/privacytoolsIO/privacytools.io/pull/1256/files#r323505120, eh.
dawidpotocki commented 2019-09-12 06:41:56 +00:00 (Migrated from github.com)
Review
Can you look at the https://github.com/privacytoolsIO/privacytools.io/pull/1256/files#r323505120, eh.
<h3>Worth Mentioning for Android</h3>
<ul>
<li><a href="https://www.stoutner.com/privacy-browser/">Privacy Browser</a> Privacy Browser is an open source Android web browser focused on user privacy. <a href="https://play.google.com/store/apps/details?id=com.google.android.webview&hl=en_US"><span class="badge badge-warning" data-toggle="tooltip" title="This software relies on a closed-source central server.">WARNING: Keep Android WebView up-to-date</span> Privacy Browser relies on the Android system webview which needs to be kept up to date to fix security issues. One can update webview by either installing it from Google Play, Yalp Store or Aurora Store. It requires Android 5.0+ so using Privacy Browser on older Androids is insecure.</a></li>
dawidpotocki commented 2019-09-01 10:49:52 +00:00 (Migrated from github.com)
Review
Change "Mozilla Firefox" to "Firefox Browser", that's how they name it now. https://github.com/privacytoolsIO/privacytools.io/blob/7022e125b9d9a14173437d2898fdbd80fa261417/_includes/sections/browser-recommendation.html#L36 https://github.com/privacytoolsIO/privacytools.io/blob/7022e125b9d9a14173437d2898fdbd80fa261417/_includes/sections/browser-recommendation.html#L83 ![image](https://user-images.githubusercontent.com/38681822/64075295-0a3e4000-cca6-11e9-9119-ac6479733a9d.png)
blacklight447 commented 2019-09-01 10:54:02 +00:00 (Migrated from github.com)
Review

Are you sure that's not only the case with the aurora version?

Are you sure that's not only the case with the aurora version?
dawidpotocki commented 2019-09-01 10:59:41 +00:00 (Migrated from github.com)
Review

Yes. I'm sure.

image
image
image
image

Yes. I'm sure. ![image](https://user-images.githubusercontent.com/38681822/64075399-4920c580-cca7-11e9-93a7-8bbffbd7395a.png) ![image](https://user-images.githubusercontent.com/38681822/64075401-563db480-cca7-11e9-9108-c7fbca0e05b7.png) ![image](https://user-images.githubusercontent.com/38681822/64075415-84bb8f80-cca7-11e9-8e9b-4c36aa1fe8e1.png) ![image](https://user-images.githubusercontent.com/38681822/64075390-2abaca00-cca7-11e9-9a91-8961df28ca85.png)
nitrohorse commented 2019-09-01 16:13:20 +00:00 (Migrated from github.com)
Review

I think we'll want all these links to be filled out in all these browser cards, yeah? Just like the password manager section.

I think we'll want all these links to be filled out in all these browser cards, yeah? Just like the [password manager section](https://www.privacytools.io/software/passwords/#pw).
blacklight447 commented 2019-09-03 09:05:58 +00:00 (Migrated from github.com)
Review

I added all the links. there is one thing I haven't made up my mind about yet: Bromite.
its not the on google play, so we need to link to either their Github release page, or the page where they describe their f-droid repo. While the Github might be easier as people can directly download it, they will not be prompted of new updates, which is a security risk. what do you think? For now, I linked to their f-droid page.

I added all the links. there is one thing I haven't made up my mind about yet: Bromite. its not the on google play, so we need to link to either their Github release page, or the page where they describe their f-droid repo. While the Github might be easier as people can directly download it, they will not be prompted of new updates, which is a security risk. what do you think? For now, I linked to their f-droid page.
Mikaela commented 2019-09-03 15:36:19 +00:00 (Migrated from github.com)
Review

I prefer F-Droid.

I prefer F-Droid.
blacklight447 commented 2019-09-04 22:04:29 +00:00 (Migrated from github.com)
Review

Im not sure on this one, @dawidpotocki mentioned its called Firefox browser now, but im personally also fine with either Mozilla Firefox or just Firefox.

Im not sure on this one, @dawidpotocki mentioned its called Firefox browser now, but im personally also fine with either Mozilla Firefox or just Firefox.
Review

I haven't found any references to "Firefox Browser" besides the Play Store listing on Android, and even then the app itself is simply "Firefox". And their new websites are all simply "Firefox".

Since we're in the browser section I don't think it's necessary to include the "Browser" part even if it is official. Just redundant.

I haven't found any references to "Firefox Browser" besides the Play Store listing on Android, and even then the app itself is simply "Firefox". And their new websites are all simply "Firefox". Since we're in the browser section I don't think it's necessary to include the "Browser" part even if it is official. Just redundant.
blacklight447 commented 2019-09-04 22:24:40 +00:00 (Migrated from github.com)
Review

Shall we go with just "Firefox" then?

Shall we go with just "Firefox" then?
blacklight447 commented 2019-09-06 10:07:47 +00:00 (Migrated from github.com)
Review

The name is now changed to just "Firefox".

The name is now changed to just "Firefox".
dawidpotocki commented 2019-09-11 23:30:00 +00:00 (Migrated from github.com)
Review

Remove en-US/, not everyone is a native English speaker.

Remove `en-US`/, not everyone is a native English speaker.
dawidpotocki commented 2019-09-11 23:45:14 +00:00 (Migrated from github.com)
Review
description='Firefox is fast, reliable, open source and respects your privacy. Don\'t forget to adjust the settings according to our
```suggestion description='Firefox is fast, reliable, open source and respects your privacy. Don\'t forget to adjust the settings according to our ```
dawidpotocki commented 2019-09-11 23:46:20 +00:00 (Migrated from github.com)
Review
recommendations: <a href="#webrtc"><i class="fas fa-link"></i> WebRTC</a> and <a href="#about_config"><i class="fas fa-link"></i> about:config</a> and get the <a href="#addons"><i class="fas fa-link"></i> privacy add-ons</a>.'
```suggestion recommendations: <a href="#webrtc"><i class="fas fa-link"></i> WebRTC</a> and <a href="#about_config"><i class="fas fa-link"></i> about:config</a> and get the <a href="#addons"><i class="fas fa-link"></i> privacy add-ons</a>.' ```
dawidpotocki commented 2019-09-12 06:33:11 +00:00 (Migrated from github.com)
Review

What is that ' doing here

What is that `'` doing here
blacklight447 commented 2019-09-12 06:36:09 +00:00 (Migrated from github.com)
Review

Thats me trying stuff to fix the build, after i made on of your suggested commits, the build broke, netlify also indicates that here is something wrong with the Firefox section, I am still trying to figure out whats wrong exactly.

Thats me trying stuff to fix the build, after i made on of your suggested commits, the build broke, netlify also indicates that here is something wrong with the Firefox section, I am still trying to figure out whats wrong exactly.
dawidpotocki commented 2019-09-12 06:41:56 +00:00 (Migrated from github.com)
Review
Can you look at the https://github.com/privacytoolsIO/privacytools.io/pull/1256/files#r323505120, eh.
<li><a href="https://www.stoutner.com/privacy-browser/">Privacy Browser</a> Privacy Browser is an open source Android web browser focused on user privacy. <a href="https://play.google.com/store/apps/details?id=com.google.android.webview&hl=en_US"><span class="badge badge-warning" data-toggle="tooltip" title="WARNING: Keep Android WebView up-to-date</span> Privacy Browser relies on the Android system webview which needs to be kept up to date to fix security issues. One can update webview by either installing it from Google Play, Yalp Store or Aurora Store. It requires Android 5.0+ so using Privacy Browser on older Androids is insecure."></a></li>
dawidpotocki commented 2019-09-01 10:49:52 +00:00 (Migrated from github.com)
Review
Change "Mozilla Firefox" to "Firefox Browser", that's how they name it now. https://github.com/privacytoolsIO/privacytools.io/blob/7022e125b9d9a14173437d2898fdbd80fa261417/_includes/sections/browser-recommendation.html#L36 https://github.com/privacytoolsIO/privacytools.io/blob/7022e125b9d9a14173437d2898fdbd80fa261417/_includes/sections/browser-recommendation.html#L83 ![image](https://user-images.githubusercontent.com/38681822/64075295-0a3e4000-cca6-11e9-9119-ac6479733a9d.png)
blacklight447 commented 2019-09-01 10:54:02 +00:00 (Migrated from github.com)
Review

Are you sure that's not only the case with the aurora version?

Are you sure that's not only the case with the aurora version?
dawidpotocki commented 2019-09-01 10:59:41 +00:00 (Migrated from github.com)
Review

Yes. I'm sure.

image
image
image
image

Yes. I'm sure. ![image](https://user-images.githubusercontent.com/38681822/64075399-4920c580-cca7-11e9-93a7-8bbffbd7395a.png) ![image](https://user-images.githubusercontent.com/38681822/64075401-563db480-cca7-11e9-9108-c7fbca0e05b7.png) ![image](https://user-images.githubusercontent.com/38681822/64075415-84bb8f80-cca7-11e9-8e9b-4c36aa1fe8e1.png) ![image](https://user-images.githubusercontent.com/38681822/64075390-2abaca00-cca7-11e9-9a91-8961df28ca85.png)
nitrohorse commented 2019-09-01 16:13:20 +00:00 (Migrated from github.com)
Review

I think we'll want all these links to be filled out in all these browser cards, yeah? Just like the password manager section.

I think we'll want all these links to be filled out in all these browser cards, yeah? Just like the [password manager section](https://www.privacytools.io/software/passwords/#pw).
nitrohorse commented 2019-09-01 16:47:02 +00:00 (Migrated from github.com)
Review

Could probably use quotes here for consistency.

Could probably use quotes here for consistency.
blacklight447 commented 2019-09-01 17:00:29 +00:00 (Migrated from github.com)
Review

fixed.

fixed.
blacklight447 commented 2019-09-01 17:07:45 +00:00 (Migrated from github.com)
Review

okay so it seems that use " instead of ' here causes netlify to shout at me, i think it has something to do with the fact that we have a hyperlink in there. i rolled it back for now

okay so it seems that use " instead of ' here causes netlify to shout at me, i think it has something to do with the fact that we have a hyperlink in there. i rolled it back for now
blacklight447 commented 2019-09-03 09:05:58 +00:00 (Migrated from github.com)
Review

I added all the links. there is one thing I haven't made up my mind about yet: Bromite.
its not the on google play, so we need to link to either their Github release page, or the page where they describe their f-droid repo. While the Github might be easier as people can directly download it, they will not be prompted of new updates, which is a security risk. what do you think? For now, I linked to their f-droid page.

I added all the links. there is one thing I haven't made up my mind about yet: Bromite. its not the on google play, so we need to link to either their Github release page, or the page where they describe their f-droid repo. While the Github might be easier as people can directly download it, they will not be prompted of new updates, which is a security risk. what do you think? For now, I linked to their f-droid page.
Mikaela commented 2019-09-03 15:36:19 +00:00 (Migrated from github.com)
Review

I prefer F-Droid.

I prefer F-Droid.
blacklight447 commented 2019-09-04 22:04:29 +00:00 (Migrated from github.com)
Review

Im not sure on this one, @dawidpotocki mentioned its called Firefox browser now, but im personally also fine with either Mozilla Firefox or just Firefox.

Im not sure on this one, @dawidpotocki mentioned its called Firefox browser now, but im personally also fine with either Mozilla Firefox or just Firefox.
Review

I haven't found any references to "Firefox Browser" besides the Play Store listing on Android, and even then the app itself is simply "Firefox". And their new websites are all simply "Firefox".

Since we're in the browser section I don't think it's necessary to include the "Browser" part even if it is official. Just redundant.

I haven't found any references to "Firefox Browser" besides the Play Store listing on Android, and even then the app itself is simply "Firefox". And their new websites are all simply "Firefox". Since we're in the browser section I don't think it's necessary to include the "Browser" part even if it is official. Just redundant.
blacklight447 commented 2019-09-04 22:24:40 +00:00 (Migrated from github.com)
Review

Shall we go with just "Firefox" then?

Shall we go with just "Firefox" then?
blacklight447 commented 2019-09-06 10:07:47 +00:00 (Migrated from github.com)
Review

The name is now changed to just "Firefox".

The name is now changed to just "Firefox".
dawidpotocki commented 2019-09-11 23:30:00 +00:00 (Migrated from github.com)
Review

Remove en-US/, not everyone is a native English speaker.

Remove `en-US`/, not everyone is a native English speaker.
dawidpotocki commented 2019-09-11 23:45:14 +00:00 (Migrated from github.com)
Review
description='Firefox is fast, reliable, open source and respects your privacy. Don\'t forget to adjust the settings according to our
```suggestion description='Firefox is fast, reliable, open source and respects your privacy. Don\'t forget to adjust the settings according to our ```
dawidpotocki commented 2019-09-11 23:46:20 +00:00 (Migrated from github.com)
Review
recommendations: <a href="#webrtc"><i class="fas fa-link"></i> WebRTC</a> and <a href="#about_config"><i class="fas fa-link"></i> about:config</a> and get the <a href="#addons"><i class="fas fa-link"></i> privacy add-ons</a>.'
```suggestion recommendations: <a href="#webrtc"><i class="fas fa-link"></i> WebRTC</a> and <a href="#about_config"><i class="fas fa-link"></i> about:config</a> and get the <a href="#addons"><i class="fas fa-link"></i> privacy add-ons</a>.' ```
dawidpotocki commented 2019-09-12 06:33:11 +00:00 (Migrated from github.com)
Review

What is that ' doing here

What is that `'` doing here
blacklight447 commented 2019-09-12 06:36:09 +00:00 (Migrated from github.com)
Review

Thats me trying stuff to fix the build, after i made on of your suggested commits, the build broke, netlify also indicates that here is something wrong with the Firefox section, I am still trying to figure out whats wrong exactly.

Thats me trying stuff to fix the build, after i made on of your suggested commits, the build broke, netlify also indicates that here is something wrong with the Firefox section, I am still trying to figure out whats wrong exactly.
dawidpotocki commented 2019-09-12 06:41:56 +00:00 (Migrated from github.com)
Review
Can you look at the https://github.com/privacytoolsIO/privacytools.io/pull/1256/files#r323505120, eh.
</ul>
dawidpotocki commented 2019-09-11 23:52:14 +00:00 (Migrated from github.com)
Review
googleplay="https://play.google.com/store/apps/details?id=org.mozilla.firefox"
android="https://www.mozilla.org/firefox/all/#product-android-release"

Android for APK download

```suggestion googleplay="https://play.google.com/store/apps/details?id=org.mozilla.firefox" android="https://www.mozilla.org/firefox/all/#product-android-release" ``` Android for APK download

dawidpotocki commented 2019-09-01 10:49:52 +00:00 (Migrated from github.com)
Review
Change "Mozilla Firefox" to "Firefox Browser", that's how they name it now. https://github.com/privacytoolsIO/privacytools.io/blob/7022e125b9d9a14173437d2898fdbd80fa261417/_includes/sections/browser-recommendation.html#L36 https://github.com/privacytoolsIO/privacytools.io/blob/7022e125b9d9a14173437d2898fdbd80fa261417/_includes/sections/browser-recommendation.html#L83 ![image](https://user-images.githubusercontent.com/38681822/64075295-0a3e4000-cca6-11e9-9119-ac6479733a9d.png)
dawidpotocki commented 2019-09-01 10:49:52 +00:00 (Migrated from github.com)
Review
Change "Mozilla Firefox" to "Firefox Browser", that's how they name it now. https://github.com/privacytoolsIO/privacytools.io/blob/7022e125b9d9a14173437d2898fdbd80fa261417/_includes/sections/browser-recommendation.html#L36 https://github.com/privacytoolsIO/privacytools.io/blob/7022e125b9d9a14173437d2898fdbd80fa261417/_includes/sections/browser-recommendation.html#L83 ![image](https://user-images.githubusercontent.com/38681822/64075295-0a3e4000-cca6-11e9-9119-ac6479733a9d.png)
blacklight447 commented 2019-09-01 10:54:02 +00:00 (Migrated from github.com)
Review

Are you sure that's not only the case with the aurora version?

Are you sure that's not only the case with the aurora version?
blacklight447 commented 2019-09-01 10:54:02 +00:00 (Migrated from github.com)
Review

Are you sure that's not only the case with the aurora version?

Are you sure that's not only the case with the aurora version?
dawidpotocki commented 2019-09-01 10:59:41 +00:00 (Migrated from github.com)
Review

Yes. I'm sure.

image
image
image
image

Yes. I'm sure. ![image](https://user-images.githubusercontent.com/38681822/64075399-4920c580-cca7-11e9-93a7-8bbffbd7395a.png) ![image](https://user-images.githubusercontent.com/38681822/64075401-563db480-cca7-11e9-9108-c7fbca0e05b7.png) ![image](https://user-images.githubusercontent.com/38681822/64075415-84bb8f80-cca7-11e9-8e9b-4c36aa1fe8e1.png) ![image](https://user-images.githubusercontent.com/38681822/64075390-2abaca00-cca7-11e9-9a91-8961df28ca85.png)
dawidpotocki commented 2019-09-01 10:59:41 +00:00 (Migrated from github.com)
Review

Yes. I'm sure.

image
image
image
image

Yes. I'm sure. ![image](https://user-images.githubusercontent.com/38681822/64075399-4920c580-cca7-11e9-93a7-8bbffbd7395a.png) ![image](https://user-images.githubusercontent.com/38681822/64075401-563db480-cca7-11e9-9108-c7fbca0e05b7.png) ![image](https://user-images.githubusercontent.com/38681822/64075415-84bb8f80-cca7-11e9-8e9b-4c36aa1fe8e1.png) ![image](https://user-images.githubusercontent.com/38681822/64075390-2abaca00-cca7-11e9-9a91-8961df28ca85.png)
nitrohorse commented 2019-09-01 16:13:20 +00:00 (Migrated from github.com)
Review

I think we'll want all these links to be filled out in all these browser cards, yeah? Just like the password manager section.

I think we'll want all these links to be filled out in all these browser cards, yeah? Just like the [password manager section](https://www.privacytools.io/software/passwords/#pw).
nitrohorse commented 2019-09-01 16:13:20 +00:00 (Migrated from github.com)
Review

I think we'll want all these links to be filled out in all these browser cards, yeah? Just like the password manager section.

I think we'll want all these links to be filled out in all these browser cards, yeah? Just like the [password manager section](https://www.privacytools.io/software/passwords/#pw).
blacklight447 commented 2019-09-03 09:05:58 +00:00 (Migrated from github.com)
Review

I added all the links. there is one thing I haven't made up my mind about yet: Bromite.
its not the on google play, so we need to link to either their Github release page, or the page where they describe their f-droid repo. While the Github might be easier as people can directly download it, they will not be prompted of new updates, which is a security risk. what do you think? For now, I linked to their f-droid page.

I added all the links. there is one thing I haven't made up my mind about yet: Bromite. its not the on google play, so we need to link to either their Github release page, or the page where they describe their f-droid repo. While the Github might be easier as people can directly download it, they will not be prompted of new updates, which is a security risk. what do you think? For now, I linked to their f-droid page.
blacklight447 commented 2019-09-03 09:05:58 +00:00 (Migrated from github.com)
Review

I added all the links. there is one thing I haven't made up my mind about yet: Bromite.
its not the on google play, so we need to link to either their Github release page, or the page where they describe their f-droid repo. While the Github might be easier as people can directly download it, they will not be prompted of new updates, which is a security risk. what do you think? For now, I linked to their f-droid page.

I added all the links. there is one thing I haven't made up my mind about yet: Bromite. its not the on google play, so we need to link to either their Github release page, or the page where they describe their f-droid repo. While the Github might be easier as people can directly download it, they will not be prompted of new updates, which is a security risk. what do you think? For now, I linked to their f-droid page.
Mikaela commented 2019-09-03 15:36:19 +00:00 (Migrated from github.com)
Review

I prefer F-Droid.

I prefer F-Droid.
Mikaela commented 2019-09-03 15:36:19 +00:00 (Migrated from github.com)
Review

I prefer F-Droid.

I prefer F-Droid.
blacklight447 commented 2019-09-04 22:04:29 +00:00 (Migrated from github.com)
Review

Im not sure on this one, @dawidpotocki mentioned its called Firefox browser now, but im personally also fine with either Mozilla Firefox or just Firefox.

Im not sure on this one, @dawidpotocki mentioned its called Firefox browser now, but im personally also fine with either Mozilla Firefox or just Firefox.
blacklight447 commented 2019-09-04 22:04:29 +00:00 (Migrated from github.com)
Review

Im not sure on this one, @dawidpotocki mentioned its called Firefox browser now, but im personally also fine with either Mozilla Firefox or just Firefox.

Im not sure on this one, @dawidpotocki mentioned its called Firefox browser now, but im personally also fine with either Mozilla Firefox or just Firefox.
Review

I haven't found any references to "Firefox Browser" besides the Play Store listing on Android, and even then the app itself is simply "Firefox". And their new websites are all simply "Firefox".

Since we're in the browser section I don't think it's necessary to include the "Browser" part even if it is official. Just redundant.

I haven't found any references to "Firefox Browser" besides the Play Store listing on Android, and even then the app itself is simply "Firefox". And their new websites are all simply "Firefox". Since we're in the browser section I don't think it's necessary to include the "Browser" part even if it is official. Just redundant.
Review

I haven't found any references to "Firefox Browser" besides the Play Store listing on Android, and even then the app itself is simply "Firefox". And their new websites are all simply "Firefox".

Since we're in the browser section I don't think it's necessary to include the "Browser" part even if it is official. Just redundant.

I haven't found any references to "Firefox Browser" besides the Play Store listing on Android, and even then the app itself is simply "Firefox". And their new websites are all simply "Firefox". Since we're in the browser section I don't think it's necessary to include the "Browser" part even if it is official. Just redundant.
blacklight447 commented 2019-09-04 22:24:40 +00:00 (Migrated from github.com)
Review

Shall we go with just "Firefox" then?

Shall we go with just "Firefox" then?
blacklight447 commented 2019-09-04 22:24:40 +00:00 (Migrated from github.com)
Review

Shall we go with just "Firefox" then?

Shall we go with just "Firefox" then?
blacklight447 commented 2019-09-06 10:07:47 +00:00 (Migrated from github.com)
Review

The name is now changed to just "Firefox".

The name is now changed to just "Firefox".
blacklight447 commented 2019-09-06 10:07:47 +00:00 (Migrated from github.com)
Review

The name is now changed to just "Firefox".

The name is now changed to just "Firefox".
dawidpotocki commented 2019-09-11 23:30:00 +00:00 (Migrated from github.com)
Review

Remove en-US/, not everyone is a native English speaker.

Remove `en-US`/, not everyone is a native English speaker.
dawidpotocki commented 2019-09-11 23:30:00 +00:00 (Migrated from github.com)
Review

Remove en-US/, not everyone is a native English speaker.

Remove `en-US`/, not everyone is a native English speaker.
dawidpotocki commented 2019-09-11 23:45:14 +00:00 (Migrated from github.com)
Review
description='Firefox is fast, reliable, open source and respects your privacy. Don\'t forget to adjust the settings according to our
```suggestion description='Firefox is fast, reliable, open source and respects your privacy. Don\'t forget to adjust the settings according to our ```
dawidpotocki commented 2019-09-11 23:45:14 +00:00 (Migrated from github.com)
Review
description='Firefox is fast, reliable, open source and respects your privacy. Don\'t forget to adjust the settings according to our
```suggestion description='Firefox is fast, reliable, open source and respects your privacy. Don\'t forget to adjust the settings according to our ```
dawidpotocki commented 2019-09-11 23:46:20 +00:00 (Migrated from github.com)
Review
recommendations: <a href="#webrtc"><i class="fas fa-link"></i> WebRTC</a> and <a href="#about_config"><i class="fas fa-link"></i> about:config</a> and get the <a href="#addons"><i class="fas fa-link"></i> privacy add-ons</a>.'
```suggestion recommendations: <a href="#webrtc"><i class="fas fa-link"></i> WebRTC</a> and <a href="#about_config"><i class="fas fa-link"></i> about:config</a> and get the <a href="#addons"><i class="fas fa-link"></i> privacy add-ons</a>.' ```
dawidpotocki commented 2019-09-11 23:46:20 +00:00 (Migrated from github.com)
Review
recommendations: <a href="#webrtc"><i class="fas fa-link"></i> WebRTC</a> and <a href="#about_config"><i class="fas fa-link"></i> about:config</a> and get the <a href="#addons"><i class="fas fa-link"></i> privacy add-ons</a>.'
```suggestion recommendations: <a href="#webrtc"><i class="fas fa-link"></i> WebRTC</a> and <a href="#about_config"><i class="fas fa-link"></i> about:config</a> and get the <a href="#addons"><i class="fas fa-link"></i> privacy add-ons</a>.' ```
dawidpotocki commented 2019-09-12 06:33:11 +00:00 (Migrated from github.com)
Review

What is that ' doing here

What is that `'` doing here
dawidpotocki commented 2019-09-12 06:33:11 +00:00 (Migrated from github.com)
Review

What is that ' doing here

What is that `'` doing here
blacklight447 commented 2019-09-12 06:36:09 +00:00 (Migrated from github.com)
Review

Thats me trying stuff to fix the build, after i made on of your suggested commits, the build broke, netlify also indicates that here is something wrong with the Firefox section, I am still trying to figure out whats wrong exactly.

Thats me trying stuff to fix the build, after i made on of your suggested commits, the build broke, netlify also indicates that here is something wrong with the Firefox section, I am still trying to figure out whats wrong exactly.
blacklight447 commented 2019-09-12 06:36:09 +00:00 (Migrated from github.com)
Review

Thats me trying stuff to fix the build, after i made on of your suggested commits, the build broke, netlify also indicates that here is something wrong with the Firefox section, I am still trying to figure out whats wrong exactly.

Thats me trying stuff to fix the build, after i made on of your suggested commits, the build broke, netlify also indicates that here is something wrong with the Firefox section, I am still trying to figure out whats wrong exactly.
dawidpotocki commented 2019-09-12 06:41:56 +00:00 (Migrated from github.com)
Review
Can you look at the https://github.com/privacytoolsIO/privacytools.io/pull/1256/files#r323505120, eh.
dawidpotocki commented 2019-09-12 06:41:56 +00:00 (Migrated from github.com)
Review
Can you look at the https://github.com/privacytoolsIO/privacytools.io/pull/1256/files#r323505120, eh.