[WIP] Browser overhaul. Browser section. #1256

Merged
blacklight447 merged 44 commits from blacklight447-ptio-patch-1 into master 2019-09-12 14:13:11 +00:00
1 changed files with 6 additions and 6 deletions
Showing only changes of commit 19d2cda52b - Show all commits

View File

@ -6,8 +6,8 @@
dawidpotocki commented 2019-09-01 10:49:52 +00:00 (Migrated from github.com)
Review
Change "Mozilla Firefox" to "Firefox Browser", that's how they name it now. https://github.com/privacytoolsIO/privacytools.io/blob/7022e125b9d9a14173437d2898fdbd80fa261417/_includes/sections/browser-recommendation.html#L36 https://github.com/privacytoolsIO/privacytools.io/blob/7022e125b9d9a14173437d2898fdbd80fa261417/_includes/sections/browser-recommendation.html#L83 ![image](https://user-images.githubusercontent.com/38681822/64075295-0a3e4000-cca6-11e9-9119-ac6479733a9d.png)
dawidpotocki commented 2019-09-01 10:49:52 +00:00 (Migrated from github.com)
Review
Change "Mozilla Firefox" to "Firefox Browser", that's how they name it now. https://github.com/privacytoolsIO/privacytools.io/blob/7022e125b9d9a14173437d2898fdbd80fa261417/_includes/sections/browser-recommendation.html#L36 https://github.com/privacytoolsIO/privacytools.io/blob/7022e125b9d9a14173437d2898fdbd80fa261417/_includes/sections/browser-recommendation.html#L83 ![image](https://user-images.githubusercontent.com/38681822/64075295-0a3e4000-cca6-11e9-9119-ac6479733a9d.png)
blacklight447 commented 2019-09-01 10:54:02 +00:00 (Migrated from github.com)
Review

Are you sure that's not only the case with the aurora version?

Are you sure that's not only the case with the aurora version?
blacklight447 commented 2019-09-01 10:54:02 +00:00 (Migrated from github.com)
Review

Are you sure that's not only the case with the aurora version?

Are you sure that's not only the case with the aurora version?
dawidpotocki commented 2019-09-01 10:59:41 +00:00 (Migrated from github.com)
Review

Yes. I'm sure.

image
image
image
image

Yes. I'm sure. ![image](https://user-images.githubusercontent.com/38681822/64075399-4920c580-cca7-11e9-93a7-8bbffbd7395a.png) ![image](https://user-images.githubusercontent.com/38681822/64075401-563db480-cca7-11e9-9108-c7fbca0e05b7.png) ![image](https://user-images.githubusercontent.com/38681822/64075415-84bb8f80-cca7-11e9-8e9b-4c36aa1fe8e1.png) ![image](https://user-images.githubusercontent.com/38681822/64075390-2abaca00-cca7-11e9-9a91-8961df28ca85.png)
dawidpotocki commented 2019-09-01 10:59:41 +00:00 (Migrated from github.com)
Review

Yes. I'm sure.

image
image
image
image

Yes. I'm sure. ![image](https://user-images.githubusercontent.com/38681822/64075399-4920c580-cca7-11e9-93a7-8bbffbd7395a.png) ![image](https://user-images.githubusercontent.com/38681822/64075401-563db480-cca7-11e9-9108-c7fbca0e05b7.png) ![image](https://user-images.githubusercontent.com/38681822/64075415-84bb8f80-cca7-11e9-8e9b-4c36aa1fe8e1.png) ![image](https://user-images.githubusercontent.com/38681822/64075390-2abaca00-cca7-11e9-9a91-8961df28ca85.png)
nitrohorse commented 2019-09-01 16:13:20 +00:00 (Migrated from github.com)
Review

I think we'll want all these links to be filled out in all these browser cards, yeah? Just like the password manager section.

I think we'll want all these links to be filled out in all these browser cards, yeah? Just like the [password manager section](https://www.privacytools.io/software/passwords/#pw).
nitrohorse commented 2019-09-01 16:13:20 +00:00 (Migrated from github.com)
Review

I think we'll want all these links to be filled out in all these browser cards, yeah? Just like the password manager section.

I think we'll want all these links to be filled out in all these browser cards, yeah? Just like the [password manager section](https://www.privacytools.io/software/passwords/#pw).
blacklight447 commented 2019-09-03 09:05:58 +00:00 (Migrated from github.com)
Review

I added all the links. there is one thing I haven't made up my mind about yet: Bromite.
its not the on google play, so we need to link to either their Github release page, or the page where they describe their f-droid repo. While the Github might be easier as people can directly download it, they will not be prompted of new updates, which is a security risk. what do you think? For now, I linked to their f-droid page.

I added all the links. there is one thing I haven't made up my mind about yet: Bromite. its not the on google play, so we need to link to either their Github release page, or the page where they describe their f-droid repo. While the Github might be easier as people can directly download it, they will not be prompted of new updates, which is a security risk. what do you think? For now, I linked to their f-droid page.
blacklight447 commented 2019-09-03 09:05:58 +00:00 (Migrated from github.com)
Review

I added all the links. there is one thing I haven't made up my mind about yet: Bromite.
its not the on google play, so we need to link to either their Github release page, or the page where they describe their f-droid repo. While the Github might be easier as people can directly download it, they will not be prompted of new updates, which is a security risk. what do you think? For now, I linked to their f-droid page.

I added all the links. there is one thing I haven't made up my mind about yet: Bromite. its not the on google play, so we need to link to either their Github release page, or the page where they describe their f-droid repo. While the Github might be easier as people can directly download it, they will not be prompted of new updates, which is a security risk. what do you think? For now, I linked to their f-droid page.
Mikaela commented 2019-09-03 15:36:19 +00:00 (Migrated from github.com)
Review

I prefer F-Droid.

I prefer F-Droid.
Mikaela commented 2019-09-03 15:36:19 +00:00 (Migrated from github.com)
Review

I prefer F-Droid.

I prefer F-Droid.
blacklight447 commented 2019-09-04 22:04:29 +00:00 (Migrated from github.com)
Review

Im not sure on this one, @dawidpotocki mentioned its called Firefox browser now, but im personally also fine with either Mozilla Firefox or just Firefox.

Im not sure on this one, @dawidpotocki mentioned its called Firefox browser now, but im personally also fine with either Mozilla Firefox or just Firefox.
blacklight447 commented 2019-09-04 22:04:29 +00:00 (Migrated from github.com)
Review

Im not sure on this one, @dawidpotocki mentioned its called Firefox browser now, but im personally also fine with either Mozilla Firefox or just Firefox.

Im not sure on this one, @dawidpotocki mentioned its called Firefox browser now, but im personally also fine with either Mozilla Firefox or just Firefox.
Review

I haven't found any references to "Firefox Browser" besides the Play Store listing on Android, and even then the app itself is simply "Firefox". And their new websites are all simply "Firefox".

Since we're in the browser section I don't think it's necessary to include the "Browser" part even if it is official. Just redundant.

I haven't found any references to "Firefox Browser" besides the Play Store listing on Android, and even then the app itself is simply "Firefox". And their new websites are all simply "Firefox". Since we're in the browser section I don't think it's necessary to include the "Browser" part even if it is official. Just redundant.
Review

I haven't found any references to "Firefox Browser" besides the Play Store listing on Android, and even then the app itself is simply "Firefox". And their new websites are all simply "Firefox".

Since we're in the browser section I don't think it's necessary to include the "Browser" part even if it is official. Just redundant.

I haven't found any references to "Firefox Browser" besides the Play Store listing on Android, and even then the app itself is simply "Firefox". And their new websites are all simply "Firefox". Since we're in the browser section I don't think it's necessary to include the "Browser" part even if it is official. Just redundant.
blacklight447 commented 2019-09-04 22:24:40 +00:00 (Migrated from github.com)
Review

Shall we go with just "Firefox" then?

Shall we go with just "Firefox" then?
blacklight447 commented 2019-09-04 22:24:40 +00:00 (Migrated from github.com)
Review

Shall we go with just "Firefox" then?

Shall we go with just "Firefox" then?
blacklight447 commented 2019-09-06 10:07:47 +00:00 (Migrated from github.com)
Review

The name is now changed to just "Firefox".

The name is now changed to just "Firefox".
blacklight447 commented 2019-09-06 10:07:47 +00:00 (Migrated from github.com)
Review

The name is now changed to just "Firefox".

The name is now changed to just "Firefox".
dawidpotocki commented 2019-09-11 23:30:00 +00:00 (Migrated from github.com)
Review

Remove en-US/, not everyone is a native English speaker.

Remove `en-US`/, not everyone is a native English speaker.
dawidpotocki commented 2019-09-11 23:30:00 +00:00 (Migrated from github.com)
Review

Remove en-US/, not everyone is a native English speaker.

Remove `en-US`/, not everyone is a native English speaker.
dawidpotocki commented 2019-09-11 23:45:14 +00:00 (Migrated from github.com)
Review
description='Firefox is fast, reliable, open source and respects your privacy. Don\'t forget to adjust the settings according to our
```suggestion description='Firefox is fast, reliable, open source and respects your privacy. Don\'t forget to adjust the settings according to our ```
dawidpotocki commented 2019-09-11 23:45:14 +00:00 (Migrated from github.com)
Review
description='Firefox is fast, reliable, open source and respects your privacy. Don\'t forget to adjust the settings according to our
```suggestion description='Firefox is fast, reliable, open source and respects your privacy. Don\'t forget to adjust the settings according to our ```
dawidpotocki commented 2019-09-11 23:46:20 +00:00 (Migrated from github.com)
Review
recommendations: <a href="#webrtc"><i class="fas fa-link"></i> WebRTC</a> and <a href="#about_config"><i class="fas fa-link"></i> about:config</a> and get the <a href="#addons"><i class="fas fa-link"></i> privacy add-ons</a>.'
```suggestion recommendations: <a href="#webrtc"><i class="fas fa-link"></i> WebRTC</a> and <a href="#about_config"><i class="fas fa-link"></i> about:config</a> and get the <a href="#addons"><i class="fas fa-link"></i> privacy add-ons</a>.' ```
dawidpotocki commented 2019-09-11 23:46:20 +00:00 (Migrated from github.com)
Review
recommendations: <a href="#webrtc"><i class="fas fa-link"></i> WebRTC</a> and <a href="#about_config"><i class="fas fa-link"></i> about:config</a> and get the <a href="#addons"><i class="fas fa-link"></i> privacy add-ons</a>.'
```suggestion recommendations: <a href="#webrtc"><i class="fas fa-link"></i> WebRTC</a> and <a href="#about_config"><i class="fas fa-link"></i> about:config</a> and get the <a href="#addons"><i class="fas fa-link"></i> privacy add-ons</a>.' ```
dawidpotocki commented 2019-09-12 06:33:11 +00:00 (Migrated from github.com)
Review

What is that ' doing here

What is that `'` doing here
dawidpotocki commented 2019-09-12 06:33:11 +00:00 (Migrated from github.com)
Review

What is that ' doing here

What is that `'` doing here
blacklight447 commented 2019-09-12 06:36:09 +00:00 (Migrated from github.com)
Review

Thats me trying stuff to fix the build, after i made on of your suggested commits, the build broke, netlify also indicates that here is something wrong with the Firefox section, I am still trying to figure out whats wrong exactly.

Thats me trying stuff to fix the build, after i made on of your suggested commits, the build broke, netlify also indicates that here is something wrong with the Firefox section, I am still trying to figure out whats wrong exactly.
blacklight447 commented 2019-09-12 06:36:09 +00:00 (Migrated from github.com)
Review

Thats me trying stuff to fix the build, after i made on of your suggested commits, the build broke, netlify also indicates that here is something wrong with the Firefox section, I am still trying to figure out whats wrong exactly.

Thats me trying stuff to fix the build, after i made on of your suggested commits, the build broke, netlify also indicates that here is something wrong with the Firefox section, I am still trying to figure out whats wrong exactly.
dawidpotocki commented 2019-09-12 06:41:56 +00:00 (Migrated from github.com)
Review
Can you look at the https://github.com/privacytoolsIO/privacytools.io/pull/1256/files#r323505120, eh.
dawidpotocki commented 2019-09-12 06:41:56 +00:00 (Migrated from github.com)
Review
Can you look at the https://github.com/privacytoolsIO/privacytools.io/pull/1256/files#r323505120, eh.
{% include cardv2.html
title="Firefox"
image="/assets/img/tools/Firefox.png"
description='Firefox is fast, reliable, open source and respects your privacy. Don\'t forget to adjust the settings according to our
dawidpotocki commented 2019-09-01 10:49:52 +00:00 (Migrated from github.com)
Review
Change "Mozilla Firefox" to "Firefox Browser", that's how they name it now. https://github.com/privacytoolsIO/privacytools.io/blob/7022e125b9d9a14173437d2898fdbd80fa261417/_includes/sections/browser-recommendation.html#L36 https://github.com/privacytoolsIO/privacytools.io/blob/7022e125b9d9a14173437d2898fdbd80fa261417/_includes/sections/browser-recommendation.html#L83 ![image](https://user-images.githubusercontent.com/38681822/64075295-0a3e4000-cca6-11e9-9119-ac6479733a9d.png)
blacklight447 commented 2019-09-01 10:54:02 +00:00 (Migrated from github.com)
Review

Are you sure that's not only the case with the aurora version?

Are you sure that's not only the case with the aurora version?
dawidpotocki commented 2019-09-01 10:59:41 +00:00 (Migrated from github.com)
Review

Yes. I'm sure.

image
image
image
image

Yes. I'm sure. ![image](https://user-images.githubusercontent.com/38681822/64075399-4920c580-cca7-11e9-93a7-8bbffbd7395a.png) ![image](https://user-images.githubusercontent.com/38681822/64075401-563db480-cca7-11e9-9108-c7fbca0e05b7.png) ![image](https://user-images.githubusercontent.com/38681822/64075415-84bb8f80-cca7-11e9-8e9b-4c36aa1fe8e1.png) ![image](https://user-images.githubusercontent.com/38681822/64075390-2abaca00-cca7-11e9-9a91-8961df28ca85.png)
nitrohorse commented 2019-09-01 16:13:20 +00:00 (Migrated from github.com)
Review

I think we'll want all these links to be filled out in all these browser cards, yeah? Just like the password manager section.

I think we'll want all these links to be filled out in all these browser cards, yeah? Just like the [password manager section](https://www.privacytools.io/software/passwords/#pw).
blacklight447 commented 2019-09-03 09:05:58 +00:00 (Migrated from github.com)
Review

I added all the links. there is one thing I haven't made up my mind about yet: Bromite.
its not the on google play, so we need to link to either their Github release page, or the page where they describe their f-droid repo. While the Github might be easier as people can directly download it, they will not be prompted of new updates, which is a security risk. what do you think? For now, I linked to their f-droid page.

I added all the links. there is one thing I haven't made up my mind about yet: Bromite. its not the on google play, so we need to link to either their Github release page, or the page where they describe their f-droid repo. While the Github might be easier as people can directly download it, they will not be prompted of new updates, which is a security risk. what do you think? For now, I linked to their f-droid page.
Mikaela commented 2019-09-03 15:36:19 +00:00 (Migrated from github.com)
Review

I prefer F-Droid.

I prefer F-Droid.
blacklight447 commented 2019-09-04 22:04:29 +00:00 (Migrated from github.com)
Review

Im not sure on this one, @dawidpotocki mentioned its called Firefox browser now, but im personally also fine with either Mozilla Firefox or just Firefox.

Im not sure on this one, @dawidpotocki mentioned its called Firefox browser now, but im personally also fine with either Mozilla Firefox or just Firefox.
Review

I haven't found any references to "Firefox Browser" besides the Play Store listing on Android, and even then the app itself is simply "Firefox". And their new websites are all simply "Firefox".

Since we're in the browser section I don't think it's necessary to include the "Browser" part even if it is official. Just redundant.

I haven't found any references to "Firefox Browser" besides the Play Store listing on Android, and even then the app itself is simply "Firefox". And their new websites are all simply "Firefox". Since we're in the browser section I don't think it's necessary to include the "Browser" part even if it is official. Just redundant.
blacklight447 commented 2019-09-04 22:24:40 +00:00 (Migrated from github.com)
Review

Shall we go with just "Firefox" then?

Shall we go with just "Firefox" then?
blacklight447 commented 2019-09-06 10:07:47 +00:00 (Migrated from github.com)
Review

The name is now changed to just "Firefox".

The name is now changed to just "Firefox".
dawidpotocki commented 2019-09-11 23:30:00 +00:00 (Migrated from github.com)
Review

Remove en-US/, not everyone is a native English speaker.

Remove `en-US`/, not everyone is a native English speaker.
dawidpotocki commented 2019-09-11 23:45:14 +00:00 (Migrated from github.com)
Review
description='Firefox is fast, reliable, open source and respects your privacy. Don\'t forget to adjust the settings according to our
```suggestion description='Firefox is fast, reliable, open source and respects your privacy. Don\'t forget to adjust the settings according to our ```
dawidpotocki commented 2019-09-11 23:46:20 +00:00 (Migrated from github.com)
Review
recommendations: <a href="#webrtc"><i class="fas fa-link"></i> WebRTC</a> and <a href="#about_config"><i class="fas fa-link"></i> about:config</a> and get the <a href="#addons"><i class="fas fa-link"></i> privacy add-ons</a>.'
```suggestion recommendations: <a href="#webrtc"><i class="fas fa-link"></i> WebRTC</a> and <a href="#about_config"><i class="fas fa-link"></i> about:config</a> and get the <a href="#addons"><i class="fas fa-link"></i> privacy add-ons</a>.' ```
dawidpotocki commented 2019-09-12 06:33:11 +00:00 (Migrated from github.com)
Review

What is that ' doing here

What is that `'` doing here
blacklight447 commented 2019-09-12 06:36:09 +00:00 (Migrated from github.com)
Review

Thats me trying stuff to fix the build, after i made on of your suggested commits, the build broke, netlify also indicates that here is something wrong with the Firefox section, I am still trying to figure out whats wrong exactly.

Thats me trying stuff to fix the build, after i made on of your suggested commits, the build broke, netlify also indicates that here is something wrong with the Firefox section, I am still trying to figure out whats wrong exactly.
dawidpotocki commented 2019-09-12 06:41:56 +00:00 (Migrated from github.com)
Review
Can you look at the https://github.com/privacytoolsIO/privacytools.io/pull/1256/files#r323505120, eh.
recommendations: <a href="#webrtc"><i class="fas fa-link"></i> WebRTC</a> and <a href="#about_config"><i class="fas fa-link"></i> about:config</a> and get the <a href="#addons"><i class="fas fa-link"></i> privacy add-ons</a>.'
dawidpotocki commented 2019-09-01 10:49:52 +00:00 (Migrated from github.com)
Review
Change "Mozilla Firefox" to "Firefox Browser", that's how they name it now. https://github.com/privacytoolsIO/privacytools.io/blob/7022e125b9d9a14173437d2898fdbd80fa261417/_includes/sections/browser-recommendation.html#L36 https://github.com/privacytoolsIO/privacytools.io/blob/7022e125b9d9a14173437d2898fdbd80fa261417/_includes/sections/browser-recommendation.html#L83 ![image](https://user-images.githubusercontent.com/38681822/64075295-0a3e4000-cca6-11e9-9119-ac6479733a9d.png)
blacklight447 commented 2019-09-01 10:54:02 +00:00 (Migrated from github.com)
Review

Are you sure that's not only the case with the aurora version?

Are you sure that's not only the case with the aurora version?
dawidpotocki commented 2019-09-01 10:59:41 +00:00 (Migrated from github.com)
Review

Yes. I'm sure.

image
image
image
image

Yes. I'm sure. ![image](https://user-images.githubusercontent.com/38681822/64075399-4920c580-cca7-11e9-93a7-8bbffbd7395a.png) ![image](https://user-images.githubusercontent.com/38681822/64075401-563db480-cca7-11e9-9108-c7fbca0e05b7.png) ![image](https://user-images.githubusercontent.com/38681822/64075415-84bb8f80-cca7-11e9-8e9b-4c36aa1fe8e1.png) ![image](https://user-images.githubusercontent.com/38681822/64075390-2abaca00-cca7-11e9-9a91-8961df28ca85.png)
nitrohorse commented 2019-09-01 16:13:20 +00:00 (Migrated from github.com)
Review

I think we'll want all these links to be filled out in all these browser cards, yeah? Just like the password manager section.

I think we'll want all these links to be filled out in all these browser cards, yeah? Just like the [password manager section](https://www.privacytools.io/software/passwords/#pw).
blacklight447 commented 2019-09-03 09:05:58 +00:00 (Migrated from github.com)
Review

I added all the links. there is one thing I haven't made up my mind about yet: Bromite.
its not the on google play, so we need to link to either their Github release page, or the page where they describe their f-droid repo. While the Github might be easier as people can directly download it, they will not be prompted of new updates, which is a security risk. what do you think? For now, I linked to their f-droid page.

I added all the links. there is one thing I haven't made up my mind about yet: Bromite. its not the on google play, so we need to link to either their Github release page, or the page where they describe their f-droid repo. While the Github might be easier as people can directly download it, they will not be prompted of new updates, which is a security risk. what do you think? For now, I linked to their f-droid page.
Mikaela commented 2019-09-03 15:36:19 +00:00 (Migrated from github.com)
Review

I prefer F-Droid.

I prefer F-Droid.
blacklight447 commented 2019-09-04 22:04:29 +00:00 (Migrated from github.com)
Review

Im not sure on this one, @dawidpotocki mentioned its called Firefox browser now, but im personally also fine with either Mozilla Firefox or just Firefox.

Im not sure on this one, @dawidpotocki mentioned its called Firefox browser now, but im personally also fine with either Mozilla Firefox or just Firefox.
Review

I haven't found any references to "Firefox Browser" besides the Play Store listing on Android, and even then the app itself is simply "Firefox". And their new websites are all simply "Firefox".

Since we're in the browser section I don't think it's necessary to include the "Browser" part even if it is official. Just redundant.

I haven't found any references to "Firefox Browser" besides the Play Store listing on Android, and even then the app itself is simply "Firefox". And their new websites are all simply "Firefox". Since we're in the browser section I don't think it's necessary to include the "Browser" part even if it is official. Just redundant.
blacklight447 commented 2019-09-04 22:24:40 +00:00 (Migrated from github.com)
Review

Shall we go with just "Firefox" then?

Shall we go with just "Firefox" then?
blacklight447 commented 2019-09-06 10:07:47 +00:00 (Migrated from github.com)
Review

The name is now changed to just "Firefox".

The name is now changed to just "Firefox".
dawidpotocki commented 2019-09-11 23:30:00 +00:00 (Migrated from github.com)
Review

Remove en-US/, not everyone is a native English speaker.

Remove `en-US`/, not everyone is a native English speaker.
dawidpotocki commented 2019-09-11 23:45:14 +00:00 (Migrated from github.com)
Review
description='Firefox is fast, reliable, open source and respects your privacy. Don\'t forget to adjust the settings according to our
```suggestion description='Firefox is fast, reliable, open source and respects your privacy. Don\'t forget to adjust the settings according to our ```
dawidpotocki commented 2019-09-11 23:46:20 +00:00 (Migrated from github.com)
Review
recommendations: <a href="#webrtc"><i class="fas fa-link"></i> WebRTC</a> and <a href="#about_config"><i class="fas fa-link"></i> about:config</a> and get the <a href="#addons"><i class="fas fa-link"></i> privacy add-ons</a>.'
```suggestion recommendations: <a href="#webrtc"><i class="fas fa-link"></i> WebRTC</a> and <a href="#about_config"><i class="fas fa-link"></i> about:config</a> and get the <a href="#addons"><i class="fas fa-link"></i> privacy add-ons</a>.' ```
dawidpotocki commented 2019-09-12 06:33:11 +00:00 (Migrated from github.com)
Review

What is that ' doing here

What is that `'` doing here
blacklight447 commented 2019-09-12 06:36:09 +00:00 (Migrated from github.com)
Review

Thats me trying stuff to fix the build, after i made on of your suggested commits, the build broke, netlify also indicates that here is something wrong with the Firefox section, I am still trying to figure out whats wrong exactly.

Thats me trying stuff to fix the build, after i made on of your suggested commits, the build broke, netlify also indicates that here is something wrong with the Firefox section, I am still trying to figure out whats wrong exactly.
dawidpotocki commented 2019-09-12 06:41:56 +00:00 (Migrated from github.com)
Review
Can you look at the https://github.com/privacytoolsIO/privacytools.io/pull/1256/files#r323505120, eh.
description="Firefox is fast, reliable, open source and respects your privacy. Don\'t forget to adjust the settings according to our
dawidpotocki commented 2019-09-01 10:49:52 +00:00 (Migrated from github.com)
Review
Change "Mozilla Firefox" to "Firefox Browser", that's how they name it now. https://github.com/privacytoolsIO/privacytools.io/blob/7022e125b9d9a14173437d2898fdbd80fa261417/_includes/sections/browser-recommendation.html#L36 https://github.com/privacytoolsIO/privacytools.io/blob/7022e125b9d9a14173437d2898fdbd80fa261417/_includes/sections/browser-recommendation.html#L83 ![image](https://user-images.githubusercontent.com/38681822/64075295-0a3e4000-cca6-11e9-9119-ac6479733a9d.png)
blacklight447 commented 2019-09-01 10:54:02 +00:00 (Migrated from github.com)
Review

Are you sure that's not only the case with the aurora version?

Are you sure that's not only the case with the aurora version?
dawidpotocki commented 2019-09-01 10:59:41 +00:00 (Migrated from github.com)
Review

Yes. I'm sure.

image
image
image
image

Yes. I'm sure. ![image](https://user-images.githubusercontent.com/38681822/64075399-4920c580-cca7-11e9-93a7-8bbffbd7395a.png) ![image](https://user-images.githubusercontent.com/38681822/64075401-563db480-cca7-11e9-9108-c7fbca0e05b7.png) ![image](https://user-images.githubusercontent.com/38681822/64075415-84bb8f80-cca7-11e9-8e9b-4c36aa1fe8e1.png) ![image](https://user-images.githubusercontent.com/38681822/64075390-2abaca00-cca7-11e9-9a91-8961df28ca85.png)
nitrohorse commented 2019-09-01 16:13:20 +00:00 (Migrated from github.com)
Review

I think we'll want all these links to be filled out in all these browser cards, yeah? Just like the password manager section.

I think we'll want all these links to be filled out in all these browser cards, yeah? Just like the [password manager section](https://www.privacytools.io/software/passwords/#pw).
blacklight447 commented 2019-09-03 09:05:58 +00:00 (Migrated from github.com)
Review

I added all the links. there is one thing I haven't made up my mind about yet: Bromite.
its not the on google play, so we need to link to either their Github release page, or the page where they describe their f-droid repo. While the Github might be easier as people can directly download it, they will not be prompted of new updates, which is a security risk. what do you think? For now, I linked to their f-droid page.

I added all the links. there is one thing I haven't made up my mind about yet: Bromite. its not the on google play, so we need to link to either their Github release page, or the page where they describe their f-droid repo. While the Github might be easier as people can directly download it, they will not be prompted of new updates, which is a security risk. what do you think? For now, I linked to their f-droid page.
Mikaela commented 2019-09-03 15:36:19 +00:00 (Migrated from github.com)
Review

I prefer F-Droid.

I prefer F-Droid.
blacklight447 commented 2019-09-04 22:04:29 +00:00 (Migrated from github.com)
Review

Im not sure on this one, @dawidpotocki mentioned its called Firefox browser now, but im personally also fine with either Mozilla Firefox or just Firefox.

Im not sure on this one, @dawidpotocki mentioned its called Firefox browser now, but im personally also fine with either Mozilla Firefox or just Firefox.
Review

I haven't found any references to "Firefox Browser" besides the Play Store listing on Android, and even then the app itself is simply "Firefox". And their new websites are all simply "Firefox".

Since we're in the browser section I don't think it's necessary to include the "Browser" part even if it is official. Just redundant.

I haven't found any references to "Firefox Browser" besides the Play Store listing on Android, and even then the app itself is simply "Firefox". And their new websites are all simply "Firefox". Since we're in the browser section I don't think it's necessary to include the "Browser" part even if it is official. Just redundant.
blacklight447 commented 2019-09-04 22:24:40 +00:00 (Migrated from github.com)
Review

Shall we go with just "Firefox" then?

Shall we go with just "Firefox" then?
blacklight447 commented 2019-09-06 10:07:47 +00:00 (Migrated from github.com)
Review

The name is now changed to just "Firefox".

The name is now changed to just "Firefox".
dawidpotocki commented 2019-09-11 23:30:00 +00:00 (Migrated from github.com)
Review

Remove en-US/, not everyone is a native English speaker.

Remove `en-US`/, not everyone is a native English speaker.
dawidpotocki commented 2019-09-11 23:45:14 +00:00 (Migrated from github.com)
Review
description='Firefox is fast, reliable, open source and respects your privacy. Don\'t forget to adjust the settings according to our
```suggestion description='Firefox is fast, reliable, open source and respects your privacy. Don\'t forget to adjust the settings according to our ```
dawidpotocki commented 2019-09-11 23:46:20 +00:00 (Migrated from github.com)
Review
recommendations: <a href="#webrtc"><i class="fas fa-link"></i> WebRTC</a> and <a href="#about_config"><i class="fas fa-link"></i> about:config</a> and get the <a href="#addons"><i class="fas fa-link"></i> privacy add-ons</a>.'
```suggestion recommendations: <a href="#webrtc"><i class="fas fa-link"></i> WebRTC</a> and <a href="#about_config"><i class="fas fa-link"></i> about:config</a> and get the <a href="#addons"><i class="fas fa-link"></i> privacy add-ons</a>.' ```
dawidpotocki commented 2019-09-12 06:33:11 +00:00 (Migrated from github.com)
Review

What is that ' doing here

What is that `'` doing here
blacklight447 commented 2019-09-12 06:36:09 +00:00 (Migrated from github.com)
Review

Thats me trying stuff to fix the build, after i made on of your suggested commits, the build broke, netlify also indicates that here is something wrong with the Firefox section, I am still trying to figure out whats wrong exactly.

Thats me trying stuff to fix the build, after i made on of your suggested commits, the build broke, netlify also indicates that here is something wrong with the Firefox section, I am still trying to figure out whats wrong exactly.
dawidpotocki commented 2019-09-12 06:41:56 +00:00 (Migrated from github.com)
Review
Can you look at the https://github.com/privacytoolsIO/privacytools.io/pull/1256/files#r323505120, eh.
recommendations: <a href="#webrtc"><i class="fas fa-link"></i> WebRTC</a> and <a href="#about_config"><i class="fas fa-link"></i> about:config</a> and get the <a href="#addons"><i class="fas fa-link"></i> privacy add-ons</a>."
dawidpotocki commented 2019-09-01 10:49:52 +00:00 (Migrated from github.com)
Review
Change "Mozilla Firefox" to "Firefox Browser", that's how they name it now. https://github.com/privacytoolsIO/privacytools.io/blob/7022e125b9d9a14173437d2898fdbd80fa261417/_includes/sections/browser-recommendation.html#L36 https://github.com/privacytoolsIO/privacytools.io/blob/7022e125b9d9a14173437d2898fdbd80fa261417/_includes/sections/browser-recommendation.html#L83 ![image](https://user-images.githubusercontent.com/38681822/64075295-0a3e4000-cca6-11e9-9119-ac6479733a9d.png)
blacklight447 commented 2019-09-01 10:54:02 +00:00 (Migrated from github.com)
Review

Are you sure that's not only the case with the aurora version?

Are you sure that's not only the case with the aurora version?
dawidpotocki commented 2019-09-01 10:59:41 +00:00 (Migrated from github.com)
Review

Yes. I'm sure.

image
image
image
image

Yes. I'm sure. ![image](https://user-images.githubusercontent.com/38681822/64075399-4920c580-cca7-11e9-93a7-8bbffbd7395a.png) ![image](https://user-images.githubusercontent.com/38681822/64075401-563db480-cca7-11e9-9108-c7fbca0e05b7.png) ![image](https://user-images.githubusercontent.com/38681822/64075415-84bb8f80-cca7-11e9-8e9b-4c36aa1fe8e1.png) ![image](https://user-images.githubusercontent.com/38681822/64075390-2abaca00-cca7-11e9-9a91-8961df28ca85.png)
nitrohorse commented 2019-09-01 16:13:20 +00:00 (Migrated from github.com)
Review

I think we'll want all these links to be filled out in all these browser cards, yeah? Just like the password manager section.

I think we'll want all these links to be filled out in all these browser cards, yeah? Just like the [password manager section](https://www.privacytools.io/software/passwords/#pw).
blacklight447 commented 2019-09-03 09:05:58 +00:00 (Migrated from github.com)
Review

I added all the links. there is one thing I haven't made up my mind about yet: Bromite.
its not the on google play, so we need to link to either their Github release page, or the page where they describe their f-droid repo. While the Github might be easier as people can directly download it, they will not be prompted of new updates, which is a security risk. what do you think? For now, I linked to their f-droid page.

I added all the links. there is one thing I haven't made up my mind about yet: Bromite. its not the on google play, so we need to link to either their Github release page, or the page where they describe their f-droid repo. While the Github might be easier as people can directly download it, they will not be prompted of new updates, which is a security risk. what do you think? For now, I linked to their f-droid page.
Mikaela commented 2019-09-03 15:36:19 +00:00 (Migrated from github.com)
Review

I prefer F-Droid.

I prefer F-Droid.
blacklight447 commented 2019-09-04 22:04:29 +00:00 (Migrated from github.com)
Review

Im not sure on this one, @dawidpotocki mentioned its called Firefox browser now, but im personally also fine with either Mozilla Firefox or just Firefox.

Im not sure on this one, @dawidpotocki mentioned its called Firefox browser now, but im personally also fine with either Mozilla Firefox or just Firefox.
Review

I haven't found any references to "Firefox Browser" besides the Play Store listing on Android, and even then the app itself is simply "Firefox". And their new websites are all simply "Firefox".

Since we're in the browser section I don't think it's necessary to include the "Browser" part even if it is official. Just redundant.

I haven't found any references to "Firefox Browser" besides the Play Store listing on Android, and even then the app itself is simply "Firefox". And their new websites are all simply "Firefox". Since we're in the browser section I don't think it's necessary to include the "Browser" part even if it is official. Just redundant.
blacklight447 commented 2019-09-04 22:24:40 +00:00 (Migrated from github.com)
Review

Shall we go with just "Firefox" then?

Shall we go with just "Firefox" then?
blacklight447 commented 2019-09-06 10:07:47 +00:00 (Migrated from github.com)
Review

The name is now changed to just "Firefox".

The name is now changed to just "Firefox".
dawidpotocki commented 2019-09-11 23:30:00 +00:00 (Migrated from github.com)
Review

Remove en-US/, not everyone is a native English speaker.

Remove `en-US`/, not everyone is a native English speaker.
dawidpotocki commented 2019-09-11 23:45:14 +00:00 (Migrated from github.com)
Review
description='Firefox is fast, reliable, open source and respects your privacy. Don\'t forget to adjust the settings according to our
```suggestion description='Firefox is fast, reliable, open source and respects your privacy. Don\'t forget to adjust the settings according to our ```
dawidpotocki commented 2019-09-11 23:46:20 +00:00 (Migrated from github.com)
Review
recommendations: <a href="#webrtc"><i class="fas fa-link"></i> WebRTC</a> and <a href="#about_config"><i class="fas fa-link"></i> about:config</a> and get the <a href="#addons"><i class="fas fa-link"></i> privacy add-ons</a>.'
```suggestion recommendations: <a href="#webrtc"><i class="fas fa-link"></i> WebRTC</a> and <a href="#about_config"><i class="fas fa-link"></i> about:config</a> and get the <a href="#addons"><i class="fas fa-link"></i> privacy add-ons</a>.' ```
dawidpotocki commented 2019-09-12 06:33:11 +00:00 (Migrated from github.com)
Review

What is that ' doing here

What is that `'` doing here
blacklight447 commented 2019-09-12 06:36:09 +00:00 (Migrated from github.com)
Review

Thats me trying stuff to fix the build, after i made on of your suggested commits, the build broke, netlify also indicates that here is something wrong with the Firefox section, I am still trying to figure out whats wrong exactly.

Thats me trying stuff to fix the build, after i made on of your suggested commits, the build broke, netlify also indicates that here is something wrong with the Firefox section, I am still trying to figure out whats wrong exactly.
dawidpotocki commented 2019-09-12 06:41:56 +00:00 (Migrated from github.com)
Review
Can you look at the https://github.com/privacytoolsIO/privacytools.io/pull/1256/files#r323505120, eh.
website="https://firefox.com"
forum="https://forum.privacytools.io/t/discussion-firefox/279"
source="https://hg.mozilla.org/mozilla-central/"
@ -22,7 +22,7 @@ netbsd="http://pkgsrc.se/www/firefox"
dawidpotocki commented 2019-09-01 10:49:52 +00:00 (Migrated from github.com)
Review
Change "Mozilla Firefox" to "Firefox Browser", that's how they name it now. https://github.com/privacytoolsIO/privacytools.io/blob/7022e125b9d9a14173437d2898fdbd80fa261417/_includes/sections/browser-recommendation.html#L36 https://github.com/privacytoolsIO/privacytools.io/blob/7022e125b9d9a14173437d2898fdbd80fa261417/_includes/sections/browser-recommendation.html#L83 ![image](https://user-images.githubusercontent.com/38681822/64075295-0a3e4000-cca6-11e9-9119-ac6479733a9d.png)
dawidpotocki commented 2019-09-01 10:49:52 +00:00 (Migrated from github.com)
Review
Change "Mozilla Firefox" to "Firefox Browser", that's how they name it now. https://github.com/privacytoolsIO/privacytools.io/blob/7022e125b9d9a14173437d2898fdbd80fa261417/_includes/sections/browser-recommendation.html#L36 https://github.com/privacytoolsIO/privacytools.io/blob/7022e125b9d9a14173437d2898fdbd80fa261417/_includes/sections/browser-recommendation.html#L83 ![image](https://user-images.githubusercontent.com/38681822/64075295-0a3e4000-cca6-11e9-9119-ac6479733a9d.png)
blacklight447 commented 2019-09-01 10:54:02 +00:00 (Migrated from github.com)
Review

Are you sure that's not only the case with the aurora version?

Are you sure that's not only the case with the aurora version?
blacklight447 commented 2019-09-01 10:54:02 +00:00 (Migrated from github.com)
Review

Are you sure that's not only the case with the aurora version?

Are you sure that's not only the case with the aurora version?
dawidpotocki commented 2019-09-01 10:59:41 +00:00 (Migrated from github.com)
Review

Yes. I'm sure.

image
image
image
image

Yes. I'm sure. ![image](https://user-images.githubusercontent.com/38681822/64075399-4920c580-cca7-11e9-93a7-8bbffbd7395a.png) ![image](https://user-images.githubusercontent.com/38681822/64075401-563db480-cca7-11e9-9108-c7fbca0e05b7.png) ![image](https://user-images.githubusercontent.com/38681822/64075415-84bb8f80-cca7-11e9-8e9b-4c36aa1fe8e1.png) ![image](https://user-images.githubusercontent.com/38681822/64075390-2abaca00-cca7-11e9-9a91-8961df28ca85.png)
dawidpotocki commented 2019-09-01 10:59:41 +00:00 (Migrated from github.com)
Review

Yes. I'm sure.

image
image
image
image

Yes. I'm sure. ![image](https://user-images.githubusercontent.com/38681822/64075399-4920c580-cca7-11e9-93a7-8bbffbd7395a.png) ![image](https://user-images.githubusercontent.com/38681822/64075401-563db480-cca7-11e9-9108-c7fbca0e05b7.png) ![image](https://user-images.githubusercontent.com/38681822/64075415-84bb8f80-cca7-11e9-8e9b-4c36aa1fe8e1.png) ![image](https://user-images.githubusercontent.com/38681822/64075390-2abaca00-cca7-11e9-9a91-8961df28ca85.png)
nitrohorse commented 2019-09-01 16:13:20 +00:00 (Migrated from github.com)
Review

I think we'll want all these links to be filled out in all these browser cards, yeah? Just like the password manager section.

I think we'll want all these links to be filled out in all these browser cards, yeah? Just like the [password manager section](https://www.privacytools.io/software/passwords/#pw).
nitrohorse commented 2019-09-01 16:13:20 +00:00 (Migrated from github.com)
Review

I think we'll want all these links to be filled out in all these browser cards, yeah? Just like the password manager section.

I think we'll want all these links to be filled out in all these browser cards, yeah? Just like the [password manager section](https://www.privacytools.io/software/passwords/#pw).
blacklight447 commented 2019-09-03 09:05:58 +00:00 (Migrated from github.com)
Review

I added all the links. there is one thing I haven't made up my mind about yet: Bromite.
its not the on google play, so we need to link to either their Github release page, or the page where they describe their f-droid repo. While the Github might be easier as people can directly download it, they will not be prompted of new updates, which is a security risk. what do you think? For now, I linked to their f-droid page.

I added all the links. there is one thing I haven't made up my mind about yet: Bromite. its not the on google play, so we need to link to either their Github release page, or the page where they describe their f-droid repo. While the Github might be easier as people can directly download it, they will not be prompted of new updates, which is a security risk. what do you think? For now, I linked to their f-droid page.
blacklight447 commented 2019-09-03 09:05:58 +00:00 (Migrated from github.com)
Review

I added all the links. there is one thing I haven't made up my mind about yet: Bromite.
its not the on google play, so we need to link to either their Github release page, or the page where they describe their f-droid repo. While the Github might be easier as people can directly download it, they will not be prompted of new updates, which is a security risk. what do you think? For now, I linked to their f-droid page.

I added all the links. there is one thing I haven't made up my mind about yet: Bromite. its not the on google play, so we need to link to either their Github release page, or the page where they describe their f-droid repo. While the Github might be easier as people can directly download it, they will not be prompted of new updates, which is a security risk. what do you think? For now, I linked to their f-droid page.
Mikaela commented 2019-09-03 15:36:19 +00:00 (Migrated from github.com)
Review

I prefer F-Droid.

I prefer F-Droid.
Mikaela commented 2019-09-03 15:36:19 +00:00 (Migrated from github.com)
Review

I prefer F-Droid.

I prefer F-Droid.
blacklight447 commented 2019-09-04 22:04:29 +00:00 (Migrated from github.com)
Review

Im not sure on this one, @dawidpotocki mentioned its called Firefox browser now, but im personally also fine with either Mozilla Firefox or just Firefox.

Im not sure on this one, @dawidpotocki mentioned its called Firefox browser now, but im personally also fine with either Mozilla Firefox or just Firefox.
blacklight447 commented 2019-09-04 22:04:29 +00:00 (Migrated from github.com)
Review

Im not sure on this one, @dawidpotocki mentioned its called Firefox browser now, but im personally also fine with either Mozilla Firefox or just Firefox.

Im not sure on this one, @dawidpotocki mentioned its called Firefox browser now, but im personally also fine with either Mozilla Firefox or just Firefox.
Review

I haven't found any references to "Firefox Browser" besides the Play Store listing on Android, and even then the app itself is simply "Firefox". And their new websites are all simply "Firefox".

Since we're in the browser section I don't think it's necessary to include the "Browser" part even if it is official. Just redundant.

I haven't found any references to "Firefox Browser" besides the Play Store listing on Android, and even then the app itself is simply "Firefox". And their new websites are all simply "Firefox". Since we're in the browser section I don't think it's necessary to include the "Browser" part even if it is official. Just redundant.
Review

I haven't found any references to "Firefox Browser" besides the Play Store listing on Android, and even then the app itself is simply "Firefox". And their new websites are all simply "Firefox".

Since we're in the browser section I don't think it's necessary to include the "Browser" part even if it is official. Just redundant.

I haven't found any references to "Firefox Browser" besides the Play Store listing on Android, and even then the app itself is simply "Firefox". And their new websites are all simply "Firefox". Since we're in the browser section I don't think it's necessary to include the "Browser" part even if it is official. Just redundant.
blacklight447 commented 2019-09-04 22:24:40 +00:00 (Migrated from github.com)
Review

Shall we go with just "Firefox" then?

Shall we go with just "Firefox" then?
blacklight447 commented 2019-09-04 22:24:40 +00:00 (Migrated from github.com)
Review

Shall we go with just "Firefox" then?

Shall we go with just "Firefox" then?
blacklight447 commented 2019-09-06 10:07:47 +00:00 (Migrated from github.com)
Review

The name is now changed to just "Firefox".

The name is now changed to just "Firefox".
blacklight447 commented 2019-09-06 10:07:47 +00:00 (Migrated from github.com)
Review

The name is now changed to just "Firefox".

The name is now changed to just "Firefox".
dawidpotocki commented 2019-09-11 23:30:00 +00:00 (Migrated from github.com)
Review

Remove en-US/, not everyone is a native English speaker.

Remove `en-US`/, not everyone is a native English speaker.
dawidpotocki commented 2019-09-11 23:30:00 +00:00 (Migrated from github.com)
Review

Remove en-US/, not everyone is a native English speaker.

Remove `en-US`/, not everyone is a native English speaker.
dawidpotocki commented 2019-09-11 23:45:14 +00:00 (Migrated from github.com)
Review
description='Firefox is fast, reliable, open source and respects your privacy. Don\'t forget to adjust the settings according to our
```suggestion description='Firefox is fast, reliable, open source and respects your privacy. Don\'t forget to adjust the settings according to our ```
dawidpotocki commented 2019-09-11 23:45:14 +00:00 (Migrated from github.com)
Review
description='Firefox is fast, reliable, open source and respects your privacy. Don\'t forget to adjust the settings according to our
```suggestion description='Firefox is fast, reliable, open source and respects your privacy. Don\'t forget to adjust the settings according to our ```
dawidpotocki commented 2019-09-11 23:46:20 +00:00 (Migrated from github.com)
Review
recommendations: <a href="#webrtc"><i class="fas fa-link"></i> WebRTC</a> and <a href="#about_config"><i class="fas fa-link"></i> about:config</a> and get the <a href="#addons"><i class="fas fa-link"></i> privacy add-ons</a>.'
```suggestion recommendations: <a href="#webrtc"><i class="fas fa-link"></i> WebRTC</a> and <a href="#about_config"><i class="fas fa-link"></i> about:config</a> and get the <a href="#addons"><i class="fas fa-link"></i> privacy add-ons</a>.' ```
dawidpotocki commented 2019-09-11 23:46:20 +00:00 (Migrated from github.com)
Review
recommendations: <a href="#webrtc"><i class="fas fa-link"></i> WebRTC</a> and <a href="#about_config"><i class="fas fa-link"></i> about:config</a> and get the <a href="#addons"><i class="fas fa-link"></i> privacy add-ons</a>.'
```suggestion recommendations: <a href="#webrtc"><i class="fas fa-link"></i> WebRTC</a> and <a href="#about_config"><i class="fas fa-link"></i> about:config</a> and get the <a href="#addons"><i class="fas fa-link"></i> privacy add-ons</a>.' ```
dawidpotocki commented 2019-09-12 06:33:11 +00:00 (Migrated from github.com)
Review

What is that ' doing here

What is that `'` doing here
dawidpotocki commented 2019-09-12 06:33:11 +00:00 (Migrated from github.com)
Review

What is that ' doing here

What is that `'` doing here
blacklight447 commented 2019-09-12 06:36:09 +00:00 (Migrated from github.com)
Review

Thats me trying stuff to fix the build, after i made on of your suggested commits, the build broke, netlify also indicates that here is something wrong with the Firefox section, I am still trying to figure out whats wrong exactly.

Thats me trying stuff to fix the build, after i made on of your suggested commits, the build broke, netlify also indicates that here is something wrong with the Firefox section, I am still trying to figure out whats wrong exactly.
blacklight447 commented 2019-09-12 06:36:09 +00:00 (Migrated from github.com)
Review

Thats me trying stuff to fix the build, after i made on of your suggested commits, the build broke, netlify also indicates that here is something wrong with the Firefox section, I am still trying to figure out whats wrong exactly.

Thats me trying stuff to fix the build, after i made on of your suggested commits, the build broke, netlify also indicates that here is something wrong with the Firefox section, I am still trying to figure out whats wrong exactly.
dawidpotocki commented 2019-09-12 06:41:56 +00:00 (Migrated from github.com)
Review
Can you look at the https://github.com/privacytoolsIO/privacytools.io/pull/1256/files#r323505120, eh.
dawidpotocki commented 2019-09-12 06:41:56 +00:00 (Migrated from github.com)
Review
Can you look at the https://github.com/privacytoolsIO/privacytools.io/pull/1256/files#r323505120, eh.
{% include cardv2.html
Mikaela commented 2019-09-03 15:31:58 +00:00 (Migrated from github.com)
Review

What is this backslash?

What is this backslash?
Mikaela commented 2019-09-03 15:32:27 +00:00 (Migrated from github.com)
Review
description="Onion Browser is a application that lets you browse the web anonymously over the Tor network on iOS devices, and is endorsed by the Tor Project. Warning: there are certain anonymity related <a href='https://onionbrowser.com/#security-advisories'>issues</a> with Onion browser due to iOS limitations."
```suggestion description="Onion Browser is a application that lets you browse the web anonymously over the Tor network on iOS devices, and is endorsed by the Tor Project. Warning: there are certain anonymity related <a href='https://onionbrowser.com/#security-advisories'>issues</a> with Onion browser due to iOS limitations." ```
Mikaela commented 2019-09-03 15:33:38 +00:00 (Migrated from github.com)
Review
description="DuckDuckGo Privacy Browser has an integrated ad blocker and shows how good certain sites privacy policy is with the integrated ToSDR extension."
```suggestion description="DuckDuckGo Privacy Browser has an integrated ad blocker and shows how good certain sites privacy policy is with the integrated ToSDR extension." ```
Mikaela commented 2019-09-03 15:34:20 +00:00 (Migrated from github.com)
Review
  <li><a href="https://snowhaze.com/en/index.html">SnowHaze</a> SnowHaze is a browser for iOS with intergrated adblocker and fingerprinting protection.</li>

I am not entirely sure if this trailing space is supposed to be here.

```suggestion <li><a href="https://snowhaze.com/en/index.html">SnowHaze</a> SnowHaze is a browser for iOS with intergrated adblocker and fingerprinting protection.</li> ``` I am not entirely sure if this trailing space is supposed to be here.
blacklight447 commented 2019-09-04 22:01:22 +00:00 (Migrated from github.com)
Review

Too my knowledge, the official name is Tor Browser for android.

Too my knowledge, the official name is Tor Browser for android.
blacklight447 commented 2019-09-04 22:03:13 +00:00 (Migrated from github.com)
Review

Ive already discussed that topic with @dawidpotocki , would seem like a good idea indeed.
I also thought we could replace the android Icon with a gplay icon, and add F-droid icon to link to the fdroid repos.

Ive already discussed that topic with @dawidpotocki , would seem like a good idea indeed. I also thought we could replace the android Icon with a gplay icon, and add F-droid icon to link to the fdroid repos.
Review
image
<img width="387" alt="image" src="https://user-images.githubusercontent.com/3637842/64295916-307b0e80-cf38-11e9-945c-bd8bc1f206f6.png">
Review
image

Regardless I'm less concerned about official names and more concerned about "clear" names.

<img width="779" alt="image" src="https://user-images.githubusercontent.com/3637842/64295942-47b9fc00-cf38-11e9-9b42-4787ab11079b.png"> Regardless I'm less concerned about official names and more concerned about "clear" names.
blacklight447 commented 2019-09-04 22:23:32 +00:00 (Migrated from github.com)
Review

Hmm, odd, the alpha application says: Tor browser for android (alpha). Maybe it was changed?
In any case, you seem to be correct here, ill change it.

Hmm, odd, the alpha application says: Tor browser for android (alpha). Maybe it was changed? In any case, you seem to be correct here, ill change it.
Mikaela commented 2019-09-05 15:42:13 +00:00 (Migrated from github.com)
Review

I find it repetitive and inconsistent, "Tor Browser" has different platforms on desktop and mobile.

I find it repetitive and inconsistent, "Tor Browser" has different platforms on desktop and mobile.
Mikaela commented 2019-09-05 15:44:11 +00:00 (Migrated from github.com)
Review

Please add a warning that users should install "Android Webview" (or similar, preferably with link) from Play/Yalp/Aurora Store and keep it up-to-date since Android ? or otherwise they will be missing a lot of browser security updates. See also the issue where it was recommended.

Please add a warning that users should install "Android Webview" (or similar, preferably with link) from Play/Yalp/Aurora Store and keep it up-to-date since Android ? or otherwise they will be missing a lot of browser security updates. See also the issue where it was recommended.
blacklight447 commented 2019-09-06 10:10:52 +00:00 (Migrated from github.com)
Review

I added the warning.

I added the warning.
title="Tor Browser - Provides Anonymity"
nitrohorse commented 2019-09-07 14:34:52 +00:00 (Migrated from github.com)
Review

What if we expanded the description to be a bit more descriptive on its feature set?

Bromite is a Chromium-based browser with security enhancedment patches from GrapheneOS and built-in adblocking and DNS over HTTPS support. More info can be found here.

What if we expanded the description to be a bit more descriptive on its feature set? > Bromite is a Chromium-based browser with security enhancedment patches from <a href='https://grapheneos.org/'>GrapheneOS</a> and built-in adblocking and DNS over HTTPS support. More info can be found <a href='https://www.bromite.org/#main-features'>here</a>.
nitrohorse commented 2019-09-07 14:36:22 +00:00 (Migrated from github.com)
Review

Could we update the description to use a - such as

Privacy Browser - An open source...

Could we update the description to use a `-` such as > Privacy Browser - An open source...
nitrohorse commented 2019-09-07 14:38:10 +00:00 (Migrated from github.com)
Review

I would probably update this to expand a bit to:

Privacy Browser - An open source web browser focused on user privacy. Features include integrated ad blocking with EasyList, SSL certificate pinning, and Tor Orbot proxy support.

I would probably update this to expand a bit to: > Privacy Browser - An open source web browser focused on user privacy. Features include integrated ad blocking with <a href='https://easylist.to/'>EasyList</a>, SSL certificate pinning, and <a href='https://guardianproject.info/apps/orbot/'>Tor Orbot</a> proxy support.
nitrohorse commented 2019-09-07 14:42:49 +00:00 (Migrated from github.com)
Review

Could we update the tooltip to something like this? (suggestions in bold)

Privacy Browser relies on the Android System WebView which should always be kept up-to-date. It can be updated by installing it from Google Play or Aurora Store which you can get from F-Droid. It requires Android 5.0+.

Could we update the tooltip to something like this? (suggestions in bold) > Privacy Browser relies on the Android **System** WebView which **should always be kept up-to-date**. **It can be updated** by installing it from Google Play or Aurora Store which you can get from F-Droid. It requires Android 5.0+.
nitrohorse commented 2019-09-07 14:47:33 +00:00 (Migrated from github.com)
Review

DuckDuckGo Privacy Browser is an open source web browser that has built-in ad and tracker blocking and utilizes ToS;DR to rate the privacy policies of the sites you visit.

> DuckDuckGo Privacy Browser **is an open source web browser that** has **built-in ad and tracker blocking** and **utilizes <a href='https://tosdr.org/'>ToS;DR</a> to rate the privacy policies of the sites you visit.**
blacklight447 commented 2019-09-07 14:49:50 +00:00 (Migrated from github.com)
Review

good idea, ill add it.

good idea, ill add it.
nitrohorse commented 2019-09-07 14:58:08 +00:00 (Migrated from github.com)
Review

What about this:

SnowHaze - An open source web browser with built-in ad, tracker, cookie, and fingerprint blocking, all customizable on a per-site basis.

What about this: > <a href="https://snowhaze.com/en/index.html">SnowHaze</a> - An open source web browser with built-in ad, tracker, cookie, and fingerprint blocking, all customizable on a per-site basis.
blacklight447 commented 2019-09-07 14:58:12 +00:00 (Migrated from github.com)
Review

fixed

fixed
blacklight447 commented 2019-09-07 14:58:35 +00:00 (Migrated from github.com)
Review

done.

done.
blacklight447 commented 2019-09-07 15:38:04 +00:00 (Migrated from github.com)
Review

done.

done.
blacklight447 commented 2019-09-07 15:38:15 +00:00 (Migrated from github.com)
Review

done

done
image="/assets/img/tools/Tor-Browser.png"
description='Tor Browser is your choice if you need an extra layer of anonymity. It\'s a modified version of Firefox ESR, which comes with pre-installed privacy add-ons, encryption and an advanced proxy. <a href='https://write.privacytools.io/my-thoughts-on-security/slicing-onions-part-1-myth-busting-tor'>How does Tor work?</a>'
dawidpotocki commented 2019-09-01 10:49:52 +00:00 (Migrated from github.com)
Review
Change "Mozilla Firefox" to "Firefox Browser", that's how they name it now. https://github.com/privacytoolsIO/privacytools.io/blob/7022e125b9d9a14173437d2898fdbd80fa261417/_includes/sections/browser-recommendation.html#L36 https://github.com/privacytoolsIO/privacytools.io/blob/7022e125b9d9a14173437d2898fdbd80fa261417/_includes/sections/browser-recommendation.html#L83 ![image](https://user-images.githubusercontent.com/38681822/64075295-0a3e4000-cca6-11e9-9119-ac6479733a9d.png)
blacklight447 commented 2019-09-01 10:54:02 +00:00 (Migrated from github.com)
Review

Are you sure that's not only the case with the aurora version?

Are you sure that's not only the case with the aurora version?
dawidpotocki commented 2019-09-01 10:59:41 +00:00 (Migrated from github.com)
Review

Yes. I'm sure.

image
image
image
image

Yes. I'm sure. ![image](https://user-images.githubusercontent.com/38681822/64075399-4920c580-cca7-11e9-93a7-8bbffbd7395a.png) ![image](https://user-images.githubusercontent.com/38681822/64075401-563db480-cca7-11e9-9108-c7fbca0e05b7.png) ![image](https://user-images.githubusercontent.com/38681822/64075415-84bb8f80-cca7-11e9-8e9b-4c36aa1fe8e1.png) ![image](https://user-images.githubusercontent.com/38681822/64075390-2abaca00-cca7-11e9-9a91-8961df28ca85.png)
nitrohorse commented 2019-09-01 16:13:20 +00:00 (Migrated from github.com)
Review

I think we'll want all these links to be filled out in all these browser cards, yeah? Just like the password manager section.

I think we'll want all these links to be filled out in all these browser cards, yeah? Just like the [password manager section](https://www.privacytools.io/software/passwords/#pw).
blacklight447 commented 2019-09-03 09:05:58 +00:00 (Migrated from github.com)
Review

I added all the links. there is one thing I haven't made up my mind about yet: Bromite.
its not the on google play, so we need to link to either their Github release page, or the page where they describe their f-droid repo. While the Github might be easier as people can directly download it, they will not be prompted of new updates, which is a security risk. what do you think? For now, I linked to their f-droid page.

I added all the links. there is one thing I haven't made up my mind about yet: Bromite. its not the on google play, so we need to link to either their Github release page, or the page where they describe their f-droid repo. While the Github might be easier as people can directly download it, they will not be prompted of new updates, which is a security risk. what do you think? For now, I linked to their f-droid page.
Mikaela commented 2019-09-03 15:36:19 +00:00 (Migrated from github.com)
Review

I prefer F-Droid.

I prefer F-Droid.
blacklight447 commented 2019-09-04 22:04:29 +00:00 (Migrated from github.com)
Review

Im not sure on this one, @dawidpotocki mentioned its called Firefox browser now, but im personally also fine with either Mozilla Firefox or just Firefox.

Im not sure on this one, @dawidpotocki mentioned its called Firefox browser now, but im personally also fine with either Mozilla Firefox or just Firefox.
Review

I haven't found any references to "Firefox Browser" besides the Play Store listing on Android, and even then the app itself is simply "Firefox". And their new websites are all simply "Firefox".

Since we're in the browser section I don't think it's necessary to include the "Browser" part even if it is official. Just redundant.

I haven't found any references to "Firefox Browser" besides the Play Store listing on Android, and even then the app itself is simply "Firefox". And their new websites are all simply "Firefox". Since we're in the browser section I don't think it's necessary to include the "Browser" part even if it is official. Just redundant.
blacklight447 commented 2019-09-04 22:24:40 +00:00 (Migrated from github.com)
Review

Shall we go with just "Firefox" then?

Shall we go with just "Firefox" then?
blacklight447 commented 2019-09-06 10:07:47 +00:00 (Migrated from github.com)
Review

The name is now changed to just "Firefox".

The name is now changed to just "Firefox".
dawidpotocki commented 2019-09-11 23:30:00 +00:00 (Migrated from github.com)
Review

Remove en-US/, not everyone is a native English speaker.

Remove `en-US`/, not everyone is a native English speaker.
dawidpotocki commented 2019-09-11 23:45:14 +00:00 (Migrated from github.com)
Review
description='Firefox is fast, reliable, open source and respects your privacy. Don\'t forget to adjust the settings according to our
```suggestion description='Firefox is fast, reliable, open source and respects your privacy. Don\'t forget to adjust the settings according to our ```
dawidpotocki commented 2019-09-11 23:46:20 +00:00 (Migrated from github.com)
Review
recommendations: <a href="#webrtc"><i class="fas fa-link"></i> WebRTC</a> and <a href="#about_config"><i class="fas fa-link"></i> about:config</a> and get the <a href="#addons"><i class="fas fa-link"></i> privacy add-ons</a>.'
```suggestion recommendations: <a href="#webrtc"><i class="fas fa-link"></i> WebRTC</a> and <a href="#about_config"><i class="fas fa-link"></i> about:config</a> and get the <a href="#addons"><i class="fas fa-link"></i> privacy add-ons</a>.' ```
dawidpotocki commented 2019-09-12 06:33:11 +00:00 (Migrated from github.com)
Review

What is that ' doing here

What is that `'` doing here
blacklight447 commented 2019-09-12 06:36:09 +00:00 (Migrated from github.com)
Review

Thats me trying stuff to fix the build, after i made on of your suggested commits, the build broke, netlify also indicates that here is something wrong with the Firefox section, I am still trying to figure out whats wrong exactly.

Thats me trying stuff to fix the build, after i made on of your suggested commits, the build broke, netlify also indicates that here is something wrong with the Firefox section, I am still trying to figure out whats wrong exactly.
dawidpotocki commented 2019-09-12 06:41:56 +00:00 (Migrated from github.com)
Review
Can you look at the https://github.com/privacytoolsIO/privacytools.io/pull/1256/files#r323505120, eh.
description="Tor Browser is your choice if you need an extra layer of anonymity. It\'s a modified version of Firefox ESR, which comes with pre-installed privacy add-ons, encryption and an advanced proxy. <a href='https://write.privacytools.io/my-thoughts-on-security/slicing-onions-part-1-myth-busting-tor'>How does Tor work?</a>"
dawidpotocki commented 2019-09-01 10:49:52 +00:00 (Migrated from github.com)
Review
Change "Mozilla Firefox" to "Firefox Browser", that's how they name it now. https://github.com/privacytoolsIO/privacytools.io/blob/7022e125b9d9a14173437d2898fdbd80fa261417/_includes/sections/browser-recommendation.html#L36 https://github.com/privacytoolsIO/privacytools.io/blob/7022e125b9d9a14173437d2898fdbd80fa261417/_includes/sections/browser-recommendation.html#L83 ![image](https://user-images.githubusercontent.com/38681822/64075295-0a3e4000-cca6-11e9-9119-ac6479733a9d.png)
blacklight447 commented 2019-09-01 10:54:02 +00:00 (Migrated from github.com)
Review

Are you sure that's not only the case with the aurora version?

Are you sure that's not only the case with the aurora version?
dawidpotocki commented 2019-09-01 10:59:41 +00:00 (Migrated from github.com)
Review

Yes. I'm sure.

image
image
image
image

Yes. I'm sure. ![image](https://user-images.githubusercontent.com/38681822/64075399-4920c580-cca7-11e9-93a7-8bbffbd7395a.png) ![image](https://user-images.githubusercontent.com/38681822/64075401-563db480-cca7-11e9-9108-c7fbca0e05b7.png) ![image](https://user-images.githubusercontent.com/38681822/64075415-84bb8f80-cca7-11e9-8e9b-4c36aa1fe8e1.png) ![image](https://user-images.githubusercontent.com/38681822/64075390-2abaca00-cca7-11e9-9a91-8961df28ca85.png)
nitrohorse commented 2019-09-01 16:13:20 +00:00 (Migrated from github.com)
Review

I think we'll want all these links to be filled out in all these browser cards, yeah? Just like the password manager section.

I think we'll want all these links to be filled out in all these browser cards, yeah? Just like the [password manager section](https://www.privacytools.io/software/passwords/#pw).
blacklight447 commented 2019-09-03 09:05:58 +00:00 (Migrated from github.com)
Review

I added all the links. there is one thing I haven't made up my mind about yet: Bromite.
its not the on google play, so we need to link to either their Github release page, or the page where they describe their f-droid repo. While the Github might be easier as people can directly download it, they will not be prompted of new updates, which is a security risk. what do you think? For now, I linked to their f-droid page.

I added all the links. there is one thing I haven't made up my mind about yet: Bromite. its not the on google play, so we need to link to either their Github release page, or the page where they describe their f-droid repo. While the Github might be easier as people can directly download it, they will not be prompted of new updates, which is a security risk. what do you think? For now, I linked to their f-droid page.
Mikaela commented 2019-09-03 15:36:19 +00:00 (Migrated from github.com)
Review

I prefer F-Droid.

I prefer F-Droid.
blacklight447 commented 2019-09-04 22:04:29 +00:00 (Migrated from github.com)
Review

Im not sure on this one, @dawidpotocki mentioned its called Firefox browser now, but im personally also fine with either Mozilla Firefox or just Firefox.

Im not sure on this one, @dawidpotocki mentioned its called Firefox browser now, but im personally also fine with either Mozilla Firefox or just Firefox.
Review

I haven't found any references to "Firefox Browser" besides the Play Store listing on Android, and even then the app itself is simply "Firefox". And their new websites are all simply "Firefox".

Since we're in the browser section I don't think it's necessary to include the "Browser" part even if it is official. Just redundant.

I haven't found any references to "Firefox Browser" besides the Play Store listing on Android, and even then the app itself is simply "Firefox". And their new websites are all simply "Firefox". Since we're in the browser section I don't think it's necessary to include the "Browser" part even if it is official. Just redundant.
blacklight447 commented 2019-09-04 22:24:40 +00:00 (Migrated from github.com)
Review

Shall we go with just "Firefox" then?

Shall we go with just "Firefox" then?
blacklight447 commented 2019-09-06 10:07:47 +00:00 (Migrated from github.com)
Review

The name is now changed to just "Firefox".

The name is now changed to just "Firefox".
dawidpotocki commented 2019-09-11 23:30:00 +00:00 (Migrated from github.com)
Review

Remove en-US/, not everyone is a native English speaker.

Remove `en-US`/, not everyone is a native English speaker.
dawidpotocki commented 2019-09-11 23:45:14 +00:00 (Migrated from github.com)
Review
description='Firefox is fast, reliable, open source and respects your privacy. Don\'t forget to adjust the settings according to our
```suggestion description='Firefox is fast, reliable, open source and respects your privacy. Don\'t forget to adjust the settings according to our ```
dawidpotocki commented 2019-09-11 23:46:20 +00:00 (Migrated from github.com)
Review
recommendations: <a href="#webrtc"><i class="fas fa-link"></i> WebRTC</a> and <a href="#about_config"><i class="fas fa-link"></i> about:config</a> and get the <a href="#addons"><i class="fas fa-link"></i> privacy add-ons</a>.'
```suggestion recommendations: <a href="#webrtc"><i class="fas fa-link"></i> WebRTC</a> and <a href="#about_config"><i class="fas fa-link"></i> about:config</a> and get the <a href="#addons"><i class="fas fa-link"></i> privacy add-ons</a>.' ```
dawidpotocki commented 2019-09-12 06:33:11 +00:00 (Migrated from github.com)
Review

What is that ' doing here

What is that `'` doing here
blacklight447 commented 2019-09-12 06:36:09 +00:00 (Migrated from github.com)
Review

Thats me trying stuff to fix the build, after i made on of your suggested commits, the build broke, netlify also indicates that here is something wrong with the Firefox section, I am still trying to figure out whats wrong exactly.

Thats me trying stuff to fix the build, after i made on of your suggested commits, the build broke, netlify also indicates that here is something wrong with the Firefox section, I am still trying to figure out whats wrong exactly.
dawidpotocki commented 2019-09-12 06:41:56 +00:00 (Migrated from github.com)
Review
Can you look at the https://github.com/privacytoolsIO/privacytools.io/pull/1256/files#r323505120, eh.
website="https://www.torproject.org/"
dawidpotocki commented 2019-09-01 11:08:24 +00:00 (Migrated from github.com)
Review

Change github="" to git: https://gitweb.torproject.org/tor-browser.git/

With this too, but replace git="":

38ae83fec2/_includes/sections/browser-recommendation.html (L25)

Change `github=""` to `git: https://gitweb.torproject.org/tor-browser.git/` With this too, but replace `git=""`: https://github.com/privacytoolsIO/privacytools.io/blob/38ae83fec22aa26d7868f9f5c580fa7deec7521c/_includes/sections/browser-recommendation.html#L25
dawidpotocki commented 2019-09-01 11:12:32 +00:00 (Migrated from github.com)
Review

Replace github="" to source="https://hg.mozilla.org/mozilla-central/".
They use self-hosted Mercurial instead of git on GitHub.

38ae83fec2/_includes/sections/browser-recommendation.html (L88)
38ae83fec2/_includes/sections/browser-recommendation.html (L10)

Replace `github=""` to `source="https://hg.mozilla.org/mozilla-central/"`. They use self-hosted Mercurial instead of git on GitHub. https://github.com/privacytoolsIO/privacytools.io/blob/38ae83fec22aa26d7868f9f5c580fa7deec7521c/_includes/sections/browser-recommendation.html#L88 https://github.com/privacytoolsIO/privacytools.io/blob/38ae83fec22aa26d7868f9f5c580fa7deec7521c/_includes/sections/browser-recommendation.html#L10
blacklight447 commented 2019-09-01 11:46:48 +00:00 (Migrated from github.com)
Review

fixed

fixed
blacklight447 commented 2019-09-01 11:48:31 +00:00 (Migrated from github.com)
Review

fixed

fixed
nitrohorse commented 2019-09-01 16:14:35 +00:00 (Migrated from github.com)
Review

...several privacy and security related patches...

I think it'd be helpful to expand a bit more on what these patches are and why they matter. In other words what makes Bromite stand out among other available browsers?

> ...several privacy and security related patches... I think it'd be helpful to expand a bit more on what these patches are and why they matter. In other words what makes Bromite stand out among other available browsers?
nitrohorse commented 2019-09-01 16:16:56 +00:00 (Migrated from github.com)
Review

We should expand on/tooltip to/hyperlink to the caveats of using Onion Browser. Definitely some gotchas to be aware of.

onion-browser

We should expand on/tooltip to/hyperlink to the caveats of using Onion Browser. Definitely some gotchas to be aware of. ![onion-browser](https://user-images.githubusercontent.com/1514352/64079183-e7c31b80-ccd3-11e9-8ffe-28d81fd95fbc.jpeg)
nitrohorse commented 2019-09-01 16:26:17 +00:00 (Migrated from github.com)
Review

I'm not so sure about SnowHaze due to a couple of things:

  • This project is currently not licensed.
  • This is not our working repository and we only push versions to this repository that have made it through Apple's review process and will be released.
  • Due to binding contracts, we are currently not allowed to publish the decrypted database [containing their list of "content blockers," "dangerous sites," "private sites," "popular sites"...]. We have added a test database which only contains a few entries for each category. This allows you to test the functionality of the database.

Also on first install you're prompted to subscribe to their VPN.

snowhaze

I think DuckDuckGo on the otherhand is a bit easier to put my confidence in.

  • We already list them as a search provider
  • DDG enumerates what ads and trackers where blocked (via their blocklist) so users can learn and see easily what's being blocked and why
  • Allows users to can view the TLS cert which is neat (likely not useful for normal users).
  • Integrates with https://tosdr.org to find any posted privacy practices for the visited site.
  • Accessible button to clear all tabs and data across.

Firefox Focus also has the same "button to clear all tabs and data" but according to its readme:

Development of this project is not currently a high priority. Because of this, we cannot guarantee timely reviews or interactions on this repository. If you would like to contribute to one of our other iOS projects, we recommend checking out Firefox iOS. We greatly appreciate your interest in and contributions towards Focus and look forward to working with you on other projects!

So I think DDG is my preferred "3rd" choice here.

I'm not so sure about SnowHaze due to a couple of things: > - This project is currently not licensed. > - This is not our working repository and we only push versions to this repository that have made it through Apple's review process and will be released. > - Due to binding contracts, we are currently not allowed to publish the decrypted database [containing their list of "content blockers," "dangerous sites," "private sites," "popular sites"...]. We have added a test database which only contains a few entries for each category. This allows you to test the functionality of the database. Also on first install you're prompted to subscribe to their VPN. ![snowhaze](https://user-images.githubusercontent.com/1514352/64079202-61f3a000-ccd4-11e9-8bae-d047cf78582f.jpeg) I think [DuckDuckGo](https://github.com/duckduckgo/iOS) on the otherhand is a bit easier to put my confidence in. * [We already list them as a search provider](https://www.privacytools.io/providers/search-engines/#search) * DDG enumerates what ads and trackers where blocked (via their blocklist) so users can learn and see easily what's being blocked and why * Allows users to can view the TLS cert which is neat (likely not useful for normal users). * Integrates with https://tosdr.org to find any posted privacy practices for the visited site. * Accessible button to clear all tabs and data across. Firefox Focus also has the same "button to clear all tabs and data" but according to its [readme](https://github.com/mozilla-mobile/focus-ios): > Development of this project is not currently a high priority. Because of this, we cannot guarantee timely reviews or interactions on this repository. If you would like to contribute to one of our other iOS projects, we recommend checking out Firefox iOS. We greatly appreciate your interest in and contributions towards Focus and look forward to working with you on other projects! So I think DDG is my preferred "3rd" choice here.
nitrohorse commented 2019-09-01 16:30:23 +00:00 (Migrated from github.com)
Review

I'm thinking for consistency, will we want to mention here that about:config and extensions aren't available? Also, Firefox comes with its own ad and tracker blocker.

I'm thinking for consistency, will we want to mention here that about:config and extensions aren't available? Also, Firefox comes with its own ad and tracker blocker.
nitrohorse commented 2019-09-01 16:34:45 +00:00 (Migrated from github.com)
Review

Also if we had a worth mentioning section we could include SnowHaze.

Also if we had a worth mentioning section we could include SnowHaze.
nitrohorse commented 2019-09-01 16:41:19 +00:00 (Migrated from github.com)
Review

I think the source is here: https://github.com/mozilla-mobile/firefox-ios

I think the source is here: https://github.com/mozilla-mobile/firefox-ios
nitrohorse commented 2019-09-01 16:42:11 +00:00 (Migrated from github.com)
Review

TODO for whatever browser is decided as the third card.

TODO for whatever browser is decided as the third card.
blacklight447 commented 2019-09-01 16:44:07 +00:00 (Migrated from github.com)
Review

Well I actually tried to keep it short so it wasn't overwhelming for normal people, maybe we could put a hyperlink in there where more is explained?

Well I actually tried to keep it short so it wasn't overwhelming for normal people, maybe we could put a hyperlink in there where more is explained?
nitrohorse commented 2019-09-01 16:44:45 +00:00 (Migrated from github.com)
Review

Not sure if the source is there or here? https://github.com/mozilla-mobile

Not sure if the source is there or here? https://github.com/mozilla-mobile
nitrohorse commented 2019-09-01 16:45:15 +00:00 (Migrated from github.com)
Review

Probably want to update this link to the mobile specific site: https://www.mozilla.org/en-US/firefox/mobile/

Probably want to update this link to the mobile specific site: https://www.mozilla.org/en-US/firefox/mobile/
blacklight447 commented 2019-09-01 16:45:44 +00:00 (Migrated from github.com)
Review

Yep, I was thinking of this myself, but me being a html newbie, I will need some help with this. In any case I already left out the "for anonymity" which is present at the tor browser listings, as it contains known issues.

Yep, I was thinking of this myself, but me being a html newbie, I will need some help with this. In any case I already left out the "for anonymity" which is present at the tor browser listings, as it contains known issues.
nitrohorse commented 2019-09-01 16:45:54 +00:00 (Migrated from github.com)
Review

Same as above, I think we'll want the mobile specific site? https://www.mozilla.org/en-US/firefox/mobile/

Same as above, I think we'll want the mobile specific site? https://www.mozilla.org/en-US/firefox/mobile/
nitrohorse commented 2019-09-01 16:47:11 +00:00 (Migrated from github.com)
Review

Could probably use quotes here for consistency.

Could probably use quotes here for consistency.
blacklight447 commented 2019-09-01 16:48:40 +00:00 (Migrated from github.com)
Review

That is certainly an option.

That is certainly an option.
blacklight447 commented 2019-09-01 16:50:36 +00:00 (Migrated from github.com)
Review

Yeah this is what i also wanted to discuss, as i don't have an iOS device in my possession, I wasn't able to test whether you can apply any about:config tweaks, or install extensions, which I why I left that part out for now, any ideas on this?

Yeah this is what i also wanted to discuss, as i don't have an iOS device in my possession, I wasn't able to test whether you can apply any about:config tweaks, or install extensions, which I why I left that part out for now, any ideas on this?
blacklight447 commented 2019-09-01 16:51:20 +00:00 (Migrated from github.com)
Review

@dawidpotocki any thoughts?

@dawidpotocki any thoughts?
blacklight447 commented 2019-09-01 16:53:09 +00:00 (Migrated from github.com)
Review

Most likely, I will update it.

Most likely, I will update it.
blacklight447 commented 2019-09-01 17:00:07 +00:00 (Migrated from github.com)
Review

changed.

changed.
blacklight447 commented 2019-09-01 17:00:17 +00:00 (Migrated from github.com)
Review

fixed

fixed
blacklight447 commented 2019-09-01 17:00:38 +00:00 (Migrated from github.com)
Review

fixed.

fixed.
blacklight447 commented 2019-09-01 17:00:56 +00:00 (Migrated from github.com)
Review

done.

done.
blacklight447 commented 2019-09-01 17:07:19 +00:00 (Migrated from github.com)
Review

okay so it seems that use " instead of ' here causes netlify to shout at me, i think it has something to do with the fact that we have a hyperlink in there. i rolled it back for now

okay so it seems that use " instead of ' here causes netlify to shout at me, i think it has something to do with the fact that we have a hyperlink in there. i rolled it back for now
nitrohorse commented 2019-09-01 17:13:19 +00:00 (Migrated from github.com)
Review

Ahh, yeah, because there's already double quotes in the hyperlink. Okay you can ignore this then 😄

Ahh, yeah, because there's already double quotes in the hyperlink. Okay you can ignore this then :smile:
blacklight447 commented 2019-09-01 17:15:49 +00:00 (Migrated from github.com)
Review

i think we should discuss it on the #1223

i think we should discuss it on the #1223
nitrohorse commented 2019-09-01 18:00:53 +00:00 (Migrated from github.com)
Review

Full WebExtension support would violate 2.5.2 in https://developer.apple.com/app-store/review/guidelines/

Apps should be self-contained in their bundles, and may not read or write data outside the designated container area, nor may they download, install, or execute code which introduces or changes features or functionality of the app, including other apps.

This prevents applications (Firefox) from running unauthorized code (extensions) that was not reviewed by Apple.

https://old.reddit.com/r/firefox/comments/6jjmbf/will_firefox_for_ios_ever_support_webextensions/djfj4hr/

Major benefits (imo) for Firefox on iOS are:

  1. the ability to sync bookmarks/passwords/browsing history.
  2. the ability to send links directly to other linked Firefox devices on the account (example, sending a link from Firefox on iOS to Firefox on desktop).
  3. built in ad/tracker blocking.
> Full WebExtension support would violate 2.5.2 in https://developer.apple.com/app-store/review/guidelines/ >> Apps should be self-contained in their bundles, and may not read or write data outside the designated container area, nor may they download, install, or execute code which introduces or changes features or functionality of the app, including other apps. > This prevents applications (Firefox) from running unauthorized code (extensions) that was not reviewed by Apple. https://old.reddit.com/r/firefox/comments/6jjmbf/will_firefox_for_ios_ever_support_webextensions/djfj4hr/ Major benefits (imo) for Firefox on iOS are: 1. the ability to sync bookmarks/passwords/browsing history. 2. the ability to send links directly to _other_ linked Firefox devices on the account (example, sending a link from Firefox on iOS to Firefox on desktop). 3. built in ad/tracker blocking.
blacklight447 commented 2019-09-01 18:03:25 +00:00 (Migrated from github.com)
Review

I was aware that Firefox had tracking protection but not ad blocking, you got any links on that?

I was aware that Firefox had tracking protection but not ad blocking, you got any links on that?
nitrohorse commented 2019-09-01 18:34:58 +00:00 (Migrated from github.com)
Review

Found this: https://github.com/mozilla-mobile/firefox-ios/issues/5198

Firefox on iOS does have content blocking and it is turned on by default. Ads are blocked, including trackers and third party cookies.

It's not as robust at all like using uBO but Firefox's "Tracking Protection" is powered by Disconnect.

Found this: https://github.com/mozilla-mobile/firefox-ios/issues/5198 > Firefox on iOS does have content blocking and it is turned on by default. Ads are blocked, including trackers and third party cookies. It's not as robust at all like using uBO but Firefox's "Tracking Protection" is powered by [Disconnect](https://disconnect.me/trackerprotection).
nitrohorse commented 2019-09-01 18:36:47 +00:00 (Migrated from github.com)
Review
As I mentioned in Wire, we could probably link to these in the description I think. I see in Onion Browser's GitHub Wiki (https://github.com/OnionBrowser/OnionBrowser/wiki) there are 3 linked security advisories: - https://github.com/OnionBrowser/OnionBrowser/wiki/2019-178:-sites-with-EV-HTTPS-certificates-leak-information-via-OCSP - https://github.com/OnionBrowser/OnionBrowser/wiki/Traffic-that-leaks-outside-of-Tor-due-to-iOS-limitations - https://github.com/OnionBrowser/OnionBrowser/wiki/2018-117:-WebRTC-leaks-real-IP-address-(or-VPN-IP-if-connected-to-a-VPN)
dawidpotocki commented 2019-09-01 23:06:15 +00:00 (Migrated from github.com)
Review

I think that's the case for iOS, but Android seems to be in that HG repo.

I think that's the case for iOS, but Android seems to be in that HG repo.
blacklight447 commented 2019-09-03 09:36:01 +00:00 (Migrated from github.com)
Review

I have now linked to extra information about the patches and what makes bromite stand out.

I have now linked to extra information about the patches and what makes bromite stand out.
blacklight447 commented 2019-09-03 09:50:43 +00:00 (Migrated from github.com)
Review

I have now linked to the advisories in the description.

I have now linked to the advisories in the description.
blacklight447 commented 2019-09-03 10:10:10 +00:00 (Migrated from github.com)
Review

I have put in a notice about the limitation and built in ad blocker in the description.

I have put in a notice about the limitation and built in ad blocker in the description.
forum="https://forum.privacytools.io/t/discussion-tor-browser/278"
git="https://trac.torproject.org/projects/tor"
dawidpotocki commented 2019-09-12 06:52:47 +00:00 (Migrated from github.com)
Review
description='Firefox is fast, reliable, open source and respects your privacy. Don\'t forget to adjust the settings according to our
```suggestion description='Firefox is fast, reliable, open source and respects your privacy. Don\'t forget to adjust the settings according to our ```
dawidpotocki commented 2019-09-12 06:53:00 +00:00 (Migrated from github.com)
Review
recommendations: <a href="#webrtc"><i class="fas fa-link"></i> WebRTC</a> and <a href="#about_config"><i class="fas fa-link"></i> about:config</a> and get the <a href="#addons"><i class="fas fa-link"></i> privacy add-ons</a>.'
```suggestion recommendations: <a href="#webrtc"><i class="fas fa-link"></i> WebRTC</a> and <a href="#about_config"><i class="fas fa-link"></i> about:config</a> and get the <a href="#addons"><i class="fas fa-link"></i> privacy add-ons</a>.' ```
dawidpotocki commented 2019-09-12 12:47:47 +00:00 (Migrated from github.com)
Review
   - An open source web browser focused on user privacy. Features include integrated ad blocking with <a href="https://easylist.to/">EasyList</a>, <a href="https://www.stoutner.com/privacy-browser-2-5/">SSL certificate pinning</a>, and <a href='https://guardianproject.info/apps/orbot/'>Tor Orbot proxy support.</a>
```suggestion - An open source web browser focused on user privacy. Features include integrated ad blocking with <a href="https://easylist.to/">EasyList</a>, <a href="https://www.stoutner.com/privacy-browser-2-5/">SSL certificate pinning</a>, and <a href='https://guardianproject.info/apps/orbot/'>Tor Orbot proxy support.</a> ```
dawidpotocki commented 2019-09-12 12:50:31 +00:00 (Migrated from github.com)
Review
    <a href="https://www.stoutner.com/privacy-browser/">Privacy Browser</a>
```suggestion <a href="https://www.stoutner.com/privacy-browser/">Privacy Browser</a> ```
@ -39,8 +39,8 @@ linux="https://www.torproject.org/download/"
dawidpotocki commented 2019-09-01 10:49:52 +00:00 (Migrated from github.com)
Review
Change "Mozilla Firefox" to "Firefox Browser", that's how they name it now. https://github.com/privacytoolsIO/privacytools.io/blob/7022e125b9d9a14173437d2898fdbd80fa261417/_includes/sections/browser-recommendation.html#L36 https://github.com/privacytoolsIO/privacytools.io/blob/7022e125b9d9a14173437d2898fdbd80fa261417/_includes/sections/browser-recommendation.html#L83 ![image](https://user-images.githubusercontent.com/38681822/64075295-0a3e4000-cca6-11e9-9119-ac6479733a9d.png)
dawidpotocki commented 2019-09-01 10:49:52 +00:00 (Migrated from github.com)
Review
Change "Mozilla Firefox" to "Firefox Browser", that's how they name it now. https://github.com/privacytoolsIO/privacytools.io/blob/7022e125b9d9a14173437d2898fdbd80fa261417/_includes/sections/browser-recommendation.html#L36 https://github.com/privacytoolsIO/privacytools.io/blob/7022e125b9d9a14173437d2898fdbd80fa261417/_includes/sections/browser-recommendation.html#L83 ![image](https://user-images.githubusercontent.com/38681822/64075295-0a3e4000-cca6-11e9-9119-ac6479733a9d.png)
blacklight447 commented 2019-09-01 10:54:02 +00:00 (Migrated from github.com)
Review

Are you sure that's not only the case with the aurora version?

Are you sure that's not only the case with the aurora version?
blacklight447 commented 2019-09-01 10:54:02 +00:00 (Migrated from github.com)
Review

Are you sure that's not only the case with the aurora version?

Are you sure that's not only the case with the aurora version?
dawidpotocki commented 2019-09-01 10:59:41 +00:00 (Migrated from github.com)
Review

Yes. I'm sure.

image
image
image
image

Yes. I'm sure. ![image](https://user-images.githubusercontent.com/38681822/64075399-4920c580-cca7-11e9-93a7-8bbffbd7395a.png) ![image](https://user-images.githubusercontent.com/38681822/64075401-563db480-cca7-11e9-9108-c7fbca0e05b7.png) ![image](https://user-images.githubusercontent.com/38681822/64075415-84bb8f80-cca7-11e9-8e9b-4c36aa1fe8e1.png) ![image](https://user-images.githubusercontent.com/38681822/64075390-2abaca00-cca7-11e9-9a91-8961df28ca85.png)
dawidpotocki commented 2019-09-01 10:59:41 +00:00 (Migrated from github.com)
Review

Yes. I'm sure.

image
image
image
image

Yes. I'm sure. ![image](https://user-images.githubusercontent.com/38681822/64075399-4920c580-cca7-11e9-93a7-8bbffbd7395a.png) ![image](https://user-images.githubusercontent.com/38681822/64075401-563db480-cca7-11e9-9108-c7fbca0e05b7.png) ![image](https://user-images.githubusercontent.com/38681822/64075415-84bb8f80-cca7-11e9-8e9b-4c36aa1fe8e1.png) ![image](https://user-images.githubusercontent.com/38681822/64075390-2abaca00-cca7-11e9-9a91-8961df28ca85.png)
nitrohorse commented 2019-09-01 16:13:20 +00:00 (Migrated from github.com)
Review

I think we'll want all these links to be filled out in all these browser cards, yeah? Just like the password manager section.

I think we'll want all these links to be filled out in all these browser cards, yeah? Just like the [password manager section](https://www.privacytools.io/software/passwords/#pw).
nitrohorse commented 2019-09-01 16:13:20 +00:00 (Migrated from github.com)
Review

I think we'll want all these links to be filled out in all these browser cards, yeah? Just like the password manager section.

I think we'll want all these links to be filled out in all these browser cards, yeah? Just like the [password manager section](https://www.privacytools.io/software/passwords/#pw).
blacklight447 commented 2019-09-03 09:05:58 +00:00 (Migrated from github.com)
Review

I added all the links. there is one thing I haven't made up my mind about yet: Bromite.
its not the on google play, so we need to link to either their Github release page, or the page where they describe their f-droid repo. While the Github might be easier as people can directly download it, they will not be prompted of new updates, which is a security risk. what do you think? For now, I linked to their f-droid page.

I added all the links. there is one thing I haven't made up my mind about yet: Bromite. its not the on google play, so we need to link to either their Github release page, or the page where they describe their f-droid repo. While the Github might be easier as people can directly download it, they will not be prompted of new updates, which is a security risk. what do you think? For now, I linked to their f-droid page.
blacklight447 commented 2019-09-03 09:05:58 +00:00 (Migrated from github.com)
Review

I added all the links. there is one thing I haven't made up my mind about yet: Bromite.
its not the on google play, so we need to link to either their Github release page, or the page where they describe their f-droid repo. While the Github might be easier as people can directly download it, they will not be prompted of new updates, which is a security risk. what do you think? For now, I linked to their f-droid page.

I added all the links. there is one thing I haven't made up my mind about yet: Bromite. its not the on google play, so we need to link to either their Github release page, or the page where they describe their f-droid repo. While the Github might be easier as people can directly download it, they will not be prompted of new updates, which is a security risk. what do you think? For now, I linked to their f-droid page.
Mikaela commented 2019-09-03 15:36:19 +00:00 (Migrated from github.com)
Review

I prefer F-Droid.

I prefer F-Droid.
Mikaela commented 2019-09-03 15:36:19 +00:00 (Migrated from github.com)
Review

I prefer F-Droid.

I prefer F-Droid.
blacklight447 commented 2019-09-04 22:04:29 +00:00 (Migrated from github.com)
Review

Im not sure on this one, @dawidpotocki mentioned its called Firefox browser now, but im personally also fine with either Mozilla Firefox or just Firefox.

Im not sure on this one, @dawidpotocki mentioned its called Firefox browser now, but im personally also fine with either Mozilla Firefox or just Firefox.
blacklight447 commented 2019-09-04 22:04:29 +00:00 (Migrated from github.com)
Review

Im not sure on this one, @dawidpotocki mentioned its called Firefox browser now, but im personally also fine with either Mozilla Firefox or just Firefox.

Im not sure on this one, @dawidpotocki mentioned its called Firefox browser now, but im personally also fine with either Mozilla Firefox or just Firefox.
Review

I haven't found any references to "Firefox Browser" besides the Play Store listing on Android, and even then the app itself is simply "Firefox". And their new websites are all simply "Firefox".

Since we're in the browser section I don't think it's necessary to include the "Browser" part even if it is official. Just redundant.

I haven't found any references to "Firefox Browser" besides the Play Store listing on Android, and even then the app itself is simply "Firefox". And their new websites are all simply "Firefox". Since we're in the browser section I don't think it's necessary to include the "Browser" part even if it is official. Just redundant.
Review

I haven't found any references to "Firefox Browser" besides the Play Store listing on Android, and even then the app itself is simply "Firefox". And their new websites are all simply "Firefox".

Since we're in the browser section I don't think it's necessary to include the "Browser" part even if it is official. Just redundant.

I haven't found any references to "Firefox Browser" besides the Play Store listing on Android, and even then the app itself is simply "Firefox". And their new websites are all simply "Firefox". Since we're in the browser section I don't think it's necessary to include the "Browser" part even if it is official. Just redundant.
blacklight447 commented 2019-09-04 22:24:40 +00:00 (Migrated from github.com)
Review

Shall we go with just "Firefox" then?

Shall we go with just "Firefox" then?
blacklight447 commented 2019-09-04 22:24:40 +00:00 (Migrated from github.com)
Review

Shall we go with just "Firefox" then?

Shall we go with just "Firefox" then?
blacklight447 commented 2019-09-06 10:07:47 +00:00 (Migrated from github.com)
Review

The name is now changed to just "Firefox".

The name is now changed to just "Firefox".
blacklight447 commented 2019-09-06 10:07:47 +00:00 (Migrated from github.com)
Review

The name is now changed to just "Firefox".

The name is now changed to just "Firefox".
dawidpotocki commented 2019-09-11 23:30:00 +00:00 (Migrated from github.com)
Review

Remove en-US/, not everyone is a native English speaker.

Remove `en-US`/, not everyone is a native English speaker.
dawidpotocki commented 2019-09-11 23:30:00 +00:00 (Migrated from github.com)
Review

Remove en-US/, not everyone is a native English speaker.

Remove `en-US`/, not everyone is a native English speaker.
dawidpotocki commented 2019-09-11 23:45:14 +00:00 (Migrated from github.com)
Review
description='Firefox is fast, reliable, open source and respects your privacy. Don\'t forget to adjust the settings according to our
```suggestion description='Firefox is fast, reliable, open source and respects your privacy. Don\'t forget to adjust the settings according to our ```
dawidpotocki commented 2019-09-11 23:45:14 +00:00 (Migrated from github.com)
Review
description='Firefox is fast, reliable, open source and respects your privacy. Don\'t forget to adjust the settings according to our
```suggestion description='Firefox is fast, reliable, open source and respects your privacy. Don\'t forget to adjust the settings according to our ```
dawidpotocki commented 2019-09-11 23:46:20 +00:00 (Migrated from github.com)
Review
recommendations: <a href="#webrtc"><i class="fas fa-link"></i> WebRTC</a> and <a href="#about_config"><i class="fas fa-link"></i> about:config</a> and get the <a href="#addons"><i class="fas fa-link"></i> privacy add-ons</a>.'
```suggestion recommendations: <a href="#webrtc"><i class="fas fa-link"></i> WebRTC</a> and <a href="#about_config"><i class="fas fa-link"></i> about:config</a> and get the <a href="#addons"><i class="fas fa-link"></i> privacy add-ons</a>.' ```
dawidpotocki commented 2019-09-11 23:46:20 +00:00 (Migrated from github.com)
Review
recommendations: <a href="#webrtc"><i class="fas fa-link"></i> WebRTC</a> and <a href="#about_config"><i class="fas fa-link"></i> about:config</a> and get the <a href="#addons"><i class="fas fa-link"></i> privacy add-ons</a>.'
```suggestion recommendations: <a href="#webrtc"><i class="fas fa-link"></i> WebRTC</a> and <a href="#about_config"><i class="fas fa-link"></i> about:config</a> and get the <a href="#addons"><i class="fas fa-link"></i> privacy add-ons</a>.' ```
dawidpotocki commented 2019-09-12 06:33:11 +00:00 (Migrated from github.com)
Review

What is that ' doing here

What is that `'` doing here
dawidpotocki commented 2019-09-12 06:33:11 +00:00 (Migrated from github.com)
Review

What is that ' doing here

What is that `'` doing here
blacklight447 commented 2019-09-12 06:36:09 +00:00 (Migrated from github.com)
Review

Thats me trying stuff to fix the build, after i made on of your suggested commits, the build broke, netlify also indicates that here is something wrong with the Firefox section, I am still trying to figure out whats wrong exactly.

Thats me trying stuff to fix the build, after i made on of your suggested commits, the build broke, netlify also indicates that here is something wrong with the Firefox section, I am still trying to figure out whats wrong exactly.
blacklight447 commented 2019-09-12 06:36:09 +00:00 (Migrated from github.com)
Review

Thats me trying stuff to fix the build, after i made on of your suggested commits, the build broke, netlify also indicates that here is something wrong with the Firefox section, I am still trying to figure out whats wrong exactly.

Thats me trying stuff to fix the build, after i made on of your suggested commits, the build broke, netlify also indicates that here is something wrong with the Firefox section, I am still trying to figure out whats wrong exactly.
dawidpotocki commented 2019-09-12 06:41:56 +00:00 (Migrated from github.com)
Review
Can you look at the https://github.com/privacytoolsIO/privacytools.io/pull/1256/files#r323505120, eh.
dawidpotocki commented 2019-09-12 06:41:56 +00:00 (Migrated from github.com)
Review
Can you look at the https://github.com/privacytoolsIO/privacytools.io/pull/1256/files#r323505120, eh.
{% include cardv2.html
title="Firefox"
image="/assets/img/tools/Firefox.png"
description='Firefox is fast, reliable, open source and respects your privacy. Don\'t forget to adjust the settings according to our
dawidpotocki commented 2019-09-01 10:49:52 +00:00 (Migrated from github.com)
Review
Change "Mozilla Firefox" to "Firefox Browser", that's how they name it now. https://github.com/privacytoolsIO/privacytools.io/blob/7022e125b9d9a14173437d2898fdbd80fa261417/_includes/sections/browser-recommendation.html#L36 https://github.com/privacytoolsIO/privacytools.io/blob/7022e125b9d9a14173437d2898fdbd80fa261417/_includes/sections/browser-recommendation.html#L83 ![image](https://user-images.githubusercontent.com/38681822/64075295-0a3e4000-cca6-11e9-9119-ac6479733a9d.png)
blacklight447 commented 2019-09-01 10:54:02 +00:00 (Migrated from github.com)
Review

Are you sure that's not only the case with the aurora version?

Are you sure that's not only the case with the aurora version?
dawidpotocki commented 2019-09-01 10:59:41 +00:00 (Migrated from github.com)
Review

Yes. I'm sure.

image
image
image
image

Yes. I'm sure. ![image](https://user-images.githubusercontent.com/38681822/64075399-4920c580-cca7-11e9-93a7-8bbffbd7395a.png) ![image](https://user-images.githubusercontent.com/38681822/64075401-563db480-cca7-11e9-9108-c7fbca0e05b7.png) ![image](https://user-images.githubusercontent.com/38681822/64075415-84bb8f80-cca7-11e9-8e9b-4c36aa1fe8e1.png) ![image](https://user-images.githubusercontent.com/38681822/64075390-2abaca00-cca7-11e9-9a91-8961df28ca85.png)
nitrohorse commented 2019-09-01 16:13:20 +00:00 (Migrated from github.com)
Review

I think we'll want all these links to be filled out in all these browser cards, yeah? Just like the password manager section.

I think we'll want all these links to be filled out in all these browser cards, yeah? Just like the [password manager section](https://www.privacytools.io/software/passwords/#pw).
blacklight447 commented 2019-09-03 09:05:58 +00:00 (Migrated from github.com)
Review

I added all the links. there is one thing I haven't made up my mind about yet: Bromite.
its not the on google play, so we need to link to either their Github release page, or the page where they describe their f-droid repo. While the Github might be easier as people can directly download it, they will not be prompted of new updates, which is a security risk. what do you think? For now, I linked to their f-droid page.

I added all the links. there is one thing I haven't made up my mind about yet: Bromite. its not the on google play, so we need to link to either their Github release page, or the page where they describe their f-droid repo. While the Github might be easier as people can directly download it, they will not be prompted of new updates, which is a security risk. what do you think? For now, I linked to their f-droid page.
Mikaela commented 2019-09-03 15:36:19 +00:00 (Migrated from github.com)
Review

I prefer F-Droid.

I prefer F-Droid.
blacklight447 commented 2019-09-04 22:04:29 +00:00 (Migrated from github.com)
Review

Im not sure on this one, @dawidpotocki mentioned its called Firefox browser now, but im personally also fine with either Mozilla Firefox or just Firefox.

Im not sure on this one, @dawidpotocki mentioned its called Firefox browser now, but im personally also fine with either Mozilla Firefox or just Firefox.
Review

I haven't found any references to "Firefox Browser" besides the Play Store listing on Android, and even then the app itself is simply "Firefox". And their new websites are all simply "Firefox".

Since we're in the browser section I don't think it's necessary to include the "Browser" part even if it is official. Just redundant.

I haven't found any references to "Firefox Browser" besides the Play Store listing on Android, and even then the app itself is simply "Firefox". And their new websites are all simply "Firefox". Since we're in the browser section I don't think it's necessary to include the "Browser" part even if it is official. Just redundant.
blacklight447 commented 2019-09-04 22:24:40 +00:00 (Migrated from github.com)
Review

Shall we go with just "Firefox" then?

Shall we go with just "Firefox" then?
blacklight447 commented 2019-09-06 10:07:47 +00:00 (Migrated from github.com)
Review

The name is now changed to just "Firefox".

The name is now changed to just "Firefox".
dawidpotocki commented 2019-09-11 23:30:00 +00:00 (Migrated from github.com)
Review

Remove en-US/, not everyone is a native English speaker.

Remove `en-US`/, not everyone is a native English speaker.
dawidpotocki commented 2019-09-11 23:45:14 +00:00 (Migrated from github.com)
Review
description='Firefox is fast, reliable, open source and respects your privacy. Don\'t forget to adjust the settings according to our
```suggestion description='Firefox is fast, reliable, open source and respects your privacy. Don\'t forget to adjust the settings according to our ```
dawidpotocki commented 2019-09-11 23:46:20 +00:00 (Migrated from github.com)
Review
recommendations: <a href="#webrtc"><i class="fas fa-link"></i> WebRTC</a> and <a href="#about_config"><i class="fas fa-link"></i> about:config</a> and get the <a href="#addons"><i class="fas fa-link"></i> privacy add-ons</a>.'
```suggestion recommendations: <a href="#webrtc"><i class="fas fa-link"></i> WebRTC</a> and <a href="#about_config"><i class="fas fa-link"></i> about:config</a> and get the <a href="#addons"><i class="fas fa-link"></i> privacy add-ons</a>.' ```
dawidpotocki commented 2019-09-12 06:33:11 +00:00 (Migrated from github.com)
Review

What is that ' doing here

What is that `'` doing here
blacklight447 commented 2019-09-12 06:36:09 +00:00 (Migrated from github.com)
Review

Thats me trying stuff to fix the build, after i made on of your suggested commits, the build broke, netlify also indicates that here is something wrong with the Firefox section, I am still trying to figure out whats wrong exactly.

Thats me trying stuff to fix the build, after i made on of your suggested commits, the build broke, netlify also indicates that here is something wrong with the Firefox section, I am still trying to figure out whats wrong exactly.
dawidpotocki commented 2019-09-12 06:41:56 +00:00 (Migrated from github.com)
Review
Can you look at the https://github.com/privacytoolsIO/privacytools.io/pull/1256/files#r323505120, eh.
recommendations: <a href="#webrtc"><i class="fas fa-link"></i> WebRTC</a> and <a href="#about_config"><i class="fas fa-link"></i> about:config</a> and get the <a href="#addons"><i class="fas fa-link"></i> privacy add-ons</a>.'
dawidpotocki commented 2019-09-01 10:49:52 +00:00 (Migrated from github.com)
Review
Change "Mozilla Firefox" to "Firefox Browser", that's how they name it now. https://github.com/privacytoolsIO/privacytools.io/blob/7022e125b9d9a14173437d2898fdbd80fa261417/_includes/sections/browser-recommendation.html#L36 https://github.com/privacytoolsIO/privacytools.io/blob/7022e125b9d9a14173437d2898fdbd80fa261417/_includes/sections/browser-recommendation.html#L83 ![image](https://user-images.githubusercontent.com/38681822/64075295-0a3e4000-cca6-11e9-9119-ac6479733a9d.png)
blacklight447 commented 2019-09-01 10:54:02 +00:00 (Migrated from github.com)
Review

Are you sure that's not only the case with the aurora version?

Are you sure that's not only the case with the aurora version?
dawidpotocki commented 2019-09-01 10:59:41 +00:00 (Migrated from github.com)
Review

Yes. I'm sure.

image
image
image
image

Yes. I'm sure. ![image](https://user-images.githubusercontent.com/38681822/64075399-4920c580-cca7-11e9-93a7-8bbffbd7395a.png) ![image](https://user-images.githubusercontent.com/38681822/64075401-563db480-cca7-11e9-9108-c7fbca0e05b7.png) ![image](https://user-images.githubusercontent.com/38681822/64075415-84bb8f80-cca7-11e9-8e9b-4c36aa1fe8e1.png) ![image](https://user-images.githubusercontent.com/38681822/64075390-2abaca00-cca7-11e9-9a91-8961df28ca85.png)
nitrohorse commented 2019-09-01 16:13:20 +00:00 (Migrated from github.com)
Review

I think we'll want all these links to be filled out in all these browser cards, yeah? Just like the password manager section.

I think we'll want all these links to be filled out in all these browser cards, yeah? Just like the [password manager section](https://www.privacytools.io/software/passwords/#pw).
blacklight447 commented 2019-09-03 09:05:58 +00:00 (Migrated from github.com)
Review

I added all the links. there is one thing I haven't made up my mind about yet: Bromite.
its not the on google play, so we need to link to either their Github release page, or the page where they describe their f-droid repo. While the Github might be easier as people can directly download it, they will not be prompted of new updates, which is a security risk. what do you think? For now, I linked to their f-droid page.

I added all the links. there is one thing I haven't made up my mind about yet: Bromite. its not the on google play, so we need to link to either their Github release page, or the page where they describe their f-droid repo. While the Github might be easier as people can directly download it, they will not be prompted of new updates, which is a security risk. what do you think? For now, I linked to their f-droid page.
Mikaela commented 2019-09-03 15:36:19 +00:00 (Migrated from github.com)
Review

I prefer F-Droid.

I prefer F-Droid.
blacklight447 commented 2019-09-04 22:04:29 +00:00 (Migrated from github.com)
Review

Im not sure on this one, @dawidpotocki mentioned its called Firefox browser now, but im personally also fine with either Mozilla Firefox or just Firefox.

Im not sure on this one, @dawidpotocki mentioned its called Firefox browser now, but im personally also fine with either Mozilla Firefox or just Firefox.
Review

I haven't found any references to "Firefox Browser" besides the Play Store listing on Android, and even then the app itself is simply "Firefox". And their new websites are all simply "Firefox".

Since we're in the browser section I don't think it's necessary to include the "Browser" part even if it is official. Just redundant.

I haven't found any references to "Firefox Browser" besides the Play Store listing on Android, and even then the app itself is simply "Firefox". And their new websites are all simply "Firefox". Since we're in the browser section I don't think it's necessary to include the "Browser" part even if it is official. Just redundant.
blacklight447 commented 2019-09-04 22:24:40 +00:00 (Migrated from github.com)
Review

Shall we go with just "Firefox" then?

Shall we go with just "Firefox" then?
blacklight447 commented 2019-09-06 10:07:47 +00:00 (Migrated from github.com)
Review

The name is now changed to just "Firefox".

The name is now changed to just "Firefox".
dawidpotocki commented 2019-09-11 23:30:00 +00:00 (Migrated from github.com)
Review

Remove en-US/, not everyone is a native English speaker.

Remove `en-US`/, not everyone is a native English speaker.
dawidpotocki commented 2019-09-11 23:45:14 +00:00 (Migrated from github.com)
Review
description='Firefox is fast, reliable, open source and respects your privacy. Don\'t forget to adjust the settings according to our
```suggestion description='Firefox is fast, reliable, open source and respects your privacy. Don\'t forget to adjust the settings according to our ```
dawidpotocki commented 2019-09-11 23:46:20 +00:00 (Migrated from github.com)
Review
recommendations: <a href="#webrtc"><i class="fas fa-link"></i> WebRTC</a> and <a href="#about_config"><i class="fas fa-link"></i> about:config</a> and get the <a href="#addons"><i class="fas fa-link"></i> privacy add-ons</a>.'
```suggestion recommendations: <a href="#webrtc"><i class="fas fa-link"></i> WebRTC</a> and <a href="#about_config"><i class="fas fa-link"></i> about:config</a> and get the <a href="#addons"><i class="fas fa-link"></i> privacy add-ons</a>.' ```
dawidpotocki commented 2019-09-12 06:33:11 +00:00 (Migrated from github.com)
Review

What is that ' doing here

What is that `'` doing here
blacklight447 commented 2019-09-12 06:36:09 +00:00 (Migrated from github.com)
Review

Thats me trying stuff to fix the build, after i made on of your suggested commits, the build broke, netlify also indicates that here is something wrong with the Firefox section, I am still trying to figure out whats wrong exactly.

Thats me trying stuff to fix the build, after i made on of your suggested commits, the build broke, netlify also indicates that here is something wrong with the Firefox section, I am still trying to figure out whats wrong exactly.
dawidpotocki commented 2019-09-12 06:41:56 +00:00 (Migrated from github.com)
Review
Can you look at the https://github.com/privacytoolsIO/privacytools.io/pull/1256/files#r323505120, eh.
description="Firefox is fast, reliable, open source and respects your privacy. Don\'t forget to adjust the settings according to our
dawidpotocki commented 2019-09-01 10:49:52 +00:00 (Migrated from github.com)
Review
Change "Mozilla Firefox" to "Firefox Browser", that's how they name it now. https://github.com/privacytoolsIO/privacytools.io/blob/7022e125b9d9a14173437d2898fdbd80fa261417/_includes/sections/browser-recommendation.html#L36 https://github.com/privacytoolsIO/privacytools.io/blob/7022e125b9d9a14173437d2898fdbd80fa261417/_includes/sections/browser-recommendation.html#L83 ![image](https://user-images.githubusercontent.com/38681822/64075295-0a3e4000-cca6-11e9-9119-ac6479733a9d.png)
blacklight447 commented 2019-09-01 10:54:02 +00:00 (Migrated from github.com)
Review

Are you sure that's not only the case with the aurora version?

Are you sure that's not only the case with the aurora version?
dawidpotocki commented 2019-09-01 10:59:41 +00:00 (Migrated from github.com)
Review

Yes. I'm sure.

image
image
image
image

Yes. I'm sure. ![image](https://user-images.githubusercontent.com/38681822/64075399-4920c580-cca7-11e9-93a7-8bbffbd7395a.png) ![image](https://user-images.githubusercontent.com/38681822/64075401-563db480-cca7-11e9-9108-c7fbca0e05b7.png) ![image](https://user-images.githubusercontent.com/38681822/64075415-84bb8f80-cca7-11e9-8e9b-4c36aa1fe8e1.png) ![image](https://user-images.githubusercontent.com/38681822/64075390-2abaca00-cca7-11e9-9a91-8961df28ca85.png)
nitrohorse commented 2019-09-01 16:13:20 +00:00 (Migrated from github.com)
Review

I think we'll want all these links to be filled out in all these browser cards, yeah? Just like the password manager section.

I think we'll want all these links to be filled out in all these browser cards, yeah? Just like the [password manager section](https://www.privacytools.io/software/passwords/#pw).
blacklight447 commented 2019-09-03 09:05:58 +00:00 (Migrated from github.com)
Review

I added all the links. there is one thing I haven't made up my mind about yet: Bromite.
its not the on google play, so we need to link to either their Github release page, or the page where they describe their f-droid repo. While the Github might be easier as people can directly download it, they will not be prompted of new updates, which is a security risk. what do you think? For now, I linked to their f-droid page.

I added all the links. there is one thing I haven't made up my mind about yet: Bromite. its not the on google play, so we need to link to either their Github release page, or the page where they describe their f-droid repo. While the Github might be easier as people can directly download it, they will not be prompted of new updates, which is a security risk. what do you think? For now, I linked to their f-droid page.
Mikaela commented 2019-09-03 15:36:19 +00:00 (Migrated from github.com)
Review

I prefer F-Droid.

I prefer F-Droid.
blacklight447 commented 2019-09-04 22:04:29 +00:00 (Migrated from github.com)
Review

Im not sure on this one, @dawidpotocki mentioned its called Firefox browser now, but im personally also fine with either Mozilla Firefox or just Firefox.

Im not sure on this one, @dawidpotocki mentioned its called Firefox browser now, but im personally also fine with either Mozilla Firefox or just Firefox.
Review

I haven't found any references to "Firefox Browser" besides the Play Store listing on Android, and even then the app itself is simply "Firefox". And their new websites are all simply "Firefox".

Since we're in the browser section I don't think it's necessary to include the "Browser" part even if it is official. Just redundant.

I haven't found any references to "Firefox Browser" besides the Play Store listing on Android, and even then the app itself is simply "Firefox". And their new websites are all simply "Firefox". Since we're in the browser section I don't think it's necessary to include the "Browser" part even if it is official. Just redundant.
blacklight447 commented 2019-09-04 22:24:40 +00:00 (Migrated from github.com)
Review

Shall we go with just "Firefox" then?

Shall we go with just "Firefox" then?
blacklight447 commented 2019-09-06 10:07:47 +00:00 (Migrated from github.com)
Review

The name is now changed to just "Firefox".

The name is now changed to just "Firefox".
dawidpotocki commented 2019-09-11 23:30:00 +00:00 (Migrated from github.com)
Review

Remove en-US/, not everyone is a native English speaker.

Remove `en-US`/, not everyone is a native English speaker.
dawidpotocki commented 2019-09-11 23:45:14 +00:00 (Migrated from github.com)
Review
description='Firefox is fast, reliable, open source and respects your privacy. Don\'t forget to adjust the settings according to our
```suggestion description='Firefox is fast, reliable, open source and respects your privacy. Don\'t forget to adjust the settings according to our ```
dawidpotocki commented 2019-09-11 23:46:20 +00:00 (Migrated from github.com)
Review
recommendations: <a href="#webrtc"><i class="fas fa-link"></i> WebRTC</a> and <a href="#about_config"><i class="fas fa-link"></i> about:config</a> and get the <a href="#addons"><i class="fas fa-link"></i> privacy add-ons</a>.'
```suggestion recommendations: <a href="#webrtc"><i class="fas fa-link"></i> WebRTC</a> and <a href="#about_config"><i class="fas fa-link"></i> about:config</a> and get the <a href="#addons"><i class="fas fa-link"></i> privacy add-ons</a>.' ```
dawidpotocki commented 2019-09-12 06:33:11 +00:00 (Migrated from github.com)
Review

What is that ' doing here

What is that `'` doing here
blacklight447 commented 2019-09-12 06:36:09 +00:00 (Migrated from github.com)
Review

Thats me trying stuff to fix the build, after i made on of your suggested commits, the build broke, netlify also indicates that here is something wrong with the Firefox section, I am still trying to figure out whats wrong exactly.

Thats me trying stuff to fix the build, after i made on of your suggested commits, the build broke, netlify also indicates that here is something wrong with the Firefox section, I am still trying to figure out whats wrong exactly.
dawidpotocki commented 2019-09-12 06:41:56 +00:00 (Migrated from github.com)
Review
Can you look at the https://github.com/privacytoolsIO/privacytools.io/pull/1256/files#r323505120, eh.
recommendations: <a href="#webrtc"><i class="fas fa-link"></i> WebRTC</a> and <a href="#about_config"><i class="fas fa-link"></i> about:config</a> and get the <a href="#addons"><i class="fas fa-link"></i> privacy add-ons</a>."
dawidpotocki commented 2019-09-01 10:49:52 +00:00 (Migrated from github.com)
Review
Change "Mozilla Firefox" to "Firefox Browser", that's how they name it now. https://github.com/privacytoolsIO/privacytools.io/blob/7022e125b9d9a14173437d2898fdbd80fa261417/_includes/sections/browser-recommendation.html#L36 https://github.com/privacytoolsIO/privacytools.io/blob/7022e125b9d9a14173437d2898fdbd80fa261417/_includes/sections/browser-recommendation.html#L83 ![image](https://user-images.githubusercontent.com/38681822/64075295-0a3e4000-cca6-11e9-9119-ac6479733a9d.png)
blacklight447 commented 2019-09-01 10:54:02 +00:00 (Migrated from github.com)
Review

Are you sure that's not only the case with the aurora version?

Are you sure that's not only the case with the aurora version?
dawidpotocki commented 2019-09-01 10:59:41 +00:00 (Migrated from github.com)
Review

Yes. I'm sure.

image
image
image
image

Yes. I'm sure. ![image](https://user-images.githubusercontent.com/38681822/64075399-4920c580-cca7-11e9-93a7-8bbffbd7395a.png) ![image](https://user-images.githubusercontent.com/38681822/64075401-563db480-cca7-11e9-9108-c7fbca0e05b7.png) ![image](https://user-images.githubusercontent.com/38681822/64075415-84bb8f80-cca7-11e9-8e9b-4c36aa1fe8e1.png) ![image](https://user-images.githubusercontent.com/38681822/64075390-2abaca00-cca7-11e9-9a91-8961df28ca85.png)
nitrohorse commented 2019-09-01 16:13:20 +00:00 (Migrated from github.com)
Review

I think we'll want all these links to be filled out in all these browser cards, yeah? Just like the password manager section.

I think we'll want all these links to be filled out in all these browser cards, yeah? Just like the [password manager section](https://www.privacytools.io/software/passwords/#pw).
blacklight447 commented 2019-09-03 09:05:58 +00:00 (Migrated from github.com)
Review

I added all the links. there is one thing I haven't made up my mind about yet: Bromite.
its not the on google play, so we need to link to either their Github release page, or the page where they describe their f-droid repo. While the Github might be easier as people can directly download it, they will not be prompted of new updates, which is a security risk. what do you think? For now, I linked to their f-droid page.

I added all the links. there is one thing I haven't made up my mind about yet: Bromite. its not the on google play, so we need to link to either their Github release page, or the page where they describe their f-droid repo. While the Github might be easier as people can directly download it, they will not be prompted of new updates, which is a security risk. what do you think? For now, I linked to their f-droid page.
Mikaela commented 2019-09-03 15:36:19 +00:00 (Migrated from github.com)
Review

I prefer F-Droid.

I prefer F-Droid.
blacklight447 commented 2019-09-04 22:04:29 +00:00 (Migrated from github.com)
Review

Im not sure on this one, @dawidpotocki mentioned its called Firefox browser now, but im personally also fine with either Mozilla Firefox or just Firefox.

Im not sure on this one, @dawidpotocki mentioned its called Firefox browser now, but im personally also fine with either Mozilla Firefox or just Firefox.
Review

I haven't found any references to "Firefox Browser" besides the Play Store listing on Android, and even then the app itself is simply "Firefox". And their new websites are all simply "Firefox".

Since we're in the browser section I don't think it's necessary to include the "Browser" part even if it is official. Just redundant.

I haven't found any references to "Firefox Browser" besides the Play Store listing on Android, and even then the app itself is simply "Firefox". And their new websites are all simply "Firefox". Since we're in the browser section I don't think it's necessary to include the "Browser" part even if it is official. Just redundant.
blacklight447 commented 2019-09-04 22:24:40 +00:00 (Migrated from github.com)
Review

Shall we go with just "Firefox" then?

Shall we go with just "Firefox" then?
blacklight447 commented 2019-09-06 10:07:47 +00:00 (Migrated from github.com)
Review

The name is now changed to just "Firefox".

The name is now changed to just "Firefox".
dawidpotocki commented 2019-09-11 23:30:00 +00:00 (Migrated from github.com)
Review

Remove en-US/, not everyone is a native English speaker.

Remove `en-US`/, not everyone is a native English speaker.
dawidpotocki commented 2019-09-11 23:45:14 +00:00 (Migrated from github.com)
Review
description='Firefox is fast, reliable, open source and respects your privacy. Don\'t forget to adjust the settings according to our
```suggestion description='Firefox is fast, reliable, open source and respects your privacy. Don\'t forget to adjust the settings according to our ```
dawidpotocki commented 2019-09-11 23:46:20 +00:00 (Migrated from github.com)
Review
recommendations: <a href="#webrtc"><i class="fas fa-link"></i> WebRTC</a> and <a href="#about_config"><i class="fas fa-link"></i> about:config</a> and get the <a href="#addons"><i class="fas fa-link"></i> privacy add-ons</a>.'
```suggestion recommendations: <a href="#webrtc"><i class="fas fa-link"></i> WebRTC</a> and <a href="#about_config"><i class="fas fa-link"></i> about:config</a> and get the <a href="#addons"><i class="fas fa-link"></i> privacy add-ons</a>.' ```
dawidpotocki commented 2019-09-12 06:33:11 +00:00 (Migrated from github.com)
Review

What is that ' doing here

What is that `'` doing here
blacklight447 commented 2019-09-12 06:36:09 +00:00 (Migrated from github.com)
Review

Thats me trying stuff to fix the build, after i made on of your suggested commits, the build broke, netlify also indicates that here is something wrong with the Firefox section, I am still trying to figure out whats wrong exactly.

Thats me trying stuff to fix the build, after i made on of your suggested commits, the build broke, netlify also indicates that here is something wrong with the Firefox section, I am still trying to figure out whats wrong exactly.
dawidpotocki commented 2019-09-12 06:41:56 +00:00 (Migrated from github.com)
Review
Can you look at the https://github.com/privacytoolsIO/privacytools.io/pull/1256/files#r323505120, eh.
website="https://www.mozilla.org/en-US/firefox/mobile/"
forum="https://forum.privacytools.io/t/discussion-firefox/279"
source="https://github.com/mozilla-mobile"
@ -92,7 +92,7 @@ android="https://www.bromite.org/news/2018-12-21-new-fdroid-repository-url"
dawidpotocki commented 2019-09-01 10:49:52 +00:00 (Migrated from github.com)
Review
Change "Mozilla Firefox" to "Firefox Browser", that's how they name it now. https://github.com/privacytoolsIO/privacytools.io/blob/7022e125b9d9a14173437d2898fdbd80fa261417/_includes/sections/browser-recommendation.html#L36 https://github.com/privacytoolsIO/privacytools.io/blob/7022e125b9d9a14173437d2898fdbd80fa261417/_includes/sections/browser-recommendation.html#L83 ![image](https://user-images.githubusercontent.com/38681822/64075295-0a3e4000-cca6-11e9-9119-ac6479733a9d.png)
dawidpotocki commented 2019-09-01 10:49:52 +00:00 (Migrated from github.com)
Review
Change "Mozilla Firefox" to "Firefox Browser", that's how they name it now. https://github.com/privacytoolsIO/privacytools.io/blob/7022e125b9d9a14173437d2898fdbd80fa261417/_includes/sections/browser-recommendation.html#L36 https://github.com/privacytoolsIO/privacytools.io/blob/7022e125b9d9a14173437d2898fdbd80fa261417/_includes/sections/browser-recommendation.html#L83 ![image](https://user-images.githubusercontent.com/38681822/64075295-0a3e4000-cca6-11e9-9119-ac6479733a9d.png)
blacklight447 commented 2019-09-01 10:54:02 +00:00 (Migrated from github.com)
Review

Are you sure that's not only the case with the aurora version?

Are you sure that's not only the case with the aurora version?
blacklight447 commented 2019-09-01 10:54:02 +00:00 (Migrated from github.com)
Review

Are you sure that's not only the case with the aurora version?

Are you sure that's not only the case with the aurora version?
dawidpotocki commented 2019-09-01 10:59:41 +00:00 (Migrated from github.com)
Review

Yes. I'm sure.

image
image
image
image

Yes. I'm sure. ![image](https://user-images.githubusercontent.com/38681822/64075399-4920c580-cca7-11e9-93a7-8bbffbd7395a.png) ![image](https://user-images.githubusercontent.com/38681822/64075401-563db480-cca7-11e9-9108-c7fbca0e05b7.png) ![image](https://user-images.githubusercontent.com/38681822/64075415-84bb8f80-cca7-11e9-8e9b-4c36aa1fe8e1.png) ![image](https://user-images.githubusercontent.com/38681822/64075390-2abaca00-cca7-11e9-9a91-8961df28ca85.png)
dawidpotocki commented 2019-09-01 10:59:41 +00:00 (Migrated from github.com)
Review

Yes. I'm sure.

image
image
image
image

Yes. I'm sure. ![image](https://user-images.githubusercontent.com/38681822/64075399-4920c580-cca7-11e9-93a7-8bbffbd7395a.png) ![image](https://user-images.githubusercontent.com/38681822/64075401-563db480-cca7-11e9-9108-c7fbca0e05b7.png) ![image](https://user-images.githubusercontent.com/38681822/64075415-84bb8f80-cca7-11e9-8e9b-4c36aa1fe8e1.png) ![image](https://user-images.githubusercontent.com/38681822/64075390-2abaca00-cca7-11e9-9a91-8961df28ca85.png)
nitrohorse commented 2019-09-01 16:13:20 +00:00 (Migrated from github.com)
Review

I think we'll want all these links to be filled out in all these browser cards, yeah? Just like the password manager section.

I think we'll want all these links to be filled out in all these browser cards, yeah? Just like the [password manager section](https://www.privacytools.io/software/passwords/#pw).
nitrohorse commented 2019-09-01 16:13:20 +00:00 (Migrated from github.com)
Review

I think we'll want all these links to be filled out in all these browser cards, yeah? Just like the password manager section.

I think we'll want all these links to be filled out in all these browser cards, yeah? Just like the [password manager section](https://www.privacytools.io/software/passwords/#pw).
blacklight447 commented 2019-09-03 09:05:58 +00:00 (Migrated from github.com)
Review

I added all the links. there is one thing I haven't made up my mind about yet: Bromite.
its not the on google play, so we need to link to either their Github release page, or the page where they describe their f-droid repo. While the Github might be easier as people can directly download it, they will not be prompted of new updates, which is a security risk. what do you think? For now, I linked to their f-droid page.

I added all the links. there is one thing I haven't made up my mind about yet: Bromite. its not the on google play, so we need to link to either their Github release page, or the page where they describe their f-droid repo. While the Github might be easier as people can directly download it, they will not be prompted of new updates, which is a security risk. what do you think? For now, I linked to their f-droid page.
blacklight447 commented 2019-09-03 09:05:58 +00:00 (Migrated from github.com)
Review

I added all the links. there is one thing I haven't made up my mind about yet: Bromite.
its not the on google play, so we need to link to either their Github release page, or the page where they describe their f-droid repo. While the Github might be easier as people can directly download it, they will not be prompted of new updates, which is a security risk. what do you think? For now, I linked to their f-droid page.

I added all the links. there is one thing I haven't made up my mind about yet: Bromite. its not the on google play, so we need to link to either their Github release page, or the page where they describe their f-droid repo. While the Github might be easier as people can directly download it, they will not be prompted of new updates, which is a security risk. what do you think? For now, I linked to their f-droid page.
Mikaela commented 2019-09-03 15:36:19 +00:00 (Migrated from github.com)
Review

I prefer F-Droid.

I prefer F-Droid.
Mikaela commented 2019-09-03 15:36:19 +00:00 (Migrated from github.com)
Review

I prefer F-Droid.

I prefer F-Droid.
blacklight447 commented 2019-09-04 22:04:29 +00:00 (Migrated from github.com)
Review

Im not sure on this one, @dawidpotocki mentioned its called Firefox browser now, but im personally also fine with either Mozilla Firefox or just Firefox.

Im not sure on this one, @dawidpotocki mentioned its called Firefox browser now, but im personally also fine with either Mozilla Firefox or just Firefox.
blacklight447 commented 2019-09-04 22:04:29 +00:00 (Migrated from github.com)
Review

Im not sure on this one, @dawidpotocki mentioned its called Firefox browser now, but im personally also fine with either Mozilla Firefox or just Firefox.

Im not sure on this one, @dawidpotocki mentioned its called Firefox browser now, but im personally also fine with either Mozilla Firefox or just Firefox.
Review

I haven't found any references to "Firefox Browser" besides the Play Store listing on Android, and even then the app itself is simply "Firefox". And their new websites are all simply "Firefox".

Since we're in the browser section I don't think it's necessary to include the "Browser" part even if it is official. Just redundant.

I haven't found any references to "Firefox Browser" besides the Play Store listing on Android, and even then the app itself is simply "Firefox". And their new websites are all simply "Firefox". Since we're in the browser section I don't think it's necessary to include the "Browser" part even if it is official. Just redundant.
Review

I haven't found any references to "Firefox Browser" besides the Play Store listing on Android, and even then the app itself is simply "Firefox". And their new websites are all simply "Firefox".

Since we're in the browser section I don't think it's necessary to include the "Browser" part even if it is official. Just redundant.

I haven't found any references to "Firefox Browser" besides the Play Store listing on Android, and even then the app itself is simply "Firefox". And their new websites are all simply "Firefox". Since we're in the browser section I don't think it's necessary to include the "Browser" part even if it is official. Just redundant.
blacklight447 commented 2019-09-04 22:24:40 +00:00 (Migrated from github.com)
Review

Shall we go with just "Firefox" then?

Shall we go with just "Firefox" then?
blacklight447 commented 2019-09-04 22:24:40 +00:00 (Migrated from github.com)
Review

Shall we go with just "Firefox" then?

Shall we go with just "Firefox" then?
blacklight447 commented 2019-09-06 10:07:47 +00:00 (Migrated from github.com)
Review

The name is now changed to just "Firefox".

The name is now changed to just "Firefox".
blacklight447 commented 2019-09-06 10:07:47 +00:00 (Migrated from github.com)
Review

The name is now changed to just "Firefox".

The name is now changed to just "Firefox".
dawidpotocki commented 2019-09-11 23:30:00 +00:00 (Migrated from github.com)
Review

Remove en-US/, not everyone is a native English speaker.

Remove `en-US`/, not everyone is a native English speaker.
dawidpotocki commented 2019-09-11 23:30:00 +00:00 (Migrated from github.com)
Review

Remove en-US/, not everyone is a native English speaker.

Remove `en-US`/, not everyone is a native English speaker.
dawidpotocki commented 2019-09-11 23:45:14 +00:00 (Migrated from github.com)
Review
description='Firefox is fast, reliable, open source and respects your privacy. Don\'t forget to adjust the settings according to our
```suggestion description='Firefox is fast, reliable, open source and respects your privacy. Don\'t forget to adjust the settings according to our ```
dawidpotocki commented 2019-09-11 23:45:14 +00:00 (Migrated from github.com)
Review
description='Firefox is fast, reliable, open source and respects your privacy. Don\'t forget to adjust the settings according to our
```suggestion description='Firefox is fast, reliable, open source and respects your privacy. Don\'t forget to adjust the settings according to our ```
dawidpotocki commented 2019-09-11 23:46:20 +00:00 (Migrated from github.com)
Review
recommendations: <a href="#webrtc"><i class="fas fa-link"></i> WebRTC</a> and <a href="#about_config"><i class="fas fa-link"></i> about:config</a> and get the <a href="#addons"><i class="fas fa-link"></i> privacy add-ons</a>.'
```suggestion recommendations: <a href="#webrtc"><i class="fas fa-link"></i> WebRTC</a> and <a href="#about_config"><i class="fas fa-link"></i> about:config</a> and get the <a href="#addons"><i class="fas fa-link"></i> privacy add-ons</a>.' ```
dawidpotocki commented 2019-09-11 23:46:20 +00:00 (Migrated from github.com)
Review
recommendations: <a href="#webrtc"><i class="fas fa-link"></i> WebRTC</a> and <a href="#about_config"><i class="fas fa-link"></i> about:config</a> and get the <a href="#addons"><i class="fas fa-link"></i> privacy add-ons</a>.'
```suggestion recommendations: <a href="#webrtc"><i class="fas fa-link"></i> WebRTC</a> and <a href="#about_config"><i class="fas fa-link"></i> about:config</a> and get the <a href="#addons"><i class="fas fa-link"></i> privacy add-ons</a>.' ```
dawidpotocki commented 2019-09-12 06:33:11 +00:00 (Migrated from github.com)
Review

What is that ' doing here

What is that `'` doing here
dawidpotocki commented 2019-09-12 06:33:11 +00:00 (Migrated from github.com)
Review

What is that ' doing here

What is that `'` doing here
blacklight447 commented 2019-09-12 06:36:09 +00:00 (Migrated from github.com)
Review

Thats me trying stuff to fix the build, after i made on of your suggested commits, the build broke, netlify also indicates that here is something wrong with the Firefox section, I am still trying to figure out whats wrong exactly.

Thats me trying stuff to fix the build, after i made on of your suggested commits, the build broke, netlify also indicates that here is something wrong with the Firefox section, I am still trying to figure out whats wrong exactly.
blacklight447 commented 2019-09-12 06:36:09 +00:00 (Migrated from github.com)
Review

Thats me trying stuff to fix the build, after i made on of your suggested commits, the build broke, netlify also indicates that here is something wrong with the Firefox section, I am still trying to figure out whats wrong exactly.

Thats me trying stuff to fix the build, after i made on of your suggested commits, the build broke, netlify also indicates that here is something wrong with the Firefox section, I am still trying to figure out whats wrong exactly.
dawidpotocki commented 2019-09-12 06:41:56 +00:00 (Migrated from github.com)
Review
Can you look at the https://github.com/privacytoolsIO/privacytools.io/pull/1256/files#r323505120, eh.
dawidpotocki commented 2019-09-12 06:41:56 +00:00 (Migrated from github.com)
Review
Can you look at the https://github.com/privacytoolsIO/privacytools.io/pull/1256/files#r323505120, eh.
{% include cardv2.html
title="Firefox"
image="/assets/img/tools/Firefox.png"
description='Firefox is fast, reliable, open source and respects your privacy. Note: because of limitations set by Apple in iOS, our recommended tweaks cannot be applied. However Mozilla has <a href="https://github.com/mozilla-mobile/firefox-ios/issues/5198">deployed</a> an built in ad block filter in the iOS version of Firefox.'
dawidpotocki commented 2019-09-01 10:49:52 +00:00 (Migrated from github.com)
Review
Change "Mozilla Firefox" to "Firefox Browser", that's how they name it now. https://github.com/privacytoolsIO/privacytools.io/blob/7022e125b9d9a14173437d2898fdbd80fa261417/_includes/sections/browser-recommendation.html#L36 https://github.com/privacytoolsIO/privacytools.io/blob/7022e125b9d9a14173437d2898fdbd80fa261417/_includes/sections/browser-recommendation.html#L83 ![image](https://user-images.githubusercontent.com/38681822/64075295-0a3e4000-cca6-11e9-9119-ac6479733a9d.png)
blacklight447 commented 2019-09-01 10:54:02 +00:00 (Migrated from github.com)
Review

Are you sure that's not only the case with the aurora version?

Are you sure that's not only the case with the aurora version?
dawidpotocki commented 2019-09-01 10:59:41 +00:00 (Migrated from github.com)
Review

Yes. I'm sure.

image
image
image
image

Yes. I'm sure. ![image](https://user-images.githubusercontent.com/38681822/64075399-4920c580-cca7-11e9-93a7-8bbffbd7395a.png) ![image](https://user-images.githubusercontent.com/38681822/64075401-563db480-cca7-11e9-9108-c7fbca0e05b7.png) ![image](https://user-images.githubusercontent.com/38681822/64075415-84bb8f80-cca7-11e9-8e9b-4c36aa1fe8e1.png) ![image](https://user-images.githubusercontent.com/38681822/64075390-2abaca00-cca7-11e9-9a91-8961df28ca85.png)
nitrohorse commented 2019-09-01 16:13:20 +00:00 (Migrated from github.com)
Review

I think we'll want all these links to be filled out in all these browser cards, yeah? Just like the password manager section.

I think we'll want all these links to be filled out in all these browser cards, yeah? Just like the [password manager section](https://www.privacytools.io/software/passwords/#pw).
blacklight447 commented 2019-09-03 09:05:58 +00:00 (Migrated from github.com)
Review

I added all the links. there is one thing I haven't made up my mind about yet: Bromite.
its not the on google play, so we need to link to either their Github release page, or the page where they describe their f-droid repo. While the Github might be easier as people can directly download it, they will not be prompted of new updates, which is a security risk. what do you think? For now, I linked to their f-droid page.

I added all the links. there is one thing I haven't made up my mind about yet: Bromite. its not the on google play, so we need to link to either their Github release page, or the page where they describe their f-droid repo. While the Github might be easier as people can directly download it, they will not be prompted of new updates, which is a security risk. what do you think? For now, I linked to their f-droid page.
Mikaela commented 2019-09-03 15:36:19 +00:00 (Migrated from github.com)
Review

I prefer F-Droid.

I prefer F-Droid.
blacklight447 commented 2019-09-04 22:04:29 +00:00 (Migrated from github.com)
Review

Im not sure on this one, @dawidpotocki mentioned its called Firefox browser now, but im personally also fine with either Mozilla Firefox or just Firefox.

Im not sure on this one, @dawidpotocki mentioned its called Firefox browser now, but im personally also fine with either Mozilla Firefox or just Firefox.
Review

I haven't found any references to "Firefox Browser" besides the Play Store listing on Android, and even then the app itself is simply "Firefox". And their new websites are all simply "Firefox".

Since we're in the browser section I don't think it's necessary to include the "Browser" part even if it is official. Just redundant.

I haven't found any references to "Firefox Browser" besides the Play Store listing on Android, and even then the app itself is simply "Firefox". And their new websites are all simply "Firefox". Since we're in the browser section I don't think it's necessary to include the "Browser" part even if it is official. Just redundant.
blacklight447 commented 2019-09-04 22:24:40 +00:00 (Migrated from github.com)
Review

Shall we go with just "Firefox" then?

Shall we go with just "Firefox" then?
blacklight447 commented 2019-09-06 10:07:47 +00:00 (Migrated from github.com)
Review

The name is now changed to just "Firefox".

The name is now changed to just "Firefox".
dawidpotocki commented 2019-09-11 23:30:00 +00:00 (Migrated from github.com)
Review

Remove en-US/, not everyone is a native English speaker.

Remove `en-US`/, not everyone is a native English speaker.
dawidpotocki commented 2019-09-11 23:45:14 +00:00 (Migrated from github.com)
Review
description='Firefox is fast, reliable, open source and respects your privacy. Don\'t forget to adjust the settings according to our
```suggestion description='Firefox is fast, reliable, open source and respects your privacy. Don\'t forget to adjust the settings according to our ```
dawidpotocki commented 2019-09-11 23:46:20 +00:00 (Migrated from github.com)
Review
recommendations: <a href="#webrtc"><i class="fas fa-link"></i> WebRTC</a> and <a href="#about_config"><i class="fas fa-link"></i> about:config</a> and get the <a href="#addons"><i class="fas fa-link"></i> privacy add-ons</a>.'
```suggestion recommendations: <a href="#webrtc"><i class="fas fa-link"></i> WebRTC</a> and <a href="#about_config"><i class="fas fa-link"></i> about:config</a> and get the <a href="#addons"><i class="fas fa-link"></i> privacy add-ons</a>.' ```
dawidpotocki commented 2019-09-12 06:33:11 +00:00 (Migrated from github.com)
Review

What is that ' doing here

What is that `'` doing here
blacklight447 commented 2019-09-12 06:36:09 +00:00 (Migrated from github.com)
Review

Thats me trying stuff to fix the build, after i made on of your suggested commits, the build broke, netlify also indicates that here is something wrong with the Firefox section, I am still trying to figure out whats wrong exactly.

Thats me trying stuff to fix the build, after i made on of your suggested commits, the build broke, netlify also indicates that here is something wrong with the Firefox section, I am still trying to figure out whats wrong exactly.
dawidpotocki commented 2019-09-12 06:41:56 +00:00 (Migrated from github.com)
Review
Can you look at the https://github.com/privacytoolsIO/privacytools.io/pull/1256/files#r323505120, eh.
description="Firefox is fast, reliable, open source and respects your privacy. Note: because of limitations set by Apple in iOS, our recommended tweaks cannot be applied. However Mozilla has <a href="https://github.com/mozilla-mobile/firefox-ios/issues/5198">deployed</a> an built in ad block filter in the iOS version of Firefox."
dawidpotocki commented 2019-09-01 10:49:52 +00:00 (Migrated from github.com)
Review
Change "Mozilla Firefox" to "Firefox Browser", that's how they name it now. https://github.com/privacytoolsIO/privacytools.io/blob/7022e125b9d9a14173437d2898fdbd80fa261417/_includes/sections/browser-recommendation.html#L36 https://github.com/privacytoolsIO/privacytools.io/blob/7022e125b9d9a14173437d2898fdbd80fa261417/_includes/sections/browser-recommendation.html#L83 ![image](https://user-images.githubusercontent.com/38681822/64075295-0a3e4000-cca6-11e9-9119-ac6479733a9d.png)
blacklight447 commented 2019-09-01 10:54:02 +00:00 (Migrated from github.com)
Review

Are you sure that's not only the case with the aurora version?

Are you sure that's not only the case with the aurora version?
dawidpotocki commented 2019-09-01 10:59:41 +00:00 (Migrated from github.com)
Review

Yes. I'm sure.

image
image
image
image

Yes. I'm sure. ![image](https://user-images.githubusercontent.com/38681822/64075399-4920c580-cca7-11e9-93a7-8bbffbd7395a.png) ![image](https://user-images.githubusercontent.com/38681822/64075401-563db480-cca7-11e9-9108-c7fbca0e05b7.png) ![image](https://user-images.githubusercontent.com/38681822/64075415-84bb8f80-cca7-11e9-8e9b-4c36aa1fe8e1.png) ![image](https://user-images.githubusercontent.com/38681822/64075390-2abaca00-cca7-11e9-9a91-8961df28ca85.png)
nitrohorse commented 2019-09-01 16:13:20 +00:00 (Migrated from github.com)
Review

I think we'll want all these links to be filled out in all these browser cards, yeah? Just like the password manager section.

I think we'll want all these links to be filled out in all these browser cards, yeah? Just like the [password manager section](https://www.privacytools.io/software/passwords/#pw).
blacklight447 commented 2019-09-03 09:05:58 +00:00 (Migrated from github.com)
Review

I added all the links. there is one thing I haven't made up my mind about yet: Bromite.
its not the on google play, so we need to link to either their Github release page, or the page where they describe their f-droid repo. While the Github might be easier as people can directly download it, they will not be prompted of new updates, which is a security risk. what do you think? For now, I linked to their f-droid page.

I added all the links. there is one thing I haven't made up my mind about yet: Bromite. its not the on google play, so we need to link to either their Github release page, or the page where they describe their f-droid repo. While the Github might be easier as people can directly download it, they will not be prompted of new updates, which is a security risk. what do you think? For now, I linked to their f-droid page.
Mikaela commented 2019-09-03 15:36:19 +00:00 (Migrated from github.com)
Review

I prefer F-Droid.

I prefer F-Droid.
blacklight447 commented 2019-09-04 22:04:29 +00:00 (Migrated from github.com)
Review

Im not sure on this one, @dawidpotocki mentioned its called Firefox browser now, but im personally also fine with either Mozilla Firefox or just Firefox.

Im not sure on this one, @dawidpotocki mentioned its called Firefox browser now, but im personally also fine with either Mozilla Firefox or just Firefox.
Review

I haven't found any references to "Firefox Browser" besides the Play Store listing on Android, and even then the app itself is simply "Firefox". And their new websites are all simply "Firefox".

Since we're in the browser section I don't think it's necessary to include the "Browser" part even if it is official. Just redundant.

I haven't found any references to "Firefox Browser" besides the Play Store listing on Android, and even then the app itself is simply "Firefox". And their new websites are all simply "Firefox". Since we're in the browser section I don't think it's necessary to include the "Browser" part even if it is official. Just redundant.
blacklight447 commented 2019-09-04 22:24:40 +00:00 (Migrated from github.com)
Review

Shall we go with just "Firefox" then?

Shall we go with just "Firefox" then?
blacklight447 commented 2019-09-06 10:07:47 +00:00 (Migrated from github.com)
Review

The name is now changed to just "Firefox".

The name is now changed to just "Firefox".
dawidpotocki commented 2019-09-11 23:30:00 +00:00 (Migrated from github.com)
Review

Remove en-US/, not everyone is a native English speaker.

Remove `en-US`/, not everyone is a native English speaker.
dawidpotocki commented 2019-09-11 23:45:14 +00:00 (Migrated from github.com)
Review
description='Firefox is fast, reliable, open source and respects your privacy. Don\'t forget to adjust the settings according to our
```suggestion description='Firefox is fast, reliable, open source and respects your privacy. Don\'t forget to adjust the settings according to our ```
dawidpotocki commented 2019-09-11 23:46:20 +00:00 (Migrated from github.com)
Review
recommendations: <a href="#webrtc"><i class="fas fa-link"></i> WebRTC</a> and <a href="#about_config"><i class="fas fa-link"></i> about:config</a> and get the <a href="#addons"><i class="fas fa-link"></i> privacy add-ons</a>.'
```suggestion recommendations: <a href="#webrtc"><i class="fas fa-link"></i> WebRTC</a> and <a href="#about_config"><i class="fas fa-link"></i> about:config</a> and get the <a href="#addons"><i class="fas fa-link"></i> privacy add-ons</a>.' ```
dawidpotocki commented 2019-09-12 06:33:11 +00:00 (Migrated from github.com)
Review

What is that ' doing here

What is that `'` doing here
blacklight447 commented 2019-09-12 06:36:09 +00:00 (Migrated from github.com)
Review

Thats me trying stuff to fix the build, after i made on of your suggested commits, the build broke, netlify also indicates that here is something wrong with the Firefox section, I am still trying to figure out whats wrong exactly.

Thats me trying stuff to fix the build, after i made on of your suggested commits, the build broke, netlify also indicates that here is something wrong with the Firefox section, I am still trying to figure out whats wrong exactly.
dawidpotocki commented 2019-09-12 06:41:56 +00:00 (Migrated from github.com)
Review
Can you look at the https://github.com/privacytoolsIO/privacytools.io/pull/1256/files#r323505120, eh.
website="https://www.mozilla.org/en-US/firefox/mobile/"
forum="https://forum.privacytools.io/t/discussion-firefox/279"
source="https://github.com/mozilla-mobile/firefox-ios"

dawidpotocki commented 2019-09-01 10:49:52 +00:00 (Migrated from github.com)
Review
Change "Mozilla Firefox" to "Firefox Browser", that's how they name it now. https://github.com/privacytoolsIO/privacytools.io/blob/7022e125b9d9a14173437d2898fdbd80fa261417/_includes/sections/browser-recommendation.html#L36 https://github.com/privacytoolsIO/privacytools.io/blob/7022e125b9d9a14173437d2898fdbd80fa261417/_includes/sections/browser-recommendation.html#L83 ![image](https://user-images.githubusercontent.com/38681822/64075295-0a3e4000-cca6-11e9-9119-ac6479733a9d.png)
dawidpotocki commented 2019-09-01 10:49:52 +00:00 (Migrated from github.com)
Review
Change "Mozilla Firefox" to "Firefox Browser", that's how they name it now. https://github.com/privacytoolsIO/privacytools.io/blob/7022e125b9d9a14173437d2898fdbd80fa261417/_includes/sections/browser-recommendation.html#L36 https://github.com/privacytoolsIO/privacytools.io/blob/7022e125b9d9a14173437d2898fdbd80fa261417/_includes/sections/browser-recommendation.html#L83 ![image](https://user-images.githubusercontent.com/38681822/64075295-0a3e4000-cca6-11e9-9119-ac6479733a9d.png)
blacklight447 commented 2019-09-01 10:54:02 +00:00 (Migrated from github.com)
Review

Are you sure that's not only the case with the aurora version?

Are you sure that's not only the case with the aurora version?
blacklight447 commented 2019-09-01 10:54:02 +00:00 (Migrated from github.com)
Review

Are you sure that's not only the case with the aurora version?

Are you sure that's not only the case with the aurora version?
dawidpotocki commented 2019-09-01 10:59:41 +00:00 (Migrated from github.com)
Review

Yes. I'm sure.

image
image
image
image

Yes. I'm sure. ![image](https://user-images.githubusercontent.com/38681822/64075399-4920c580-cca7-11e9-93a7-8bbffbd7395a.png) ![image](https://user-images.githubusercontent.com/38681822/64075401-563db480-cca7-11e9-9108-c7fbca0e05b7.png) ![image](https://user-images.githubusercontent.com/38681822/64075415-84bb8f80-cca7-11e9-8e9b-4c36aa1fe8e1.png) ![image](https://user-images.githubusercontent.com/38681822/64075390-2abaca00-cca7-11e9-9a91-8961df28ca85.png)
dawidpotocki commented 2019-09-01 10:59:41 +00:00 (Migrated from github.com)
Review

Yes. I'm sure.

image
image
image
image

Yes. I'm sure. ![image](https://user-images.githubusercontent.com/38681822/64075399-4920c580-cca7-11e9-93a7-8bbffbd7395a.png) ![image](https://user-images.githubusercontent.com/38681822/64075401-563db480-cca7-11e9-9108-c7fbca0e05b7.png) ![image](https://user-images.githubusercontent.com/38681822/64075415-84bb8f80-cca7-11e9-8e9b-4c36aa1fe8e1.png) ![image](https://user-images.githubusercontent.com/38681822/64075390-2abaca00-cca7-11e9-9a91-8961df28ca85.png)
nitrohorse commented 2019-09-01 16:13:20 +00:00 (Migrated from github.com)
Review

I think we'll want all these links to be filled out in all these browser cards, yeah? Just like the password manager section.

I think we'll want all these links to be filled out in all these browser cards, yeah? Just like the [password manager section](https://www.privacytools.io/software/passwords/#pw).
nitrohorse commented 2019-09-01 16:13:20 +00:00 (Migrated from github.com)
Review

I think we'll want all these links to be filled out in all these browser cards, yeah? Just like the password manager section.

I think we'll want all these links to be filled out in all these browser cards, yeah? Just like the [password manager section](https://www.privacytools.io/software/passwords/#pw).
blacklight447 commented 2019-09-03 09:05:58 +00:00 (Migrated from github.com)
Review

I added all the links. there is one thing I haven't made up my mind about yet: Bromite.
its not the on google play, so we need to link to either their Github release page, or the page where they describe their f-droid repo. While the Github might be easier as people can directly download it, they will not be prompted of new updates, which is a security risk. what do you think? For now, I linked to their f-droid page.

I added all the links. there is one thing I haven't made up my mind about yet: Bromite. its not the on google play, so we need to link to either their Github release page, or the page where they describe their f-droid repo. While the Github might be easier as people can directly download it, they will not be prompted of new updates, which is a security risk. what do you think? For now, I linked to their f-droid page.
blacklight447 commented 2019-09-03 09:05:58 +00:00 (Migrated from github.com)
Review

I added all the links. there is one thing I haven't made up my mind about yet: Bromite.
its not the on google play, so we need to link to either their Github release page, or the page where they describe their f-droid repo. While the Github might be easier as people can directly download it, they will not be prompted of new updates, which is a security risk. what do you think? For now, I linked to their f-droid page.

I added all the links. there is one thing I haven't made up my mind about yet: Bromite. its not the on google play, so we need to link to either their Github release page, or the page where they describe their f-droid repo. While the Github might be easier as people can directly download it, they will not be prompted of new updates, which is a security risk. what do you think? For now, I linked to their f-droid page.
Mikaela commented 2019-09-03 15:36:19 +00:00 (Migrated from github.com)
Review

I prefer F-Droid.

I prefer F-Droid.
Mikaela commented 2019-09-03 15:36:19 +00:00 (Migrated from github.com)
Review

I prefer F-Droid.

I prefer F-Droid.
blacklight447 commented 2019-09-04 22:04:29 +00:00 (Migrated from github.com)
Review

Im not sure on this one, @dawidpotocki mentioned its called Firefox browser now, but im personally also fine with either Mozilla Firefox or just Firefox.

Im not sure on this one, @dawidpotocki mentioned its called Firefox browser now, but im personally also fine with either Mozilla Firefox or just Firefox.
blacklight447 commented 2019-09-04 22:04:29 +00:00 (Migrated from github.com)
Review

Im not sure on this one, @dawidpotocki mentioned its called Firefox browser now, but im personally also fine with either Mozilla Firefox or just Firefox.

Im not sure on this one, @dawidpotocki mentioned its called Firefox browser now, but im personally also fine with either Mozilla Firefox or just Firefox.
Review

I haven't found any references to "Firefox Browser" besides the Play Store listing on Android, and even then the app itself is simply "Firefox". And their new websites are all simply "Firefox".

Since we're in the browser section I don't think it's necessary to include the "Browser" part even if it is official. Just redundant.

I haven't found any references to "Firefox Browser" besides the Play Store listing on Android, and even then the app itself is simply "Firefox". And their new websites are all simply "Firefox". Since we're in the browser section I don't think it's necessary to include the "Browser" part even if it is official. Just redundant.
Review

I haven't found any references to "Firefox Browser" besides the Play Store listing on Android, and even then the app itself is simply "Firefox". And their new websites are all simply "Firefox".

Since we're in the browser section I don't think it's necessary to include the "Browser" part even if it is official. Just redundant.

I haven't found any references to "Firefox Browser" besides the Play Store listing on Android, and even then the app itself is simply "Firefox". And their new websites are all simply "Firefox". Since we're in the browser section I don't think it's necessary to include the "Browser" part even if it is official. Just redundant.
blacklight447 commented 2019-09-04 22:24:40 +00:00 (Migrated from github.com)
Review

Shall we go with just "Firefox" then?

Shall we go with just "Firefox" then?
blacklight447 commented 2019-09-04 22:24:40 +00:00 (Migrated from github.com)
Review

Shall we go with just "Firefox" then?

Shall we go with just "Firefox" then?
blacklight447 commented 2019-09-06 10:07:47 +00:00 (Migrated from github.com)
Review

The name is now changed to just "Firefox".

The name is now changed to just "Firefox".
blacklight447 commented 2019-09-06 10:07:47 +00:00 (Migrated from github.com)
Review

The name is now changed to just "Firefox".

The name is now changed to just "Firefox".
dawidpotocki commented 2019-09-11 23:30:00 +00:00 (Migrated from github.com)
Review

Remove en-US/, not everyone is a native English speaker.

Remove `en-US`/, not everyone is a native English speaker.
dawidpotocki commented 2019-09-11 23:30:00 +00:00 (Migrated from github.com)
Review

Remove en-US/, not everyone is a native English speaker.

Remove `en-US`/, not everyone is a native English speaker.
dawidpotocki commented 2019-09-11 23:45:14 +00:00 (Migrated from github.com)
Review
description='Firefox is fast, reliable, open source and respects your privacy. Don\'t forget to adjust the settings according to our
```suggestion description='Firefox is fast, reliable, open source and respects your privacy. Don\'t forget to adjust the settings according to our ```
dawidpotocki commented 2019-09-11 23:45:14 +00:00 (Migrated from github.com)
Review
description='Firefox is fast, reliable, open source and respects your privacy. Don\'t forget to adjust the settings according to our
```suggestion description='Firefox is fast, reliable, open source and respects your privacy. Don\'t forget to adjust the settings according to our ```
dawidpotocki commented 2019-09-11 23:46:20 +00:00 (Migrated from github.com)
Review
recommendations: <a href="#webrtc"><i class="fas fa-link"></i> WebRTC</a> and <a href="#about_config"><i class="fas fa-link"></i> about:config</a> and get the <a href="#addons"><i class="fas fa-link"></i> privacy add-ons</a>.'
```suggestion recommendations: <a href="#webrtc"><i class="fas fa-link"></i> WebRTC</a> and <a href="#about_config"><i class="fas fa-link"></i> about:config</a> and get the <a href="#addons"><i class="fas fa-link"></i> privacy add-ons</a>.' ```
dawidpotocki commented 2019-09-11 23:46:20 +00:00 (Migrated from github.com)
Review
recommendations: <a href="#webrtc"><i class="fas fa-link"></i> WebRTC</a> and <a href="#about_config"><i class="fas fa-link"></i> about:config</a> and get the <a href="#addons"><i class="fas fa-link"></i> privacy add-ons</a>.'
```suggestion recommendations: <a href="#webrtc"><i class="fas fa-link"></i> WebRTC</a> and <a href="#about_config"><i class="fas fa-link"></i> about:config</a> and get the <a href="#addons"><i class="fas fa-link"></i> privacy add-ons</a>.' ```
dawidpotocki commented 2019-09-12 06:33:11 +00:00 (Migrated from github.com)
Review

What is that ' doing here

What is that `'` doing here
dawidpotocki commented 2019-09-12 06:33:11 +00:00 (Migrated from github.com)
Review

What is that ' doing here

What is that `'` doing here
blacklight447 commented 2019-09-12 06:36:09 +00:00 (Migrated from github.com)
Review

Thats me trying stuff to fix the build, after i made on of your suggested commits, the build broke, netlify also indicates that here is something wrong with the Firefox section, I am still trying to figure out whats wrong exactly.

Thats me trying stuff to fix the build, after i made on of your suggested commits, the build broke, netlify also indicates that here is something wrong with the Firefox section, I am still trying to figure out whats wrong exactly.
blacklight447 commented 2019-09-12 06:36:09 +00:00 (Migrated from github.com)
Review

Thats me trying stuff to fix the build, after i made on of your suggested commits, the build broke, netlify also indicates that here is something wrong with the Firefox section, I am still trying to figure out whats wrong exactly.

Thats me trying stuff to fix the build, after i made on of your suggested commits, the build broke, netlify also indicates that here is something wrong with the Firefox section, I am still trying to figure out whats wrong exactly.
dawidpotocki commented 2019-09-12 06:41:56 +00:00 (Migrated from github.com)
Review
Can you look at the https://github.com/privacytoolsIO/privacytools.io/pull/1256/files#r323505120, eh.
dawidpotocki commented 2019-09-12 06:41:56 +00:00 (Migrated from github.com)
Review
Can you look at the https://github.com/privacytoolsIO/privacytools.io/pull/1256/files#r323505120, eh.