Split website into different files per section #730

jonah · 2019-01-20T15:22:53Z

Vincevrp commented

2019-01-20 15:22:53 +00:00

(Migrated from github.com)

Description

I'm cleaning up some code as I'm splitting the website into separate files.

List of changes:

Clean up code on moved sections
Reworked browser addons section
Reworked Firefox tweaks section
Reworked Android addons section (same as browser)
Reworked footer

Again, might be worth using rebase here.

Screenshots

## Description I'm cleaning up some code as I'm splitting the website into separate files. List of changes: * Clean up code on moved sections * Reworked browser addons section * Reworked Firefox tweaks section * Reworked Android addons section (same as browser) * Reworked footer Again, might be worth using rebase here. ## Screenshots ![Addons section](https://user-images.githubusercontent.com/13933712/51441222-223cf280-1cc7-11e9-847a-505296441665.png) ![Firefox tweaks](https://user-images.githubusercontent.com/13933712/51442175-05f28300-1cd2-11e9-92b7-fd19539875b2.png) ![Footer](https://user-images.githubusercontent.com/13933712/51444652-51b52480-1cf2-11e9-904e-00fa2c93bf8d.png)

jonah reviewed 2019-01-20 18:04:31 +00:00

_includes/card.html

						
				@ -35,3 +35,3 @@

				                    {% else %}

				                        {{ include.url | remove: "https://" | remove: "http://" | remove: "www." | remove: "/" }}

				                        {{ include.url | remove: "https://" | remove: "http://" | remove: "www." | remove: "/" | remove: "github.com" }}

				                    {% endif %}

jonah commented

2019-01-20 18:02:20 +00:00

Can you give me an example of when that is useful?

_includes/sections/vpn.html

						
				@ -0,0 +1,266 @@

				<h1 id="vpn" class="anchor"><a href="#vpn"><i class="fas fa-link anchor-icon"></i></a> VPN providers with extra layers of privacy</h1>

jonah commented

2019-01-20 18:04:21 +00:00

The pattern for sections is repetitive. Perhaps we could

{% include section name="vpn" title="VPN providers with extra layers of privacy
alert="All provider listed here are outside the US..."
alert_color:"success"
%}```

The pattern for sections is repetitive. Perhaps we could ``` {% include section name="vpn" title="VPN providers with extra layers of privacy alert="All provider listed here are outside the US..." alert_color:"success" %}```

Vincevrp (Migrated from github.com) reviewed 2019-01-20 18:32:21 +00:00

_includes/card.html

						
				@ -35,3 +35,3 @@

				                    {% else %}

				                        {{ include.url | remove: "https://" | remove: "http://" | remove: "www." | remove: "/" }}

				                        {{ include.url | remove: "https://" | remove: "http://" | remove: "www." | remove: "/" | remove: "github.com" }}

				                    {% endif %}

Vincevrp (Migrated from github.com) commented

2019-01-20 18:32:21 +00:00

As I wrote in the description of 63c4a7cc95

This fixes the broken Magic Wormhole button

As I wrote in the description of 63c4a7cc95ec2cfdacd548ff171622e663fd7391 > This fixes the broken Magic Wormhole button

Vincevrp (Migrated from github.com) reviewed 2019-01-20 18:39:35 +00:00

_includes/sections/vpn.html

						
				@ -0,0 +1,266 @@

				<h1 id="vpn" class="anchor"><a href="#vpn"><i class="fas fa-link anchor-icon"></i></a> VPN providers with extra layers of privacy</h1>

Vincevrp (Migrated from github.com) commented

2019-01-20 18:39:35 +00:00

It's minor but could be an enhancement in the future. Though it might add unnecessary complexity.

jonah approved these changes 2019-01-20 20:26:41 +00:00

This repo is archived. You cannot comment on pull requests.

1 Participants

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: privacyguides/privacytools.io#730

				`@ -0,0 +1,266 @@`
				`<h1 id="vpn" class="anchor"><a href="#vpn"><i class="fas fa-link anchor-icon"></i></a> VPN providers with extra layers of privacy</h1>`