[Feature] Add Contrib/Non-free Tag #687

Merged
asddsaz merged 21 commits from patch-14 into master 2019-06-20 22:03:29 +00:00
asddsaz commented 2018-12-23 05:14:17 +00:00 (Migrated from github.com)

Description: Add contrib tag to software that recommends or depends on non-free software.
What is contrib? Contrib is a term created by the Debian Foundation to discern from software that is free software but may depend on non-free software.
But, isn't everything listed on privacytools.io only free software? Nope, especially not OSes of which many will auto-install non-free firmware like QubesOS.

**Description**: Add contrib tag to software that recommends or depends on non-free software. **What is contrib**? Contrib is a term created by the [Debian Foundation](https://www.wikipedia.org/wiki/Debian) to discern from software that is free software but may depend on non-free software. **But, isn't everything listed on privacytools.io only free software?** Nope, especially not OSes of which many will auto-install non-free firmware like [QubesOS](https://www.reddit.com/r/fsf/comments/8ue7fi/thoughts_on_qubes_os/).
privacytoolsIO (Migrated from github.com) reviewed 2018-12-23 05:14:17 +00:00
Vincevrp (Migrated from github.com) reviewed 2018-12-23 05:14:17 +00:00
blacklight447 (Migrated from github.com) reviewed 2018-12-23 05:14:17 +00:00
ghost commented 2018-12-23 09:53:59 +00:00 (Migrated from github.com)

Please add the labels the same way Brave's experimental label is added.

Please add the labels the same way Brave's experimental label is added.
ghost commented 2018-12-23 10:38:54 +00:00 (Migrated from github.com)

Note that you can't use " or , in the labels attribute. I will write a wiki page about this sometime.

For commas you can use ,.

Note that you can't use `"` or `,` in the labels attribute. I will write a wiki page about this sometime. For commas you can use `,`.
Mikaela commented 2018-12-23 16:48:19 +00:00 (Migrated from github.com)

Should something be done to apps that are free and use free servers, but where server is not configurable, for example Signal?

Should something be done to apps that are free and use free servers, but where server is not configurable, for example Signal?
ghost commented 2018-12-23 16:50:20 +00:00 (Migrated from github.com)

With Wire we warn about plaintext metadata. If Signal's open source frontend encrypts everything, there's nothing to warn about.

With Wire we warn about plaintext metadata. If Signal's open source frontend encrypts everything, there's nothing to warn about.
asddsaz commented 2018-12-24 03:05:48 +00:00 (Migrated from github.com)

Please add the labels the same way Brave's experimental label is added.

@Shifterovich Done!

> Please add the labels the same way Brave's experimental label is added. @Shifterovich Done!
jonah requested changes 2018-12-24 10:04:37 +00:00

You left the HTML in the description here.

You left the HTML in the description here.

You left the HTML in the description here.

You left the HTML in the description here.

You left the HTML in the description here.

You left the HTML in the description here.

You left the HTML in the description here.

You left the HTML in the description here.

You left the HTML in the description here.

You left the HTML in the description here.
asddsaz commented 2018-12-24 19:49:27 +00:00 (Migrated from github.com)

@Shifterovich Would you mind plz explaining the requested changes. I do not understand. :)

@Shifterovich Would you mind plz explaining the requested changes. I do not understand. :)
ghost commented 2018-12-24 19:58:14 +00:00 (Migrated from github.com)

You added the labels=... but kept the <span class="badge badge-warning" data-toggle="tooltip" title="This ... in the description.

You added the `labels=...` but kept the `<span class="badge badge-warning" data-toggle="tooltip" title="This ...` in the `description`.
asddsaz commented 2018-12-24 20:17:43 +00:00 (Migrated from github.com)

@Shifterovich Hmm, try re-pulling. I only see it for LineageOS. I made sure to fix that. :)
Thank you so much for your help!

@Shifterovich Hmm, try re-pulling. I only see it for LineageOS. I made sure to fix that. :) Thank you so much for your help!
asddsaz (Migrated from github.com) reviewed 2018-12-24 20:24:22 +00:00
asddsaz (Migrated from github.com) commented 2018-12-24 20:24:21 +00:00

This is outdated, I fixed this in the Minor Fix commit.

This is outdated, I fixed this in the [Minor Fix](https://github.com/privacytoolsIO/privacytools.io/pull/687/commits/9d20e276e043101183e6d44383e1d012fc7815f1) commit.
asddsaz (Migrated from github.com) reviewed 2018-12-24 20:24:54 +00:00
asddsaz (Migrated from github.com) commented 2018-12-24 20:24:54 +00:00

This is outdated, I fixed this in the Minor Fix commit.

This is outdated, I fixed this in the [Minor Fix](https://github.com/privacytoolsIO/privacytools.io/pull/687/commits/9d20e276e043101183e6d44383e1d012fc7815f1) commit.
asddsaz (Migrated from github.com) reviewed 2018-12-24 20:25:31 +00:00
asddsaz (Migrated from github.com) commented 2018-12-24 20:25:31 +00:00

This is outdated, I fixed this in the Minor Fix commit.

This is outdated, I fixed this in the [Minor Fix](https://github.com/privacytoolsIO/privacytools.io/pull/687/commits/9d20e276e043101183e6d44383e1d012fc7815f1) commit.
ghost commented 2018-12-24 20:28:59 +00:00 (Migrated from github.com)

Yeah, the issue with the description is now fixed.


This software may depend on or recommend non-free software.

How do you mean recommend?

Yeah, the issue with the description is now fixed. --- > This software may depend on or recommend non-free software. How do you mean recommend?
asddsaz commented 2018-12-24 21:06:46 +00:00 (Migrated from github.com)

@Shifterovich So, one example would be that Ubuntu "recommends" non-free software like Steam.

The main issue with the items I want to currently add this to is firmware but if an OS/App recommends a user to install non-free software you could use the same tag.
Preferably, it would have a more specific warning like:

This software may recommend non-free software such as apps or addons.

It is meant to warn the user that although the app is free software it may ask to install non-free software.

@Shifterovich So, one example would be that Ubuntu "recommends" non-free software like [Steam](https://www.wikipedia.org/wiki/Steam_(software)). The main issue with the items I want to currently add this to is firmware but if an OS/App recommends a user to install non-free software you could use the same tag. Preferably, it would have a more specific warning like: > This software may recommend non-free software such as apps or addons. It is meant to warn the user that although the app is free software it may ask to install non-free software.
ghost commented 2018-12-24 22:00:15 +00:00 (Migrated from github.com)

In what way does Ubuntu recommend Steam? (If it does, I haven't noticed.)

In what way does Ubuntu recommend Steam? (If it does, I haven't noticed.)
asddsaz commented 2018-12-25 01:55:55 +00:00 (Migrated from github.com)

In what way does Ubuntu recommend Steam? (If it does, I haven't noticed.)

During installation they show many apps available for Ubuntu, many are non-free. They also have many non-free apps in their App Store.

The FSF/GNU has a good article on this:

Ubuntu provides specific repositories of nonfree software, and Canonical expressly promotes and recommends nonfree software under the Ubuntu name in some of their distribution channels. Ubuntu offers the option to install only free packages, which means it also offers the option to install nonfree packages too. In addition, the version of Linux, the kernel, included in Ubuntu contains firmware blobs.

The “Ubuntu Software Center” lists proprietary programs and free programs jumbled together. It is hard to tell which ones are free since proprietary programs for download at no charge are labelled “free”.

Source: http://www.gnu.org/distros/common-distros.html

> In what way does Ubuntu recommend Steam? (If it does, I haven't noticed.) During installation they show many apps available for Ubuntu, many are [non-free](https://www.wikipedia.org/wiki/Proprietary_software). They also have many [non-free](https://www.wikipedia.org/wiki/Proprietary_software) apps in their App Store. The [FSF](https://www.fsf.org)/[GNU](http://www.gnu.org) has a good article on this: > Ubuntu provides specific repositories of nonfree software, and Canonical expressly promotes and recommends nonfree software under the Ubuntu name in some of their distribution channels. Ubuntu offers the option to install only free packages, which means it also offers the option to install nonfree packages too. In addition, the version of Linux, the kernel, included in Ubuntu contains firmware blobs. > > The “Ubuntu Software Center” lists proprietary programs and free programs jumbled together. It is hard to tell which ones are free since proprietary programs for download at no charge are labelled “free”. Source: http://www.gnu.org/distros/common-distros.html
jonah reviewed 2018-12-25 09:52:30 +00:00
Vincevrp (Migrated from github.com) reviewed 2018-12-30 19:24:20 +00:00
Vincevrp (Migrated from github.com) commented 2018-12-30 19:24:19 +00:00

Is there a reason you changed those?

Is there a reason you changed those?
Vincevrp (Migrated from github.com) reviewed 2018-12-30 19:24:31 +00:00
Vincevrp (Migrated from github.com) left a comment

Could you please add some screenshots?

Could you please add some screenshots?
jonah reviewed 2018-12-30 20:43:08 +00:00

Since is no painful escaping is solved by this, this should be reverted to be consistent with the include's other properties.

Since is no painful escaping is solved by this, this should be reverted to be consistent with the include's other properties.
asddsaz (Migrated from github.com) reviewed 2018-12-31 00:50:39 +00:00
asddsaz (Migrated from github.com) commented 2018-12-31 00:50:39 +00:00

@Vincevrp @Shifterovich Done! (fa6f752fe4)

If I remember correctly, the reasons I did this was because ' " ' was in the description. Therefore I had to switch on order for it to compile properly. But, this should no longer be a problem.

@Vincevrp @Shifterovich Done! (https://github.com/privacytoolsIO/privacytools.io/pull/687/commits/fa6f752fe4e57f839eef9f3454e088a9a169e970) If I remember correctly, the reasons I did this was because ' " ' was in the description. Therefore I had to switch on order for it to compile properly. But, this should no longer be a problem.
asddsaz commented 2018-12-31 00:54:53 +00:00 (Migrated from github.com)

Could you please add some screenshots?

Hopefully this gives you kinda an idea:

image

@Vincevrp @Shifterovich

> Could you please add some screenshots? Hopefully this gives you kinda an idea: ![image](https://user-images.githubusercontent.com/42685606/50553098-b05d2480-0c97-11e9-898f-dac64fe463e6.png) @Vincevrp @Shifterovich
privacytoolsIO commented 2019-04-01 03:12:01 +00:00 (Migrated from github.com)

hi guys, whats the status here?

hi guys, whats the status here?
Mikaela (Migrated from github.com) requested changes 2019-04-21 20:42:41 +00:00
Mikaela (Migrated from github.com) left a comment

This PR seems to have became outdated/merge conflicting due to the website update. I would also like to see how this looks in practice and I think Netlify integration would kick in and bring a preview when the PR is updated.

This PR seems to have became outdated/merge conflicting due to the website update. I would also like to see how this looks in practice and I think Netlify integration would kick in and bring a preview when the PR is updated.
asddsaz commented 2019-05-02 23:20:34 +00:00 (Migrated from github.com)

@Vincevrp

@Vincevrp
privacytoolsIO commented 2019-05-06 10:16:45 +00:00 (Migrated from github.com)

I don't think we need this feature at the moment.

I don't think we need this feature at the moment.
Mikaela commented 2019-05-06 19:36:04 +00:00 (Migrated from github.com)

There is still a merge conflict.

I think especially the privacy concious users of https://github.com/privacytoolsIO/privacytools.io/issues/880 might appreciate this.

There is still a merge conflict. I think especially the privacy concious users of https://github.com/privacytoolsIO/privacytools.io/issues/880 might appreciate this.
netlify[bot] commented 2019-05-08 04:56:00 +00:00 (Migrated from github.com)

Deploy preview for privacytools-io ready!

Built with commit ace1ef623b

https://deploy-preview-687--privacytools-io.netlify.com

Deploy preview for *privacytools-io* ready! Built with commit ace1ef623b32b8b4760a3d5ca5d5df1a116b7ab8 https://deploy-preview-687--privacytools-io.netlify.com
asddsaz commented 2019-05-08 04:57:14 +00:00 (Migrated from github.com)

This PR seems to have became outdated/merge conflicting due to the website update. I would also like to see how this looks in practice and I think Netlify integration would kick in and bring a preview when the PR is updated.

Thanks! This should be fixed in last commit/PR.

@Mikaela

> This PR seems to have became outdated/merge conflicting due to the website update. I would also like to see how this looks in practice and I think Netlify integration would kick in and bring a preview when the PR is updated. Thanks! This _should_ be fixed in last [commit/PR](https://github.com/privacytoolsIO/privacytools.io/pull/687/commits/896bfb6261275086ac5c912551425abe9e24f46a). @Mikaela
Mikaela (Migrated from github.com) reviewed 2019-05-08 10:10:36 +00:00
Mikaela (Migrated from github.com) commented 2019-05-08 10:07:57 +00:00

Why the change of " to ' ?

Why the change of " to ' ?
blacklight447 commented 2019-05-08 10:41:27 +00:00 (Migrated from github.com)

Seems fine to me👍

Seems fine to me:+1:
jonah reviewed 2019-05-11 21:14:09 +00:00
jonah left a comment

This seems fine at a cursory glance but I don't want to approve any changes without @BurungHantu1605 or @privacytoolsIO/editorial looking at this.

This seems fine at a cursory glance but I don't want to approve any changes without @BurungHantu1605 or @privacytoolsIO/editorial looking at this.
Mikaela commented 2019-05-11 21:22:15 +00:00 (Migrated from github.com)

There are three OKs (including yours), but @blacklight447-ptio didn't catch the review approval button being in top right of "files changed".

There are three OKs (including yours), but @blacklight447-ptio didn't catch the review approval button being in top right of "files changed".

I'm more just not 100% sure if noting contrib on not completely free tools is in-scope for this project. It might make people more wary of using certain tools when in reality if people used any of the tools we recommend it would be a significant net benefit to privacy overall.

But I also don't have any problem with this being added.

I'm more just not 100% sure if noting `contrib` on not completely free tools is in-scope for this project. It might make people more wary of using certain tools when in reality if people used *any* of the tools we recommend it would be a significant net benefit to privacy overall. But I also don't have any problem with this being added.
ghost commented 2019-05-12 08:34:10 +00:00 (Migrated from github.com)

A downside is that it will pollute the source code and the site with a ton of contrib labels.

I'm more just not 100% sure if noting contrib on not completely free tools is in-scope for this project. [...] But I also don't have any problem with this being added.

We should only add things if there's a benefit to adding them.

A downside is that it will pollute the source code and the site with a ton of `contrib` labels. > I'm more just not 100% sure if noting contrib on not completely free tools is in-scope for this project. [...] But I also don't have any problem with this being added. We should only add things if there's a benefit to adding them.
asddsaz commented 2019-05-12 22:34:26 +00:00 (Migrated from github.com)

A downside is that it will pollute the source code and the site with a ton of contrib labels.

I'm more just not 100% sure if noting contrib on not completely free tools is in-scope for this project. [...] But I also don't have any problem with this being added.

We should only add things if there's a benefit to adding them.

@Shifterovich I'm not sure I understand, this is already part of my PR.
I didn't add it to all the non-free search engines and hosting sites. I also didn't add it to services like Signal or the tons of VPNs with proprietary back-ends.

If anybody would like discussing adding the label to these, I'de be open to it.
But adding it to OSes is an important role. Many sites and resources don't list it.

Personally, I don't want non-free firmware installed. I don't use my laptops built-in Bluetooth because it requires drivers I cannot audit or change.
I also rely on my OS's repos to be transparent and remove or warn me of software that isn't free or may be a security risk.

People just don't understand the flaws with OSes like Ubuntu and Qubes.
Warning people allows them to make their own choice. It adds what is very similar to a warning label.

I'm more just not 100% sure if noting contrib on not completely free tools is in-scope for this project. It might make people more wary of using certain tools when in reality if people used any of the tools we recommend it would be a significant net benefit to privacy overall.

But I also don't have any problem with this being

OS's like Qubes, OpenWRT, pfSense, Tails, Ubuntu Touch, e.c.t aren't made for every day people.

They were made for people either with extensive computer knowledge or people who are willing to take the time to research.

Very few people will take the time to load OSes like OpenWRT on their routers.

If you want an easy-to-use privacy-focused OS you run an OS like Debian or Trisquel.
OSes like Qubes or Tails aren't very beginner friendly.

Qubes was my first Linux OS and almost made me quit. It slows down applications and it makes it very difficult to run packages like Snap without running in a template or standalone VM. Too many terms to learn IMHO. I will say, it is a great OS for security experts.
Tails (and other live USB OSes) is easy to use, but very specialized. I don't see people switching because of a "contrib" tag.

:)

> A downside is that it will pollute the source code and the site with a ton of `contrib` labels. > > > I'm more just not 100% sure if noting contrib on not completely free tools is in-scope for this project. [...] But I also don't have any problem with this being added. > > We should only add things if there's a benefit to adding them. @Shifterovich I'm not sure I understand, this is already part of my PR. I didn't add it to all the non-free [search engines](https://github.com/privacytoolsIO/privacytools.io/issues/912) and hosting sites. I also didn't add it to services like Signal or the tons of VPNs with proprietary back-ends. If anybody would like discussing adding the label to these, I'de be open to it. But adding it to OSes is an important role. Many sites and resources don't list it. Personally, I don't want non-free firmware installed. I don't use my laptops built-in Bluetooth because it requires drivers I cannot audit or change. I also rely on my OS's repos to be transparent and remove or warn me of software that isn't free or may be a security risk. People just don't understand the flaws with OSes like Ubuntu and Qubes. Warning people allows them to make their own choice. It adds what is very similar to a warning label. > I'm more just not 100% sure if noting `contrib` on not completely free tools is in-scope for this project. It might make people more wary of using certain tools when in reality if people used _any_ of the tools we recommend it would be a significant net benefit to privacy overall. > > But I also don't have any problem with this being OS's like Qubes, OpenWRT, pfSense, Tails, Ubuntu Touch, e.c.t aren't made for every day people. They were made for people either with extensive computer knowledge or people who are willing to take the time to research. Very few people will take the time to load OSes like OpenWRT on their routers. If you want an easy-to-use privacy-focused OS you run an OS like Debian or Trisquel. OSes like Qubes or Tails aren't very beginner friendly. Qubes was my first Linux OS and almost made me quit. It slows down applications and it makes it very difficult to run packages like Snap without running in a template or standalone VM. Too many terms to learn IMHO. I will say, it is a great OS for security experts. Tails (and other live USB OSes) is easy to use, but very specialized. I don't see people switching because of a "contrib" tag. :)
ghost commented 2019-05-13 15:34:05 +00:00 (Migrated from github.com)

I didn't look at the diff and automatically assumed the label was added to a ton of cards, sorry.

My opinion is the same as @JonahAragon's.

I didn't look at the diff and automatically assumed the label was added to a ton of cards, sorry. My opinion is the same as @JonahAragon's.
jonah reviewed 2019-05-13 15:34:20 +00:00
jonah reviewed 2019-05-13 20:18:24 +00:00
jonah left a comment

This is a relatively minor change to the operating systems sections only, so I'm okay with merging this.

This is a relatively minor change to the operating systems sections only, so I'm okay with merging this.
asddsaz commented 2019-05-17 04:45:58 +00:00 (Migrated from github.com)

There appears to have been couple of OSes with non-free kernels I must've forgotten to add the label to.
(mainly just DD-WRT, Whonix, and SubgraphOS)
But, wanted to inform you on why the extra commits.

@Shifterovich @JonahAragon @Mikaela @blacklight447-ptio

Like Before, OSes like Arch that list free'd alternatives don't need to tag.
Since, they say state that they aren't fully free in their description.

There appears to have been couple of OSes with non-free kernels I must've forgotten to add the label to. (mainly just DD-WRT, Whonix, and SubgraphOS) But, wanted to inform you on why the extra commits. @Shifterovich @JonahAragon @Mikaela @blacklight447-ptio Like Before, OSes like Arch that list free'd alternatives don't need to tag. Since, they say state that they aren't fully free in their description.
asddsaz commented 2019-05-30 22:58:55 +00:00 (Migrated from github.com)

Aye, I was just curious if any of the past reviews have changed.
If they have, is there any changes that you would like undone or reverted or changed?

There hasn't been a discussion here is a while. :)

@JonahAragon @Shifterovich @Mikaela

Aye, I was just curious if any of the past reviews have changed. If they have, is there any changes that you would like undone or reverted or changed? There hasn't been a discussion here is a while. :) @JonahAragon @Shifterovich @Mikaela
jonah reviewed 2019-06-01 17:38:59 +00:00
jonah left a comment

I overall approve of this PR but it has some strange code style related things that should be fixed.

I overall approve of this PR but it has some strange code style related things that should be fixed.

I'd also like to know this? Seems inconsistent.

  description="Tails is a live operating system, that starts on almost any computer from a DVD, USB stick, or SD card. It aims at preserving privacy and anonymity, and helps to: Use the Internet anonymously and circumvent censorship; Internet connections go through the Tor network; leave no trace on the computer; use state-of-the-art cryptographic tools to encrypt files, emails and instant messaging."
I'd also like to know this? Seems inconsistent. ```suggestion description="Tails is a live operating system, that starts on almost any computer from a DVD, USB stick, or SD card. It aims at preserving privacy and anonymity, and helps to: Use the Internet anonymously and circumvent censorship; Internet connections go through the Tor network; leave no trace on the computer; use state-of-the-art cryptographic tools to encrypt files, emails and instant messaging." ```
{% include sections/participate.html %}

This is not good style.

```suggestion {% include sections/participate.html %} ``` This is not good style.
asddsaz (Migrated from github.com) reviewed 2019-06-06 21:32:05 +00:00
asddsaz (Migrated from github.com) commented 2019-06-06 21:32:05 +00:00

It does seem to make any difference to the visual side.

I'll commit suggestion.

It does seem to make any difference to the visual side. I'll commit suggestion.
asddsaz (Migrated from github.com) reviewed 2019-06-06 21:36:10 +00:00
asddsaz (Migrated from github.com) commented 2019-06-06 21:36:10 +00:00

Should be fixed in later commit. :)

Thanks!

Should be fixed in later commit. :) Thanks!
jonah approved these changes 2019-06-07 22:53:19 +00:00
jonah approved these changes 2019-06-08 09:58:00 +00:00

Okay well, I suppose I'll go ahead and merge this 🤞

Okay well, I suppose I'll go ahead and merge this 🤞
This repo is archived. You cannot comment on pull requests.
No Milestone
No Assignees
1 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: privacyguides/privacytools.io#687
No description provided.