Create panel-item class to replace inline CSS #538

2018-10-21T18:11:39Z

Vincevrp commented

2018-10-21 18:11:39 +00:00

(Migrated from github.com)

Description

Replaced inline CSS and obsolete align attribute with a class for all images in .panel-body

HTML Preview

https://htmlpreview.github.io/?https://github.com/Vincevrp/privacytools.io/blob/master/index.html

### Description Replaced inline CSS and obsolete align attribute with a class for all images in `.panel-body` ### HTML Preview https://htmlpreview.github.io/?https://github.com/Vincevrp/privacytools.io/blob/master/index.html

ghost commented

2018-10-22 08:28:39 +00:00

(Migrated from github.com)

Thanks. After your PR yesterday, I looked at the W3 validator and saw that there are indeed many, many issues.

👍 1

Vincevrp commented

2018-10-22 20:02:33 +00:00

(Migrated from github.com)

I'm trying to fix most of them as we speak. Maybe we should implement some sort of CI/CD that validates the code. I'm willing to help implement this.

ghost commented

2018-10-23 13:18:12 +00:00

(Migrated from github.com)

I thought about that a few days ago. We probably don't need something like StyleCI as it's not very relevant for HTML, but maybe some HTML validation CI would be useful.

I'll have to check if I have enough permissions to set up a CI for PTIO, as I'm only a collaborator and @privacytoolsIO is not an organization.

I thought about that a few days ago. We probably don't need something like StyleCI as it's not very relevant for HTML, but maybe some HTML validation CI would be useful. I'll have to check if I have enough permissions to set up a CI for PTIO, as I'm only a collaborator and @privacytoolsIO is not an organization.

👍 1

This repo is archived. You cannot comment on pull requests.

1 Participants

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: privacyguides/privacytools.io#538