Fix for tooltips on badge #2167

Merged
Gusted merged 3 commits from Tooltip-Patch into master 2020-12-29 13:25:10 +00:00
Gusted commented 2020-12-26 18:23:59 +00:00 (Migrated from github.com)

Description

Resolves: https://github.com/privacytools/privacytools.io/pull/2139#issuecomment-751338425 @dngray

Check List

  • I understand that by not opening an issue about a software/service/similar addition/removal, this pull request will be closed without merging.

  • I have read and understand the contributing guidelines.

  • The project is Free Libre and/or Open Source Software

<!-- PLEASE READ OUR CODE OF CONDUCT (https://wiki.privacytools.io/view/PrivacyTools:Code_of_Conduct) AND CONTRIBUTING GUIDELINES (https://github.com/privacytools/privacytools.io/blob/master/.github/CONTRIBUTING.md) BEFORE SUBMITTING --> ## Description Resolves: https://github.com/privacytools/privacytools.io/pull/2139#issuecomment-751338425 @dngray #### Check List <!-- Please add an x in each box below, like so: [x] --> - [x] I understand that by not opening an issue about a software/service/similar addition/removal, this pull request will be closed without merging. - [x] I have read and understand [the contributing guidelines](https://github.com/privacytools/privacytools.io/blob/master/.github/CONTRIBUTING.md). - [x] The project is [Free Libre](https://en.wikipedia.org/wiki/Free_software) and/or [Open Source](https://en.wikipedia.org/wiki/Open-source_software) Software * Netlify preview for the mainly edited page: https://deploy-preview-2167--privacytools-io.netlify.app/
dngray commented 2020-12-28 06:30:10 +00:00 (Migrated from github.com)

Thanks for this, will review!

Thanks for this, will review!
dngray commented 2020-12-28 14:42:58 +00:00 (Migrated from github.com)

I had a look at this, any chance we can get it not bold

168891569

Like if you look how it was originally:

I had a look at this, any chance we can get it not bold ![168891569](https://user-images.githubusercontent.com/48640805/103221561-db2bf300-491a-11eb-85de-a229ea2e77b4.png) Like if you look how it was originally: ![](https://user-images.githubusercontent.com/48640805/103148914-b8ec7680-475c-11eb-857f-794760f19691.png)
dngray commented 2020-12-29 06:58:25 +00:00 (Migrated from github.com)

Hmm, i think setting font-weight: normal; might be the right solution. Though I would have thought it would have been normal to begin with. Must have inherited the boldness from somewhere else.

352908706

Hmm, i think setting `font-weight: normal;` might be the right solution. Though I would have thought it would have been normal to begin with. Must have inherited the boldness from somewhere else. ![352908706](https://user-images.githubusercontent.com/48640805/103264650-37d2f080-49a3-11eb-8ee3-44759070ef1d.png)
Gusted commented 2020-12-29 13:03:25 +00:00 (Migrated from github.com)

Must have inherited the boldness from somewhere else.

The badge itself seems to have an bold font-weight.

Hmm, i think setting font-weight: normal; might be the right solution.

I couldn't think of anything else.

> Must have inherited the boldness from somewhere else. The badge itself seems to have an `bold` font-weight. > Hmm, i think setting `font-weight: normal;` might be the right solution. I couldn't think of anything else.
dngray (Migrated from github.com) approved these changes 2020-12-29 13:24:55 +00:00
This repo is archived. You cannot comment on pull requests.
No reviewers
No Milestone
No Assignees
1 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: privacyguides/privacytools.io#2167
No description provided.