privacyguides/privacytools.io
Archived
1
0
Fork 0
Code Issues 304 Pull Requests 47 Activity

Update Javascript dependencies #2166

Merged
Gusted merged 2 commits from jqeury-fix into master 2020-12-29 13:52:17 +00:00
Conversation 5 Commits 2 Files Changed 4 +13 -12
Gusted commented 2020-12-25 15:20:11 +00:00 (Migrated from github.com)
Copy Link

Description

Resolves: #2165

As in issue #2165 the current version of Bootstrap still relies on jQuery, since v5 bootstrap only relies on the already existence popper.js(@popper/core) dependency.
Thereby updating those 2 dependencies fixes this issue and still maintain all features.
Eventually the non beta of Bootstrap v5 can be used when it's stable.

Summary of what this PR means:

  • Update bootstrap to v5.0.0-beta1.
  • Update popper.js to v2.6.0.
  • Update Javascript license of popper.js.
  • Bump version in scripts.html.

Check List

  • I understand that by not opening an issue about a software/service/similar addition/removal, this pull request will be closed without merging.

  • I have read and understand the contributing guidelines.

  • The project is Free Libre and/or Open Source Software

## Description Resolves: #2165 As in issue #2165 the current version of Bootstrap still relies on jQuery, since v5 bootstrap only relies on the already existence popper.js(`@popper/core`) dependency. Thereby updating those 2 dependencies fixes this issue and still maintain all features. Eventually the non beta of Bootstrap v5 can be used when it's stable. Summary of what this PR means: - Update bootstrap to v5.0.0-beta1. - Update popper.js to v2.6.0. - Update Javascript license of popper.js. - Bump version in `scripts.html`. #### Check List - [x] I understand that by not opening an issue about a software/service/similar addition/removal, this pull request will be closed without merging. - [x] I have read and understand [the contributing guidelines](https://github.com/privacytools/privacytools.io/blob/master/.github/CONTRIBUTING.md). - [x] The project is [Free Libre](https://en.wikipedia.org/wiki/Free_software) and/or [Open Source](https://en.wikipedia.org/wiki/Open-source_software) Software * Netlify preview for the mainly edited page: https://deploy-preview-2166--privacytools-io.netlify.app/
dngray commented 2020-12-25 15:28:19 +00:00 (Migrated from github.com)
Copy Link

Thanks a lot for this, I'll check it out soon!

Thanks a lot for this, I'll check it out soon!
👍 1
dngray commented 2020-12-26 09:17:41 +00:00 (Migrated from github.com)
Copy Link

Looks good.

Only errors i was seeing was:

/usr/lib/ruby/gems/2.7.0/gems/jekyll-3.8.5/lib/jekyll/convertible.rb:41: warning: Using the last argument as keyword parameters is deprecated
/usr/lib/ruby/gems/2.7.0/gems/jekyll-3.8.5/lib/jekyll/tags/include.rb:194: warning: Using the last argument as keyword parameters is deprecated
/usr/lib/ruby/gems/2.7.0/gems/pathutil-0.16.2/lib/pathutil.rb:502: warning: Using the last argument as keyword parameters is deprecated
/usr/lib/ruby/gems/2.7.0/gems/rb-inotify-0.10.0/lib/rb-inotify/watcher.rb:66: warning: rb_safe_level will be removed in Ruby 3.0

I wonder if there's anything we can do about these.

Looks good. Only errors i was seeing was: ``` /usr/lib/ruby/gems/2.7.0/gems/jekyll-3.8.5/lib/jekyll/convertible.rb:41: warning: Using the last argument as keyword parameters is deprecated /usr/lib/ruby/gems/2.7.0/gems/jekyll-3.8.5/lib/jekyll/tags/include.rb:194: warning: Using the last argument as keyword parameters is deprecated /usr/lib/ruby/gems/2.7.0/gems/pathutil-0.16.2/lib/pathutil.rb:502: warning: Using the last argument as keyword parameters is deprecated /usr/lib/ruby/gems/2.7.0/gems/rb-inotify-0.10.0/lib/rb-inotify/watcher.rb:66: warning: rb_safe_level will be removed in Ruby 3.0 ``` I wonder if there's anything we can do about these.
Gusted commented 2020-12-26 18:32:47 +00:00 (Migrated from github.com)
Copy Link

Looks good.

Only errors i was seeing was:

/usr/lib/ruby/gems/2.7.0/gems/jekyll-3.8.5/lib/jekyll/convertible.rb:41: warning: Using the last argument as keyword parameters is deprecated
/usr/lib/ruby/gems/2.7.0/gems/jekyll-3.8.5/lib/jekyll/tags/include.rb:194: warning: Using the last argument as keyword parameters is deprecated
/usr/lib/ruby/gems/2.7.0/gems/pathutil-0.16.2/lib/pathutil.rb:502: warning: Using the last argument as keyword parameters is deprecated
/usr/lib/ruby/gems/2.7.0/gems/rb-inotify-0.10.0/lib/rb-inotify/watcher.rb:66: warning: rb_safe_level will be removed in Ruby 3.0

I wonder if there's anything we can do about these.

Those are ruby dependencies. A small sudo bundle update should update most dependencies to 2.7+ ruby language. The only warning after updating is

/var/lib/gems/2.7.0/gems/pathutil-0.16.2/lib/pathutil.rb:502: warning: Using the last argument as keyword parameters is deprecated

Which seems to me that some dependency is still using an old version of pathutil, but that's an issue for another pr/issue.

> Looks good. > > Only errors i was seeing was: > > ``` > /usr/lib/ruby/gems/2.7.0/gems/jekyll-3.8.5/lib/jekyll/convertible.rb:41: warning: Using the last argument as keyword parameters is deprecated > /usr/lib/ruby/gems/2.7.0/gems/jekyll-3.8.5/lib/jekyll/tags/include.rb:194: warning: Using the last argument as keyword parameters is deprecated > /usr/lib/ruby/gems/2.7.0/gems/pathutil-0.16.2/lib/pathutil.rb:502: warning: Using the last argument as keyword parameters is deprecated > /usr/lib/ruby/gems/2.7.0/gems/rb-inotify-0.10.0/lib/rb-inotify/watcher.rb:66: warning: rb_safe_level will be removed in Ruby 3.0 > ``` > > I wonder if there's anything we can do about these. Those are ruby dependencies. A small `sudo bundle update` should update most dependencies to 2.7+ ruby language. The only warning after updating is ``` /var/lib/gems/2.7.0/gems/pathutil-0.16.2/lib/pathutil.rb:502: warning: Using the last argument as keyword parameters is deprecated ``` Which seems to me that some dependency is still using an old version of `pathutil`, but that's an issue for another pr/issue.
Gusted commented 2020-12-26 18:37:35 +00:00 (Migrated from github.com)
Copy Link

Which seems to me that some dependency is still using an old version of pathutil, but that's an issue for another pr/issue.

https://github.com/envygeeks/pathutil the last update was from 2018 and is 0.16.2 which is currently specified in gemfile.lock. pathutil is utilized by jekyll.

Their is an open issue about it https://github.com/envygeeks/pathutil/issues/4 and an open PR https://github.com/envygeeks/pathutil/pull/5, however their seems to be no progress.

> ~Which seems to me that some dependency is still using an old version of `pathutil`, but that's an issue for another pr/issue.~ https://github.com/envygeeks/pathutil the last update was from 2018 and is `0.16.2` which is currently specified in `gemfile.lock`. `pathutil` is utilized by `jekyll`. Their is an open issue about it https://github.com/envygeeks/pathutil/issues/4 and an open PR https://github.com/envygeeks/pathutil/pull/5, however their seems to be no progress.
dngray (Migrated from github.com) approved these changes 2020-12-29 13:52:05 +00:00
This repo is archived. You cannot comment on pull requests.
Reviewers
No Reviewers
dngray
Labels
Clear labels
🔍🤖 Search Engines
approved
approved, waiting for a PR
dependencies
Pull requests that update a dependency file
duplicate
feedback wanted
high priority
I2P
The Invisible Internet Project (I2P)
iOS
low priority
OS
Operating Systems
Self-contained networks
Social media
stale
A label for stalebot if it gets added
streaming
Anything related to media streaming.
todo
Tor
Anything covering the Tor network
WIP
active work in progress, do not merge or PR (yet)!
wontfix
Issues or bugs that will not be fixed and/or do not have significant impact on the project.
XMPP
Extensible Messaging and Presence Protocol
[m]
Matrix protocol
₿ cryptocurrency
ℹ️ help wanted
↔️ file sharing
⚙️ web extensions
Browser Extension related issues
✨ enhancement
❌ software removal
💬 discussion
🤖 Android
🐛 bug
💢 conflicting
📝 correction
Correction of content on the website
🆘 critical
📧 email
🔒 file encryption
📁 file storage
🦊 Firefox
Firefox & forks, about:config etc.
💻 hardware
🌐 hosting
🏠 housekeeping
Anything primarily related to site cleanup.
🔐 password managers
🧰 productivity tools
🔎 research required
🌐 Social News Aggregators
🆕 software suggestion
👥 team chat
🔒 VPN
Virtual Private Network
🌐 website issue
*Technical* issues with the website.
🚫 Windows
👁️ browsers
🖊️ digital notebooks
🗄️ DNS
Domain Name System
🗨️ instant messaging (im)
🇦🇶 translations
Anything covering a translated version of the site
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
jonah
No Assignees
1 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: privacyguides/privacytools.io#2166
No description provided.
Delete Branch "jqeury-fix"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?