Cleanup jQuery #2139
No reviewers
Labels
No Label
🔍🤖 Search Engines
approved
dependencies
duplicate
feedback wanted
high priority
I2P
iOS
low priority
OS
Self-contained networks
Social media
stale
streaming
todo
Tor
WIP
wontfix
XMPP
[m]
₿ cryptocurrency
ℹ️ help wanted
↔️ file sharing
⚙️ web extensions
✨ enhancement
❌ software removal
💬 discussion
🤖 Android
🐛 bug
💢 conflicting
📝 correction
🆘 critical
📧 email
🔒 file encryption
📁 file storage
🦊 Firefox
💻 hardware
🌐 hosting
🏠 housekeeping
🔐 password managers
🧰 productivity tools
🔎 research required
🌐 Social News Aggregators
🆕 software suggestion
👥 team chat
🔒 VPN
🌐 website issue
🚫 Windows
👁️ browsers
🖊️ digital notebooks
🗄️ DNS
🗨️ instant messaging (im)
🇦🇶 translations
No Milestone
No Assignees
1 Participants
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: privacyguides/privacytools.io#2139
Loading…
Reference in New Issue
No description provided.
Delete Branch "master"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Description
As jQuery was only used for the tooltip implementation, it was better to have it rewritten in vanilla CSS and have another dependency removed. I've changed the
title
attributes todata-original-title
so it was consistent with all other tooltips.Bootstrap/Popper seems to work without jQuery and doesn't throw errors.
Resolves: #1356
Check List
I understand that by not opening an issue about a software/service/similar addition/removal, this pull request will be closed without merging.
I have read and understand the contributing guidelines.
The project is Free Libre and/or Open Source Software
Netlify preview for the mainly edited page: https://deploy-preview-2139--privacytools-io.netlify.app/
Code repository of the project (if applicable):
I'll have a look at this one later today. Just need to verify everything works.
Hey @dngray
Was their any update on this?
Regards,
Gusted
I've checked this out and it seems to work, so approving.
Thanks!
Hmm I think I've noticed a breakage. For example in
afd7e216ce
it looks like:Where as after
21c894eef7
@Gusted not sure how I missed that the first time. Got any idea what is causing it?
It seems to be happening on all warnings, I will have a look what's going on here.
Aha, those little warnings has
Which causes to let the tooltip inherit it and therefore make the tooltip content 1 long text.
I will open up a PR to fix this.
@Gusted much appreciated, this wasn't my area of expertise so it helps having someone who knows how to fix this nicely 👍
No problems.