Cleanup jQuery #2139

2020-11-25T16:32:31Z

Gusted commented

2020-11-25 16:32:31 +00:00

(Migrated from github.com)

Description

As jQuery was only used for the tooltip implementation, it was better to have it rewritten in vanilla CSS and have another dependency removed. I've changed the title attributes to data-original-title so it was consistent with all other tooltips.
Bootstrap/Popper seems to work without jQuery and doesn't throw errors.

Resolves: #1356

Check List

I understand that by not opening an issue about a software/service/similar addition/removal, this pull request will be closed without merging.
I have read and understand the contributing guidelines.
The project is Free Libre and/or Open Source Software

Netlify preview for the mainly edited page: https://deploy-preview-2139--privacytools-io.netlify.app/
Code repository of the project (if applicable):

## Description As jQuery was only used for the tooltip implementation, it was better to have it rewritten in vanilla CSS and have another dependency removed. I've changed the `title` attributes to `data-original-title` so it was consistent with all other tooltips. Bootstrap/Popper seems to work without jQuery and doesn't throw errors. Resolves: #1356 #### Check List  - [x] I understand that by not opening an issue about a software/service/similar addition/removal, this pull request will be closed without merging. - [x] I have read and understand [the contributing guidelines](https://github.com/privacytools/privacytools.io/blob/master/.github/CONTRIBUTING.md). - [x] The project is [Free Libre](https://en.wikipedia.org/wiki/Free_software) and/or [Open Source](https://en.wikipedia.org/wiki/Open-source_software) Software * Netlify preview for the mainly edited page: https://deploy-preview-2139--privacytools-io.netlify.app/ * Code repository of the project (if applicable):

dngray commented

2020-11-25 17:06:18 +00:00

(Migrated from github.com)

I'll have a look at this one later today. Just need to verify everything works.

👍 2

Gusted commented

2020-12-01 22:26:01 +00:00

(Migrated from github.com)

Hey @dngray

Was their any update on this?

Regards,
Gusted

Hey @dngray Was their any update on this? Regards, Gusted

dngray commented

2020-12-13 20:37:16 +00:00

(Migrated from github.com)

I've checked this out and it seems to work, so approving.

🚀 1

dngray (Migrated from github.com) approved these changes 2020-12-13 20:37:25 +00:00

Gusted commented

2020-12-13 20:38:22 +00:00

(Migrated from github.com)

I've checked this out and it seems to work, so approving.

Thanks!

> I've checked this out and it seems to work, so approving. Thanks!

dngray commented

2020-12-26 09:29:10 +00:00

(Migrated from github.com)

Hmm I think I've noticed a breakage. For example in https://github.com/privacytools/privacytools.io/commit/afd7e216ce9799a585f3dc8ff89aa243cd1d8e24 it looks like:

Where as after https://github.com/privacytools/privacytools.io/commit/21c894eef786e34b111918f83170a3783391687f

@Gusted not sure how I missed that the first time. Got any idea what is causing it?

Hmm I think I've noticed a breakage. For example in https://github.com/privacytools/privacytools.io/commit/afd7e216ce9799a585f3dc8ff89aa243cd1d8e24 it looks like: ![1613684226](https://user-images.githubusercontent.com/48640805/103148914-b8ec7680-475c-11eb-857f-794760f19691.png) Where as after https://github.com/privacytools/privacytools.io/commit/21c894eef786e34b111918f83170a3783391687f ![1057488041](https://user-images.githubusercontent.com/48640805/103148917-bf7aee00-475c-11eb-9bc0-47911c88bbd4.png) @Gusted not sure how I missed that the first time. Got any idea what is causing it?

Gusted commented

2020-12-26 15:58:08 +00:00

(Migrated from github.com)

It seems to be happening on all warnings, I will have a look what's going on here.

![image](https://user-images.githubusercontent.com/25481501/103154924-17344c00-4793-11eb-8f31-19b90ba75362.png) It seems to be happening on all warnings, I will have a look what's going on here.

Gusted commented

2020-12-26 16:06:28 +00:00

(Migrated from github.com)

Aha, those little warnings has

white-space: nowrap;

Which causes to let the tooltip inherit it and therefore make the tooltip content 1 long text.
I will open up a PR to fix this.

Aha, those little warnings has ```CSS white-space: nowrap; ``` Which causes to let the tooltip inherit it and therefore make the tooltip content 1 long text. I will open up a PR to fix this.

dngray commented

2020-12-27 10:29:53 +00:00

(Migrated from github.com)

@Gusted much appreciated, this wasn't my area of expertise so it helps having someone who knows how to fix this nicely 👍

@Gusted much appreciated, this wasn't my area of expertise so it helps having someone who knows how to fix this nicely :+1:

👍 1

Gusted commented

2020-12-27 16:53:58 +00:00

(Migrated from github.com)

@Gusted much appreciated, this wasn't my area of expertise so it helps having someone who knows how to fix this nicely +1

No problems.

> @Gusted much appreciated, this wasn't my area of expertise so it helps having someone who knows how to fix this nicely +1 No problems.

This repo is archived. You cannot comment on pull requests.

1 Participants

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: privacyguides/privacytools.io#2139